January 2014 - Wine-Devel - list.winehq.org

Re: user32/tests: Avoid preprocessor checks to ensure it compiles

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4400 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

Jan. 22, 2014

Re: add Japanese man page of wine.

by Akihiro Sagawa

On Tue, 21 Jan 2014 23:56:15 +0900, Akira Nakagawa wrote: > diff --git a/loader/Makefile.in b/loader/Makefile.in > index 665bdda..80966fa 100644 > --- a/loader/Makefile.in > +++ b/loader/Makefile.in > @@ -8,6 +8,7 @@ MANPAGES = \ > wine.de.UTF-8.man.in \ > wine.fr.UTF-8.man.in \ > wine.man.in \ > + wine.ja.UTF-8.man.in \ > wine.pl.UTF-8.man.in > > IN_SRCS = \ Please keep alphabetical order. > diff --git a/loader/wine.ja.UTF-8.man.in b/loader/wine.ja.UTF-8.man.in > new file mode 100644 > index 0000000..c07adaa > --- /dev/null > +++ b/loader/wine.ja.UTF-8.man.in > @@ -0,0 +1,304 @@ (..) > +CUIの実行可能プログラム(Windowsコンソールプログラム)を実行するには、 > +.BR wineの代わりに The last line should be ".BR wine の代わりに" (note the space character after wine). Because groff thinks "wineの代わりに" is one word, whole of the sentence outputs in bold face. But, we just need to emphasize "wine". Please recheck other .RI, .RB, .BR, .IR macro lines. groff_man(7) describes these macro usages. Akihiro Sagawa

Jan. 22, 2014

Re:[PATCH 4/5] gdiplus: Implement SetPageTransform playback.

by Akira Nakagawa

You have written the following: but you missed break;at the end of case {}. + case EmfPlusRecordTypeSetPageTransform: + { + EmfPlusSetPageTransform *record = (EmfPlusSetPageTransform*)header; + GpUnit unit = (GpUnit)flags; + + if (dataSize + sizeof(EmfPlusRecordHeader) < sizeof(EmfPlusSetPageTransform)) + return InvalidParameter; + + real_metafile->page_unit = unit; + real_metafile->page_scale = record->PageScale; + + return METAFILE_PlaybackUpdateWorldTransform(real_metafile); + } default:

Jan. 22, 2014

Re: Add support to arguments with dash in taskkill

by Dmitry Timoshkov

中川祥 <matyapiro31(a)gmail.com> wrote: > you compare the text without checking if it is 2 byte word. > Is there any problem? What problem are you talking about? -- Dmitry.

Jan. 22, 2014

Re: Add support to arguments with dash in taskkill

by 中川祥

you compare the text without checking if it is 2 byte word. Is there any problem?

Jan. 22, 2014

Re: [PATCH 2/3] riched20: Use codepage in ME_ToUnicode. (try 7)

by Jactry Zeng

Hello Alexandre, 2014/1/7 Alexandre Julliard <julliard(a)winehq.org> > > Jactry Zeng <jactry92(a)gmail.com> writes: > > > From 4bda4b989cef6ee1f45e6ee989e63db05ef770de Mon Sep 17 00:00:00 2001 > > From: Jactry Zeng <jactry92(a)gmail.com> > > Date: Sun, 5 Jan 2014 20:58:55 +0800 > > Subject: riched20: Use codepage in ME_ToUnicode. > > > > --- > > dlls/riched20/editor.c | 15 ++++++++------- > > dlls/riched20/editor.h | 4 ++-- > > dlls/riched20/string.c | 12 ++++++------ > > 3 files changed, 16 insertions(+), 15 deletions(-) > > It doesn't work: Sorry, I missed a ME_ToUnicode() in this patch. And another try was sent. Thanks for your review! > > > ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so editor && touch editor.ok > editor.c:7423: Test failed: GetWindowText returned 1 > editor.c:7424: Test failed: buf = l > make: *** [editor.ok] Error 2 > > -- > Alexandre Julliard > julliard(a)winehq.org -- Regards, Jactry Zeng

Jan. 21, 2014

Re: [patch]: include : Add missing API to direct-x 9's shader header

by Kai Tietz

Hi, 2014/1/21 Dmitry Timoshkov <dmitry(a)baikal.ru>: > Kai Tietz <ktietz70(a)googlemail.com> wrote: > >> -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, >> 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b); >> +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7, >> 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1); > > A quick google search seems to contradict this change. Where does this > come from? You should learn to use Google more proper. As then you would find that IID_ID3DXConstantTable is in Wine indeed wrong. At least for version 43. I used as reference the documentation to be found at http://www-personal.umich.edu/~bazald/l/api/d3dx9shader_8h.html . > Also all of this looks like a plain copy/paste from MS headers, > you can't do that. This allegation is not true. I don't copy paste. > > -- > Dmitry.

Jan. 21, 2014

Re: [patch]: include : Add missing API to direct-x 9's shader header

by Henri Verbeet

On 21 January 2014 17:23, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Kai Tietz <ktietz70(a)googlemail.com> wrote: > >> -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, >> 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b); >> +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7, >> 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1); > > A quick google search seems to contradict this change. Where does this > come from? IIRC some interfaces changed GUIDs while keeping the same name between d3dx9 versions. The changed GUID matches the SDK headers for version 43. It seems likely 43 will be the last version of d3dx9, so we may want to match that, but we'd have to change e.g. the D3DX_SDK_VERSION define as well in that case.

Jan. 21, 2014

Re: [patch]: include : Add missing API to direct-x 9's shader header

by Dmitry Timoshkov

Kai Tietz <ktietz70(a)googlemail.com> wrote: > -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, > 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b); > +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7, > 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1); A quick google search seems to contradict this change. Where does this come from? Also all of this looks like a plain copy/paste from MS headers, you can't do that. -- Dmitry.

Jan. 21, 2014

Re: [PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS

by Pavel Shilovsky

2014/1/20 Volker Lendecke <Volker.Lendecke(a)sernet.de>: >> You can try to use O_PATH flag. It doesn't give you a delete access >> but should be ok because further deleting will be done without file >> descriptor -- through unlink syscall. > > Ok, I did not know about O_PATH. Thanks for that! > > So I do an open with O_PATH. How do I then make sure that > nobody else has a O_DENYDELETE set without doing the unlink > itself? It's not possible with the current API to do it through open syscall. Another possibility is to look at /proc/locks. But I think we really need O_DELETE flag that will force a file to be removed on close - we will be able to do O_DENYDELETE checks atomically. -- Best regards, Pavel Shilovsky.

Jan. 21, 2014