January 2014 - Wine-Devel - list.winehq.org

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.

by Huw Davies

On Tue, Jan 07, 2014 at 02:33:32PM +0100, Ralf Habacker wrote: > @@ -1327,6 +1327,20 @@ BOOL WINAPI GetTextExtentExPointW( HDC hdc, LPCWSTR str, INT count, INT max_ext, > } > } > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } Does Windows really do this only in the same-scaled, non-sheared case? Huw.

Jan. 7, 2014

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.

by Nikolay Sivov

On 1/7/2014 17:33, Ralf Habacker wrote: > This patch detects operational condition first and then removes > temporary rotation from the world transform. > Bug: http://bugs.winehq.org/show_bug.cgi?id=33190 > --- > dlls/gdi32/font.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } > + Flag really means do we need to restore transform or not. > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED && exclude_rotation == TRUE ) > + { > + SetWorldTransform( hdc, &old ); > + } > + Doesn't look like you need to check a mode again.

Jan. 7, 2014

Re: [1/4] gid32: Add matrix helper functions.

by Nikolay Sivov

On 1/7/2014 17:31, Ralf Habacker wrote: > Contains basic functions required by further patches > --- > dlls/gdi32/dibdrv/graphics.c | 49 > ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > That should be merged with a first patch that uses it. > +/* > + check matrix for condition > +*/ > +BOOL hasRotatedAndSameScaledMatrixOnly(XFORM *xform) > +{ > + return xform->eM11 == xform->eM22 && > + -xform->eM21 == xform->eM12; > +} > + Comment is telling nothing, 'xform' should be const probably. > + double determinant = 0; > + > + /* xform = xfrom-transposed * xform */ > + xform->eM11 = sqrt( xform->eM11 * xform->eM11 + xform->eM21 * xform->eM21 ); > + xform->eM22 = sqrt( xform->eM12 * xform->eM12 + xform->eM22 * xform->eM22 ); > + xform->eM12 = 0; > + xform->eM21 = 0; > + xform->eDx = 0; > + xform->eDy = 0; > + > + if ( rotation_and_translation == NULL ) > + return TRUE; > + > + determinant = xform->eM11 * xform->eM22; > + > + inverse_matrix_scale.eM11 = xform->eM22 / determinant; Is it possible to get 0 determinant here? Function never returns FALSE, so return value is useless. Also please follow function and variable naming conventions used in this file.

Jan. 7, 2014

Re: shell32/tests: Add test for SHGetPathFromIDListA

by Nikolay Sivov

On 1/7/2014 16:08, Zhenbo Li wrote: > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/pidl.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 dlls/shell32/tests/pidl.c > Please use some existing file. > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + LPCSTR pszPath; > + > + pszPath = malloc(MAX_PATH); > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + > + free((void *)pszPath); > +} > + You don't need to allocate it here, even if had to Heap* functions should be used.

Jan. 7, 2014

Re: shell32/tests: Add test for SHGetPathFromIDListA

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4048 Your paranoid android. === wxppro (32 bit pidl) === No test summary line found === wvista (32 bit pidl) === No test summary line found === w2008s64 (32 bit pidl) === No test summary line found === w7pro64 (32 bit pidl) === No test summary line found === w2008s64 (64 bit pidl) === No test summary line found === w7pro64 (64 bit pidl) === No test summary line found

Jan. 7, 2014

Re: WineHQ Downtime

by Francois Gouget

On Mon, 6 Jan 2014, Jeremy Newman wrote: > Starting tomorrow at 10:00 CST we will be performing updates and maintenance > to the WineHQ server. The service window should be around 2 hours at most. > Various services will experience outages during this time frame. > > This will affect www.winehq.org, appdb.winehq.org, bugs.winehq.org, > forum.winehq.org, source.winehq.org, mailing lists, and GIT. Note that this will also impact newtestbot.winehq.org. -- Francois Gouget <fgouget(a)codeweavers.com>

Jan. 7, 2014

Re: user32/tests: Use BOOL type where appropriate

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4032 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

Jan. 7, 2014

Re: [2/2] ws2_32/tests: Show that the last WSACleanup must destroy sockets

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4029 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4220C0

Jan. 6, 2014

Re: [1/2] ws2_32/tests: Add some FIONREAD tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4028 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

Jan. 6, 2014

Re: [PATCH 2/3] riched20: Use codepage in ME_ToUnicode. (try 7)

by Alexandre Julliard

Jactry Zeng <jactry92(a)gmail.com> writes: > From 4bda4b989cef6ee1f45e6ee989e63db05ef770de Mon Sep 17 00:00:00 2001 > From: Jactry Zeng <jactry92(a)gmail.com> > Date: Sun, 5 Jan 2014 20:58:55 +0800 > Subject: riched20: Use codepage in ME_ToUnicode. > > --- > dlls/riched20/editor.c | 15 ++++++++------- > dlls/riched20/editor.h | 4 ++-- > dlls/riched20/string.c | 12 ++++++------ > 3 files changed, 16 insertions(+), 15 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so editor && touch editor.ok editor.c:7423: Test failed: GetWindowText returned 1 editor.c:7424: Test failed: buf = l make: *** [editor.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Jan. 6, 2014