January 2014 - Wine-Devel - list.winehq.org

Re: [1/7] gdi32: Relax vertical face requirements.

by Dmitry Timoshkov

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -2148,6 +2148,9 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_ > #endif /* HAVE_CARBON_CARBON_H */ > > do { > + const DWORD DBCS_MASK = 0x3e0000; dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000, I'd guess that one of these places needs to be fixed. -- Dmitry.

Jan. 4, 2014

Re: [4/7] gdi32/tests: Add more GetCharABCWidths tests for rotated font.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3979 Your paranoid android. === wxppro (32 bit font) === font.c:1330: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0

Jan. 4, 2014

Re: [4/4] ws2_32/tests: Add some FIONREAD tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3976 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead

Jan. 4, 2014

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3975 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

Jan. 4, 2014

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)

by Dmitry Timoshkov

Zhenbo Li <litimetal(a)gmail.com> wrote: > > This block looks like an orphaned part of some removed test. > > > Do you know what's wrong with such code? It tests nothing and should be removed. -- Dmitry.

Jan. 4, 2014

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)

by Zhenbo Li

2014/1/4 Dmitry Timoshkov <dmitry(a)baikal.ru>: > > This block looks like an orphaned part of some removed test. Do you know what's wrong with such code? BTW, I found that I still missed > handle = FindFirstFileA(buffer2, &data); in this patch. -- Have a nice day! Zhenbo Li

Jan. 4, 2014

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)

by Dmitry Timoshkov

Zhenbo Li <litimetal(a)gmail.com> wrote: > + > + err = GetLastError(); > + ok ( handle != INVALID_HANDLE_VALUE, "FindFirstFile on %s failed\n", buffer2 ); > + ok ( !err , "FindFirstFile failed, Error number %d\n", err ); > + This block looks like an orphaned part of some removed test. -- Dmitry.

Jan. 4, 2014

Question about test_RemoveDirectory()

by Zhenbo Li

Hello, I found that test_RemoveDirectory() is in dlls/kernel32/tests/file.c, while RemoveDirectoryA() and RemoveDirectoryW() are in dlls/kernel32/path.c I checked git log, and found that they came from commit ad9b79932410f7c, Reimplemented CreateDirectoryW and RemoveDirectoryW using ntdll functions. Should I move test_RemoveDirectory() to dlls/kernel32/tests/path.c? Thanks. -- Have a nice day! Zhenbo Li

Jan. 4, 2014

Re: kernel32/tests: Add test for FindFirstFileA() (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3973 Your paranoid android. === wxppro (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === wvista (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0

Jan. 4, 2014

Re: ntdll/tests: Add test for deleting via NtOpenFile

by Zhenbo Li

2014/1/4 Marvin <testbot(a)winehq.org>: > > > === w7pro64 (32 bit file) === > file.c:331: Test failed: open L"system32" failed c000003b > file.c:338: Test failed: open L"SYSTEM32" failed c000003b > file.c:346: Test failed: open L"\\SYSTEM32" failed c0000034 > file.c:356: Test failed: open L"\\SYSTEM32" failed c000003b They are old test cases. I don't know they failed. Could someone explain it? Thank you. -- Have a nice day! Zhenbo Li

Jan. 4, 2014