January 2014 - Wine-Devel - list.winehq.org

RE: [PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS

by Frank Filz

> 2014/1/17 Frank Filz <ffilzlnx(a)mindspring.com>: > > This looks wonderful and will be useful to the Ganesha user space NFS > > server also. > > > > I do have a couple questions. > > > > 1. How will this interact with the idea of private locks from the > > patch set Jeff Layton has been pushing? > > They don't touch each other. > > > > > 2. If a process opens multiple file descriptors with deny modes, will > > they conflict with each other (which is the behavior we will want for > Ganesha). > > Yes, a deny mode is associated with file descriptor - so, it will conflict with any > other access/deny modes of file descriptors from any process. > > > > > 3. Is there any functionality to upgrade or downgrade the access and > > deny modes (thinking in terms of NFS v4 support of OPEN upgrade and > > OPEN_DOWNGRADE operations). > > The proposed patchset doesn't allow to change deny modes after an open is > done. But we can add a functionality to let flock syscall change deny modes > as on option. Yes, that would be good. NFS v4 allows upgrade/downgrade of acces/deny modes (hmm, changing access mode would be trickier, but we need to be able to upgrade/downgrade those as well as deny modes...). It could still be done with an fcntl. I don't know if any NFS clients make use of upgrade/downgrade (I do know there are pynfs tests for it). Interestingly, upgrade/downgrade would be a solution to Ganesha's problems with POSIX locks being dumped on any file descriptor close since we could change the access mode as needed rather than needing to close and open the file. Frank

Jan. 27, 2014

Re: Cross-regressions between wine and mesa: how to handle them?

by Ruslan Kabatsayev

On Mon, Jan 27, 2014 at 5:53 PM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2014-01-26 14:08, schrieb Ruslan Kabatsayev: >> For end user this looks like failing software, and moreover, it's >> not easy to understand which software does have bug. Wine >> perspective: On the one hand, wine seems to use what Mesa exposes. >> On the other, why use shaders for games which don't need them? > There are some corner cases in the d3d fixed function pipeline which > we can't handle properly without shaders. Unfortunately, once we > detect such a corner case it's too late to turn on shaders. > > A possible workaround for the user is to set UseGLSL=disabled. It's > not a good long-term fix though. > >> Mesa perspective: On the one hand, it wants to advertise more >> support for latest OpenGL standards. On the other, why do it for >> very old HW which doesn't support it? > Does the "slow" mean that Wine hits a software rendering fallback and > Mesa emulates vertex shaders with the CPU? I hated it when OSX > advertised features the card didn't have, and I think it's a very bad > idea for Mesa to do the same thing. Yes, a SW fallback. Vertex shaders are always on CPU on i915 by design. It's fragment shaders which suffer from SW fallback when something is used which is unsupported by the chip. > > The GL errors should be fixed though. Can you try to find the commits > in Wine and Mesa that started those errors? Yeah, I've already bisected Mesa. Its commits (which appear next to each other in history) are: 1) The one making wine 1.5.17 slow: 97217a40f97cdeae0304798b607f704deb0c3558 is the first bad commit commit 97217a40f97cdeae0304798b607f704deb0c3558 Author: Eric Anholt <eric(a)anholt.net> Date: Wed Apr 17 13:55:08 2013 -0700 i915: Always enable GL 2.0 support. There's no point in shipping a non-GL2 driver today. :040000 040000 d039f68bbc5a5e610adbeb3d310350a844911fea efac289465401566fec6063b544c0a844e302559 M src 2) The one leading to GL_INVALID_FRAMEBUFFER_OPERATION: 4df1b986d3e44dc035227054000a1d0e1846ef07 is the first bad commit commit 4df1b986d3e44dc035227054000a1d0e1846ef07 Author: Eric Anholt <eric(a)anholt.net> Date: Wed Apr 17 19:10:29 2013 -0700 i915: Add support for GL_EXT_texture_sRGB and GL_EXT_texture_sRGB_decode. This brings the driver up to GL 2.1. :040000 040000 efac289465401566fec6063b544c0a844e302559 5bd49114ce64a359f4a0e3673ec27ca01590adbc M src I'm bisecting wine now to find which commit starts GL_INVALID_FRAMEBUFFER_OPERATION error. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJS5mTVAAoJEN0/YqbEcdMwViwP/3iPmbKEtH/5BBcNLg/IqxGJ > sie+Qn2Yibp+LBf2iYPqshjDKAHBNXiaiMKqTKG8GWzGC235K/Nqc0QoV2sFRRJW > EiroXisQlG6AupmWKqzqldSVYC93tehCQdp982Rk3XYENQmmsuE+OSwMwXAg32ji > 8gKSrZ7EYwT2b4NYy79o7p/KiR5+nO/Mwm7m8wNYLoYPPjQ3yk95pxPxlNlsuAZw > eEeDRNU7lXtIGrYsO+xpA4saCW93vZp2rUqXLlQjAMdOi2HU3F5R7jmsLn/pqvJV > rIawm53PMP7bauUcB926StXYwW8yLeEHAbGtER4t2nJKf9tHNrNNKD0Q8CwrpE1F > fKwMJDHx5YVkeftADm2OiX4PNKflvwfeKTeib9ChCP7ApXbulbRi3Qx/n7Al+ZWv > 6THEBaSS9PlxvPQQ1zwSduATfAMKsMulxDz6I0SPclVTnFTmMcfLxcNtFIHsjkCR > US7Q6hKGHfqLO/OQEdpiJ/4KlQmXrkQkWj0VOwnsBmWjBFv02Q/8Xoj4i50f7Qev > 7KadSvgpgAg5Yu468jBbiVwxibxaxNQZNuJgFUnDfMyMdwBYXD613Ngnm1GriOUO > F+MWvaCKpMK4zsAYIZg366GTjH7XqANVZ1vaCruoAdmB6r39A3/mMiS5kmPoPLP5 > /6tpS/N9eJfBOVyzv9Au > =q+e8 > -----END PGP SIGNATURE-----

Jan. 27, 2014

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().

by Ken Thomases

On Jan 27, 2014, at 12:20 PM, Henri Verbeet wrote: > device: 100 tests executed (0 marked as todo, 0 failures), 0 skipped. Excellent. Bruno also reports no test failures with the new patch. And it removes the broken() entirely, so I'm more confident that it's meaningful. I'll reduce the tracing and resubmit, unless I get bad news from other folks' testing. -Ken

Jan. 27, 2014

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().

by Henri Verbeet

On 27 January 2014 19:03, Ken Thomases <ken(a)codeweavers.com> wrote: > On Jan 27, 2014, at 10:28 AM, Ken Thomases wrote: > >> Thanks for testing on native. And to anybody else listening, I would appreciate more tests on native. > > Actually, I have a new patch that I would appreciate help with testing on native. The patch and a pre-compiled test executable are on this testbot job: > > Job: https://newtestbot.winehq.org/JobDetails.pl?Key=4471 > Patch: https://newtestbot.winehq.org/GetFile.pl?JobKey=4471&StepKey=1 > Executable: https://newtestbot.winehq.org/GetFile.pl?JobKey=4471&StepKey=2 > device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_X1R5G5B5 not supported device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_A1R5G5B5 not supported device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2354: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_A8R8G8B8 not supported device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 1 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2316: Display format D3DFMT_UNKNOWN not supported device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2354: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device: 100 tests executed (0 marked as todo, 0 failures), 0 skipped.

Jan. 27, 2014

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().

by Henri Verbeet

On 27 January 2014 17:28, Ken Thomases <ken(a)codeweavers.com> wrote: >> device.c:2316: Display format D3DFMT_X1R5G5B5 not supported > > means that IDirect3D9_GetAdapterModeCount(…, D3DFMT_X1R5G5B5) returned 0 modes. This: > MSDN for IDirect3D9_EnumAdapterModes() also seems to hint that D3DFMT_R5G6B5, D3DFMT_X1R5G5B5 and D3DFMT_A1R5G5B5 are supposed to be equivalent as far as display modes are concerned. This may be a quirk of the AMD driver, but I don't have a lot of Windows or NVIDIA systems to really compare. > Do you think I should just ignore "nmodes" for windowed mode? It seems like the test is saying that CheckDeviceType() doesn't care whether the display format is supported for windowed mode. Of course, it's unreliable to extrapolate from a single data point. > I'm not sure. Come to think about it, the broken() in this test is perhaps a bit overly broad as well. >> … and produces quite a lot of output in general > > Yeah, although there was a corresponding trace() in the X8R8G8B8 loop in the old code. Since I was consolidating multiple loops into one, I took the union of the features of all of the loops. I can reduce that if you like. > Yeah, it's nice for debugging now, but in the general case it just makes it harder to spot failures.

Jan. 27, 2014

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().

by Ken Thomases

On Jan 27, 2014, at 10:28 AM, Ken Thomases wrote: > Thanks for testing on native. And to anybody else listening, I would appreciate more tests on native. Actually, I have a new patch that I would appreciate help with testing on native. The patch and a pre-compiled test executable are on this testbot job: Job: https://newtestbot.winehq.org/JobDetails.pl?Key=4471 Patch: https://newtestbot.winehq.org/GetFile.pl?JobKey=4471&StepKey=1 Executable: https://newtestbot.winehq.org/GetFile.pl?JobKey=4471&StepKey=2 Run the executable with the argument "device": d3d9_test.exe device Thanks in advance, Ken

Jan. 27, 2014

Re: [PATCH] scrrun: Implement IFolder::get_Path()

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/scrrun/filesystem.c | 10 ++++++++-- > dlls/scrrun/tests/filesystem.c | 9 ++++++++- > 2 files changed, 16 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M scrrun.dll -p scrrun_test.exe.so filesystem && touch filesystem.ok filesystem.c:886: Test failed: got L"wine_ppds", expected L"a" filesystem.c:892: Test failed: got L"C:\\users\\julliard\\Temp\\wine_ppds", expected L"C:\\users\\julliard\\Temp\\a" make[1]: *** [filesystem.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Jan. 27, 2014

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().

by Ken Thomases

On Jan 27, 2014, at 5:16 AM, Henri Verbeet wrote: > On 22 January 2014 23:42, Ken Thomases <ken(a)codeweavers.com> wrote: >> >> Consolidates duplicated code by using a simpler table-driven mechanism. >> Instead of manually listing out certain combinations of display formats vs. >> backbuffer formats, it just lists the formats and some metadata about them. >> The algorithm tests every format against every format, using the metadata >> to predict success or failure. This also tests that CheckDeviceType() fails >> for display formats for which there are no adapter modes, rather than >> skipping those. >> >> Tests windowed mode. >> --- >> dlls/d3d9/tests/device.c | 162 ++++++++++++++++++---------------------------- >> 1 files changed, 64 insertions(+), 98 deletions(-) >> > > This fails on native (Win 7, AMD Radeon HD 6310) That's very peculiar. This: > device.c:2316: Display format D3DFMT_X1R5G5B5 not supported means that IDirect3D9_GetAdapterModeCount(…, D3DFMT_X1R5G5B5) returned 0 modes. This: > device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 > device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_R5G6B5(23) windowed passed while it wasn't expected to means that IDirect3D9_CheckDeviceType(…, D3DFMT_X1R5G5B5, D3DFMT_R5G6B5, TRUE) succeeded. I would not have expected that CheckDeviceType() would succeed if the DisplayFormat parameter was one which the adapter doesn't support modes for. Prior to my patch, the CheckDeviceType() test would have been skipped when the adapter doesn't provide modes for the display format. I can go back to that, but it seems unfortunate. This result is telling us something potentially important about the behavior of CheckDeviceType(). Do you think I should just ignore "nmodes" for windowed mode? It seems like the test is saying that CheckDeviceType() doesn't care whether the display format is supported for windowed mode. Of course, it's unreliable to extrapolate from a single data point. > … and produces quite a lot of output in general Yeah, although there was a corresponding trace() in the X8R8G8B8 loop in the old code. Since I was consolidating multiple loops into one, I took the union of the features of all of the loops. I can reduce that if you like. Thanks for testing on native. And to anybody else listening, I would appreciate more tests on native. -Ken

Jan. 27, 2014

Re: [PATCH 2/2] includes: Fix IDirect3DSwapChain8_Present argument count.

by Henri Verbeet

On 27 January 2014 14:41, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -#define IDirect3DSwapChain8_Present(p,a,b,c) (p)->lpVtbl->Present(p,a,b,c) > +#define IDirect3DSwapChain8_Present(p,a,b,c,d) (p)->lpVtbl->Present(p,a,b,c,d) I think you should fix the C++ version as well.

Jan. 27, 2014

Re: Cross-regressions between wine and mesa: how to handle them?

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-26 14:08, schrieb Ruslan Kabatsayev: > For end user this looks like failing software, and moreover, it's > not easy to understand which software does have bug. Wine > perspective: On the one hand, wine seems to use what Mesa exposes. > On the other, why use shaders for games which don't need them? There are some corner cases in the d3d fixed function pipeline which we can't handle properly without shaders. Unfortunately, once we detect such a corner case it's too late to turn on shaders. A possible workaround for the user is to set UseGLSL=disabled. It's not a good long-term fix though. > Mesa perspective: On the one hand, it wants to advertise more > support for latest OpenGL standards. On the other, why do it for > very old HW which doesn't support it? Does the "slow" mean that Wine hits a software rendering fallback and Mesa emulates vertex shaders with the CPU? I hated it when OSX advertised features the card didn't have, and I think it's a very bad idea for Mesa to do the same thing. The GL errors should be fixed though. Can you try to find the commits in Wine and Mesa that started those errors? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS5mTVAAoJEN0/YqbEcdMwViwP/3iPmbKEtH/5BBcNLg/IqxGJ sie+Qn2Yibp+LBf2iYPqshjDKAHBNXiaiMKqTKG8GWzGC235K/Nqc0QoV2sFRRJW EiroXisQlG6AupmWKqzqldSVYC93tehCQdp982Rk3XYENQmmsuE+OSwMwXAg32ji 8gKSrZ7EYwT2b4NYy79o7p/KiR5+nO/Mwm7m8wNYLoYPPjQ3yk95pxPxlNlsuAZw eEeDRNU7lXtIGrYsO+xpA4saCW93vZp2rUqXLlQjAMdOi2HU3F5R7jmsLn/pqvJV rIawm53PMP7bauUcB926StXYwW8yLeEHAbGtER4t2nJKf9tHNrNNKD0Q8CwrpE1F fKwMJDHx5YVkeftADm2OiX4PNKflvwfeKTeib9ChCP7ApXbulbRi3Qx/n7Al+ZWv 6THEBaSS9PlxvPQQ1zwSduATfAMKsMulxDz6I0SPclVTnFTmMcfLxcNtFIHsjkCR US7Q6hKGHfqLO/OQEdpiJ/4KlQmXrkQkWj0VOwnsBmWjBFv02Q/8Xoj4i50f7Qev 7KadSvgpgAg5Yu468jBbiVwxibxaxNQZNuJgFUnDfMyMdwBYXD613Ngnm1GriOUO F+MWvaCKpMK4zsAYIZg366GTjH7XqANVZ1vaCruoAdmB6r39A3/mMiS5kmPoPLP5 /6tpS/N9eJfBOVyzv9Au =q+e8 -----END PGP SIGNATURE-----

Jan. 27, 2014