January 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().

by Henri Verbeet

On 22 January 2014 23:42, Ken Thomases <ken(a)codeweavers.com> wrote: > > Consolidates duplicated code by using a simpler table-driven mechanism. > Instead of manually listing out certain combinations of display formats vs. > backbuffer formats, it just lists the formats and some metadata about them. > The algorithm tests every format against every format, using the metadata > to predict success or failure. This also tests that CheckDeviceType() fails > for display formats for which there are no adapter modes, rather than > skipping those. > > Tests windowed mode. > --- > dlls/d3d9/tests/device.c | 162 ++++++++++++++++++---------------------------- > 1 files changed, 64 insertions(+), 98 deletions(-) > This fails on native (Win 7, AMD Radeon HD 6310), and produces quite a lot of output in general: device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_X1R5G5B5 not supported device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_R5G6B5(23) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_X1R5G5B5(24) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A1R5G5B5(25) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_X8R8G8B8(22) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A8R8G8B8(21) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A2R10G10B10(35) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_UNKNOWN(0) windowed passed while it wasn't expected to device.c:2316: Display format D3DFMT_A1R5G5B5 not supported device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_A8R8G8B8 not supported device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2316: Display format D3DFMT_UNKNOWN not supported device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0

Jan. 27, 2014

Re: [PATCH] api-ms-win-core-synch-l1-2-0: Add stub dll.

by Martin Storsjö

On Mon, 27 Jan 2014, Dmitry Timoshkov wrote: > Martin Storsjo <martin(a)martin.st> wrote: > >> --- /dev/null >> +++ b/dlls/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.spec > > Windows 7 64-bit here has only api-ms-win-core-synch-l1-1-0.dll, > did you really mean 1-2-0 and what version of Windows provides it? Yes, I meant 1-2-0, and Windows 8.1 (and Windows Phone 8.0, and possibly desktop Windows 8.0 as well) provides it. >> +@ stdcall OpenEventA(long long str) kernel32.OpenEventA >> +@ stdcall OpenEventW(long long wstr) kernel32.OpenEventW >> +@ stdcall OpenMutexW(long long wstr) kernel32.OpenMutexW >> +@ stdcall OpenSemaphoreWlong long wstr) kernel32.OpenSemaphoreW > > The string with OpenSemaphoreW has a typo. Ah, sorry, forgot to amend the patch. Will send a v2 with that fixed. // Martin

Jan. 27, 2014

Re: [PATCH] api-ms-win-core-synch-l1-2-0: Add stub dll.

by Dmitry Timoshkov

Martin Storsjo <martin(a)martin.st> wrote: > --- /dev/null > +++ b/dlls/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.spec Windows 7 64-bit here has only api-ms-win-core-synch-l1-1-0.dll, did you really mean 1-2-0 and what version of Windows provides it? > +@ stdcall OpenEventA(long long str) kernel32.OpenEventA > +@ stdcall OpenEventW(long long wstr) kernel32.OpenEventW > +@ stdcall OpenMutexW(long long wstr) kernel32.OpenMutexW > +@ stdcall OpenSemaphoreWlong long wstr) kernel32.OpenSemaphoreW The string with OpenSemaphoreW has a typo. If somebody else like me wonders why there is no OpenMutexA and OpenSemaphoreA then the answer is that at least 1-1-0 version of this dll in Windows 7 doesn't export them. -- Dmitry.

Jan. 27, 2014

Re: Cross-regressions between wine and mesa: how to handle them?

by Jerome Leclanche

On Sun, Jan 26, 2014 at 1:08 PM, Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > Hi all, > > I've come across a problem, which may be simplest to see in the > following workability diagram, tested on GTAVC on a i915 machine: > _____________________________________________ > Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| > ____9.0_____|____OK____|____OK____|___slow___| > ___~9.1-____|____OK____|___slow___|___slow___| > ___~9.1+____|____OK____|_GL_error_|_GL_error_| > > Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with > "-" earlier commit and "+" later one. > "slow" means slide show instead of normal animation. > "GL error" is a set of errors like > "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> > GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / > 677". > Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. > > All these things are related to wine trying to use GLSL as much as > possible, and Mesa trying to make it seem that it supports OpenGL 2+, > even on chips like i915, which don't support it. > > For end user this looks like failing software, and moreover, it's not > easy to understand which software does have bug. > Wine perspective: On the one hand, wine seems to use what Mesa > exposes. On the other, why use shaders for games which don't need > them? > Mesa perspective: On the one hand, it wants to advertise more support > for latest OpenGL standards. On the other, why do it for very old HW > which doesn't support it? > > So, I'm not sure where I should report these regressions - to > bugs.winehq.org or to bugs.freedesktop.org? I remember some similar > bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and > fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 > worked perfectly for all Mesa versions - is it really Mesa fault that > newer versions of wine don't work? > > Could someone please explain how to handle such situations? > > Regards, > Ruslan > > Quickest way is most likely to do a regression test in Wine wine Mesa 9.1, file a bug and if there is a mesa regression in the lot (this might all be normal behaviour), you will be asked to file a bug upstream on freedesktop.org. J. Leclanche

Jan. 26, 2014

Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes

by Dmitry Timoshkov

Marcus Meissner <marcus(a)jet.franken.de> wrote: > > > +typedef DWORD TP_VERSION,*PTP_VERSION; > > > > PSDK 7.1 has this one and many other definitions in winnt.h instead. > > Hmm. MSDN says differently: > > http://msdn.microsoft.com/en-us/library/windows/desktop/ms687053%28v=vs.85%… > > WinBase.h on Windows Vista, Windows 7, Windows Server 2008, and Windows Server 2008 R2 (include Windows.h); > Threadpoolapiset.h on Windows 8 and Windows Server 2012 It would be better to check actual PSDK headers instead of online docs. -- Dmitry.

Jan. 26, 2014

Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes

by Nikolay Sivov

On 1/26/2014 19:36, Marcus Meissner wrote: >>> +typedef DWORD TP_VERSION,*PTP_VERSION; >> PSDK 7.1 has this one and many other definitions in winnt.h instead. > Hmm. MSDN says differently: > > http://msdn.microsoft.com/en-us/library/windows/desktop/ms687053%28v=vs.85%… > > WinBase.h on Windows Vista, Windows 7, Windows Server 2008, and Windows Server 2008 R2 (include Windows.h); > Threadpoolapiset.h on Windows 8 and Windows Server 2012 > > So where should I move it? I checked SDK 6.0, 7.0, 7.1 and 8.0, all of these have it in winnt.h > > Ciao, Marcus > > >

Jan. 26, 2014

Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes

by Marcus Meissner

On Mon, Jan 27, 2014 at 12:21:21AM +0900, Dmitry Timoshkov wrote: > Marcus Meissner <marcus(a)jet.franken.de> wrote: > > > +#define WINPR_API WINBASEAPI > > This definition doesn't exist in PSDK 7.1. hmm, ok, can redo. > > +typedef DWORD TP_VERSION,*PTP_VERSION; > > PSDK 7.1 has this one and many other definitions in winnt.h instead. Hmm. MSDN says differently: http://msdn.microsoft.com/en-us/library/windows/desktop/ms687053%28v=vs.85%… WinBase.h on Windows Vista, Windows 7, Windows Server 2008, and Windows Server 2008 R2 (include Windows.h); Threadpoolapiset.h on Windows 8 and Windows Server 2012 So where should I move it? Ciao, Marcus

Jan. 26, 2014

Re: [PATCH 2/2] kernel32: very simple initial threadpool test

by Dmitry Timoshkov

Marcus Meissner <marcus(a)jet.franken.de> wrote: > +static NTAPI void threadpool_workcallback(PTP_CALLBACK_INSTANCE instance, void *context, PTP_WORK work) { > + int *foo = (int*)context; > + > + (*foo)++; > +} Although this most likely compiles without warnings 'NTAPI' should be replaced by the correct one, and its placement should be fixed. -- Dmitry.

Jan. 26, 2014

Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes

by Dmitry Timoshkov

Marcus Meissner <marcus(a)jet.franken.de> wrote: > +#define WINPR_API WINBASEAPI This definition doesn't exist in PSDK 7.1. > +typedef DWORD TP_VERSION,*PTP_VERSION; PSDK 7.1 has this one and many other definitions in winnt.h instead. -- Dmitry.

Jan. 26, 2014

Cross-regressions between wine and mesa: how to handle them?

by Ruslan Kabatsayev

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

Jan. 26, 2014