January 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode

by Bruno Jesus

On Thu, Jan 23, 2014 at 9:41 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 +++ > dlls/bcrypt/tests/bcrypt.c | 59 > +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 65 insertions(+) > Hi, Kai. > + status = pBCryptGetFipsAlgorithmMode(&result); > + ok(!status, "expected status STATUS_SUCCESS(0), got 0x%08X\n", status); > + ok(!result, "expected result FALSE, got %d\n", result); If the value depends on a registry entry how can you be sure it will always return 0? If the registry key is the only parameter required to return in this function IMO you should read the registry here and check against that instead of a fixed value. Best wishes, Bruno

Jan. 24, 2014

Re: mscms: make missing lcms2 an error, not a fixme

by Austin English

On Thu, Jan 23, 2014 at 2:23 AM, Hans Leidekker <hans(a)codeweavers.com>wrote: > On Wed, 2014-01-22 at 21:28 -0800, Austin English wrote: > > It breaks applications (e.g., the Adobe Flash installer), it should be > an error. > > In that case many other fixme's also qualify as errors ;-) Loading mscms > without > liblcms2 support doesn't necessarily mean that the application will break. > It may > not actually use it or it may only use functions that don't depend on > liblcms2. > Fair point, I was unclear. Similar cases (missing native OS libraries) tend to be errors. I've noticed this for at least gnutls and libxml2 on 64-bit distros that weren't yet fully multiarch. I had trouble finding the lcms issue until I scanned more carefully, since it wasn't an ERR ;). I don't really see the harm in upgrading it (considering it is a misconfiguration/broken package, not missing functionality waiting for developer action). -- -Austin

Jan. 23, 2014

Re: [PATCH 4/5] gdiplus: Implement SetPageTransform playback.

by Bruno Jesus

On Wed, Jan 22, 2014 at 10:49 AM, Akira Nakagawa <matyapiro31(a)gmail.com> wrote: > You have written the following: > but you missed break;at the end of case {}. There is a return, so there is no need for a break. > + case EmfPlusRecordTypeSetPageTransform: > + { > + EmfPlusSetPageTransform *record = (EmfPlusSetPageTransform*)header; > + GpUnit unit = (GpUnit)flags; > + > + if (dataSize + sizeof(EmfPlusRecordHeader) < sizeof(EmfPlusSetPageTransform)) > + return InvalidParameter; > + > + real_metafile->page_unit = unit; > + real_metafile->page_scale = record->PageScale; > + > + return METAFILE_PlaybackUpdateWorldTransform(real_metafile); > + } > default:

Jan. 23, 2014

Re: mscms: make missing lcms2 an error, not a fixme

by Hans Leidekker

On Wed, 2014-01-22 at 21:28 -0800, Austin English wrote: > It breaks applications (e.g., the Adobe Flash installer), it should be an error. In that case many other fixme's also qualify as errors ;-) Loading mscms without liblcms2 support doesn't necessarily mean that the application will break. It may not actually use it or it may only use functions that don't depend on liblcms2.

Jan. 23, 2014

Re: [PATCH] bcrypt: Added stub implementation for BCryptGetFipsAlgorithmMode

by Kai Blaschke

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > user32 and gdi32 APIs are not used in the test and should be removed > from the imports list. > > Probably BCryptGetFipsAlgorithmMode should be loaded dynamically. > A usual test for invalid (NULL) argument would be useful. Also > status should be printed in hex to match ntstatus.h definitions. Valid points, consider it done. Additionally, I did some quick research about the implementation of BCryptGetFipsAlgorithmMode, and all it actually does is querying two registry keys, as documented in the Windows knowledge base article 811833 (http://support.microsoft.com/kb/811833/en-us) I'm going to implement this properly instead of a stub, and also add a NULL pointer check for pfEnabled, returning STATUS_INVALID_PARAMETER if it fails. Scrub my patch, I'll send in a new one. -- Kai

Jan. 23, 2014

Re: shlwapi/tests: Avoid preprocessor check to ensure it compiles

by Dmitry Timoshkov

André Hentschel <nerv(a)dawncrow.de> wrote: > -#if 0 /* This test crashes on WinXP SP2 */ > +if (0) > +{ > ret = (*pSHCreateStreamOnFileA)(test_file, mode | stgm, NULL); > ok(ret == E_INVALIDARG, "SHCreateStreamOnFileA: expected E_INVALIDARG, got 0x%08x\n", ret); > -#endif > +} Please keep the comment. -- Dmitry.

Jan. 23, 2014

Re: [PATCH] bcrypt: Added stub implementation for BCryptGetFipsAlgorithmMode

by Dmitry Timoshkov

Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > diff --git a/dlls/bcrypt/tests/Makefile.in b/dlls/bcrypt/tests/Makefile.in > new file mode 100644 > index 0000000..363986e > --- /dev/null > +++ b/dlls/bcrypt/tests/Makefile.in > @@ -0,0 +1,5 @@ > +TESTDLL = bcrypt.dll > +IMPORTS = user32 gdi32 bcrypt user32 and gdi32 APIs are not used in the test and should be removed from the imports list. > +static void test_getFipsAlgorithmMode(void) > +{ > + BOOLEAN result = TRUE; > + NTSTATUS status = BCryptGetFipsAlgorithmMode(&result); > + ok(!status, "expected status STATUS_SUCCESS(0), got %d\n", status); > + ok(!result, "expected result FALSE, got %d\n", result); > +} Probably BCryptGetFipsAlgorithmMode should be loaded dynamically. A usual test for invalid (NULL) argument would be useful. Also status should be printed in hex to match ntstatus.h definitions. -- Dmitry.

Jan. 23, 2014

Re: Add support to arguments with dash in taskkill

by Dmitry Timoshkov

Akira Nakagawa <matyapiro31(a)gmail.com> wrote: > if (*argdata != '/' && *argdata != '-') > argdata is wchar type,so you should do as > if (*argdata != L'/' && *argdata != L'-') Not really, ASCII set (0 - 0x7f) is replicated in unicode. -- Dmitry.

Jan. 23, 2014

Re:Add support to arguments with dash in taskkill

by Akira Nakagawa

if (*argdata != '/' && *argdata != '-') argdata is wchar type,so you should do as if (*argdata != L'/' && *argdata != L'-')

Jan. 23, 2014

Re: [PATCH 1/2] advapi32: Foundation for HKCR merge

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4407 Your paranoid android. === build (build) === Patch failed to apply

Jan. 23, 2014