October 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9167 Your paranoid android. === w7u (32 bit msg) === msg.c:12149: Test failed: unexpected hwnd 0017014A msg.c:12171: Test failed: bad time 3077e/3078e

Oct. 1, 2014

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-01 16:28, schrieb Dmitry Timoshkov: > My understanding is that not the absence of minimize/maximize > button prevents an ability to programmatically minimize/maximize a > window, but an item in the system menu. I'd suggest to also add a > test for sending WM_SYSCOMMAND/SC_MINIMIZE/SC_MAXIMIZE behaviour. Is there a dedicated flag that controls the system menu item? (There is in X11 / MWM, and it is what controls the questionable behavior in Metacity). My goal with this test is to reproduce what d3d9 does - and that's ShowWindow(SW_MINIMIZE or rather SW_SHOWMINIMIZED) on a Window without a caption, minimize button and depending on the game sometimes without WS_SYSMENU. Minimization seems to work regardless of window style. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJULBMRAAoJEN0/YqbEcdMwN2IP/idGvTgrk6bH9lQmv/rK64Hi ZiBIipwOKxRB0s4YL/R9Ww7Vuw0ns7PqJyXpiSQpYe4kPibVGc3+ClkE95+SUDYK Kzd0toQb+qe5+hZqny+AyqNZYeOBIuoZcb8P0icyIovFZ46imB82c/uY3sMOo/iD I2sh+Q1MyqAVzres3/KByxbqq12FoZ8GGJ9lFDoKVhR0rm96C9q5w3Z4JTlhvzWj IF7/aRHfneatbACGZk/3ABS3qNSAQqIf+Uv4S6x80LtEzMXj/JohzfmMvWYDWxGb jmnWHvhHQXzUkm8WIf0nr/3iWAi8h9WlwjyW/ut4J48PFvrytkDaUQz4Be85WlPd PjseZB+YVthsa4VRdcRDCZPIvXAlIWWjwpaZBqEYB4LKR5wKZZQcWu8/ByQq5Hb4 P8plScVFotTDWhx+2Q63TIYHndzAMqxQYx0iLveyUT03qYc4wDmVNxmuM8UX56WN /cIl4Iv0AgWynuFOt5aVxILQGbtvWXjO+vEenaxjUoDxljUcLDfBdzrKVsH3bkYX a0S4UW5ZLojfRxJ/RXThDaF9MxHGMNonREuPbGYbEZjRnkMUSqhkzGkKEuViBQrZ mFIBEyHSU8jnXWpPUmrMrZ/PUYwTJ3/01gxFFoX1ntK4LsSmppszPpSADw5CQOAU 5cPByJDr6Qw3+w4UZjkD =OrFp -----END PGP SIGNATURE-----

Oct. 1, 2014

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.

by Dmitry Timoshkov

Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This shows that the abesence of a minimization button does not prevent > the application from programmatically minimizing the window. KWin and > fvwm behave like Windows in this regard, whereas Metacity-based WMs > prevent the minimization. My understanding is that not the absence of minimize/maximize button prevents an ability to programmatically minimize/maximize a window, but an item in the system menu. I'd suggest to also add a test for sending WM_SYSCOMMAND/SC_MINIMIZE/SC_MAXIMIZE behaviour. -- Dmitry.

Oct. 1, 2014

Re: [2/4] server: Support sending process and thread security descriptors for the "new_process" request in the protocol.

by Alexandre Julliard

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > + if (req->process_sd_size > get_req_data_size() || > + req->thread_sd_size > get_req_data_size() - req->process_sd_size || > + req->info_size > get_req_data_size() - req->process_sd_size - req->thread_sd_size) > + { > + close( socket_fd ); > + return; > + } You have to return an error. > + req_info = (const startup_info_t *) > + ((char*)get_req_data() + req->process_sd_size + req->thread_sd_size); > + req_env = (const WCHAR *) > + ((char*)get_req_data() + req->process_sd_size + req->thread_sd_size + req->info_size); > + req_env_size = get_req_data_size() - (req->process_sd_size + req->thread_sd_size + req->info_size); These may not be valid pointers (alignment is not checked) so it would be better to avoid declaring them as variables. -- Alexandre Julliard julliard(a)winehq.org

Oct. 1, 2014

Re: Wine Gecko 2.34-beta1 release

by Jacek Caban

On 10/01/14 14:00, Jacek Caban wrote: > The tip usually needs some patches on top of it to > build, To be clear, those are always on their way to upstream. The problem is that for some of them, it take a while. Jacek

Oct. 1, 2014

Re: [PATCH 4/5] d3d9/tests: Add a test for vs_3_0 shaders using more than 256 constants.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-09-30 14:51, schrieb Matteo Bruni: > --- > dlls/d3d9/tests/device.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) I think it would be a good idea to check the behavior of d3d9ex. It may lift some restrictions of plain d3d9. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUK+z6AAoJEN0/YqbEcdMwrrsP/1aU53A4nN8vmohZ4KtnKs42 DYvnr1cJxCjRCTM9c8xcH4t1FAMcbIy0HTygQNrvifvYBZbGqSmkA3vArIRxsIeK t5vSlAFvV14sWi4krsw+sRLzsYtpe1LWji9AW6DpzheJDNl2eaE2oxFRhloPv/KE 9d2O3x/9g0ww/231drtc6RxL5kd7cFs15XKw1LnawurxOB79McuEFkt75OEOFpB6 7wlzQdhe9PI0uiluxhXfKqLF3EehBR4j2KAYQO5O8KpFLMObSUJrdwhvc6Fmlwtb t6vH20mDewuCJF6fliCKyLpM4ujnxuwmBz5sl6D50javzknqX2kzG5PX6jnj8ezR iSBoGZJMY/B+UKKMHgJNzgbP6g3X7LICAs7lBlfuiTdVau+YvUf+8JiNoCkF7NFO aXPuVt/rJ+4k5Q5ZFCq9Vt7dmy9gtJGM8ZJw4z30Nz0v16LSRFQHMfBaqco3HCib todvTsy1/bLwrA6k+ANvWWwJmqKHaLIFm7ZcEZNi5cMxNtAKKHbyPzN19syhFuVU gxlqVtTuB/yT+3Kd7G+1pH2Wr7NZNG1szJfQLVS4ns4PXBtbarINDCYW2fUpfvS6 bpzMjYzWe0ePGN58XRCVqrptx7q6IW3GLueJYq5zSHsRRmawwQx1xJBTA0qAqq7I GworiiALSOo3MMD4YZb+ =42bF -----END PGP SIGNATURE-----

Oct. 1, 2014

Re: Wine Gecko 2.34-beta1 release

by Jacek Caban

On 09/24/14 16:51, Qian Hong wrote: > Hi Jacek, > > On Wed, Sep 24, 2014 at 9:42 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: >> We need a long term solution, which means >> working on auto generated C/C++ bindings based on the new, WebIDL files. >> I may write a separated mail about that if there is an interest. > Thanks for the hard work on wine gecko! > For the WebIDL topic, I believe it is interesting and appreciated :) OK, I will write a separated mail about it soon. > BTW, as we discussed in MN, could we host a read-only public mailing > list or similar things to monitor wine-gecko daily build failures? We can't really monitor wine-gecko daily. wine-gecko is updated only when I do merges (in the past it was about once a week and I hope to go back to this strategy). I always make sure that it builds and that Wine can use it after such merge. However, we may build on top of Gecko (mozilla-central) tree. That's where most build problems come from (the diff between those branches are our modifications for Wine). I thought about it a bit. I have a cron job that builds Gecko tip nightly on my box. The easy way would be for this cron job to send a mail to such mailing list. However, I'm not sure that's a good idea. The tip usually needs some patches on top of it to build, so it's not really usable for people without them. I could publicize those patches, but then we have a pretty complicated situation anyway. We were also talking about more ambitious solution of setting up build bot. That's much more work, but it also has way more benefits. It would be great to have such thing working, but I can't spend too much time on it. If we had a volunteer to do that, I'm happy to talk about it. Jacek

Oct. 1, 2014

Re: [PATCH 5/5] jscript: Added support for '-' CC expression.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9163 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Oct. 1, 2014

Re: [PATCH 2/5] jscript: Added tests for @if/@elif/@else/@end.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9160 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Oct. 1, 2014

Re: dpnet: Implement IDirectPlay8Address GetComponentByName (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9156 Your paranoid android. === w8 (32 bit address) === Failure running script in VM: timed out waiting for the child process

Oct. 1, 2014