November 2014 - Wine-Devel - list.winehq.org

Re: wined3d: Add NVIDIA Geforce GT 750M to supported device list.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-14 01:30, schrieb Jonas Maebe: > FWIW, I have such an NVIDIA Geforce GT 750M card (under OS X > 10.9.5) and Crossover 13.2 returned 768MB of vram for it. Crossover > 14/14.0.1 returns 128MB instead, which resulted in a number of > games suddenly crashing because they ran out of VRAM. CrossOver isn't really the concern for this mailing list, but I'll have a look. CrossOver used to use ARB shaders for performance reasons, but on 13.x (and 14.x) we changed this on OSX because OSX supports only 128 fragment program env parameters, which isn't enough for many modern Shader Model 3 games (they expect 256). So I don't think shader_arb_get_caps is to blame. What does Wine return for your card? If it also misidentifies the card it's something we should fix. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUZd2uAAoJEN0/YqbEcdMwkuEP/i9s3yl9JiAkl4jRZG9mmeRP xXd0KqiZhVR9lJMIL5q+FDZk+2FiAneBr4d9JsCYpOjQDfX02Ae/sZCJkrUIGs5f 7g0DqTalZiU+c60tx+n5cApRVT0E7dOaxWpb6u9wloV+VhWF2pq5ukWzqnaTBG1F Uw68V9gj8dd0v/5LG9Z/chM5MZubRjYMpxnxV+YljVgtTMA2Di9lCQzIFLLLJ4ql GXoVZrpHSZtIrWmr3cb6x/Z5gD5qh3pOrLAC1MbW40srUOeVT2sKBjWyHGj40HLx 3RcihRf4Anr7l1SnmIg6V+AWs0GxUAkC1SLgV7v+lS72qrGtk4Wm5X/cnR7oGhIn THo2RqaX1tC6dDKhdVabuiIwkCD9l7DxjzdAbUqq7+o9h3r76u8N9YnSOTWouaUX Xne/qzoLsIm7kgFO7ZsS4Q10X6VE7OGcYM6fFDrAvvMr5/j0gfV5fKBz5AoQ8riI aEE/ilw4VnT4hNTQ4JlibVUhg7D2yFKdRRd6wlJ5aiBQnZbUR0s64qB+JgxvuK2V mEadFk6Akx6Pay41LLnfqEvSKJ3gIB+V34GHwXFg5guMfx7N8KEKN+liWjKSPsVS 9iLJ8yQhJyQ4EZTy5F/gz69RaqQ+afHkIyCxZyWb4XmjgjJw/1gcNDXQRkjj+iEI K/4xIFWaGT1saJhyoVCO =/sPJ -----END PGP SIGNATURE-----

Nov. 14, 2014

Re: [2/2] ntdll: Implement Rtl[Add|Remove]VectoredContinueHandler semi-stubs.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10262 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/003C0001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

Nov. 14, 2014

Re: [1/2] ntdll/tests: Add basic tests for Rtl[Add|Remove]VectoredContinueHandler.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10261 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00350000/00350001 exception: unhandled exception 80000004 at 00350000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/00350001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/003D0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/003C0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

Nov. 14, 2014

Re: [PATCH 5/7] d3d8/tests: Test style changes on focus loss.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10250 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2889: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2893: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2916: Test failed: Failed to reset device, hr 0x88760868. device.c:2920: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2924: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2938: Test failed: Failed to set foreground window. device.c:2942: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:2946: Test failed: Expected device window extended style 0x108, got 0x100.

Nov. 14, 2014

Re: [PATCH 4/7] d3d8/tests: Test messages on focus loss.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10249 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000301BA, got 0002004C. device.c:2888: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2892: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2915: Test failed: Failed to reset device, hr 0x88760868. device.c:2919: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2923: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3291: Test failed: Failed to reset device. device.c:3298: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3306: Test failed: Expected wndproc != 0x413100.

Nov. 14, 2014

Re: wined3d: Add NVIDIA Geforce GT 750M to supported device list.

by Jonas Maebe

FWIW, I have such an NVIDIA Geforce GT 750M card (under OS X 10.9.5) and Crossover 13.2 returned 768MB of vram for it. Crossover 14/14.0.1 returns 128MB instead, which resulted in a number of games suddenly crashing because they ran out of VRAM. This issue was quickly diagnosed by the helpful Codeweavers support person, and resolved by adding the registry entry to override the video memory size. Looking at the current source code, I assume that's because shader_arb_get_caps() can set the shader_caps->vs_version maximally to 3, while d3d_level_from_caps() will only return WINED3D_D3D_LEVEL_10 for shader_caps->vs_version==4. As a result, d3d_level_from_caps now returns WINED3D_D3D_LEVEL_9_SM3, which is translated for an unknown NVidia card into CARD_NVIDIA_GEFORCE_6800. That one is indeed defined as having 128MB of VRAM.

Nov. 14, 2014

Re: winemac: WS_EX_DLGMODALFRAME shouldn't prevent the window being resizeable.

by Ken Thomases

On Nov 13, 2014, at 10:00 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > Hi, > > On Nov 13, 2014, at 3:26 AM, Huw Davies <huw(a)codeweavers.com> wrote: > >> --- >> dlls/winemac.drv/window.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c >> index e61a517..54bd56e 100644 >> --- a/dlls/winemac.drv/window.c >> +++ b/dlls/winemac.drv/window.c >> @@ -72,12 +72,12 @@ static void get_cocoa_window_features(struct macdrv_win_data *data, >> if (ex_style & WS_EX_TOOLWINDOW) wf->utility = TRUE; >> } >> } >> - if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; >> - else if (style & WS_THICKFRAME) >> + if (style & WS_THICKFRAME) >> { >> wf->shadow = TRUE; >> if (!data->shaped) wf->resizable = TRUE; >> } >> + else if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; >> else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) wf->shadow = TRUE; >> } > > I think that's the correct logic, but it would be better to separate out setting resizable and shadow. The shadow stuff can be a single "if" with the conditions ORed together. Resizable can be a single "if" or even a simple assignment of a boolean expression. Er, too late it seems. Never mind then. :) -Ken

Nov. 13, 2014

Re: winemac: WS_EX_DLGMODALFRAME shouldn't prevent the window being resizeable.

by Ken Thomases

Hi, On Nov 13, 2014, at 3:26 AM, Huw Davies <huw(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index e61a517..54bd56e 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -72,12 +72,12 @@ static void get_cocoa_window_features(struct macdrv_win_data *data, > if (ex_style & WS_EX_TOOLWINDOW) wf->utility = TRUE; > } > } > - if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > - else if (style & WS_THICKFRAME) > + if (style & WS_THICKFRAME) > { > wf->shadow = TRUE; > if (!data->shaped) wf->resizable = TRUE; > } > + else if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) wf->shadow = TRUE; > } I think that's the correct logic, but it would be better to separate out setting resizable and shadow. The shadow stuff can be a single "if" with the conditions ORed together. Resizable can be a single "if" or even a simple assignment of a boolean expression. Thanks, Ken

Nov. 13, 2014

Re: [PATCH] reg.exe: Modernise print functions

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-10 14:05, schrieb Jonathan Vollebregt: > Unfortunately if I pass in anything besides a pointer it will > segfault. It actually wants a format string "%1!d!" for ints which > is hardly compact (Especially since we have to type it out in a > WCHAR array) > > There must be a better way to get the size of the string... Fwiw, I cannot really comment on this patch because I have no experience with output handling. I'm afraid the two of you have to come to an agreement on your own. Just two general observations: *) The entire console writing code is terribly verbose, but I guess that's the Windows API's fault. What may help is a helper file similar to include/wine/list.h that contains this code, so it doesn't have to be re-coded in every program. I haven't looked at the individual implementations though. *) I see the static buffer passed to LoadString as a relatively minor issue because the length of those strings is fixed. Translations may cause problems I guess. Does SizeofResource() help here? I'm a bit confused re HMODULE and HINSTANCE. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUZLzJAAoJEN0/YqbEcdMwDrMP/Anod8C7HBg5lm+6N8dsitLK x+43aRa4lFEpZjQfpCf8TM3GMH7QupWppDh6tVYjRR9jKkAv003aTJRhqJMAHprH tq84pGMaQVi7I0ZDVoUL/svWX7wj/HTts6VHhs1dfheREi7LE08L8AG3pcU/rFn5 r2P9UhSHyBtIhn+XQSQVn+Ssf2bwoqPcuY/C9w1aynt9qUpuPTxUPOPFtLZvzBLo 1fIWFZGFTzpf3qQk8saeSMNLT09NKscDhQC7jfkTHlRAbdJxK1fbD0QFgcAlZVzP dHNx0TqJENTCvMS9ZSYhvOB6EQQB9mQH342RkMzkWMKc6cSEp9i7ts3B7hLy83uB 53OILAVKuFWc9mocjCmhKy2WgvhAMxYozw3sHi/n46vulRDxloMjMvJn2tKF7lmA wghxYnzPibtLgFT1XiRQFLjL5oADOfu86rTn4p1NvA9oACVIqA/eClbzcQUjgnz3 uKiM/Noy3zCGeYg4wrHf4dKnsXz8exSYXPQwCl0hIH04ccZgANqz8a+dN1pYj+BZ Pn00z8K2vg+Ym7YSgMn/8Sc1JpvF+uY7thoWQPJOZZ2mMGyuMoC7TpbDyd/E69rl 9+HybOJZH2aWonU6aJ4C0CC4SNpYXGZByYskyHgf5cGDLrD469mAISyysFO1AATX KW09FeePhDwdtC6CzynL =pPPj -----END PGP SIGNATURE-----

Nov. 13, 2014

Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-13 11:44, schrieb Henri Verbeet: > This patch is mostly just blocked by the tests failing, but I'd > also have to wonder if the window proc should be installed in the > first place if the device is created with NOWINDOWCHANGES. The tests say yes - patch 3 adds NOWINDOWCHANGES to test_wndproc, and the window proc is still modififed. Even with NOWINDOWCHANGES d3d9 restores the screen resolution on focus loss, and it knows about focus loss somehow (TestCooperativeLevel returns the expected values), and replacing the wndproc is kinda necessary for both of these. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUZJHQAAoJEN0/YqbEcdMwHlEP/RnugjwwACCms0/nLIon7n11 zsj3RDbYf2N3BKc8UgC3jD85pd8kLC+t+VKCsrUUZStPTlLe4tl3gkL05l1VorJs h4JZoRAa6Qt3YrcfW11VXuqNqoyt8YXTvSTh+JrtijdzPOMgefB0tr+EjLXRQNY1 xBnNam3LUyw7NfRz3QdKFD4uXhJtyc8bhBvR2VIWLa1jMwlsV8LuWTgRh7DyCEjZ lMJ5cPYjjERRCU+1h5Y+nUHiXqFWAB6hWoBud1lKrnJfJCqsuJ7udrsKi73g+FcG XZ4VHbMurdpjwjT4BnnTtEDF/yjolV19CoSH9D7OfjgKJe8vrV3JzRLSW8y2O7bS cNMajIlk3ywTqMzH2ZEmzungBW8Ldpi7sE3clRhrJRWgRlty623zfR6Wc8vo5z3U 6qgrU2WCejUM3t74t15cFEHfpg3sT25iGD/XWskW7EcrrdWudEjJo01/fTT6eOeF GF52FPUaiwfQ+alQXHDAw5NcVcLsiA0gi35SQ9ebYdpMwrC1W/HXxB0t8fidfZu7 +/Ttu9qUxUZlay/lB5YBiSe7QHCWj9Vf/tfcbjsqCPrD/ov4/C1a+/mO8Ot3FNAZ IBMDrdJ+M74hVHkkjncg9gRtwOrHN9w2ywav28+02vidjqHQg2KwpQHElUMem5n0 eVVETgwSARjaxy3kAuvV =Mc7Q -----END PGP SIGNATURE-----

Nov. 13, 2014