November 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 1/4] wined3d: Vertex fog uses the absolute eye position z (v3).

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-27 14:14, schrieb Joachim Priesner: > Am Donnerstag, 27. November 2014 schrieb Stefan Dösinger: >> This is written from scratch, but inspired by the patch from >> Joachim Priesner. The included test tests the absolute minimum >> necessary to show that the abs() needs to be placed in the fixed >> function vertex pipeline replacement shader. It ignores vertex >> and pixel shader behavior. > > Does this mean I can finally stop worrying about my version of the > bug fix and concentrate on getting my other two pending patch sets > in? Yes. Version 3 of my patches made it in, so your game should work now. The part from your test that tested the vertex shader behavior is still on my todo list, but since we don't know any application that has a problem with the current behavior it is fairly low priority. I must admit that the way we handled this was not our finest hour. It is quite clear that we have a big problem with handling new or sporadic contributors. > ws2_32: WS_get_local_ips: Fix ordering of IP addresses by metric > if two addresses have the same metric (try 2) > > which seems pretty straightforward and fixes a real bug, and also > on I agree that it is straightforward. I only see a minor issue: I think you can drop the if (!left || !right) check - the qsort man page suggests this is not necessary. I guess writing tests for this is impossible because the input comes directly from the host system's network setup which can only be modified with root permissions. The other problem ws2_32 has is that there's apparently no one except Alexandre who claims to know it well. > [PATCH 3/3] comctl32: Implement the TaskDialog function (try 2) > [PATCH 2/3] comctl32: Basic implementation of TaskDialogIndirect > (try 2) [PATCH 1/3] comctl32: Move TaskDialogIndirect function to > separate file (try 2) I have never touched comctl32, so I'm not really qualified here. The overall feeling is that the code looks like is is copypasted together from various places. (The style inconsistencies trigger that suspicion). Combined with the lack of tests it raises the question of how solid this implementation is in the long run. Also the defines like TD_WARNING_ICON look like they're copypasted from Microsoft's header. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUeERNAAoJEN0/YqbEcdMwCIsP/0GAOAbqlEQRR0Md7dHE6z2n 3tHm8Too/wkPSmF89r0/PwPAn9eEuoWxpwVFSOsup8fyFAGZ66BEOITnQF9hiE4A SPtkrkV4HNNgw/m+iYZuUmf4daZLE8/iEwVenaaDrwpruFC84zGBrKBOfpNba8fH JeM1peJftvh9uR8aR9ARIonGKbghIsby0ce5SbKMSZJ2ufycsAhx+YQOyXmm6G4A oKADQDmbdtfMopeswyZyInKBiOOFCR+XrnbRLxMl/cj4u9gT7HisTIQsNzYoDdym qT9XSRaI/ksbOW2siEbKkKhxLr+27WbJRuKL9tVN8fydbj65+KDQDeMLHQe+1DTO kOU2/9l3IDXICDP3x7EtlK1sO3CdcaTrWyqz6BUInPVmoxtwVM7qWebpw8Ulq0o4 AAU5r1Y7A1tD8iAB1q15iw66kGQDDdaOtaZisbJHzznpWkL1MI10PVk2qMpONOaE Al6XauEZaiJR+0Fi/cqt9LOV+iEg+0OeU/cOz+DPR2FhkeDhec06No/EFqbNusSK klYfF7SqQ4OwZs3LcQBQwYlQy1ienj9oenX0KxlCxAXahTa1z3DGDCuuji9pPUnF 9fZc9Aaa1hFP7sWf2WpgVqyB5/HFZUWm2uyDVA/Ft+AJyld0046K0jPVowb0CXCS auBFcZHd1dZRCIPIjgN4 =+m+F -----END PGP SIGNATURE-----

Nov. 28, 2014

Re: winetest: Skip over stub dll if detected

by Rosanne DiMesio

On Thu, 27 Nov 2014 14:15:16 -0600 Austin English <austinenglish(a)gmail.com> wrote: > On Nov 27, 2014 3:28 AM, "Stefan Dösinger" <stefandoesinger(a)gmail.com> > wrote: > > > > > > + * Windows 8 has a concept of stub DLL's. When DLLMain is called the > user is prompted > > > + * to install that component. To bypass this check we need to look > at the version resource. > > A matter of opinion according to Wikipedia, feel free to ignore me: > "DLLs" would be better as the plural of "DLL". "DLL's" looks like the > possessive, although > http://en.wikipedia.org/wiki/English_plurals#Plurals_of_letters_and_abbrevi… > says that using 's to form the plural of an abbreviation is legitimate. > > The apostrophe is sometimes used, but it's definitely not the preferred way. Using apostrophes to pluralize abbreviations and numbers was more common in the past, but is outdated. In contemporary usage, apostrophes are for possessives and contractions, and only used to pluralize in cases where they are needed to make the meaning clear (e.g., "A's" vs "As").

Nov. 27, 2014

Re: winetest: Skip over stub dll if detected

by Austin English

On Nov 27, 2014 3:28 AM, "Stefan Dösinger" <stefandoesinger(a)gmail.com> wrote: > > > + * Windows 8 has a concept of stub DLL's. When DLLMain is called the user is prompted > > + * to install that component. To bypass this check we need to look at the version resource. > A matter of opinion according to Wikipedia, feel free to ignore me: "DLLs" would be better as the plural of "DLL". "DLL's" looks like the possessive, although http://en.wikipedia.org/wiki/English_plurals#Plurals_of_letters_and_abbrevi… says that using 's to form the plural of an abbreviation is legitimate. The apostrophe is sometimes used, but it's definitely not the preferred way.

Nov. 27, 2014

Re: [1/3] wined3d: Add a new enum for GL_EXT_geometry_shader4

by Henri Verbeet

On 25 November 2014 at 00:34, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > În ziua de Lun 24 Noi 2014, la 21:54:02, Matteo Bruni a scris: >> Not going to happen this year, hopefully at some point next year. >> I agree with Henri that it isn't probably worth to add this kind of >> stuff just for the fallback. > If it's not ok to add support for new extensions just to improve the fall-back > mechanism then how about reverting to the old behaviour of treating all DX9 > SM3 cards as DX10? While it was wrong, no one complained about it. But they do > complain about the new behaviour. Most likely because most DX9 era cards are > already explicitly recognized while most cards hitting the fall-back are newer > ones that are actually DX10 or even DX11 capable. > I don't have the impression that this is a big issue for most people. We certainly don't seem to get a lot of bug reports about this, and the workaround is fairly easy.

Nov. 27, 2014

Re: [PATCH 1/4] wined3d: Vertex fog uses the absolute eye position z (v3).

by Joachim Priesner

Am Donnerstag, 27. November 2014 schrieb Stefan Dösinger: > This is written from scratch, but inspired by the patch from Joachim > Priesner. The included test tests the absolute minimum necessary to show > that the abs() needs to be placed in the fixed function vertex pipeline > replacement shader. It ignores vertex and pixel shader behavior. Does this mean I can finally stop worrying about my version of the bug fix and concentrate on getting my other two pending patch sets in? If so, I'd very much like feedback on 107283 Pending Joachim Priesner ws2_32: WS_get_local_ips: Fix ordering of IP addresses by metric if two addresses have the same metric (try 2) which seems pretty straightforward and fixes a real bug, and also on [PATCH 3/3] comctl32: Implement the TaskDialog function (try 2) [PATCH 2/3] comctl32: Basic implementation of TaskDialogIndirect (try 2) [PATCH 1/3] comctl32: Move TaskDialogIndirect function to separate file (try 2) which I submitted almost two months ago, but which, after one round of feedback, vanished from the patches list without further comment. What can I do to make these patches better? Add tests? Split into smaller files? Give up altogether? NB, both patch sets fix issues with applications I work with -- does creating a bug report increase the chances of the patches getting looked at? Thanks for any help. Joachim

Nov. 27, 2014

Re: [PATCH 1/5] wined3d: Vertex fog uses the absolute eye position z (v2).

by Henri Verbeet

On 27 November 2014 at 10:47, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: >> For what it's worth, I still plan to merge device.c and visual.c >> at some point in the future, > I don't like this idea. I prefer to be able to run the visual tests on > Windows without the mode setting tests in device.c messing up my > screen and taking forever on my slow monitor. I'm also not a fan of > 30k lines of code in a file, although that doesn't mean we have to go > to the opposite extreme and add hundreds of 50-line .java files. > Actually, new tests should in general go into device.c although we haven't really been enforcing that, in part because we currently don't have the get_surface_color() / getPixelColor() helpers in device.c. Merging would help with duplication of helper functions, and also be more consistent with the ddraw, d3d10core and d2d1 tests. D3d9 in particular is weird because it has the device/visual split for d3d9, but a single file for d3d9ex. Perhaps some of the mode setting tests can be merged together, although obviously at the cost of increased complexity, or perhaps we can e.g. introduce a WINETEST_ environment variable to avoid running them. I think improving the mode setting tests is a separate issue from merging device.c and visual.c though. As an aside, many of the Present() calls in visual.c are really only useful when debugging, and just removing them may speed things up as well, although I haven't verified that. > (Yeah, I can comment out unused tests while working on a new one, but > that's awkward too.) I pretty much already always do that. In part because it helps to avoid depending on side effects of previous tests, and in part because it's just so much faster, especially on the testbot.

Nov. 27, 2014

Re: [PATCH 1/5] wined3d: Vertex fog uses the absolute eye position z (v2).

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-27 10:22, schrieb Henri Verbeet: > For what it's worth, I still plan to merge device.c and visual.c > at some point in the future, I don't like this idea. I prefer to be able to run the visual tests on Windows without the mode setting tests in device.c messing up my screen and taking forever on my slow monitor. I'm also not a fan of 30k lines of code in a file, although that doesn't mean we have to go to the opposite extreme and add hundreds of 50-line .java files. (Yeah, I can comment out unused tests while working on a new one, but that's awkward too.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUdvNMAAoJEN0/YqbEcdMwiH8P/01Nb8L4AvvJSedspW7DVrfN Auotg4zhcjEaQ6XwqIWp4H/WkItJemHV871z3UQ7gLUSSbSa2+iONtd0NUpqbCJj H7AFh+jzHI1M2TUDHTzaXekMQ/XW/mtfaDDSwsjqG56K2S47fbSjN8FkmyNx5T6J BuU5lDz0w0dB/3L4VxGOd68Pqwag2DIcAzsmKUY3bVtWpuuY0dfZad7RJAJ95KIt UvSVL/grqN4zH33VwRrkUkgWfYwAtuLgg5DjjzWlaFPETbwT0iIzMcD2BawCPOfy KuoaP/ythS7zOwflijE+y46rCqLS70W66px56xHt3JKZcUFw5CAban2TNxFCGl1h VGXQTDNV1U3YeC+v+lpBuRycIrGkoTncXEoyH0qSX8PV/AcWlcZIpSuDtLV27dir qsX198zm311eFPfLo4OK5ATxvolBMjNS7gS0YEXPoJoH6hPQX2R+VeLXc3lRICaw NKUu0zSLSvm4ysufSZvMGlzdrxTFMxIT5+tccNUN4cTvBvT9bjqBbpCkPrZlcAkv oplV32aVOJ4RXaYAoKEYhmDEccIFlsLAYfHIqKpLp0wTdd+s2nI65P/U/K4E1Ut4 v65nUx7xixqJmpMiPi6bZgVP3hoElTK8Kvs1bFyylGzWIQWZNv3flRpRTWfY2PT1 ffnYZKN8qRo/kpOLz2n6 =raX1 -----END PGP SIGNATURE-----

Nov. 27, 2014

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate (v2).

by Henri Verbeet

On 27 November 2014 at 10:33, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > I can't look into the AMD drivers, so I don't know for sure, but I think this is different. fog_test, fog_interpolation_test want a redundant application of the projection matrix. In this case there's a SetTransform(D3DTS_PROJECTION) already, but the z = 0.0 part breaks AMD drivers in RHW draws. > > Why are you asking? Do you have some idea what is causing this behavior? > Mostly just curiosity.

Nov. 27, 2014

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate (v2).

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-27 10:27, schrieb Henri Verbeet: > On 26 November 2014 at 19:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> + /* Needed to make AMD drivers happy. Yeah, it is not supposed to >> + * have an effect on RHW draws. */ >> + static const D3DMATRIX identity = >> + {{{ >> + 1.0f, 0.0f, 0.0f, 0.0f, >> + 0.0f, 1.0f, 0.0f, 0.0f, >> + 0.0f, 0.0f, 1.0f, 0.0f, >> + 0.0f, 0.0f, 0.0f, 1.0f >> + }}}; > Is this the same projection matrix issue as in > fog_test()/fog_with_shader_tests()/etc.? I can't look into the AMD drivers, so I don't know for sure, but I think this is different. fog_test, fog_interpolation_test want a redundant application of the projection matrix. In this case there's a SetTransform(D3DTS_PROJECTION) already, but the z = 0.0 part breaks AMD drivers in RHW draws. Why are you asking? Do you have some idea what is causing this behavior? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUdu/4AAoJEN0/YqbEcdMwYHwP+wfCV/wc3k/UC7rIEuiV3Yb2 Y8UZj790hTsnugODUsy4a/Dk9E/qgko24qBCbL4TLmvKvXz9FDukXxY6Ru2c86JT Cb2zCMhzoOQ74i8nVhvR0faA4/gwGK3c1GUHEtCruEntUuSEGE3EvFk5l99MgltX 147v+J8qt8InXtH+9IzG1aG0G4i1BB61Uau0ZT3llbEhSkkpq0Rw1gH4UsXHb66j RWUp8H0cPfRSzv8wBv44xS3dsthUF3V+PuC/tYVIzMghSOaEIPZFcKR0HsGz/2Y0 7QIdlRvzs+k5Lzv6HwGJf4XHFRTJPvexkb8VmIEtYuR6mIDObNqInbQUECw66wGE Mczc7RihYCufbYl8JVT3mtKaG8fsTp64a6OLNrM3dsSW5CFLsevL6QfH/A+wFopk eTPo12274ehhzC1DZlqPL6svX/J+PTHJT3FyIxZKsinMaOxqfY5QJhmGFXqMaSYT RCDz/pSG0LeaXVbl2dR2ABotzWYGwBeLJYzar8fYu00Gv3wvRk9cd/AlbvkIAtl1 SAhmYzvwYWaX16uLRj04fW0M5TmTXW+VUDVjKzrM+0Q2UyblfIkDj/wvRJxROT2S HC0dVTevof8hVY7MJ1o94L6wV+mAkMktNXwb0ddbrEdt76j1rBe8c43LAi31Ek7E RdzxUPj8ItbG4GGeb2p1 =5+Vg -----END PGP SIGNATURE-----

Nov. 27, 2014

Re: winetest: Skip over stub dll if detected

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-27 04:11, schrieb Alistair Leslie-Hughes: > Hi, > > Changelog: > winetest: Skip over stub dll if detected Does LoadLibrary(LOAD_LIBRARY_AS_DATAFILE) avoid triggering the "do you want to install dplay?" message box? (I guess because DllMain is not called) > + LPSTR data = HeapAlloc(GetProcessHeap(), 0, size); > ... > + if (VerQueryValueA(data, buf, (LPVOID*)&p, &size)) LPJUNK. (Use void ** for LPVOID *) > + sprintf(buf, "\\StringFileInfo\\%04x%04x\\OriginalFilename", MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), 1200); I'll test this on my non-english Windows and see if this works as intended. > + * Windows 8 has a concept of stub DLL's. When DLLMain is called the user is prompted > + * to install that component. To bypass this check we need to look at the version resource. A matter of opinion according to Wikipedia, feel free to ignore me: "DLLs" would be better as the plural of "DLL". "DLL's" looks like the possessive, although http://en.wikipedia.org/wiki/English_plurals#Plurals_of_letters_and_abbrevi… says that using 's to form the plural of an abbreviation is legitimate. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUdu6IAAoJEN0/YqbEcdMwmZQP/i9yruybSkmeAtFnaAu6SPG9 r73Q/028i2u/mOqaxrc90L/uzM1+sOU7Y9hctp0obQJ1RjpNJqhtqV5UnyFrdWIP 2B6LsrOjk99pxUXDEsLX8r5cSnQqdXqpqey600WQDJwFp/hrnIC3QF3MPheIqkJh I7OUptt6QPTQpdJmab4rh7Bt+/hEVwol4wNF3UW6S4cYvdh6L5UtEW5OK4+qelWC 8ztulOrGkvlJfwV3ax3fKfu/7UpROyBi6yVKTuuprCxvKCHpr41Vxl+JWmBef16v VHZYJ0Jo9OrW48PGTp0mnL9tP/BVIrwcc8lJLIyvYqc3T2FoVXqQBAo/X3RUYQGF mlVdThstHTSQDldSJfwYhZETxPsjRS9hud3DWNjj5YzLPnw9kpKL+cOVDIze3GXV 9xikER+GQMPRjsh5EK1Z5Jtwn3i0V8XF5aDJBLJT8zXE8EOYjFCwl6YOPSgXRF0P FDzPfkex7NJaefjJ5tQmJw8MFYwP5HU+nBTlwwzoiAtca6+zfn/aULlmFJcDU9Zq gjnY7eUIngRqnPPVBbYz+5B7+YMwjoN7NvTtQ/C4uuufvulYa9gvuakg15HZKVE8 GIwISlj8SSbmoSNMRgfoADBiCurDNlh3rMTeuWKMNREAX+x0EsoOBVgHZ3qS+vqP ZixdoJfhP2OPm1LMWiUN =0DlV -----END PGP SIGNATURE-----

Nov. 27, 2014