November 2014 - Wine-Devel - list.winehq.org

Re: fusion: Remove unused IAssemblyCacheItem (Clang)

by Nikolay Sivov

On 21.11.2014 22:58, André Hentschel wrote: > --- > dlls/fusion/asmcache.c | 94 -------------------------------------------------- > 1 file changed, 94 deletions(-) > I guess the idea was to create some instance with CreateAssemblyCacheItem(), it's trivial and I think we should do that instead of removing item code (even if it's a stub).

Nov. 22, 2014

Re: dwrite/tests: Remove unused functions (Clang)

by Nikolay Sivov

On 21.11.2014 22:58, André Hentschel wrote: > --- > dlls/dwrite/tests/analyzer.c | 7 ------- > dlls/dwrite/tests/layout.c | 7 ------- > 2 files changed, 14 deletions(-) I'll send a patch to use those helpers, don't remove them for now.

Nov. 22, 2014

Re: dwrite: Remove unused code (Clang)

by Nikolay Sivov

On 21.11.2014 22:58, André Hentschel wrote: > --- > dlls/dwrite/bidi.c | 6 ------ > dlls/dwrite/shape.c | 2 -- > 2 files changed, 8 deletions(-) > I don't mind, let's remove that. Looks like iso_previousChar() could be removed from usp10 too then.

Nov. 22, 2014

Re: wined3d: Add NVIDIA Geforce GT 750M to supported device list.

by Andrei Slăvoiu

În ziua de Mar 18 Noi 2014, la 23:32:47, Andrei Slăvoiu a scris: > I was thinking of adding another extra check to > d3d_level_from_caps similar to the one that checks for GLSL 1.30 for the > mesa drivers. > > But since now that function no longer has access to gl_info and it would be > very ugly to add it back just for this extension how about setting a new > lets call it WINED3D_SHADER_CAP_GEOMETRY_SHADER4 to wined3d_caps in case > this extension is found but not everything that is required for true SM4 > support? Since nobody replied I just went ahead and wrote the code. See my latest series on the patches list.

Nov. 21, 2014

Re: [PATCH 5/5] d3d8: Only one fullscreen swapchain is allowed.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10398 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

Nov. 21, 2014

Re: [PATCH 4/5] d3d8/tests: Fix test_cursor().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10397 Your paranoid android. === w8 (32 bit device) === device.c:1186: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1231: Test failed: Reset failed, hr 0x88760868. device.c:1233: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1237: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1244: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1245: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1246: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1247: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1248: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1249: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1254: Test failed: Screen width is 640, expected 800. device.c:1255: Test failed: Screen height is 480, expected 600. device.c:1261: Test failed: Back buffer width is 640, expected 800. device.c:1263: Test failed: Back buffer height is 480, expected 600. device.c:1293: Test failed: Screen width is 640, expected 1024. device.c:1294: Test failed: Screen height is 480, expected 768. device.c:2481: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2486: Test failed: The focus window is active. device.c:2494: Test failed: Got unexpected hr 0x88760869. device.c:2500: Test failed: Got unexpect screen size 800x600. device.c:2515: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2524: Test failed: Got unexpect screen size 800x600. device.c:2537: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2544: Test failed: Got unexpect width 640. device.c:2545: Test failed: Got unexpect height 480.

Nov. 21, 2014

Re: [PATCH 1/5] dxgi/tests: Test fullscreen and multiple swapchains.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10394 Your paranoid android. === wvistau64 (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w2008s64 (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w7u (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w8 (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === wvistau64 (64 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w2008s64 (64 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0.

Nov. 21, 2014

Re: gdiplus:GdipDrawImagePointsRect has a nosie vertical line output after resampled

by Vincent Povirk

This will break in cases where the destination area (defined by points) is not a rectangle. On Fri, Nov 21, 2014 at 8:32 AM, 刘昌辉 <liuchanghui(a)linuxdeepin.com> wrote: > > > >

Nov. 21, 2014

Re: [PATCH 4/5] wined3d: Don't minimize hidden Windows.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-20 11:35, schrieb Henri Verbeet: I'm working on a test to show that we should set device->filter_messages = TRUE around the ShowWindow(SW_MINIMIZE) call. I'll change this when adding this test. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUb2ufAAoJEN0/YqbEcdMwPmoP/RHYXBNqdaAaNzalmS0Govlr q9MA3oxVswytrneRfdMu8HU/Yw1G4la1J0lZrU+n1W8KuQ4JjN6BhJaJqK8+09NG plxT/+oGpi2MzmxHVAFIeevxs62BS4UYqThvbxZNDVlDDstKEt6AGCzS9ipuNGpF ciTv3/FfzxAEOsWfkmh1McmvY4bhGpPOzcwJMdF6YJG6vwi8bZXXOf2wFxH/p+9N 01KS/2PZC3bhq1P/ZktMKNRNGZ+rU54qjnO+2u38qTNZfYv3ddV4mteHHLUwz7Y9 IVu/aKcKv5XAhO7iOgoO36ywj8dYZ+4esdqEkz9yufnVGRA9xgX7ZuPaveaVQ94O ENhj7tpcWoXko0u87+G+JV4onl8WIMDzvAJXpCGNlFzqtujzlp7kTM2lI7viXlLW 4zDC6wHPOPfFGfJoRB9PX/iTlzXCR3zAE3w/rFt52UV/m6CcAFe7mFr6McFvAa2F VUTfrb8w+NhN6KPKk0O70tTbmClsEdgAAL8M8j/KHzRfGymdcKXvGPiszcpEOJBn vNBQuAI9vaf/WDAhPgttFLJZxa0IKsmOOGO1hbFvHV9eiVXItcqDEdAJWJeUQraB rGP9WAX9K5jc6UmzQMelMY/KWCdipB/adOjI4esaiUMCg+x/zezMAll2Lzj/LDhO OhyT8lOIZuoziLdpp64D =HfsN -----END PGP SIGNATURE-----

Nov. 21, 2014

Re: gdiplus:GdipDrawImagePointsRect has a nosie vertical line output after resampled

by Sebastian Lackner

Hi, while looking quickly over your patch I noticed a couple of mistakes / things you should probably change: On 21.11.2014 15:32, 刘昌辉 wrote: >+ int src_img_height = src_rect.Height; >+ int dest_img_width = dest_rect.X + dest_rect.Width; >+ int dest_img_height = dest_rect.Height; >+ BYTE* src_img_data = malloc (src_img_width*src_img_height*4); >+ BYTE* dest_img_data = malloc (dest_img_width*dest_img_height*4); You shouldn't use malloc(...) and free(...) in wine source, use HeapAlloc(...) and HeapFree(...) instead. >+ >+ /*first line*/ >+ value = *( (DWORD*)dest_img_data + dest_rect.X) ; >+ /*printf ("pixel(%d,%d) = %08x\n", dest_rect.X, 0, value );*/ I assume the printf was for debugging, remove it, or if it is really very important then use trace(...) instead. Other tests use GdipBitmapGetPixel(...) for reading the color of specific pixels. If its possible to use that here too, it would look a bit better than directly accessing the memory. >+ ok ( value > 0, >+ "dest image color should same as src image color\n"); You are switching between different styles in your patch several times. Try to make the style match a bit more the sourrounding code, especially whitespace before and after functions. In this case a linebreak is also not really necessary for example, other lines are much longer. Regards, Sebastian

Nov. 21, 2014