December 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 08/15] msvcr120: Remove stray parameter specs for stub functions.

by Alexandre Julliard

Martin Storsjö <martin(a)martin.st> writes: > Ok, thanks for clarifying. The issue I encountered was that if I ran > tools/make_specfiles afterwards (after setting up msvcr120_app to be > synced against msvcr120), the make_specfiles script ended up changing > msvcr120_app.spec like this: > > -@ stub _wperror > +@ cdecl _wperror(wstr) msvcr120._wperror > > (Which is wrong since _wperror only is a stub in msvcr120 as well.) There's nothing wrong with forwarding to a stub. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2014

Re: [PATCH 08/15] msvcr120: Remove stray parameter specs for stub functions.

by Martin Storsjö

> Martin Storsjo <martin(a)martin.st> writes: > > > This avoids adding stray functions when using make_specfiles. > > There shouldn't be any reason to do that. The parameters are here on > purpose. Ok, thanks for clarifying. The issue I encountered was that if I ran tools/make_specfiles afterwards (after setting up msvcr120_app to be synced against msvcr120), the make_specfiles script ended up changing msvcr120_app.spec like this: -@ stub _wperror +@ cdecl _wperror(wstr) msvcr120._wperror (Which is wrong since _wperror only is a stub in msvcr120 as well.) But I guess this is an issue with make_specfiles then, not with the specfile itself. // Martin

Dec. 3, 2014

Re: [PATCH 08/15] msvcr120: Remove stray parameter specs for stub functions.

by Alexandre Julliard

Martin Storsjo <martin(a)martin.st> writes: > This avoids adding stray functions when using make_specfiles. There shouldn't be any reason to do that. The parameters are here on purpose. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2014

Re: Puzzle about ExtSelectClipRgn?

by Vincent Povirk

This is possible if both regions are more complex shapes (not just one rectangle) that do not share any pixels. For example, the clip region could consist of the rectangles (693,5)-(694,6) and (762,27)-(763,28); and hregion could be (762,5)-(763,6) and (693,27)-(694,28). You can use GetRegionData to determine the exact set of rectangles in the region.

Dec. 3, 2014

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.

by Qian Hong

Hi Indrek, On Mon, Dec 1, 2014 at 3:46 PM, Indrek Altpere <efbiaiinzinz(a)hotmail.com> wrote: > Hello > > I even saw your patch in my inbox but it does not appear at > https://source.winehq.org/patches/data/107949 for some reason, so I don't > remember what lines you changed exactly so apologies if I seem to be > re-stating things tou fixed already. > > > When checking > http://source.winehq.org/git/wine.git/blob_plain/HEAD:/loader/wine.inf.in > there is also tons of other discrepancies (if you didn't already). > > > Parameters are escaped with ""%1"" but not command: > HKCR,Msi.Package\shell\Open\command,,2,"%11%\msiexec.exe /i ""%1""" > HKCR,Msi.Package\shell\Repair\command,,2,"%11%\msiexec.exe /f ""%1""" > HKCR,Msi.Package\shell\Uninstall\command,,2,"%11%\msiexec.exe /x ""%1""" > > > Command itself is escaped: > HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" > > > Neither command nor parameter is escaped: > HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe > setupapi,InstallHinfSection DefaultInstall 132 %1" > > HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" > > > If winebrowser needs escaping because %11 contains a space then all other > places also use %11 need that escaping. And if msiexec need to escape %1 > then all other places need it too don't they? > Thanks a lot for your comment, I'm investigating a bit more... Will update later :) -- Regards, Qian Hong - http://www.codeweavers.com

Dec. 3, 2014

Re: [PATCH 01/15] msvcr120: Implement the _vacopy function.

by Alexandre Julliard

Martin Storsjö <martin(a)martin.st> writes: >> dlls/msvcr120/msvcr120.spec | 2 +- >> dlls/msvcrt/misc.c | 8 ++++++++ >> include/msvcrt/crtdefs.h | 2 ++ >> 3 files changed, 11 insertions(+), 1 deletion(-) > > I saw on http://source.winehq.org/patches/ that this one was rejected > - > any comment on why and what needs to be fixed? Same problem, va_copy is not available everywhere. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2014

Re: [PATCH 01/15] msvcr120: Implement the _vacopy function.

by Martin Storsjö

Hi, On Mon, 1 Dec 2014, Martin Storsjo wrote: > --- > dlls/msvcr120/msvcr120.spec | 2 +- > dlls/msvcrt/misc.c | 8 ++++++++ > include/msvcrt/crtdefs.h | 2 ++ > 3 files changed, 11 insertions(+), 1 deletion(-) I saw on http://source.winehq.org/patches/ that this one was rejected - any comment on why and what needs to be fixed? // Martin

Dec. 3, 2014

Re: [PATCH 02/15] msvcr120: Implement more C99 math functions.

by Martin Storsjö

On Tue, 2 Dec 2014, Alexandre Julliard wrote: > Martin Storsjo <martin(a)martin.st> writes: > >> Implement the *rint, trunc, *round, log2, exp2 and cbrt >> function families. >> >> These are directly passed on to the corresponding host >> libc functions. > > You can't do that, there's no guarantee that the host has these > functions. Ok, so I should try to detect whether the host libc has got the C99 functions, and try to emulate them using other (C90) functions otherwise. I did notice that msvcrt already uses sinhf unconditionally, and this is also a function only available since C99. // Martin

Dec. 3, 2014

Re: ole32: fixed CoWaitForMultipleHandles cause app hang

by Sebastian Lackner

On 03.12.2014 08:15, Changhui Liu wrote: > > > Do I understand you correctly that this is caused by my recent fix of CoWaitForMultipleHandles? Which app is it? Your change might be correct, but to ensure that this is the case please add a test for it: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ole32/tests/compobj.c… Moreover you should completely remove old code then, not just comment it out. Regards, Sebastian

Dec. 3, 2014

Puzzle about ExtSelectClipRgn?

by Changhui Liu

Dear all, I test this code : void test (HDC hdc, HRGN hregion) { RECT srcbox; RECT dstbox; GetClipBox(hdc, &dstbox); GetRgnBox(hregion, &srcbox); TRACE("Before ExtSelectClipRgn:%s,%s\n", wine_dbgstr_rect(&srcbox), wine_dbgstr_rect(&dstbox) ); ExtSelectClipRgn(hdc, hregion, RGN_AND ); GetClipBox(graphics->hdc,&dstbox); TRACE("After ExtSelectClipRgn:%s,%s\n", wine_dbgstr_rect(&dstbox) ); } It output in wine is : Before ExtSelectClipRgn:(693,5)-(763,28),(693,5)-(763,28) After ExtSelectClipRgn:(693,5)-(693,5) But I think it should be output: Before ExtSelectClipRgn:(693,5)-(763,28),(693,5)-(763,28) After ExtSelectClipRgn:(693,5)-(763,28) Where is my understanding mistake, or is it a bug in ExtSelectClipRgn? Thank you!

Dec. 3, 2014