December 2014 - Wine-Devel - list.winehq.org

Re: FOSDEM 2015

by Rosanne DiMesio

On Mon, 29 Dec 2014 11:12:21 -0600 Jeremy White <jwhite(a)codeweavers.com> wrote: > > Hmm. We don't really have a procedure for this, do we? We asked > Roseanne to coordinate finding events for people to talk at, as far as I > recall. I've created a wiki page listing conferences for 2015, http://wiki.winehq.org/Conferences2015, though many of the dates are still TBA. One coming up soon is SCALE 13x in Los Angeles, Feb. 19-22. It's too late to submit papers, but their website says that "Non-Profit/Dot-Org exhibitor opportunities are available," so getting a table might still be possible. Conferences with RFP deadlines coming up soon: Hong Kong Open Source Conference 2015: Hong Kong, June 26-27; RFP deadline Jan. 11, 2015 LinuxFest Northwest 2015: Bellingham WA, April 25-26; RFP deadline Jan. 30, 2015

Dec. 30, 2014

Re: kernel32: Implement Get{Time,Date}FormatEx

by Nikolay Sivov

On 30.12.2014 2:06, Sean Burke wrote: > Provides an implementation of time and date format functions added in > Vista sufficient to allow some basic applications requiring them to run. > Includes necessary tests and header defs. > > > Sean Burke > > > Hi, Sean. As you can see tests are failing on win2000 and winxp because these calls are not available on these platforms. You should use GetProcAddress() to fix that. > +@ stdcall GetDateFormatEx(ptr long ptr wstr ptr long ptr) First argument should be 'wstr' as well. > +@ stdcall GetTimeFormatEx(ptr long ptr wstr ptr long) Same. > +INT WINAPI GetDateFormatEx(LPCWSTR lpLocaleName, DWORD dwFlags, > + const SYSTEMTIME* lpDate, LPCWSTR lpFormat, > + LPWSTR lpDateStr, INT cchDate, LPCWSTR lpCalendar) Please use cleaner argument names, like 'localename', 'flags', 'date', 'format', etc. So lowercase, no prefix. > + lcid = LocaleNameToLCID(lpLocaleName, 0); > + > + return NLS_GetDateTimeFormatW(lcid, dwFlags | DATE_DATEVARSONLY, lpDate, > + lpFormat, lpDateStr, cchDate); No real need for temporary 'lcid' variable.

Dec. 30, 2014

Re: kernel32: Implement Get{Time,Date}FormatEx

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10947 Your paranoid android. === w2000pro (32 bit locale) === The test timed out === wxppro (32 bit locale) === The test timed out

Dec. 30, 2014

Any last UTF-7 comments?

by Alex Henrie

Now that Alexandre has merged a complete set of UTF-7 tests, are there any more comments on the two implementation patches before I submit those as well? https://github.com/alexhenrie/wine/commits/master -Alex

Dec. 29, 2014

Re: [PATCH] dsound: allow LOCHARDWARE flag

by Alexandre Julliard

Mark Harmstone <hellas(a)burntcomma.com> writes: > @@ -975,12 +975,6 @@ HRESULT DirectSoundDevice_CreateSoundBuffer( > TRACE("(lpwfxFormat=%p)\n",dsbd->lpwfxFormat); > } > > - if (dsbd->dwFlags & DSBCAPS_LOCHARDWARE && > - !(dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER)) { > - TRACE("LOCHARDWARE is not supported, returning E_NOTIMPL\n"); > - return E_NOTIMPL; > - } > - It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dsound.dll -p dsound_test.exe.so dsound && touch dsound.ok dsound.c:1705: Test failed: CreateSoundBuffer(1) gave wrong error: 00000000 -- Alexandre Julliard julliard(a)winehq.org

Dec. 29, 2014

Re: ntdll: fix read_directory_getdirentries() under FreeBSD.

by David Naylor

On Monday, 29 December 2014 18:50:12 André Hentschel wrote: > Am 29.12.2014 um 17:34 schrieb David Naylor: > > On Monday, 29 December 2014 14:32:20 André Hentschel wrote: </snip> Thanks :-) > >> You're adding a FIXME comment, but you should rather clarify your > >> question, use wine-devel and/or IRC and/or "git blame" for that.> > > The change in question was done by Alexandre Julliard, in revision > > 96b7c71c. > "git show 96b7c71c" gives some information My understanding is that has_wildcard() returns false if the pattern it contains will only match a singe file. If we have already received that file then there is no reason continue processing the directory contents. In the case of getdirentries(), it will attempt a "reset" however in this case there is no need for such extra work since a "restart" will not occur. ???

Dec. 29, 2014

Re: ntdll: fix read_directory_getdirentries() under FreeBSD.

by André Hentschel

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 29.12.2014 um 17:34 schrieb David Naylor: > On Monday, 29 December 2014 14:32:20 André Hentschel wrote: >> Am 28.12.2014 um 21:09 schrieb David Naylor: >>> Change the handling of getdirentries(2) by: - tracking the data pointer instead of subtracting 'res' - simplify rewind by skipping re-appending entries onto the list - try make the logic easier to follow --- dlls/ntdll/directory.c | 73 +++++++++++++++++++------------------------------- 1 file changed, 28 insertions(+), 45 deletions(-) >> Hi and welcome to Wine development, > > Hi, > > Thanks for the welcome. > >> maybe it's just me, but the patch is not easy to review. > > The patch was almost a complete rewrite, taking a different approach to solve the problem, so I would suggest looking at it more applied than as a change to code. > >> Is it possible to split the patch into multiple atomic patches (maybe three, as in the change list you provided)? > > I think I could split it up. I'll do what I can. How do I mark this patch as superseded by the other (split-up) patches? mention it in the first patch of the series >> Also, how does the patch fix Wine on FreeBSD? > > Please see bug 35397 [1] for the full details. The summary is that resumes failed, duplicating items and skipping over others. mentioning the bug number is always a good idea >> A quick look at the patch itself: You missed a whitespace at the last lseek call. > > Will fix. > >> You're adding a FIXME comment, but you should rather clarify your question, use wine-devel and/or IRC and/or "git blame" for that. > > The change in question was done by Alexandre Julliard, in revision 96b7c71c. "git show 96b7c71c" gives some information -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQGcBAEBAgAGBQJUoZRTAAoJEGm5GZTakYssyWYMAJ+3/qJfM20AyThz0Rg9/9oI hfG/VXXDB3swzJmOgyhHwQWWuedVDu9zc33qV90tN3LKavbXwvyuWNoPuJoPyFM5 kgztboOfXreOemv1iyei+Rlwt3B711DAWFclWM/mtdPnA7FFiMv/yOhozfLcD327 C13u026wzNSd1LKsV22vPge9OqY6U5pBNiuEYLMm+5S5+YHX/P2uD6isQdaB/OV3 SWkjQ0y2eOkt+uvu2Iv0TZJLuN9w6LUaq8oEpyF8t7lOGdUJZ2gWOeKxRz7LihC6 ox1zrz3/9rLKmawHHey0rxdG+46LmPx8szq/lzSpYiYRn1/V4vengf/cR4XyTMDc kGY6KrUyRCC247b/us2Vzqhb31og/0auSRNMXZwMB6jKWXzMMEcgIdV6Sa+8nw8J q0FWEJE1o5wOUke7HTEcddaYCxPGycRwxYhNzF19UL9IuQuQxpXjBv6Z36AtqwuV UZCah3S/5X+eYLXXQ1UXr5Hba2BLNLs9/u0Pk9qifw== =neiw -----END PGP SIGNATURE-----

Dec. 29, 2014

Re: FOSDEM 2015

by Jeremy White

> My main agenda is to sit in the Xorg room for smalltalk. If there's > interest on part of the Xorg developers I can give an updated > performance talk like the last two years. If anyone is planning a Wine > table I can help out with it, or talk to other upstream projects if > anyone else here has any errands to take care of. Hmm. We don't really have a procedure for this, do we? We asked Roseanne to coordinate finding events for people to talk at, as far as I recall. I'm not sure what the plan was if people came with an idea, like this. This will all need a 'blessing' from the Wine fiscal committee, but it certainly seems to line up with our stated goals. Then the question becomes if anyone else (even non devs, maybe especially non devs) would be interesting in running a Wine table, or if we're just thinking of sending Stefan. How about if we appoint Stefan in charge of coordinating this? Stefan, when you have a more clear idea of who/what/when/how much, how about if you drop a private line to me, Michael, Marcus, Austin, and Alexandre for us to decide on the funding. Cheers, Jeremy

Dec. 29, 2014

Re: secur32: Always tell the user that libgnutls could not be loaded

by Henri Verbeet

On 28 December 2014 at 13:00, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Ensures a message is printed in the standard output to make the > problem obvious. Will solve problems like the one in > https://bugs.winehq.org/show_bug.cgi?id=35180#c4: > You'd probably want that to go to the winediag channel then.

Dec. 29, 2014

Re: FOSDEM 2015

by Henri Verbeet

On 29 December 2014 at 08:19, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > Party Fund has enough resources to send myself (and/or Henri and > Matteo if they're interested) to FOSDEM. > Not particularly. Primarily because FOSDEM has a tendency to schedule their conference around the same time I'd like to go skiing, but of course also for much of the same reasons that there won't be a Wine room this time.

Dec. 29, 2014