February 2014 - Wine-Devel - list.winehq.org

Fwd: [The Wine Project] Your organization application has been accepted.

by Austin English

We're in for GSoC 2014! Please update http://wiki.winehq.org/SummerOfCode#head-008ecfc639831c4db4d11a0e8983ef4eb0… any ideas you have for potential students. Let me or Andre know if you have any questions. ---------- Forwarded message ---------- From: <no-reply(a)google-melange.appspotmail.com> Date: Mon, Feb 24, 2014 at 10:40 AM Subject: [The Wine Project] Your organization application has been accepted. To: austinenglish(a)gmail.com Congratulations! Your Organization Application for The Wine Project to Google Summer of Code 2014 has been accepted. Your organization's information will be auto-populated from your Organization profile onto our Participating Organizations page. Please click http://www.google-melange.com/gsoc/org/profile/edit/google/gsoc2014/wine if you want to modify your Organization profile. We recommend you take time to review your profile carefully and add relevant information and links for the students where applicable. If you have questions about items on this profile we would recommend you read over the Melange User's Guide's section titled "Our organization was accepted! How do I create my organization homepage?<http://en.flossmanuals.net/melange/org-application-period/> " Please be aware the your organization's information is now available to students, so you should expect to get contact from potential applicants very soon. If you have any questions, please email Carol Smith directly at carols(a)google.com, but generally, you are off to the races. Student applications formally open on 10 March at 19:00 UTC. Best regards, -- -Austin

Feb. 28, 2014

Re: itss: Use BOOL type where appropriate

by Nikolay Sivov

On 2/28/2014 20:17, Frédéric Delanoy wrote: > --- > dlls/itss/lzx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dlls/itss/lzx.c b/dlls/itss/lzx.c > index 01a9492..9e343da 100644 > --- a/dlls/itss/lzx.c > +++ b/dlls/itss/lzx.c > @@ -85,14 +85,14 @@ struct LZXstate > ULONG window_posn; /* current offset within the window */ > ULONG R0, R1, R2; /* for the LRU offset system */ > UWORD main_elements; /* number of main tree elements */ > - int header_read; /* have we started decoding at all yet? */ > + BOOL header_read; /* have we started decoding at all yet? */ > UWORD block_type; /* type of this block */ > ULONG block_length; /* uncompressed length of this block */ > ULONG block_remaining; /* uncompressed bytes still left to decode */ > ULONG frames_read; /* the number of CFDATA blocks processed */ > LONG intel_filesize; /* magic header value used for transform */ > LONG intel_curpos; /* current offset in transform space */ > - int intel_started; /* have we seen any translatable data yet? */ > + BOOL intel_started; /* have we seen any translatable data yet? */ > This is a part of another project, I don't think we need it to differ more than it does already.

Feb. 28, 2014

Re: TestBot job 5278 results: [PATCH] scrrun: Implement CreateTextFile() method (try2)

by Nikolay Sivov

On 2/28/2014 18:42, Marvin wrote: > === w2000pro (32 bit filesystem) === > > scrrun: > filesystem.c:140: Test failed: got 0x800a0046 I don't think it's related, this test already supposed to fail, with a different error code however.

Feb. 28, 2014

Re: [PATCH] scrrun: Implement CreateTextFile() method (try2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5278 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

Feb. 28, 2014

Re: [PATCH] scrrun: Implement CreateTextFile() method

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + /* map access mode */ > + if (mode & (ForWriting | ForAppending)) > + access = GENERIC_WRITE; > + if (mode & ForReading) > + access |= GENERIC_READ; Probably append mode needs additional handling. -- Dmitry.

Feb. 28, 2014

Re: [PATCH] scrrun: Implement CreateTextFile() method

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5276 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

Feb. 28, 2014

Re: [PATCH 4/5] ddraw/tests: Don't trust what EnumDevices() tells us about the supported Z buffer formats.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5274 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:746: Test failed: Got unexpected color 0x00000000. ddraw2.c:3199: Test failed: Got unexpected color 0x000000ff. Failure running script in VM: network read timed out === w8 (32 bit ddraw1) === ddraw1.c:783: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4103: Test failed: Got unexpected refcount 3. ddraw1.c:4122: Test failed: Got unexpected refcount 3. ddraw1.c:4129: Test failed: Got unexpected hr 0. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 2. ddraw1.c:4140: Test failed: Got unexpected hr 0. ddraw1.c:4143: Test failed: Got unexpected refcount 2. ddraw1.c:4145: Test failed: Got unexpected refcount 1.

Feb. 28, 2014

Re: [PATCH 3/5] ddraw/tests: Properly create offscreen plain surfaces.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5273 Your paranoid android. === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5817: Test failed: Got unexpected refcount 3. ddraw4.c:5836: Test failed: Got unexpected refcount 3. ddraw4.c:5843: Test failed: Got unexpected hr 0. ddraw4.c:5846: Test failed: Got unexpected refcount 3. ddraw4.c:5848: Test failed: Got unexpected refcount 2. ddraw4.c:5854: Test failed: Got unexpected hr 0. ddraw4.c:5857: Test failed: Got unexpected refcount 2. ddraw4.c:5859: Test failed: Got unexpected refcount 1. ddraw4.c:5861: Test failed: Got unexpected refcount 6. ddraw4.c:5985: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:6024: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6027: Test failed: Got unexpected hr 0. ddraw4.c:6029: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6032: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6035: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6037: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6040: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6042: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6045: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6047: Test failed: Got unexpected hr 0x887601c2.

Feb. 28, 2014

Re: [PATCH 2/5] ddraw/tests: Try 24 bpp display modes if 32 bpp modes are unavailable.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5272 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00425FE5 === w8 (32 bit ddraw2) === ddraw2.c:5217: Test failed: Got unexpected refcount 3. ddraw2.c:5236: Test failed: Got unexpected refcount 3. ddraw2.c:5243: Test failed: Got unexpected hr 0. ddraw2.c:5246: Test failed: Got unexpected refcount 3. ddraw2.c:5248: Test failed: Got unexpected refcount 2. ddraw2.c:5254: Test failed: Got unexpected hr 0. ddraw2.c:5257: Test failed: Got unexpected refcount 2. ddraw2.c:5259: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:4120: Test failed: Got unexpected refcount 3. ddraw1.c:4139: Test failed: Got unexpected refcount 3. ddraw1.c:4146: Test failed: Got unexpected hr 0. ddraw1.c:4149: Test failed: Got unexpected refcount 3. ddraw1.c:4151: Test failed: Got unexpected refcount 2. ddraw1.c:4157: Test failed: Got unexpected hr 0. ddraw1.c:4160: Test failed: Got unexpected refcount 2. ddraw1.c:4162: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045AFE8 === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 0043FF75 === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057.

Feb. 28, 2014

Re: msi: Use BOOL type where appropriate

by Hans Leidekker

On Fri, 2014-02-28 at 10:35 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h > index 75d1920..62d69b2 100644 > --- a/dlls/msi/msipriv.h > +++ b/dlls/msi/msipriv.h > @@ -409,13 +409,13 @@ typedef struct tagMSIPACKAGE > struct list sourcelist_info; > struct list sourcelist_media; > > - unsigned char scheduled_action_running : 1; > - unsigned char commit_action_running : 1; > - unsigned char rollback_action_running : 1; > - unsigned char need_reboot_at_end : 1; > - unsigned char need_reboot_now : 1; > - unsigned char need_rollback : 1; > - unsigned char full_reinstall : 1; > + BOOL scheduled_action_running; > + BOOL commit_action_running; > + BOOL rollback_action_running; > + BOOL need_reboot_at_end; > + BOOL need_reboot_now; > + BOOL need_rollback; > + BOOL full_reinstall; > } MSIPACKAGE; > > typedef struct tagMSIPREVIEW > @@ -486,10 +486,10 @@ typedef struct tagMSICOMPONENT > MSIASSEMBLY *assembly; > int num_clients; > > - unsigned int anyAbsent:1; > - unsigned int hasAdvertisedFeature:1; > - unsigned int hasLocalFeature:1; > - unsigned int hasSourceFeature:1; > + BOOL anyAbsent; > + BOOL hasAdvertisedFeature; > + BOOL hasLocalFeature; > + BOOL hasSourceFeature; > } MSICOMPONENT; > > typedef struct tagComponentList I don't think it's worth the extra memory use here.

Feb. 28, 2014

Swat4 -too dark shadows maybe solved

by Jarkko Korpi

I downloaded swat4 demo. It has too dark swats and shadows. http://bugs.winehq.org/show_bug.cgi?id=8848 (which is reported here too also with demo) I think I figured out what is causing it. I noticed that setting windows registerykey useGLSL=disabled made swats look like normal (see my sent pics). I debuged the game and there wasn't many different lines. fixme:exec:SHELL_execute flags ignored: 0x00000100 fixme:process:GetProcessWorkingSetSize (0xffffffff,0x33eac4,0x33eac0): stub fixme:win:EnumDisplayDevicesW ((null),0,0x33ed48,0x00000000), stub! fixme:wbemprox:client_security_SetBlanket 0x7cf14558, 0x1396f0, 10, 0, (null), 3, 3, (nil), 0x00000000 fixme:wbemprox:client_security_Release 0x7cf14558 fixme:wbemprox:wbem_services_CreateInstanceEnum unsupported flags 0x00000030 fixme:win:EnumDisplayDevicesW ((null),0,0x33ec68,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x33ef58,0x00000000), stub! fixme:system:SystemParametersInfoW Unimplemented action: 59 (SPI_SETSTICKYKEYS) fixme:win:EnumDisplayDevicesW ((null),0,0x33ca58,0x00000000), stub! fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. etc etc But I think wine is missing the next feature, what's causing the black shadows http://msdn.microsoft.com/en-us/library/windows/desktop/bb173461%28v=vs.85%… "You can include the D3DSGR_CALIBRATE value for the first parameter of SetGammaRamp", well its definitely trying to set gamma, but it's IGNORED. Here are the pics, before and setting that useGLSL registery key http://postimg.org/image/kxct6863j/ http://postimg.org/image/n48bm1dk9/ But setting that registery key dosn't help on shadows which are too dark. According to my knowledge reading some part of that Microsoft explanation making this setgammaramp function shoulnt be too hard, it just adjust the amount of RGB.

Feb. 28, 2014

Re: Failing dpnet tests

by Alistair Leslie-Hughes

On 25/02/2014 2:10 AM, Francois Gouget wrote: > On Wed, 19 Feb 2014, Alistair Leslie-Hughes wrote: > [...] >> Would it be possible to test windows 8 without the firewall enabled? >> > > I suspect a simple LoadLibrary() will trigger that dialog too so some > other approach may be needed. Maybe something based on FindExecutable() > would work. > After some testing, LoadLibrary and LoadLibraryEx trigger DLLmain to be called. The dpnet.dll exists in the system32 directory but is a stub dll which causes that dialog to appear. Still working on using LoadLibraryEx to load the DLL as a resources only (Assuming it wont call DLLMain). From there it would be possible to check the Filename or Origial name from the Version properties. Well that's my plan. If anybody else has any ideas, happy to listen. Alistair.

Feb. 28, 2014

Re: dmime: Do not try to query a NULL direct sound buffer

by Aric Stewart

On 2014/02/26 18:11, Nikolay Sivov wrote: > On 2/26/2014 13:03, Aric Stewart wrote: >> --- >> dlls/dmime/audiopath.c | 33 ++++++++++++++++++--------------- >> 1 file changed, 18 insertions(+), 15 deletions(-) > Why is it NULL though? The only place I found that sets it is this: > > --- > hr = IDirectSound8_CreateSoundBuffer ((LPDIRECTSOUND8) This->pDirectSound, &desc, &buffer, NULL); > if (FAILED(hr)) { > HeapFree(GetProcessHeap(), 0, default_path); > *ppNewPath = NULL; > return DSERR_BUFFERLOST; > } > default_path->pDSBuffer = buffer; > --- > > That means CreateSoundBuffer() doesn't return error code properly? > > It is NULL because of Andrew's commit: commit 629e857c2ee0e8816a11ee4ab446c13798362f33 Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Apr 18 10:14:01 2012 -0500 dmime: Don't try to create a standard audio path if the client didn't ask for one. -aric

Feb. 28, 2014

Re: shell32: Supply a module name to CreateProcess

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -330,9 +332,14 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait, > /* ShellExecute specifies the command from psei->lpDirectory > * if present. Not from the current dir as CreateProcess does */ > if( lpDirectory ) > + { > if( ( gcdret = GetCurrentDirectoryW( MAX_PATH, curdir))) > if( !SetCurrentDirectoryW( lpDirectory)) > ERR("cannot set directory %s\n", debugstr_w(lpDirectory)); > + > + PathCombineW(module_path, psei->lpDirectory, psei->lpFile); > + path = module_path; > + } We'd want to specify the path in all cases, not only when we have a directory. Also the SetCurrentDirectory shouldn't be needed with a proper path. -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2014

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox() (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5256 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8158: Test failed: Mesh 27: new_num_vertices == 6, expected 4. mesh.c:8172: Test failed: Mesh 27: indices[3] == 3, expected 1 mesh.c:8172: Test failed: Mesh 27: indices[4] == 4, expected 3 mesh.c:8172: Test failed: Mesh 27: indices[5] == 5, expected 2 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 mesh.c:8228: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000).

Feb. 27, 2014

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox()

by Matteo Bruni

u2014-02-27 12:19 GMT+01:00 Marvin <testbot(a)winehq.org>: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5232 > > Your paranoid android. > > > === w8 (32 bit mesh) === > mesh.c:8156: Test failed: Mesh 27: new_num_vertices == 6, expected 4. > mesh.c:8170: Test failed: Mesh 27: indices[3] == 3, expected 1 > mesh.c:8170: Test failed: Mesh 27: indices[4] == 4, expected 3 > mesh.c:8170: Test failed: Mesh 27: indices[5] == 5, expected 2 > mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 > mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 > mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 > mesh.c:8226: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000). > FWIW, this test failure is unrelated to the patch. I see it's failing inconsistently on Win8, while e.g. it doesn't fail for me on Win7. As far as I understand, it's the float color vertex data the culprit (i.e. native d3dx9 doesn't really handle that case and the test passes or fails "by luck"). I'm going to send a patch for that.

Feb. 27, 2014

Re: urlmon: Fixed url.c tests on IE11.

by Jacek Caban

On 02/27/14 16:43, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5243 > > Your paranoid android. > > > === wxppro (32 bit url) === > url.c:1669: Test failed: unexpected call OnProgress_FINDINGRESOURCE > url.c:1878: Test failed: binding failed: 800c0005, expected 00000000 > url.c:1889: Test failed: res = 00002efd, expected 00000000 > url.c:3146: Test failed: expected OnProgress_SENDINGREQUEST > url.c:3152: Test failed: expected OnResponse > url.c:3156: Test failed: expected OnProgress_MIMETYPEAVAILABLE > url.c:3157: Test failed: expected OnProgress_BEGINDOWNLOADDATA > url.c:3158: Test failed: expected OnProgress_ENDDOWNLOADDATA > url.c:3170: Test failed: expected OnDataAvailable Those are existing ones still left to fix. Jacek

Feb. 27, 2014

Re: Use of wined3d_mutex?

by Max Woodbury

On 02/27/2014 03:10 AM, Stefan Dösinger wrote: > > Am 2014-02-26 20:13, schrieb Max TenEyck Woodbury: >> In particular, user call back functions are being called in >> several places with this mutex held. If the callback starts >> another thread to do something graphical where the thread needs the >> mutex, and then waits for the thread to finish, both threads will >> hang until the mutex times out. There are also places where a >> function that takes out the mutex is called with the mutex already >> held. >> > ddraw calls application-provided callback functions. A long time ago I > did some testing on Windows, and it also uses a dll-global lock for > ddraw and keeps it held when calling those callbacks. So we're doing > the right thing here. > Thank you for the information. That means I can ignore that issue. > In case of d3d8/9, there are in theory the Resource's SetPrivateData, > GetPrivateData and FreePrivateData functions that can call application > code, specificly an IUnknown's AddRef and Release function. I have > never tested how those behave wrt the dll lock. This thing can also be > used to write a black-box test to see at which granularity Windows > does d3d8/9 synchronization. > Uh, OK. (More information than I can handle at the moment. Maybe later...) >> Switching to another terminal window and back again sometimes >> breaks these deadlocks. >> > That seems wrong, unless we're accidentally holding those locks while > sending window messages. > With the time-out in place, it is hard to tell if it is still a problem, but it used to happen irregularly. It seemed to be something racy. It showed up with one batch of patches and then disappear after a couple more sets. Whatever it is, it is a really old problem. IIRC it was more of a problem with ddraw4 and ddraw7 than it was with the earlier interfaces... max

Feb. 27, 2014

Re: urlmon: Fixed url.c tests on IE11.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5243 Your paranoid android. === wxppro (32 bit url) === url.c:1669: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1878: Test failed: binding failed: 800c0005, expected 00000000 url.c:1889: Test failed: res = 00002efd, expected 00000000 url.c:3146: Test failed: expected OnProgress_SENDINGREQUEST url.c:3152: Test failed: expected OnResponse url.c:3156: Test failed: expected OnProgress_MIMETYPEAVAILABLE url.c:3157: Test failed: expected OnProgress_BEGINDOWNLOADDATA url.c:3158: Test failed: expected OnProgress_ENDDOWNLOADDATA url.c:3170: Test failed: expected OnDataAvailable

Feb. 27, 2014

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken

by Bruno Jesus

On Thu, Feb 27, 2014 at 11:43 AM, Marvin <testbot(a)winehq.org> wrote: > === wxppro (32 bit sock) === > sock: unhandled exception c0000005 at 00000000 > > === wvistau64 (32 bit sock) === > sock: unhandled exception c0000005 at 00000000 > > === w2008s64 (64 bit sock) === > sock: unhandled exception c0000005 at 000007FEFE4220C0 > > === w7pro64 (64 bit sock) === > sock.c:622: Test failed: oob_server (98c): not at the OOB mark: 1 There are also these weird crashes when (I guess) WSACleanup is called twice to test the not initialized error. -- Bruno

Feb. 27, 2014

Re: [PATCH 1/2] d3dx9: Implement D3DXCreateBox()

by Henri Verbeet

I'm not really in charge of d3dx9, and I would've expected Matteo or Rico to write this instead, but here are some comments. On 27 February 2014 11:38, Gediminas Jakutis <gediminas(a)varciai.lt> wrote: > + static const float sign_x[24] = {-1.0f, -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, > + 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, > + -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f}; The explicit array size isn't needed, and I don't think it adds much for clarity. The indentation looks pretty arbitrary, the usual style for tables like these is to put the brace on a new line, and then indent the elements once. I.e.: static const float sign_x[] = { -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, }; > + TRACE("(%p, %f, %f, %f, %p, %p)\n", device, width, height, depth, mesh, adjacency); I know d3dx9 isn't terribly consistent about this, but: TRACE("device %p, width %.8e, height %.8e, depth %.8e, mesh %p, adjacency %p.\n", device, width, height, depth, mesh, adjacency); > + hr = D3DXCreateMeshFVF(12, 24, D3DXMESH_MANAGED, D3DFVF_XYZ | D3DFVF_NORMAL, device, &box); > + > + if (FAILED(hr)) > + { > + return hr; > + } > + > + if (FAILED(hr = box->lpVtbl->LockVertexBuffer(box, 0, (void **)&vertices))) > + { > + box->lpVtbl->Release(box); > + return hr; > + } These are inconsistent. I'd prefer the second. > + for (i = 0; i < 24; i++) > + { > + vertices[i].position.x = width * sign_x[i]; > + vertices[i].position.y = height * sign_y[i]; > + vertices[i].position.z = depth * sign_z[i]; I suppose this works, but I think it would be clearer to store a unit box as an array of D3DXVECTOR3s, and then call D3DXVec3Scale() on the vectors. The "24" would then become "ARRAY_SIZE(unit_box)" as well. > + hr = D3DXCreateBuffer(36 * sizeof(DWORD), adjacency); > + > + if (FAILED(hr)) if (FAILED(hr = D3DXCreateBuffer(sizeof(adjacency_table), adjacency)))

Feb. 27, 2014

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken

by Bruno Jesus

On Thu, Feb 27, 2014 at 11:33 AM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > dlls/ws2_32/tests/sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 2252245..3f27b02 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -610,7 +610,7 @@ static VOID WINAPI oob_server ( server_params *par ) > ok ( pos == -1, "simple_server (%x): test pattern error: %d\n", id, pos); > > ioctlsocket ( mem->sock[0].s, SIOCATMARK, &atmark ); > - ok ( atmark == 1, "oob_server (%x): unexpectedly at the OOB mark: %i\n", id, atmark ); > + ok ( atmark == 1 || broken(atmark == 0), "oob_server (%x): unexpectedly at the OOB mark: %i\n", id, atmark ); There is other test failing too, right? At least for me. So this would only "solve" half of the problem. What we need to do IMO is simplify the test using a more sequential way to ensure normal and OOB data does not get mixed. Regards, Bruno

Feb. 27, 2014

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5238 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFE4220C0 === w7pro64 (64 bit sock) === sock.c:622: Test failed: oob_server (98c): not at the OOB mark: 1

Feb. 27, 2014

Re: ddraw/tests: Don't crash after a failed CreateSurface() call.

by Henri Verbeet

On 27 February 2014 02:46, Francois Gouget <fgouget(a)codeweavers.com> wrote: > Is there a way to check what surface types are supported? In theory, but in practice the most reliable way seems to be calling CreateSurface() and seeing if it works. Unfortunately the correct way to fix these depends a bit on the specific case. E.g.: > @@ -4817,6 +4819,8 @@ static void test_set_surface_desc(void) > > hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); > ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); > + if (FAILED(hr)) > + goto done; > > hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); > ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); > @@ -5113,6 +5117,12 @@ static void test_user_memory_getdc(void) > ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; > hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); > ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); > + if (FAILED(hr)) > + { > + IDirectDraw2_Release(ddraw); > + DestroyWindow(window); > + return; > + } > > hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); > ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); These can be fixed by adding DDSCAPS_OFFSCREENPLAIN to ddsd.ddsCaps.dwCaps.

Feb. 27, 2014

Re: d3d9/tests: Fix some test failures on Windows 2000.

by Henri Verbeet

On 27 February 2014 03:27, Francois Gouget <fgouget(a)codeweavers.com> wrote: > The remaining CreateDevice() calls seem to be using pretty different > parameters. > > For instance in test_mipmap_levels() it uses a different backbuffer > format, does not set its size, sets EnableAutoDepthStencil to FALSE and > passes D3DDEVTYPE_NULLREF. Will the test really still make sense if all > that is changed? > Yeah. > Another example is test_depthstenciltest() which sets > EnableAutoDepthStencil to FALSE but still sets AutoDepthStencilFormat. > That's different from create_device() and intentionally so. > > (test_reset() does so once too without a comment which looks more > questionable) > Yeah, both of those intentionally don't set EnableAutoDepthStencil. > The problem is there's about 20 remaining CreateDevice() calls and I > would be hard pressed to tell if they are crucially different from what > create_device() does. > Ok, I'll look into it a bit.

Feb. 27, 2014

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.

by Henri Verbeet

On 27 February 2014 02:24, Francois Gouget <fgouget(a)codeweavers.com> wrote: > * QEmu can emulate an old Cirrus 5446 graphics card that tops out at > 24bpp and thus does not support the 32bpp modes we want. For Windows > 2000 that's all that works. > For most of these tests, perhaps all of them, we don't care about the difference between 24 and 32 bpp modes. I'm going to look into writing a small set_display_mode() helper that just tries both, which would allow these tests to be run on the Windows 2000 testbot as well. That doesn't help for 8 bpp modes, but there are only a few tests that need those, and I think the way we handle those currently is fine.

Feb. 27, 2014

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 2).

by Henri Verbeet

> diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 0ceb6f1..c7c420a 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +void wined3d_privstore_init(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +void wined3d_privstore_cleanup(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, DWORD *flags) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > Perhaps this should just be a set of inline helpers in something like include/wine/wined3d_util.h, or possibly wined3d.h, similar to e.g. include/wine/list.h. I'm not really a fan of the name wined3d_privstore. I suppose wined3d_private_store would be slightly preferable, but I don't think that's particularly great either.

Feb. 27, 2014

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5232 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8156: Test failed: Mesh 27: new_num_vertices == 6, expected 4. mesh.c:8170: Test failed: Mesh 27: indices[3] == 3, expected 1 mesh.c:8170: Test failed: Mesh 27: indices[4] == 4, expected 3 mesh.c:8170: Test failed: Mesh 27: indices[5] == 5, expected 2 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 mesh.c:8226: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000).

Feb. 27, 2014

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-27 02:24, schrieb Francois Gouget: > * HD4000 : Intel they decided that 256 color modes are obsolete > (they are) and not worth supporting. Out of curiosity, does that system run old game classics like Age of Empires 2 or old StarCraft 1? If so, how? If not, I'd consider that a pretty bad non-feature. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTDvTdAAoJEN0/YqbEcdMw+lcP/j5K7N52A6J6WhLqpSZrP7Ha AbptP8Z9L+O0G33rZlUbZAsT8w64aTDXjKL9ahIua9ia+lxl55JJaD9ectiV8clo 22PNXK1CdubY3pIrwKdlax0f+hM5ZqTOBN6gaG1th/CTau8SqXSI3scJZDoimnJO 9UQpwYj6smghh3uQhYx62KJKPDe3Ek9zgAMKRdkWRGc5P4zL/tk4uwGYm8CGM8Oy eAg9tthRUwDeYUaQ/MPdAOO82T42Z9WLEvJO+zk/VNr23P7E+H4WoYAuM9JMM1dP 8/x6CM7hmVrz8sE45wgpxrD/IDzZtIIzEBndjojhBEp2bctEIUJADKk23zGnIxHy 87OotuP7BFgrtZG0vXWO2eOV1xmcdXWdhZaHYzG8MDHLsUwLBgzL49gC5wA+UHL3 ad/IhIr+ok9wx1dXJYMrLfrPG05x93f1CmeNnPXU7gv1z/pQ+VoLbIvhsvlLUdap 9mmJC9ogbBju7whb+aNF1SAi/JrE4IkohiDkGvii2vWB4eGpOUCxKfhriEyJTKRQ iEjcWzxZ0d9CzDA0Lhe18ia8LoUafDvY9U/Q6c6fWhA/xt8ysTvgU+CmfiFNg9xN cYGkZSEaFMrq9mWfTRAdi/Kl7ZJ2DgOZGq3hKHm5XSd4rKkLlAWOpELiycpl8tqQ gaOLXi9E/iShT2ECIEu5 =AGOH -----END PGP SIGNATURE-----

Feb. 27, 2014

Re: [PATCH] taskschd: Create dummy task definition for GetTask()

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> RegisteredTask_create() doesn't handle NULL definition, > >> neither does IRegisteredTask code. If it's meant to be fixed differently > >> please let me know. > > This still needs a lot of work, there is no need to pitch in. > > > Oh yeah, I need it, it crashes for me. I have a patch which implements most of task management on the client side, and that would fix this particular problem. But I'm not sure yet whether to send it for inclusuion since it should be moved into the service at some point. -- Dmitry.

Feb. 27, 2014

Re: Use of wined3d_mutex?

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-26 20:13, schrieb Max TenEyck Woodbury: > In particular, user call back functions are being called in > several places with this mutex held. If the callback starts > another thread to do something graphical where the thread needs the > mutex, and then waits for the thread to finish, both threads will > hang until the mutex times out. There are also places where a > function that takes out the mutex is called with the mutex already > held. ddraw calls application-provided callback functions. A long time ago I did some testing on Windows, and it also uses a dll-global lock for ddraw and keeps it held when calling those callbacks. So we're doing the right thing here. In case of d3d8/9, there are in theory the Resource's SetPrivateData, GetPrivateData and FreePrivateData functions that can call application code, specificly an IUnknown's AddRef and Release function. I have never tested how those behave wrt the dll lock. This thing can also be used to write a black-box test to see at which granularity Windows does d3d8/9 synchronization. > Switching to another terminal window and back again sometimes > breaks these deadlocks. That seems wrong, unless we're accidentally holding those locks while sending window messages. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTDvMPAAoJEN0/YqbEcdMwg0kP/0VGijPb4vGV9iFAcYdA7P0j GGapgcXy8Iv5Mpf3aJodEK6awCB5aVYfTC90Qr1ys04WJSQqvN+GDL4+fu9189hf sO+pK2kXlPmpmPjTwisqiT31BZ+wAN+7llPbJXpTkMw6xwKl+lxq9jm81FUmNT5S 0zFhEFCwbrPfydHNKp9/5vUpFTZ4dt7vycUg7Be7ujqUnr+JKo9SGiOz5eDE3E9R CIR03JTg0wQitiekxcdbhSQ0K/mIg857WzCTWa+Lc0r/bij6Ebf6NQPI+oobbOJI 9GbeFhwcKtLppO6B075F82j07jyLiNVC+k19UtW4Dby0gLeOI458smcEy8zUVEk5 Rfwgbej7xpHirWpMOgy0B0UtIH1HQkMs8dTKa5XfyZGLyVkoj+wnsf1PXCIVbphZ VvCt6htV0PgDzlYMOpMaja0/yebfscRnY1nCHOdaYMtTMoGAfclRK/yMdVR8Q5tO joEqAMtG20NcpbIPgRc/ZFFj5S7lZH+NTdd5MYxy1CmC7+AZ3XrSShfSFzFSS0Z5 KrHGQ0Z28DbFdWOBlVZOfe38ffj82On++cRzKTyChLBU+g80ZRzfPJMQ+ZEdu9qz AY+inhWRfs84XM1GupRgxU0Jlih10KoXiVCTVzlMJDIQY8/Efd8dD3b7ewXRgsV3 GVQxXjBp2XqhGRaqcZPr =+HPs -----END PGP SIGNATURE-----

Feb. 27, 2014

Re: [PATCH] taskschd: Create dummy task definition for GetTask()

by Nikolay Sivov

On 2/27/2014 11:49, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> RegisteredTask_create() doesn't handle NULL definition, >> neither does IRegisteredTask code. If it's meant to be fixed differently >> please let me know. > This still needs a lot of work, there is no need to pitch in. > Oh yeah, I need it, it crashes for me.

Feb. 27, 2014

Re: [PATCH] taskschd: Create dummy task definition for GetTask()

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > RegisteredTask_create() doesn't handle NULL definition, > neither does IRegisteredTask code. If it's meant to be fixed differently > please let me know. This still needs a lot of work, there is no need to pitch in. -- Dmitry.

Feb. 27, 2014

Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid (try3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5216 Your paranoid android. === wvistau64 (64 bit olepicture) === olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 === w2008s64 (64 bit olepicture) === olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 === w7pro64 (64 bit olepicture) === olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000 olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x800a017c olepicture.c:646: Test failed: DISPID_PICT_RENDER returned wrong code, 0x80020005, expected 0x00000000

Feb. 27, 2014

Re: [2/2] ws2_32: Add WSAEnumNameSpaceProviders[A|W] implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5214 Your paranoid android. === build (build) === Make failed

Feb. 27, 2014

Re: [1/2] ws2_32/tests: Add WSAEnumNameSpaceProviders[A|W] tests (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5213 Your paranoid android. === build (build) === Make failed

Feb. 27, 2014

Use of wined3d_mutex?

by Max Woodbury

I have been looking at the use of the wined3d_mutex_lock and wined3d_mutex_unlock functions in the drawing code. I strongly suspect that it is being badly over-used. In particular, user call back functions are being called in several places with this mutex held. If the callback starts another thread to do something graphical where the thread needs the mutex, and then waits for the thread to finish, both threads will hang until the mutex times out. There are also places where a function that takes out the mutex is called with the mutex already held. Switching to another terminal window and back again sometimes breaks these deadlocks. It used to be that I had to do this several times doing a 'make test', but it just takes a long time now. (Yes, years ago I left the test running for several hours when I went out for a few hours and it was still hung when I got back. That does not happen now,) This shows up running Guild Wars 2. I have a CPU monitor running while I play and I can see the game chomping on both cores, except that the game will sometimes hang for 30-45 seconds and then resume. I am in the process of annotating the drawing routines use of the mutex, and there is simply a lot of code to go through. Could someone with a good understanding of the drawing part of wine comment please. In particular, are there places where the lock-like action of the reference counts can be used in place of taking out the mutex? max

Feb. 27, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Max Woodbury

On 02/26/2014 08:32 PM, Erich E. Hoover wrote: > On Wed, Feb 26, 2014 at 6:10 PM, Max Woodbury <mtewoodbury(a)gmail.com> wrote: >> ... >> So it's mainly on style: >> >> - I've been reading other peoples code for 50 years and that aspect >> of K&R is much easier to handle in my opinion. Same with the >> extra blank line. Other parts of wine use the style and are much >> easier to read as a result. >> >> - And the miscount can't simply be ignored? > > Very little of Wine uses a blank line after an if, and I've never seen > it with a single line statement. That doesn't really matter though, > the rest of the function (and really the whole file) is in Allman > style and our current guidelines require matching the surrounding > style. (Note: I am not in charge of this, so debating me on the topic > is pointless) > Bluntly Allman style sucks. It is just plain hard to read. Also, the blank line is associated with the 'return' and is often used. >> If you read kernel code, you'll find that just returning to >> application level is sometimes enough to free the missing resource. >> That happens often enough that a single quick retry on EAGAIN is >> warranted. > > I'm not familiar enough with what you're trying to do, but if the > buffer is full and the kernel throws back EAGAIN then it would seem > that you're not in such a time crunch that waiting for the higher > level to handle it is going to be a problem. I could be wrong though, > I don't do a lot of high-throughput socket programming. > Not a buffers full problem. Internal locks that get released from a thread switch and things like that. Worth ONE retry to see if they clear. If its still stuck on the second attempt, punt. And it's not me, it's the game... >> Bringing the relevant part of the retry code down and applying it to >> only those parts where is has a strong likelihood of doing the most >> good is exactly what the patch does. If one retry is not enough, then >> higher level strategy is needed so no changes are called for on the >> higher level. A loop at this level is _not_ a good idea since there >> would have to be something to break the loop if it runs too long. > > I believe that Ken was suggesting that there are ways to do this such > that the higher level can handle EGAIN and the lower level EINTR. In > my, admittedly limited, experience with this issue his suggestion > seems reasonable, but I could be wrong. However, I am sure that if > you put together a convincing test case that it will make getting the > patch accepted a lot easier (though not guaranteed). > TEST CASE?!? Not! Multi-thread with graphics throwing interrupts left and right! Disk interrupts. Real internet delays. Instead, just watch the game with the problem for a day or two. Better read a few good Unix programming text. Ask the impossible why dont'cha. >> In other words, this fiddle is based on several decades of experience with >> kernel and bottom level application debugging experience. At >> least look at it and test it before rejecting it on superficial grounds. > > Please do not be confused, I am not in charge of acceptance/rejection. > I have, however, been involved in Wine long enough to know that if > you don't address the issues mentioned on this list (either with an > explanation, the addition of new tests, or changing the code to handle > the case mentioned) then AJ will usually reject the patch. > Yep. If it were possible, I'd do just that, but it's not... On the other hand, forgetting a CC is bad. (Fixed. Want to compare years on the list? I've a few...) > Best, > Erich

Feb. 27, 2014

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5210 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00426DB5 === w8 (32 bit ddraw2) === ddraw2.c:5278: Test failed: Got unexpected refcount 3. ddraw2.c:5297: Test failed: Got unexpected refcount 3. ddraw2.c:5304: Test failed: Got unexpected hr 0. ddraw2.c:5307: Test failed: Got unexpected refcount 3. ddraw2.c:5309: Test failed: Got unexpected refcount 2. ddraw2.c:5315: Test failed: Got unexpected hr 0. ddraw2.c:5318: Test failed: Got unexpected refcount 2. ddraw2.c:5320: Test failed: Got unexpected refcount 1. No test summary line found Failure running script in VM: network read timed out === w8 (32 bit ddraw1) === ddraw1.c:4182: Test failed: Got unexpected refcount 3. ddraw1.c:4201: Test failed: Got unexpected refcount 3. ddraw1.c:4208: Test failed: Got unexpected hr 0. ddraw1.c:4211: Test failed: Got unexpected refcount 3. ddraw1.c:4213: Test failed: Got unexpected refcount 2. ddraw1.c:4219: Test failed: Got unexpected hr 0. ddraw1.c:4222: Test failed: Got unexpected refcount 2. ddraw1.c:4224: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045C558 === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 00441995 === w8 (32 bit ddraw4) === ddraw4.c:5874: Test failed: Got unexpected refcount 3. ddraw4.c:5893: Test failed: Got unexpected refcount 3. ddraw4.c:5900: Test failed: Got unexpected hr 0. ddraw4.c:5903: Test failed: Got unexpected refcount 3. ddraw4.c:5905: Test failed: Got unexpected refcount 2. ddraw4.c:5911: Test failed: Got unexpected hr 0. ddraw4.c:5914: Test failed: Got unexpected refcount 2. ddraw4.c:5916: Test failed: Got unexpected refcount 1. ddraw4.c:5918: Test failed: Got unexpected refcount 6. Timeout Failure running script in VM: network read timed out

Feb. 27, 2014

Re: d3d9/tests: Fix some test failures on Windows 2000.

by Francois Gouget

On Tue, 25 Feb 2014, Henri Verbeet wrote: > On 24 February 2014 23:54, Francois Gouget <fgouget(a)codeweavers.com> wrote: > > --- > > > > This fixes some tests on the WineTestBot VM. > > > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > Most of the IDirect3D9_CreateDevice() calls in device.c should be > calls to create_device() instead. (And then just skip() if it fails to > create a device.) I think the only exceptions are test_fpu_setup() and > test_swvp_buffer(). The remaining CreateDevice() calls seem to be using pretty different parameters. For instance in test_mipmap_levels() it uses a different backbuffer format, does not set its size, sets EnableAutoDepthStencil to FALSE and passes D3DDEVTYPE_NULLREF. Will the test really still make sense if all that is changed? Another example is test_depthstenciltest() which sets EnableAutoDepthStencil to FALSE but still sets AutoDepthStencilFormat. That's different from create_device() and intentionally so. (test_reset() does so once too without a comment which looks more questionable) The problem is there's about 20 remaining CreateDevice() calls and I would be hard pressed to tell if they are crucially different from what create_device() does. -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 27, 2014

Re: ddraw/tests: Simplify the 'NT4 testbot' special case a bit.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5209 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 004267A5 === w8 (32 bit ddraw2) === Timeout === w8 (32 bit ddraw1) === ddraw1.c:4113: Test failed: Got unexpected refcount 3. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4139: Test failed: Got unexpected hr 0. ddraw1.c:4142: Test failed: Got unexpected refcount 3. ddraw1.c:4144: Test failed: Got unexpected refcount 2. ddraw1.c:4150: Test failed: Got unexpected hr 0. ddraw1.c:4153: Test failed: Got unexpected refcount 2. ddraw1.c:4155: Test failed: Got unexpected refcount 1.

Feb. 27, 2014

Re: ddraw: Add some more D3DDEVCAPS constants.

by Francois Gouget

On Wed, 26 Feb 2014, Henri Verbeet wrote: > > --- a/include/d3dcaps.h > > +++ b/include/d3dcaps.h > > @@ -302,6 +302,11 @@ typedef struct _D3DDeviceDesc7 { > > #define D3DDEVCAPS_HWTRANSFORMANDLIGHT 0x00010000 > > #define D3DDEVCAPS_CANBLTSYSTONONLOCAL 0x00020000 > > #define D3DDEVCAPS_HWRASTERIZATION 0x00080000 > > +#define D3DDEVCAPS_PUREDEVICE 0x00100000 > > +#define D3DDEVCAPS_QUINTICRTPATCHES 0x00200000 > > +#define D3DDEVCAPS_RTPATCHES 0x00400000 > > +#define D3DDEVCAPS_RTPATCHHANDLEZERO 0x00800000 > > +#define D3DDEVCAPS_NPATCHES 0x01000000 > Where did you find these? They're not in any SDK I have. My mistake. They're supposed to be in d3d8caps.h and d3d9caps.h (and they are already there in Wine), not in plain d3dcaps.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

Feb. 27, 2014

ddraw/tests: Don't crash after a failed CreateSurface() call.

by Francois Gouget

So there are a number of CreateSurface() calls that fail and these are causing the tests to crash. For instance for ddraw2: http://test.winehq.org/data/tests/ddraw:ddraw2.html Is there a way to check what surface types are supported? create_device() calls EnumDevices() but finding a match clearly does not guarantee we'll be able to create a surface given the error we get there (but presumably that check was more for the following CreateDevice() call). I tried using EnumSurfaces() but without much luck. I'm also a bit worried that DDENUMSURFACES_MATCH is not used anywhere in Wine (*). Alternatively we can just react to failing CreateSurface() calls and clean up + abort a bit like is done in the following patch. (*) Also the DDENUMSURFACES_{SEARCH,MATCH}TYPE macros found in dlls/ddraw/ddraw.c are not used anymore since c8901d6f. diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 5a3bd77..2a5a9c4 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -227,7 +227,7 @@ static IDirect3DDevice2 *create_device(IDirectDraw2 *ddraw, HWND window, DWORD c surface_desc.dwWidth = 640; surface_desc.dwHeight = 480; hr = IDirectDraw2_CreateSurface(ddraw, &surface_desc, &ds, NULL); - ok(SUCCEEDED(hr), "Failed to create depth buffer, hr %#x.\n", hr); + ok(SUCCEEDED(hr) || broken(hr == DDERR_INVALIDPIXELFORMAT), "Failed to create depth buffer, hr %#x.\n", hr); if (FAILED(hr)) { IDirect3D2_Release(d3d); @@ -4451,6 +4451,8 @@ static void test_surface_lock(void) hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, type %s, hr %#x.\n", tests[i].name, hr); + if (FAILED(hr)) + continue; memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); @@ -4817,6 +4819,8 @@ static void test_set_surface_desc(void) hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + goto done; hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); @@ -5113,6 +5117,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw2_Release(ddraw); + DestroyWindow(window); + return; + } hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 81c043c..5da4a71 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -5423,6 +5423,12 @@ static void test_set_surface_desc(void) hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw4_Release(ddraw); + DestroyWindow(window); + return; + } reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -5715,6 +5721,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw4_Release(ddraw); + DestroyWindow(window); + return; + } memset(data, 0xaa, sizeof(data)); reset_ddsd(&ddsd); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 8e01238..4735fca 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -5301,6 +5301,12 @@ static void test_set_surface_desc(void) hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw7_Release(ddraw); + DestroyWindow(window); + return; + } reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -5594,6 +5600,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw7_Release(ddraw); + DestroyWindow(window); + return; + } memset(data, 0xaa, sizeof(data)); reset_ddsd(&ddsd);

Feb. 27, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Erich E. Hoover

On Wed, Feb 26, 2014 at 6:10 PM, Max Woodbury <mtewoodbury(a)gmail.com> wrote: > ... > So it's mainly on style: > > - I've been reading other peoples code for 50 years and that aspect > of K&R is much easier to handle in my opinion. Same with the > extra blank line. Other parts of wine use the style and are much > easier to read as a result. > > - And the miscount can't simply be ignored? Very little of Wine uses a blank line after an if, and I've never seen it with a single line statement. That doesn't really matter though, the rest of the function (and really the whole file) is in Allman style and our current guidelines require matching the surrounding style. (Note: I am not in charge of this, so debating me on the topic is pointless) > If you read kernel code, you'll find that just returning to > application level is sometimes enough to free the missing resource. > That happens often enough that a single quick retry on EAGAIN is > warranted. I'm not familiar enough with what you're trying to do, but if the buffer is full and the kernel throws back EAGAIN then it would seem that you're not in such a time crunch that waiting for the higher level to handle it is going to be a problem. I could be wrong though, I don't do a lot of high-throughput socket programming. > Bringing the relevant part of the retry code down and applying it to > only those parts where is has a strong likelihood of doing the most > good is exactly what the patch does. If one retry is not enough, then > higher level strategy is needed so no changes are called for on the > higher level. A loop at this level is _not_ a good idea since there > would have to be something to break the loop if it runs too long. I believe that Ken was suggesting that there are ways to do this such that the higher level can handle EGAIN and the lower level EINTR. In my, admittedly limited, experience with this issue his suggestion seems reasonable, but I could be wrong. However, I am sure that if you put together a convincing test case that it will make getting the patch accepted a lot easier (though not guaranteed). > In other words, this fiddle is based on several decades of experience with > kernel and bottom level application debugging experience. At > least look at it and test it before rejecting it on superficial grounds. Please do not be confused, I am not in charge of acceptance/rejection. I have, however, been involved in Wine long enough to know that if you don't address the issues mentioned on this list (either with an explanation, the addition of new tests, or changing the code to handle the case mentioned) then AJ will usually reject the patch. Best, Erich

Feb. 27, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Max Woodbury

On 02/26/2014 08:10 PM, Bruno Jesus wrote: > On Wed, Feb 26, 2014 at 6:30 PM, Max Woodbury <mtewoodbury(a)gmail.com> wrote: >> Guild Wars 2. See other sub-thread. > > Can you share the URL to the other sub-thread, please? > > Ken pointed out that I had forgotten to CC the list. I hope that I've fixed that now... max

Feb. 27, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Max Woodbury

On 02/26/2014 06:36 PM, Erich E. Hoover wrote: > On Wed, Feb 26, 2014 at 4:26 PM, Max Woodbury <mtewoodbury(a)gmail.com> wrote: >> Please explain in words of one syllable why this has been rejected? > > Probably for the reasons Ken already mentioned: > 1) Strange blank line after "if (n == -1)" > 2) Unnecessary style change to K&R style ("if (ret >= 0) {") > 3) "[PATCH 2/2]" with no "[PATCH 1/2]" > 4) No explanation for his comment that EAGAIN is probably not needed. > EINTR might want this behavior, but EGAIN should not. > 5) If you bring this code "down" to where you have then you need to > remove it from the "higher" level: > http://source.winehq.org/source/dlls/ws2_32/socket.c#L4494 > http://source.winehq.org/source/dlls/ws2_32/socket.c#L6500 > 6) It should be in a loop > > Does that help? > > Best, > Erich > > So it's mainly on style: - I've been reading other peoples code for 50 years and that aspect of K&R is much easier to handle in my opinion. Same with the extra blank line. Other parts of wine use the style and are much easier to read as a result. - And the miscount can't simply be ignored? If you read kernel code, you'll find that just returning to application level is sometimes enough to free the missing resource. That happens often enough that a single quick retry on EAGAIN is warranted. Bringing the relevant part of the retry code down and applying it to only those parts where is has a strong likelihood of doing the most good is exactly what the patch does. If one retry is not enough, then higher level strategy is needed so no changes are called for on the higher level. A loop at this level is _not_ a good idea since there would have to be something to break the loop if it runs too long. In other words, this fiddle is based on several decades of experience with kernel and bottom level application debugging experience. At least look at it and test it before rejecting it on superficial grounds. max

Feb. 27, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Bruno Jesus

On Wed, Feb 26, 2014 at 6:30 PM, Max Woodbury <mtewoodbury(a)gmail.com> wrote: > Guild Wars 2. See other sub-thread. Can you share the URL to the other sub-thread, please?

Feb. 27, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Erich E. Hoover

On Wed, Feb 26, 2014 at 4:26 PM, Max Woodbury <mtewoodbury(a)gmail.com> wrote: > Please explain in words of one syllable why this has been rejected? Probably for the reasons Ken already mentioned: 1) Strange blank line after "if (n == -1)" 2) Unnecessary style change to K&R style ("if (ret >= 0) {") 3) "[PATCH 2/2]" with no "[PATCH 1/2]" 4) No explanation for his comment that EAGAIN is probably not needed. EINTR might want this behavior, but EGAIN should not. 5) If you bring this code "down" to where you have then you need to remove it from the "higher" level: http://source.winehq.org/source/dlls/ws2_32/socket.c#L4494 http://source.winehq.org/source/dlls/ws2_32/socket.c#L6500 6) It should be in a loop Does that help? Best, Erich

Feb. 26, 2014

Fwd: Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Max TenEyck Woodbury

-------- Original Message -------- Subject: Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR. Date: Wed, 26 Feb 2014 13:33:22 -0500 From: Max Woodbury <mtewoodbury(a)gmail.com> To: Ken Thomases <ken(a)codeweavers.com> On 02/23/2014 05:23 AM, Ken Thomases wrote: > On Feb 21, 2014, at 6:35 PM, mtewoodbury(a)gmail.com wrote: > >> Note that this greatly improves network reliability. > > How did you determine that? How could we confirm that? Feature of Guild Wars 2 (trading post) that failed to work on wine now works. Lower Game latency. Fewer login failures. > > >> - if ( (n = recvmsg(fd, &hdr, wsa->flags)) == -1 ) >> + n = recvmsg(fd, &hdr, wsa->flags); >> + if (n == -1 && (errno == EINTR || errno == EAGAIN)) >> + n = recvmsg(fd, &hdr, wsa->flags); >> + if (n == -1) >> + >> return -1; > > What's with that blank line between the last "if" and its corresponding statement? To emphasize the exit from the function. I find that I often want to know where such exits are and this makes them easier to fined. Personal preference... > >> - if (ret >= 0) >> - { >> + if (ret == -1 && (errno == EINTR || errno == EAGAIN)) >> + ret = sendmsg(fd, &hdr, wsa->flags); /* Try it again quickly */ >> + if (ret >= 0) { > > Why did you change the existing lines? You could have just added your two lines. Mostly just personal preference... > > In general: > > Is this actually the second patch of a two-patch series as indicated by the "[PATCH 2/2]" > in the subject? I didn't receive the first patch. No, my dyslexia strikes again. > > Have you tested to see if just retrying on EINTR is sufficient to improve the > reliability? EAGAIN is not typically a situation where an immediate retry helps. EAGAIN says specifically resources _temporarily_ unavailable. How temporary is not specified, so one quick retry could fix the problem. > > The callers of WS2_recv() and WS2_send() already have tests for EINTR and EAGAIN. > The strategy for dealing with those should probably exist in just one place. > For my part, I think that all interruptible syscalls should be in a loop that > immediately retries for EINTR, but EAGAIN should usually go back to some select(), > poll(), kevent() or similar wait function. I'd more or less agree except that there is, if I recall correctly, some other stuff that has to happen before the retry at the higher levels and I was getting game feature failures and latency waiting for those fixes. By all means, something like this could and should be done for most system calls. This one just annoyed me enough to try fiddling with it. Since it seemed to make a difference, I posted it... > > -Ken

Feb. 26, 2014

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

by Max Woodbury

Please explain in words of one syllable why this has been rejected?

Feb. 26, 2014