February 2014 - Wine-Devel - list.winehq.org

Re: winemac.drv: Improve positioning of IME client window based on caret

by Ken Thomases

On Feb 19, 2014, at 3:08 AM, Aric Stewart wrote: > diff --git a/dlls/winemac.drv/ime.c b/dlls/winemac.drv/ime.c > index 2c74f6e..066c77a 100644 > --- a/dlls/winemac.drv/ime.c > +++ b/dlls/winemac.drv/ime.c > @@ -1585,14 +1585,20 @@ BOOL query_ime_char_rect(macdrv_query* query) > if (focus && (focus == hwnd || IsChild(hwnd, focus)) && > GetClientRect(focus, &charpos.rcDocument)) > { > + HDC hdc = GetDC(focus); > + TEXTMETRICA tm; > + > if (!GetCaretPos((POINT*)&charpos.rcDocument)) > charpos.rcDocument.left = charpos.rcDocument.top = 0; > > + GetTextMetricsA(hdc, &tm); > charpos.rcDocument.right = charpos.rcDocument.left + 1; > + charpos.rcDocument.bottom = charpos.rcDocument.top + tm.tmHeight; > MapWindowPoints(focus, 0, (POINT*)&charpos.rcDocument, 2); > > *rect = cgrect_from_rect(charpos.rcDocument); > ret = TRUE; > + ReleaseDC(focus, hdc); > } > } I don't think this does what you want. GetDC() typically returns a DC whose parameters were reset. It doesn't know what font has previously been used in the window. So, you're basically getting the metrics for the System font. I suppose that may be better than nothing. Also, you don't check if GetTextMetricsA() succeeded. Perhaps using GetGUIThreadInfo() and the rcCaret field of the GUITHREADINFO structure would be better than using GetCaretPos(). In that case, you'd map the coordinates from hwndCaret (which may be different from "focus") to the screen. Be sure to read the remarks in the MSDN docs for the GetGUIThreadInfo() function about how to use rcCaret, although it's not clear to me if Wine implements this faithfully. -Ken

Feb. 19, 2014

Wine 64 bit

by Kevin Davies

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

Feb. 19, 2014

Re: [3/3] gdi32/tests: Avoid using GetGlyphIndices directly.

by 中川祥

What a phrase it is! By the way,please replay to my patches 102290 and 102289. Please comment if they are safe,if true,they will be comitted. 2014-02-19 21:02 GMT+09:00 Akihiro Sagawa <sagawa.aki(a)gmail.com>: > > This makes NT4 happy. > --- > dlls/gdi32/tests/font.c | 45 ++++++++++++++++++++++++++++----------------- > 1 file changed, 28 insertions(+), 17 deletions(-) > > > > >

Feb. 19, 2014

ff-core effect id handling in case of a failed effect upload

by Elias Vanderstuyft

Hi, In the process of reviewing the Wine DInput translation layer, I noticed an inconvenience (in the ff-core implementation?) that can possibly lead to confusing problems to application developers (not only for Wine), in short: If a new (id==-1) effect was uploaded (look at ff-core.c::input_ff_upload(...)) that failed (e.g. returning EINVAL), ff-core will have assigned a positive number to the effect id. This can be confusing because the dev->ff->effects[] array will not contain an element at the index of that new effect id. Here is a more elaborated description/discussion: - This is a bug that is either the responsibility of the Linux kernel, or of Wine (and possibly other applications that do the same thing as described below): It is caused by the following situation: When uploading an effect, the specific kernel device driver may return an error, e.g. EINVAL for example when a periodic's effect period is set to zero. This error will then be returned by "ioctl(*(This->fd), EVIOCSFF, &This->effect)". With or without error, one can find out that /drivers/input/ff-core.c:input_ff_upload(...) is called, which will set effect->id >= 0, if it was set to -1 (=> new effect created) by the user. But in case of an error: - Assume effect->id was set to -1 by the user: The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will also be set >= 0 (*). The offending effect will not be saved in the ff->effects[] array (***). - Assume effect->id was set >= 0 by the user (and ff->effects[effect->id] is a valid existing effect): The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will remain unchanged (**). The offending effect will not overwrite the ff->effects[effect->id] element (****). Is this (see *, **, *** and ****) desired behaviour? - If yes: Change the following in Wine's dinput/effect_linuxinput.c:90 : if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { to : int effectId_old = This->effect.id; if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { This->effect.id = effectId_old; - If no for *: Kernel code /drivers/input/ff-core.c:input_ff_upload(...) has to be patched to revert "effect->id" back to its original value set by the user, which is only needed when the initial (by user) value of "effect->id" was equal to -1. - If no for **** (or maybe also ***): ff->effects[effect->id] could be replaced by an 'empty' effect (however this can get complex because the effect's type has to remain unchanged) This would be a change in the kernel code /drivers/input/ff-core.c:input_ff_upload(...). - If no for **: I don't really know. Discussion is needed. - In my opinion, **, *** and **** are desired behaviour, while * should leave the effect->id at -1. In that case, Wine's dinput implementation does not have to be patched, and the kernel code only should apply a minor patch. Best regards, Elias

Feb. 19, 2014

Re: msi: Dont crash on installation of services without component KeyPath

by Aric Stewart

Ok, I will try that tomorrow and report if windows successfully installs the service or not. -aric On 2014/02/19 20:28, Hans Leidekker wrote: > On Wed, 2014-02-19 at 20:03 +0900, Aric Stewart wrote: >> I have not dug into the details, but I know it does not crash and the >> overall install does succeed. >> >> I can try investigating further on windows, Is there an easy way to >> determine what service this is and if it gets successfully installed on windows? > > A +msi,+service trace should reveal the service name. "sc query" will list > installed services, for example. > >

Feb. 19, 2014

Re: msi: Dont crash on installation of services without component KeyPath

by Hans Leidekker

On Wed, 2014-02-19 at 20:03 +0900, Aric Stewart wrote: > I have not dug into the details, but I know it does not crash and the > overall install does succeed. > > I can try investigating further on windows, Is there an easy way to > determine what service this is and if it gets successfully installed on windows? A +msi,+service trace should reveal the service name. "sc query" will list installed services, for example.

Feb. 19, 2014

Re: shell32: Ensure that tmpdir contains long path name.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5017 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:1211: Test failed: expected 1 args, got 4 shlexec.c:2283: Test failed: argcA expected 5, but got 4 === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD34F.tmp\wtD35F.tmp" Exec") WaitForSingleObject returned 258

Feb. 19, 2014

Re: msi: Dont crash on installation of services without component KeyPath

by Aric Stewart

I have not dug into the details, but I know it does not crash and the overall install does succeed. I can try investigating further on windows, Is there an easy way to determine what service this is and if it gets successfully installed on windows? -aric On 2014/02/19 18:11, Hans Leidekker wrote: > On Wed, 2014-02-19 at 17:57 +0900, Aric Stewart wrote: >> Well the image path in the component is optional and looking at the documentation >> for CreateServiceW lpBinaryPathName is also optional. So it seemed correct. >> >> If you feel like we should just exit then that is acceptable as well. > > What happens on Windows? > >

Feb. 19, 2014

[idea]wine support for Chrome OS

by 中川祥

Now,we don't run wine in Chrome OS. Google also think they can run windows executable files. My idea is about how to use wine in the OS. Google Chrome has two types of extensions:one is the extension,that support only web technology.the other is PPAPI,Google Native Client. Here's the overview↓ https://developers.google.com/native-client/dev/overview For example,Flash Player uses PPAPI. C/C++ programs can be transformed and run in its sandbox. then we can run wine in Chrome OS. I think if wine supports Chrome OS,Google helps us.

Feb. 19, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

On 19 February 2014 02:53, Ken Thomases <ken(a)codeweavers.com> wrote: > OK, I can see how that would happen. However, my wined3d patch didn't change that part of the logic. I think my test just exposed a pre-existing bug. It doesn't show up without my wined3d patch applied because, in that case, wined3d fails to restore the window's pixel format and leaves it with a double-buffered pixel format. The two bugs cancel each other out and fixing one allowed the other to be revealed. > With the current code, the pixel format only needs changing if the GL context also does, that's just an implication of setting/restoring both at the same time.

Feb. 19, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

On 19 February 2014 04:30, Ken Thomases <ken(a)codeweavers.com> wrote: > I guess this may be less efficient than we'd want. Ideally, as little WGL state as possible would be checked other than when context->level transitions from 0 to 1. context_enter() could check it at that time. Rather than using restore_ctx being non-NULL as a proxy for whether the context needs to be set, we'd use a separate, explicit flag: > > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index 4679b25..a0d078c 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -1109,6 +1109,7 @@ void context_release(struct wined3d_context *context) > context->restore_ctx = NULL; > context->restore_dc = NULL; > } > + context->needs_set = 0; > } > } > > @@ -1127,7 +1128,10 @@ static void context_enter(struct wined3d_context *context) > current_gl, wglGetCurrentDC()); > context->restore_ctx = current_gl; > context->restore_dc = wglGetCurrentDC(); > + context->needs_set = 1; > } > + else if (context->pixel_format != GetPixelFormat(context->hdc)) > + context->needs_set = 1; > } > } > > @@ -3051,7 +3055,7 @@ struct wined3d_context *context_acquire(const struct wined3d_device *device, str > if (!context_set_current(context)) > ERR("Failed to activate the new context.\n"); > } > - else if (context->restore_ctx) > + else if (context->needs_set) > { > context_set_gl_context(context); > } > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 0a1511b..0ceb6f1 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1085,7 +1085,8 @@ struct wined3d_context > DWORD fixed_function_usage_map : 8; /* MAX_TEXTURES, 8 */ > DWORD lowest_disabled_stage : 4; /* Max MAX_TEXTURES, 8 */ > DWORD rebind_fbo : 1; > - DWORD padding : 19; > + DWORD needs_set : 1; > + DWORD padding : 18; > DWORD shader_update_mask; > DWORD constant_update_mask; > DWORD numbered_array_mask; I think that mostly works, but you'll probably want to clear needs_set in context_set_gl_context() instead of in context_release(). I think there's also an argument somewhere that context_update_window() should set needs_set instead of calling context_set_pixel_format() and context_set_gl_context().

Feb. 19, 2014

Patch to fix bug 34324

by Zhenbo Li

Hello, I've been working on http://bugs.winehq.org/show_bug.cgi?id=34324. Till now, I have found two solutions, one is simple and one is complex. Both of them would fix #34324, and I don't know which one is better. As Alexandre Julliard mentioned[1], I would use the value of GetLastError() as the return (error) value in delete_files(). The simple patch would fix part of the 'todo_wine' marks. Meanwhile, the complex patch would fix *all* todo marks about return value in test_delete(). I really appreciate your help (especially for Dmitry Timoshkov, thank you very much). And I'm looking for your feedbacks. Thank you. [1]: http://markmail.org/message/fblet7gadeusyauv#query:+page:1+mid:6eu2a72uuchh… -- Have a nice day! Zhenbo Li

Feb. 19, 2014

Re: msi: Dont crash on installation of services without component KeyPath

by Hans Leidekker

On Wed, 2014-02-19 at 17:57 +0900, Aric Stewart wrote: > Well the image path in the component is optional and looking at the documentation > for CreateServiceW lpBinaryPathName is also optional. So it seemed correct. > > If you feel like we should just exit then that is acceptable as well. What happens on Windows?

Feb. 19, 2014

Re: msi: Dont crash on installation of services without component KeyPath

by Aric Stewart

Well the image path in the component is optional and looking at the documentation for CreateServiceW lpBinaryPathName is also optional. So it seemed correct. If you feel like we should just exit then that is acceptable as well. -aric On 2014/02/19 17:51, Hans Leidekker wrote: > On Wed, 2014-02-19 at 14:49 +0900, Aric Stewart wrote: >> diff --git a/dlls/msi/action.c b/dlls/msi/action.c >> index 07322fe..a004225 100644 >> --- a/dlls/msi/action.c >> +++ b/dlls/msi/action.c >> @@ -5794,27 +5794,30 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) >> goto done; >> } >> key = MSI_RecordGetString(row, 6); >> - file = msi_get_loaded_file(package, key); >> - msiobj_release(&row->hdr); >> - if (!file) >> - { >> - ERR("Failed to load the service file\n"); >> - goto done; >> - } >> - >> - if (!args || !args[0]) image_path = file->TargetPath; >> - else >> + if (key) >> { >> - int len = strlenW(file->TargetPath) + strlenW(args) + 2; >> - if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) >> + file = msi_get_loaded_file(package, key); >> + msiobj_release(&row->hdr); >> + if (!file) >> { >> - ret = ERROR_OUTOFMEMORY; >> + ERR("Failed to load the service file\n"); >> goto done; >> } >> >> - strcpyW(image_path, file->TargetPath); >> - strcatW(image_path, szSpace); >> - strcatW(image_path, args); >> + if (!args || !args[0]) image_path = file->TargetPath; >> + else >> + { >> + int len = strlenW(file->TargetPath) + strlenW(args) + 2; >> + if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) >> + { >> + ret = ERROR_OUTOFMEMORY; >> + goto done; >> + } >> + >> + strcpyW(image_path, file->TargetPath); >> + strcatW(image_path, szSpace); >> + strcatW(image_path, args); >> + } >> } >> service = CreateServiceW(hscm, name, disp, GENERIC_ALL, serv_type, >> start_type, err_control, image_path, load_order, >> @@ -5831,7 +5834,7 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) >> WARN("failed to set service description %u\n", GetLastError()); >> } >> >> - if (image_path != file->TargetPath) msi_free(image_path); >> + if (image_path && image_path != file->TargetPath) msi_free(image_path); >> done: >> CloseServiceHandle(service); >> CloseServiceHandle(hscm); > > Should we still create the service if the installer doesn't specify the image path? > >

Feb. 19, 2014

Re: msi: Dont crash on installation of services without component KeyPath

by Hans Leidekker

On Wed, 2014-02-19 at 14:49 +0900, Aric Stewart wrote: > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index 07322fe..a004225 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -5794,27 +5794,30 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) > goto done; > } > key = MSI_RecordGetString(row, 6); > - file = msi_get_loaded_file(package, key); > - msiobj_release(&row->hdr); > - if (!file) > - { > - ERR("Failed to load the service file\n"); > - goto done; > - } > - > - if (!args || !args[0]) image_path = file->TargetPath; > - else > + if (key) > { > - int len = strlenW(file->TargetPath) + strlenW(args) + 2; > - if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) > + file = msi_get_loaded_file(package, key); > + msiobj_release(&row->hdr); > + if (!file) > { > - ret = ERROR_OUTOFMEMORY; > + ERR("Failed to load the service file\n"); > goto done; > } > > - strcpyW(image_path, file->TargetPath); > - strcatW(image_path, szSpace); > - strcatW(image_path, args); > + if (!args || !args[0]) image_path = file->TargetPath; > + else > + { > + int len = strlenW(file->TargetPath) + strlenW(args) + 2; > + if (!(image_path = msi_alloc(len * sizeof(WCHAR)))) > + { > + ret = ERROR_OUTOFMEMORY; > + goto done; > + } > + > + strcpyW(image_path, file->TargetPath); > + strcatW(image_path, szSpace); > + strcatW(image_path, args); > + } > } > service = CreateServiceW(hscm, name, disp, GENERIC_ALL, serv_type, > start_type, err_control, image_path, load_order, > @@ -5831,7 +5834,7 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) > WARN("failed to set service description %u\n", GetLastError()); > } > > - if (image_path != file->TargetPath) msi_free(image_path); > + if (image_path && image_path != file->TargetPath) msi_free(image_path); > done: > CloseServiceHandle(service); > CloseServiceHandle(hscm); Should we still create the service if the installer doesn't specify the image path?

Feb. 19, 2014

Re: Failing dpnet tests

by Alistair Leslie-Hughes

Hi Francois, The issue is when it run on the test bot. This patch removed all tests and traces around CoCreateInstance. https://newtestbot.winehq.org/JobDetails.pl?Key=4949&log_201=1#k201 Its timing out. I've seen this on Linux when mixing native dpnsvr.exe and builtin dpnet.dll due to the missing callback in dpnet.dll (not a windows issue). If dpnsvr uses the local address instead of the loopback then this cause the timeout. Would it be possible to test windows 8 without the firewall enabled? It's going to be hard to get patches accepted if win8 keeps failing. Best Regards Alistair Leslie-Hughes

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Ken Thomases

On Feb 18, 2014, at 7:53 PM, Ken Thomases wrote: > This fixes it, although it may be more crude than we'd like: > - else if (context->restore_ctx) > + else if (context->restore_ctx || context->pixel_format != GetPixelFormat(wglGetCurrentDC())) On second thought, that would be unreliable. It depends on the app's DC still being valid, which it may not be. We'd have to check using a DC for the window that would actually be used if the context were to be made current. (I think we can ignore the swapchain backup DC, since that's used when the pixel format can't be set on context->hdc and the condition will be true, which is what we want.) So: else if (context->restore_ctx || context->pixel_format != GetPixelFormat(context->hdc)) I guess this may be less efficient than we'd want. Ideally, as little WGL state as possible would be checked other than when context->level transitions from 0 to 1. context_enter() could check it at that time. Rather than using restore_ctx being non-NULL as a proxy for whether the context needs to be set, we'd use a separate, explicit flag: diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 4679b25..a0d078c 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -1109,6 +1109,7 @@ void context_release(struct wined3d_context *context) context->restore_ctx = NULL; context->restore_dc = NULL; } + context->needs_set = 0; } } @@ -1127,7 +1128,10 @@ static void context_enter(struct wined3d_context *context) current_gl, wglGetCurrentDC()); context->restore_ctx = current_gl; context->restore_dc = wglGetCurrentDC(); + context->needs_set = 1; } + else if (context->pixel_format != GetPixelFormat(context->hdc)) + context->needs_set = 1; } } @@ -3051,7 +3055,7 @@ struct wined3d_context *context_acquire(const struct wined3d_device *device, str if (!context_set_current(context)) ERR("Failed to activate the new context.\n"); } - else if (context->restore_ctx) + else if (context->needs_set) { context_set_gl_context(context); } diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 0a1511b..0ceb6f1 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1085,7 +1085,8 @@ struct wined3d_context DWORD fixed_function_usage_map : 8; /* MAX_TEXTURES, 8 */ DWORD lowest_disabled_stage : 4; /* Max MAX_TEXTURES, 8 */ DWORD rebind_fbo : 1; - DWORD padding : 19; + DWORD needs_set : 1; + DWORD padding : 18; DWORD shader_update_mask; DWORD constant_update_mask; DWORD numbered_array_mask; -Ken

Feb. 18, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Christopher Thielen

Good point. Maybe knowing the offset isn't too useful for now. I still haven't figured out through what mechanism the game draws this missing cursor. The D3D9 cursor functions never make a sound in the logs and while the User32 LoadCursor/SetCursor/clipping stuff is called an awful lot on initialization, it looks like it's always for the system cursors. I also pasted in a method to dump to a .bmp file anything that goes through LoadIcon and wound up with one icon I don't recall and another which was simply Wine's icon. So, my hunch now is that the game draws the cursor using DirectX and uses User32 only for setting mouse clipping. Is there a decent way to dump as a file every DX resource loaded that's under a certain size? I'd like to confirm my theory and maybe if I'm lucky figure out which DX surface/texture is being drawn incorrectly (if any). - Christopher Thielen On 02/18/2014 12:16 AM, Stefan Dösinger wrote: > > Am 18.02.2014 um 06:12 schrieb Christopher Thielen <christopher(a)thielen.co>: >> Two questions: >> 1) Is there a way to add timestamps to the TRACE statements in Wine? > WINEDEBUG=+timestamp > > This adds timestamps to other traces, so you can do e.g. WINEDEBUG=d3d,timestamp to get a d3d trace with timestamps. > >> 2) If I know which file is opened by the game, is there a way to debug from that point on, i.e. capture the fopen() and enable +cursor,+resource,+d3d TRACES for say, only 5 seconds after that point? Something along those lines? > Afaik no. You could use some search and replace tricks in text editors or with command line text tools though. >> >> I can find the exact offset within the data file used to load the missing resource - but I'd need a way to know when a fread() was that far along. I figure if I can determine that I can determine if the cursor is loaded as a Windows cursor or as a D3D surface and go from there. > Note that there are plenty of ways to open and read files. fopen and fread are just one of them. There are win32 equivalents of those C functions, and there are specific resource loading functions which you’ve probably already seen. >

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Ken Thomases

On Feb 18, 2014, at 5:40 PM, Henri Verbeet wrote: > After thinking about it for a bit, I think the issue is essentially > that context_acquire() depends on context_enter() to set > context->restore_ctx when context_set_gl_context() needs to be called. > If only the pixel format is different context_set_gl_context() will > not be called. OK, I can see how that would happen. However, my wined3d patch didn't change that part of the logic. I think my test just exposed a pre-existing bug. It doesn't show up without my wined3d patch applied because, in that case, wined3d fails to restore the window's pixel format and leaves it with a double-buffered pixel format. The two bugs cancel each other out and fixing one allowed the other to be revealed. This fixes it, although it may be more crude than we'd like: diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 4679b25..3d11c16 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -3051,7 +3056,7 @@ struct wined3d_context *context_acquire(const struct wined3d_device *device, str if (!context_set_current(context)) ERR("Failed to activate the new context.\n"); } - else if (context->restore_ctx) + else if (context->restore_ctx || context->pixel_format != GetPixelFormat(wglGetCurrentDC())) { context_set_gl_context(context); } -Ken

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

After thinking about it for a bit, I think the issue is essentially that context_acquire() depends on context_enter() to set context->restore_ctx when context_set_gl_context() needs to be called. If only the pixel format is different context_set_gl_context() will not be called.

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

On 18 February 2014 23:14, Ken Thomases <ken(a)codeweavers.com> wrote: > On Feb 18, 2014, at 10:08 AM, Henri Verbeet wrote: >> ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p >> d3d9_test.exe.so device && touch device.ok >> ... >> device.c:7547: Test succeeded >> X Error of failed request: BadMatch (invalid parameter attributes) >> Major opcode of failed request: 154 (GLX) >> Minor opcode of failed request: 11 (X_GLXSwapBuffers) >> Serial number of failed request: 4929 >> Current serial number in output stream: 4933 >> make: *** [device.ok] Error 1 > > Is this with or without patch 1 applied? > With. Without patch 1, I get test failures, but not the BadMatch error.

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Ken Thomases

On Feb 18, 2014, at 10:08 AM, Henri Verbeet wrote: > On 17 February 2014 22:25, Ken Thomases <ken(a)codeweavers.com> wrote: >> dlls/d3d9/tests/device.c | 144 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 144 insertions(+) >> > Unfortunately this fails here: > > ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p > d3d9_test.exe.so device && touch device.ok > ... > device.c:7547: Test succeeded > X Error of failed request: BadMatch (invalid parameter attributes) > Major opcode of failed request: 154 (GLX) > Minor opcode of failed request: 11 (X_GLXSwapBuffers) > Serial number of failed request: 4929 > Current serial number in output stream: 4933 > make: *** [device.ok] Error 1 Is this with or without patch 1 applied? -Ken

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

On 17 February 2014 22:25, Ken Thomases <ken(a)codeweavers.com> wrote: > dlls/d3d9/tests/device.c | 144 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 144 insertions(+) > Unfortunately this fails here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so device && touch device.ok ... device.c:7547: Test succeeded X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 154 (GLX) Minor opcode of failed request: 11 (X_GLXSwapBuffers) Serial number of failed request: 4929 Current serial number in output stream: 4933 make: *** [device.ok] Error 1

Feb. 18, 2014

Re: [PATCH] user32: Use public define for Dialog class atom

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > /* Built-in class names (see _Undocumented_Windows_ p.418) */ > #define POPUPMENU_CLASS_ATOM MAKEINTATOM(32768) /* PopupMenu */ > #define DESKTOP_CLASS_ATOM MAKEINTATOM(32769) /* Desktop */ > -#define DIALOG_CLASS_ATOM MAKEINTATOM(32770) /* Dialog */ > #define WINSWITCH_CLASS_ATOM MAKEINTATOM(32771) /* WinSwitch */ > #define ICONTITLE_CLASS_ATOM MAKEINTATOM(32772) /* IconTitle */ This list is very handy when searching for an atom constant in the user32 code, also there is no point in breaking "grep CLASS_ATOM" in favour of a dubious use of just one constant from a public header. -- Dmitry.

Feb. 18, 2014

Re: Failing dpnet tests

by Francois Gouget

On Tue, 18 Feb 2014, Alistair Leslie-Hughes wrote: > Hi, > > On Windows 8, the dpnet are failing with a timeout. I don't see a timeout for either the dpnet:peer or dpnet:server tests: http://test.winehq.org/data/tests/dpnet:peer.html http://test.winehq.org/data/tests/dpnet:server.html In fact it's green on all Windows platforms for the past 12 runs. Kudos! > After manually running the tests, I found a possible cause. > > The dpnet.dll cause the dpnsvr.exe to be loaded which attempts to > create a socket. In turn the firewall dialog appears prompting > whether it's allowed to do so. So no communication between the dpnet test exe > and dpnsvr.exe thus the timeout. > > Could someone run the dpnet test manually and allow the dpnsvr.exe > to create connections? I have run both tests manually on my Windows 8.1 laptop. On the first run the dpnet:server test caused the firewall dialog to pop up but that did not stop the test and it completed almost immediately. A number of other tests cause the firewall dialog to pop up but I believe that as long as the connections are to and/or from the localhost, the firewall lets them through and so does not cause trouble. -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows (try2)

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -1098,13 +1098,62 @@ INT WINAPI GetClassNameW( HWND hwnd, LPWSTR buffer, INT count ) > return ret; > } > > +struct builtinclass_name > +{ > + const char *nameA; > + const WCHAR *nameW; > + int len; > +}; > + > +static const WCHAR buttonW[] = {'B','u','t','t','o','n',0}; > +static const WCHAR comboboxW[] = {'C','o','m','b','o','B','o','x',0}; > +static const WCHAR dialogW[] = {'#','3','2','7','7','0',0}; > +static const WCHAR editW[] = {'E','d','i','t',0}; > +static const WCHAR listboxW[] = {'L','i','s','t','B','o','x',0}; > +static const WCHAR mdiclientW[] = {'M','D','I','C','l','i','e','n','t',0}; > +static const WCHAR scrollbarW[] = {'S','c','r','o','l','l','B','a','r',0}; > +static const WCHAR staticW[] = {'S','t','a','t','i','c',0}; > + > +static const struct builtinclass_name builtinclass_names[BUILTINTYPE_MAX] = > +{ > + { "Button", buttonW, sizeof(buttonW)/sizeof(WCHAR) }, > + { "ComboBox", comboboxW, sizeof(comboboxW)/sizeof(WCHAR) }, > + { "#32770", dialogW, sizeof(dialogW)/sizeof(WCHAR) }, > + { "Edit", editW, sizeof(editW)/sizeof(WCHAR) }, > + { "ListBox", listboxW, sizeof(listboxW)/sizeof(WCHAR) }, > + { "MDIClient", mdiclientW, sizeof(mdiclientW)/sizeof(WCHAR) }, > + { "ScrollBar", scrollbarW, sizeof(scrollbarW)/sizeof(WCHAR) }, > + { "Static", staticW, sizeof(staticW)/sizeof(WCHAR) } > +}; You should use the existing builtin class descriptors instead of duplicating that info. -- Alexandre Julliard julliard(a)winehq.org

Feb. 18, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Stefan Dösinger

Am 18.02.2014 um 06:12 schrieb Christopher Thielen <christopher(a)thielen.co>: > Two questions: > 1) Is there a way to add timestamps to the TRACE statements in Wine? WINEDEBUG=+timestamp This adds timestamps to other traces, so you can do e.g. WINEDEBUG=d3d,timestamp to get a d3d trace with timestamps. > 2) If I know which file is opened by the game, is there a way to debug from that point on, i.e. capture the fopen() and enable +cursor,+resource,+d3d TRACES for say, only 5 seconds after that point? Something along those lines? Afaik no. You could use some search and replace tricks in text editors or with command line text tools though. > > I can find the exact offset within the data file used to load the missing resource - but I'd need a way to know when a fread() was that far along. I figure if I can determine that I can determine if the cursor is loaded as a Windows cursor or as a D3D surface and go from there. Note that there are plenty of ways to open and read files. fopen and fread are just one of them. There are win32 equivalents of those C functions, and there are specific resource loading functions which you’ve probably already seen.

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

by Nikolay Sivov

On 2/18/2014 11:42, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> + else if (ptr->builtin_type != -1) >> + { >> + const struct builtinclass_name *classname = &builtinclass_names[ptr->builtin_type]; >> + ret = min( count, classname->len ) - 1; >> + memcpy( buffer, classname->nameA, ret ); >> + buffer[ret] = 0; >> + } > In case of count = 0 this code will overwrite random data. > No, it won't.

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + else if (ptr->builtin_type != -1) > + { > + const struct builtinclass_name *classname = &builtinclass_names[ptr->builtin_type]; > + ret = min( count, classname->len ) - 1; > + memcpy( buffer, classname->nameA, ret ); > + buffer[ret] = 0; > + } In case of count = 0 this code will overwrite random data. -- Dmitry.

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4995 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6429: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6451: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6429: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6451: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6429: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6451: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 win.c:6212: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 0000000000000000 win.c:2988: Test failed: GetFocus() = 0000000000000000 win.c:3011: Test failed: GetActiveWindow() = 0000000000000000 win.c:3011: Test failed: GetFocus() = 0000000000000000 win.c:3072: Test failed: GetActiveWindow() = 0000000000000000 win.c:3072: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 0000000000000000 win.c:2988: Test failed: GetFocus() = 0000000000000000 win.c:3011: Test failed: GetActiveWindow() = 0000000000000000 win.c:3011: Test failed: GetFocus() = 0000000000000000 win.c:3072: Test failed: GetActiveWindow() = 0000000000000000 win.c:3072: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 0000000000000000 win.c:2988: Test failed: GetFocus() = 0000000000000000 win.c:3011: Test failed: GetActiveWindow() = 0000000000000000 win.c:3011: Test failed: GetFocus() = 0000000000000000 win.c:3072: Test failed: GetActiveWindow() = 0000000000000000 win.c:3072: Test failed: GetFocus() = 0000000000000000

Feb. 18, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Christopher Thielen

I still haven't figured this bug out yet but Erich Hoover's help I've at least determined the missing cursor is not loaded from a resource in the .exe. I ported an Allegro-based fan tool somebody wrote in 2000 to Linux+SDL and have determined that the missing cursor is loaded from a resource file in the game's static/bitmap.flx file. Two questions: 1) Is there a way to add timestamps to the TRACE statements in Wine? 2) If I know which file is opened by the game, is there a way to debug from that point on, i.e. capture the fopen() and enable +cursor,+resource,+d3d TRACES for say, only 5 seconds after that point? Something along those lines? I can find the exact offset within the data file used to load the missing resource - but I'd need a way to know when a fread() was that far along. I figure if I can determine that I can determine if the cursor is loaded as a Windows cursor or as a D3D surface and go from there. Any ideas? - Christopher Thielen On 02/17/2014 12:27 PM, Christopher Thielen wrote: > I should clarify as per Stefan Dösinger's comments that I have only been > using the gog.com version (both under Wine and in my testing so far > under Windows XP) so the nGlide wrapper code paths should be the same. > The original, non-gog.com version is more or less garbage due to some > CD-ROM driver DRM-trickery. > > Erich Hoover suggested to look at WINEDEBUG=+cursor,+icon,+resource and > see if the game is merely using 'traditional' cursors. I do know this > game was in development for quite a while and originally started out as > a Glide game, so it makes some sense that the DirectX ShowCursor stuff > might not be used at all. I tried TRACE'ing d3d8_device,d3d9_device,and > dinput but found no calls related to cursors. > > The WINEDEBUG=+cursor,+icon,+resource trace does appear to be onto > something though. I attached the log to the bug but here are some snippets: > > trace:icon:ICO_LoadIcon 0x360000 0x360086 > trace:cursor:CreateIconFromResourceEx 0x37dc22 (1128 bytes), ver > 00030000, 32x32 icon > trace:cursor:ungrab_clipping_window no longer clipping > trace:icon:DrawIconEx > (hdc=0x2002d,pos=23.4,hicon=0x10044,extend=32.32,istep=0,br=(nil),flags=0x0000000b) > > trace:resource:LdrFindResource_U module 0x7e920000 type #0018 name #0002 > lang 0000 level 3 > trace:resource:find_entry_by_id root 0x7e93f3b4 dir 0x7e93f3b4 id 0018 > not found > trace:cursor:LoadCursorW (nil), #7f00 > trace:resource:LoadImageW ((nil),#7f00,2,0,0,0x00008040) > trace:cursor:CURSORICON_Load (nil), #7f00, 0x0, depth 32, fCursor 1, > flags 0x8040 > > In particular, when the user presses 'Q', it should toggle the cursor > icon. Here is the log grepped for "cursor:LoadIconW": > > trace:cursor:LoadIconW (nil), #7f05 > trace:cursor:LoadIconW (nil), #7f05 > trace:cursor:LoadIconW 0x7edb0000, L"" > trace:cursor:LoadIconW (nil), L"" > trace:cursor:LoadIconW (nil), #7f05 > trace:cursor:LoadIconW 0x7edf0000, #0001 > trace:cursor:LoadIconW 0x7edb0000, #0001 > trace:cursor:LoadIconW (nil), #7f05 > trace:cursor:LoadIconW (nil), #7f00 > trace:cursor:LoadIconW (nil), #7f00 > > Am I wrong in reading this as the game toggling between two cursors? Is > there a way to dump the ICO resource from LoadIconW to the file system > to debug which icons it is trying and/or failing to load? > > Thanks again to everybody for all your help so far, > Christopher Thielen > > On 02/16/2014 11:55 AM, Stefan Dösinger wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Am 2014-02-16 20:39, schrieb Christopher Thielen: >>> fixme:d3d:wined3d_debug_location Unrecognized location flag(s) >>> 0xfffffc00. >> These lines are harmless. That's pretty much code doing something like >> this >> >> TRACE("Removing flags %s.\n", >> wined3d_debug_location(~WINED3D_LOCATION_SYSMEM); >> >> which ends up passing a value like 0xfffffffe to wined3d_debug_location. >> >> wined3d_debug_location then does something like >> >> if (flags & (SYSMEM | BUFFER | ALL | DEFINED | FLAGS)) >> FIXME("Unrecognized location flag(s) %#x.\n", flags); >> >> What is missing here is a logical and that filters out unknown flags in >> places where a bitwise not is used, or maybe just the removal of the >> unknown flags fixme in wined3d_debug_location. >> >>> Unfortunately, there is no reference to "ddraw7_GetCaps" or >>> "GetCaps" anywhere in the 975 MB log. That confirms it isn't using >>> overlays, right? >> Pretty much, yeah. >> >>> fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 >> That's WINED3DUSAGE_TEXTURE and needs to be added to the debug function. >> >>> This gog.com version uses nGlide to wrap the Glide API to DirectX >>> calls - DX9 I believe, based on the requirements of nGlide >>> (http://www.zeus-software.com/downloads/nglide) Not sure if this >>> information helps. >> This means the GOG version is using an entirely different codepath >> than what you're trying to run. It is quite possible that the codepath >> you're running is broken in some way. I recommend to test if the >> game's ddraw codepath is working properly on Windows before you bang >> your head against it. It can save you a lot of time :-) . >> >> If it turns out that the ddraw codepath is working just fine on >> Windows 7 there's certainly value in fixing it. If it is not, but it >> is working on e.g. Windows XP, it might still be worth a look. >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2.0.22 (GNU/Linux) >> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ >> >> iQIcBAEBAgAGBQJTARfAAAoJEN0/YqbEcdMwSC0P/1iZxKSLjIqEXeDmPsy7ARU9 >> vWm0Uqo0SYdCAEemGA2vD53IuojRUyMZ9E0ikfCZ7qlVK7uaFs54TtiY15C+p6ic >> gZhNezdyt/6idLootvCsJ9ZDoSaFdIDvoWga7JThwlZnfGVVZIGj6WeJeTV+rXon >> QHkQO/jghlHpgZIT6mdicvsltaWujg+Idwfuz1Z8i8+fKEhy7Uvp+QKCqsF8JdNf >> AuDceOPwF8aaH0YWVieyQfTiqzv4RHTnF5i+LGWPx61SRuRXi2YT+2hHlTbspua2 >> 6/FfQ+c2P6eoI39UiRysWL8+zB+T0o5V0JOF2PD5EJGqc+vP4066XkxZlA7Kdl6W >> h8RCzDbU+gxeq49cXHTG6AbvLUdkbDowo/dwW6x4wOmnlzZBW5CNxF0NbQ0Jf4sW >> mQLynduNdejnqgwZSFb5m8AoTqCZ+XbLkGq5uPAcAz6TIlsrKW7oQ41rTkeLxpU/ >> Z5nlLDmC5MIP8t8he2KuLu8eVrLhSsxYFEyeevhHY/SvNkmi1LxkXJMQHt8gDpdi >> 3ZW+LuW5nsOJ/9T7vH27ENorqRNtpFWnpdwPMyBgQJbPlNCYVp5ZTKE8WHpk+fk4 >> T+LzzbOlli8svOLHll4rmDhD89qYiQQUWNv7V7XjTHrgrxpZFY5aLXrprEGTc6Kc >> PCO4omr8MIkjrtJAHfKX >> =evKW >> -----END PGP SIGNATURE----- >> > >

Feb. 17, 2014

Re: ws2_32: Fix conversion of address in GetAddrInfoW (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4994 Your paranoid android. === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (b28): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB3F3A === wvistau64 (32 bit sock) === sock.c:613: Test failed: oob_server (190): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:603: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:613: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit sock) === sock.c:613: Test failed: oob_server (63c): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:613: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:613: Test failed: oob_server (968): unexpectedly at the OOB mark: 0

Feb. 17, 2014

Re: ws2_32: Fix conversion of address in GetAddrInfoW

by Bruno Jesus

On Tue, Feb 18, 2014 at 1:06 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Bruno Jesus <00cpxxx(a)gmail.com> wrote: > >> >> + else if(a->ai_canonname || b->ai_canonname) >> >> + ok(0, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); >> > >> > It would look more natural IMHO to use >> > ok(!a->ai_canonname && !b->ai_canonname, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); >> > instead of explicit ok(0) (here and in the not unicode variant). >> >> Indeed, much better. > > Please take into account my typos above (remove '!'s). If one of the strings are not present both must be null. So it's OK to have ok(!a->ai_canonname && !b->ai_canonname). Actually I changed the text to reflect that: if (a->ai_canonname && b->ai_canonname) { ok(!strcmp(a->ai_canonname, b->ai_canonname), "Wrong canonical name '%s' != '%s'\n", a->ai_canonname, b->ai_canonname); } else ok(!a->ai_canonname && !b->ai_canonname, "Expected both names absent (%p != %p)\n", a->ai_canonname, b->ai_canonname); I think that it's correct like this. > -- > Dmitry.

Feb. 17, 2014

Re: ws2_32: Fix conversion of address in GetAddrInfoW

by Dmitry Timoshkov

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > >> + else if(a->ai_canonname || b->ai_canonname) > >> + ok(0, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); > > > > It would look more natural IMHO to use > > ok(!a->ai_canonname && !b->ai_canonname, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); > > instead of explicit ok(0) (here and in the not unicode variant). > > Indeed, much better. Please take into account my typos above (remove '!'s). -- Dmitry.

Feb. 17, 2014

Re: ws2_32: Fix conversion of address in GetAddrInfoW

by Bruno Jesus

On Tue, Feb 18, 2014 at 12:11 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Bruno Jesus <00cpxxx(a)gmail.com> wrote: > >> + if (a->ai_canonname && b->ai_canonname) >> + { >> + char bufa[128], bufb[128]; >> + WideCharToMultiByte(CP_ACP, 0, a->ai_canonname, -1, >> + bufa, sizeof(bufa), NULL, NULL); >> + WideCharToMultiByte(CP_ACP, 0, b->ai_canonname, -1, >> + bufb, sizeof(bufb), NULL, NULL); >> + ok(!strcmp(bufa, bufb), "Wrong canonical name '%s' != '%s'\n", bufa, bufb); >> + } > > I'd suggest to avoid using fixed size buffers and call lstrcmpW() for > comparison and wine_dbgstr_w() to print the values. For some stupid reason I was trying to use wine_debugstr_w instead of wine_dbgstr_w, so I looked for an alternative way... >> + else if(a->ai_canonname || b->ai_canonname) >> + ok(0, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); > > It would look more natural IMHO to use > ok(!a->ai_canonname && !b->ai_canonname, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); > instead of explicit ok(0) (here and in the not unicode variant). Indeed, much better. >> + if (a || b) >> + ok(0, "Expected both addresses null (%p != %p)\n", a, b); > > Same here. Yep. > -- > Dmitry. Thanks, Dmitry. Bruno

Feb. 17, 2014

Re: ws2_32: Fix conversion of address in GetAddrInfoW

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4992 Your paranoid android. === wxppro (32 bit sock) === sock.c:617: Test failed: oob_server (b28): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:607: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:617: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 === wvistau64 (64 bit sock) === sock.c:617: Test failed: oob_server (b5c): unexpectedly at the OOB mark: 0 No test summary line found === w2008s64 (64 bit sock) === sock.c:617: Test failed: oob_server (744): unexpectedly at the OOB mark: 0

Feb. 17, 2014

Re: ws2_32: Fix conversion of address in GetAddrInfoW

by Dmitry Timoshkov

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + if (a->ai_canonname && b->ai_canonname) > + { > + char bufa[128], bufb[128]; > + WideCharToMultiByte(CP_ACP, 0, a->ai_canonname, -1, > + bufa, sizeof(bufa), NULL, NULL); > + WideCharToMultiByte(CP_ACP, 0, b->ai_canonname, -1, > + bufb, sizeof(bufb), NULL, NULL); > + ok(!strcmp(bufa, bufb), "Wrong canonical name '%s' != '%s'\n", bufa, bufb); > + } I'd suggest to avoid using fixed size buffers and call lstrcmpW() for comparison and wine_dbgstr_w() to print the values. > + else if(a->ai_canonname || b->ai_canonname) > + ok(0, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); It would look more natural IMHO to use ok(!a->ai_canonname && !b->ai_canonname, "Expected both canonical names present (%p != %p)\n", a->ai_canonname, b->ai_canonname); instead of explicit ok(0) (here and in the not unicode variant). > + if (a || b) > + ok(0, "Expected both addresses null (%p != %p)\n", a, b); Same here. -- Dmitry.

Feb. 17, 2014

Re: [PATCH] kernel32: FindExInfoBasic added

by Zhenbo Li

2014-02-17 4:49 GMT+08:00 Marcus Meissner <marcus(a)jet.franken.de>: > > > > Lightroom calls it with FindExInfoBasic ... MSDN says its basically same as Standard, but without the short filename returned. > > As untangling the short filename handling is kind of large, lets just ignore > it. Hello, Marcus I have a question. As MSDN said[1] , "The FindFirstFileEx function does not query the short file name, improving overall enumeration speed." Then I can't get the *exact* difference between them. Could you please make a brief explanation? Or a few test-cases may be helpful? BTW, I found an old patch[2], which focus on the same issue. Maybe it would offer a reference? [1]: http://msdn.microsoft.com/en-us/library/aa364415%28v=vs.85%29.aspx [2]: http://www.winehq.org/pipermail/wine-patches/2013-May/124116.html -- Have a nice day! Zhenbo Li

Feb. 17, 2014

Re: [PATCH] kernel32: FindExInfoBasic added

by Zhenbo Li

2014-02-17 4:49 GMT+08:00 Marcus Meissner <marcus(a)jet.franken.de>: > > > > Lightroom calls it with FindExInfoBasic ... MSDN says its basically same as Standard, but without the short filename returned. > > As untangling the short filename handling is kind of large, lets just ignore > it. Hello, Marcus I have a question. As MSDN said[1] , "The FindFirstFileEx function does not query the short file name, improving overall enumeration speed." Then I can't get the *exact* difference between them. Could you please make a brief explanation? Or a few test-cases may be helpful? BTW, I found an old patch[2], which focus on the same issue. Maybe it would offer a reference? [1]: http://msdn.microsoft.com/en-us/library/aa364415%28v=vs.85%29.aspx [2]: http://www.winehq.org/pipermail/wine-patches/2013-May/124116.html -- Have a nice day! Zhenbo Li

Feb. 17, 2014

Re: [PATCH 4/4] ddraw/tests: Test that DirectDraw doesn't modify the pixel format of the window it targets. (try 2)

by Ken Thomases

On Feb 17, 2014, at 6:29 PM, Marvin wrote: > === w8 (32 bit ddraw2) === > ddraw2.c:5212: Test failed: Got unexpected refcount 3. > … > > === w8 (32 bit ddraw1) === > ddraw1.c:4115: Test failed: Got unexpected refcount 3. > … > > === w8 (32 bit ddraw7) === > ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. > … > > === w8 (32 bit ddraw4) === > ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. > … Not related to my patch. -Ken

Feb. 17, 2014

Re: [PATCH 4/4] ddraw/tests: Test that DirectDraw doesn't modify the pixel format of the window it targets. (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4985 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:5212: Test failed: Got unexpected refcount 3. ddraw2.c:5231: Test failed: Got unexpected refcount 3. ddraw2.c:5238: Test failed: Got unexpected hr 0. ddraw2.c:5241: Test failed: Got unexpected refcount 3. ddraw2.c:5243: Test failed: Got unexpected refcount 2. ddraw2.c:5249: Test failed: Got unexpected hr 0. ddraw2.c:5252: Test failed: Got unexpected refcount 2. ddraw2.c:5254: Test failed: Got unexpected refcount 1. The test timed out === w8 (32 bit ddraw1) === ddraw1.c:4115: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 3. ddraw1.c:4141: Test failed: Got unexpected hr 0. ddraw1.c:4144: Test failed: Got unexpected refcount 3. ddraw1.c:4146: Test failed: Got unexpected refcount 2. ddraw1.c:4152: Test failed: Got unexpected hr 0. ddraw1.c:4155: Test failed: Got unexpected refcount 2. ddraw1.c:4157: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw7) === ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw7.c:4049: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. No test summary line found Failure running script in VM: network read timed out === w8 (32 bit ddraw4) === ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5808: Test failed: Got unexpected refcount 3. ddraw4.c:5827: Test failed: Got unexpected refcount 3. ddraw4.c:5834: Test failed: Got unexpected hr 0. ddraw4.c:5837: Test failed: Got unexpected refcount 3. ddraw4.c:5839: Test failed: Got unexpected refcount 2. ddraw4.c:5845: Test failed: Got unexpected hr 0. ddraw4.c:5848: Test failed: Got unexpected refcount 2. ddraw4.c:5850: Test failed: Got unexpected refcount 1. ddraw4.c:5852: Test failed: Got unexpected refcount 6. ddraw4.c:5976: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:6015: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6018: Test failed: Got unexpected hr 0. ddraw4.c:6020: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6023: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6026: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6028: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6031: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6033: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6036: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6038: Test failed: Got unexpected hr 0x887601c2.

Feb. 17, 2014

Re: [PATCH 3/4] d3d8/tests: Test that Direct3D8 doesn't modify the pixel format of the window it targets. (try 2)

by Ken Thomases

On Feb 17, 2014, at 5:12 PM, Marvin wrote: > === w8 (32 bit device) === > device.c:1204: Test failed: TestCooperativeLevel failed, hr 0x88760868. > device.c:1249: Test failed: Reset failed, hr 0x88760868. > device.c:1251: Test failed: TestCooperativeLevel failed, hr 0x88760869. > device.c:1255: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. > device.c:1262: Test failed: D3DVIEWPORT->X = 10, expected 0. > device.c:1263: Test failed: D3DVIEWPORT->Y = 20, expected 0. > device.c:1264: Test failed: D3DVIEWPORT->Width = 400, expected 800. > device.c:1265: Test failed: D3DVIEWPORT->Height = 300, expected 600. > device.c:1266: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. > device.c:1267: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. > device.c:1272: Test failed: Screen width is 640, expected 800. > device.c:1273: Test failed: Screen height is 480, expected 600. > device.c:1279: Test failed: Back buffer width is 640, expected 800. > device.c:1281: Test failed: Back buffer height is 480, expected 600. > device.c:1311: Test failed: Screen width is 640, expected 1024. > device.c:1312: Test failed: Screen height is 480, expected 768. > device.c:2572: Test failed: Expected foreground window 00030180, got 00010048. > device.c:3177: Test failed: Got unexpect width 640. > device.c:3178: Test failed: Got unexpect height 480. > device.c:3190: Test failed: Got unexpect width 640. > device.c:3191: Test failed: Got unexpect height 480. > device.c:3268: Test failed: Expected wndproc 0x410530, got 0x410530. Not related to my patch. -Ken

Feb. 17, 2014

Re: [1/3] user32: Add a test for empty popup menus.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c > index 6f13fac..0be4afc 100644 > --- a/dlls/user32/tests/menu.c > +++ b/dlls/user32/tests/menu.c It would be much better to create a proper message test instead, and it would show what actually is going on. -- Dmitry.

Feb. 17, 2014

Re: [PATCH 3/4] d3d8/tests: Test that Direct3D8 doesn't modify the pixel format of the window it targets. (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4984 Your paranoid android. === w8 (32 bit device) === device.c:1204: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1249: Test failed: Reset failed, hr 0x88760868. device.c:1251: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1255: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1262: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1263: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1264: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1265: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1266: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1267: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1272: Test failed: Screen width is 640, expected 800. device.c:1273: Test failed: Screen height is 480, expected 600. device.c:1279: Test failed: Back buffer width is 640, expected 800. device.c:1281: Test failed: Back buffer height is 480, expected 600. device.c:1311: Test failed: Screen width is 640, expected 1024. device.c:1312: Test failed: Screen height is 480, expected 768. device.c:2572: Test failed: Expected foreground window 00030180, got 00010048. device.c:3177: Test failed: Got unexpect width 640. device.c:3178: Test failed: Got unexpect height 480. device.c:3190: Test failed: Got unexpect width 640. device.c:3191: Test failed: Got unexpect height 480. device.c:3268: Test failed: Expected wndproc 0x410530, got 0x410530.

Feb. 17, 2014

Re: user32/tests: Flush pending events before testing menu messages.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4981 Your paranoid android. === w8 (32 bit msg) === msg.c:5965: Test failed: Regions are different msg.c:5965: Test failed: Regions are different msg.c:5965: Test failed: Regions are different msg.c:8366: Test failed: did not get expected count for minimum timeout (54 != ~64). msg.c:12089: Test failed: unexpected message 31f msg.c:12090: Test failed: bad wparam 1 msg.c:12100: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

Feb. 17, 2014

Failing dpnet tests

by Alistair Leslie-Hughes

Hi, On Windows 8, the dpnet are failing with a timeout. After manually running the tests, I found a possible cause. The dpnet.dll cause the dpnsvr.exe to be loaded which attempts to create a socket. In turn the firewall dialog appears prompting whether it's allowed to do so. So no communication between the dpnet test exe and dpnsvr.exe thus the timeout. Could someone run the dpnet test manually and allow the dpnsvr.exe to create connections? Best Regards Alistair Leslie-Hughes

Feb. 17, 2014

Re: ddraw/tests: Skip some tests when switching the display mode is not supported.

by Francois Gouget

On Mon, 17 Feb 2014, Marvin wrote: [...] > ddraw4.c:5804: Test failed: Failed to set display mode, hr 0x80004001. This failure is taken care of by the other SetDisplayMode() patch. All the other failures are unrelated to SetDisplayMode(). -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 17, 2014

Re: ddraw/tests: Skip some tests when switching the display mode is not supported.

by Francois Gouget

On Mon, 17 Feb 2014, Henri Verbeet wrote: > On 17 February 2014 17:45, Francois Gouget <fgouget(a)codeweavers.com> wrote: > > This can happen on Windows 8 when the 'Microsoft Basic Display Adapter' driver does not recognize the graphics card, for instance QEmu's 'vga' graphics card. > > As mentioned earlier on IRC, I think that setup is broken for the > purpose of running the tests. Yes, I will tweak the configuration of these two VMs. But I think the patch still makes sense. The API behaves in a sane and rational way: some functionality is not supported so it returns E_NOTIMPL. That's something our tests should be able to handle. -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 17, 2014

Re: [PATCH 2/7] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 3)

by Ken Thomases

On Feb 14, 2014, at 11:53 AM, Henri Verbeet wrote: > On 14 February 2014 00:31, Ken Thomases <ken(a)codeweavers.com> wrote: >> + /* If no opengl32 function has been called, GetPixelFormat() doesn't reflect a >> + prior SetPixelFormat(). So, call wglCreateContext() even though it will fail. */ >> + hglrc = wglCreateContext(hdc); >> + ok(hglrc == NULL, "wglCreateContext succeeded when no pixel format has been set\n"); >> + if (hglrc) wglDeleteContext(hglrc); > I decided to look into this a bit, but could only reproduce it on the > testbot. It seems just loading opengl32 is enough to make > GetPixelFormat() work. (Also see > https://newtestbot.winehq.org/JobDetails.pl?Key=4908.) It seems that dynamically linked libraries are not initialized until called, while dynamically loaded libraries are initialized immediately. Or something like that. If I take your patch and remove the LoadLibraryA()/FreeLibrary() calls but add opengl32 to the IMPORTS, then it fails on a real Windows 7 machine. Patch and executable are available from <https://newtestbot.winehq.org/JobDetails.pl?Key=4980> although, at this writing, the test itself hadn't completed on the testbot. I guess dynamic loading is good enough for me. I'll rework the patches and resubmit. -Ken

Feb. 17, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Christopher Thielen

I should clarify as per Stefan Dösinger's comments that I have only been using the gog.com version (both under Wine and in my testing so far under Windows XP) so the nGlide wrapper code paths should be the same. The original, non-gog.com version is more or less garbage due to some CD-ROM driver DRM-trickery. Erich Hoover suggested to look at WINEDEBUG=+cursor,+icon,+resource and see if the game is merely using 'traditional' cursors. I do know this game was in development for quite a while and originally started out as a Glide game, so it makes some sense that the DirectX ShowCursor stuff might not be used at all. I tried TRACE'ing d3d8_device,d3d9_device,and dinput but found no calls related to cursors. The WINEDEBUG=+cursor,+icon,+resource trace does appear to be onto something though. I attached the log to the bug but here are some snippets: trace:icon:ICO_LoadIcon 0x360000 0x360086 trace:cursor:CreateIconFromResourceEx 0x37dc22 (1128 bytes), ver 00030000, 32x32 icon trace:cursor:ungrab_clipping_window no longer clipping trace:icon:DrawIconEx (hdc=0x2002d,pos=23.4,hicon=0x10044,extend=32.32,istep=0,br=(nil),flags=0x0000000b) trace:resource:LdrFindResource_U module 0x7e920000 type #0018 name #0002 lang 0000 level 3 trace:resource:find_entry_by_id root 0x7e93f3b4 dir 0x7e93f3b4 id 0018 not found trace:cursor:LoadCursorW (nil), #7f00 trace:resource:LoadImageW ((nil),#7f00,2,0,0,0x00008040) trace:cursor:CURSORICON_Load (nil), #7f00, 0x0, depth 32, fCursor 1, flags 0x8040 In particular, when the user presses 'Q', it should toggle the cursor icon. Here is the log grepped for "cursor:LoadIconW": trace:cursor:LoadIconW (nil), #7f05 trace:cursor:LoadIconW (nil), #7f05 trace:cursor:LoadIconW 0x7edb0000, L"" trace:cursor:LoadIconW (nil), L"" trace:cursor:LoadIconW (nil), #7f05 trace:cursor:LoadIconW 0x7edf0000, #0001 trace:cursor:LoadIconW 0x7edb0000, #0001 trace:cursor:LoadIconW (nil), #7f05 trace:cursor:LoadIconW (nil), #7f00 trace:cursor:LoadIconW (nil), #7f00 Am I wrong in reading this as the game toggling between two cursors? Is there a way to dump the ICO resource from LoadIconW to the file system to debug which icons it is trying and/or failing to load? Thanks again to everybody for all your help so far, Christopher Thielen On 02/16/2014 11:55 AM, Stefan Dösinger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2014-02-16 20:39, schrieb Christopher Thielen: >> fixme:d3d:wined3d_debug_location Unrecognized location flag(s) >> 0xfffffc00. > These lines are harmless. That's pretty much code doing something like > this > > TRACE("Removing flags %s.\n", > wined3d_debug_location(~WINED3D_LOCATION_SYSMEM); > > which ends up passing a value like 0xfffffffe to wined3d_debug_location. > > wined3d_debug_location then does something like > > if (flags & (SYSMEM | BUFFER | ALL | DEFINED | FLAGS)) > FIXME("Unrecognized location flag(s) %#x.\n", flags); > > What is missing here is a logical and that filters out unknown flags in > places where a bitwise not is used, or maybe just the removal of the > unknown flags fixme in wined3d_debug_location. > >> Unfortunately, there is no reference to "ddraw7_GetCaps" or >> "GetCaps" anywhere in the 975 MB log. That confirms it isn't using >> overlays, right? > Pretty much, yeah. > >> fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 > That's WINED3DUSAGE_TEXTURE and needs to be added to the debug function. > >> This gog.com version uses nGlide to wrap the Glide API to DirectX >> calls - DX9 I believe, based on the requirements of nGlide >> (http://www.zeus-software.com/downloads/nglide) Not sure if this >> information helps. > This means the GOG version is using an entirely different codepath > than what you're trying to run. It is quite possible that the codepath > you're running is broken in some way. I recommend to test if the > game's ddraw codepath is working properly on Windows before you bang > your head against it. It can save you a lot of time :-) . > > If it turns out that the ddraw codepath is working just fine on > Windows 7 there's certainly value in fixing it. If it is not, but it > is working on e.g. Windows XP, it might still be worth a look. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJTARfAAAoJEN0/YqbEcdMwSC0P/1iZxKSLjIqEXeDmPsy7ARU9 > vWm0Uqo0SYdCAEemGA2vD53IuojRUyMZ9E0ikfCZ7qlVK7uaFs54TtiY15C+p6ic > gZhNezdyt/6idLootvCsJ9ZDoSaFdIDvoWga7JThwlZnfGVVZIGj6WeJeTV+rXon > QHkQO/jghlHpgZIT6mdicvsltaWujg+Idwfuz1Z8i8+fKEhy7Uvp+QKCqsF8JdNf > AuDceOPwF8aaH0YWVieyQfTiqzv4RHTnF5i+LGWPx61SRuRXi2YT+2hHlTbspua2 > 6/FfQ+c2P6eoI39UiRysWL8+zB+T0o5V0JOF2PD5EJGqc+vP4066XkxZlA7Kdl6W > h8RCzDbU+gxeq49cXHTG6AbvLUdkbDowo/dwW6x4wOmnlzZBW5CNxF0NbQ0Jf4sW > mQLynduNdejnqgwZSFb5m8AoTqCZ+XbLkGq5uPAcAz6TIlsrKW7oQ41rTkeLxpU/ > Z5nlLDmC5MIP8t8he2KuLu8eVrLhSsxYFEyeevhHY/SvNkmi1LxkXJMQHt8gDpdi > 3ZW+LuW5nsOJ/9T7vH27ENorqRNtpFWnpdwPMyBgQJbPlNCYVp5ZTKE8WHpk+fk4 > T+LzzbOlli8svOLHll4rmDhD89qYiQQUWNv7V7XjTHrgrxpZFY5aLXrprEGTc6Kc > PCO4omr8MIkjrtJAHfKX > =evKW > -----END PGP SIGNATURE----- >

Feb. 17, 2014