February 2014 - Wine-Devel - list.winehq.org

Re: ddraw/tests: Skip some tests when switching the display mode is not supported.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4973 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:842: Test failed: Failed to create d3d device (0x887602ea) ddraw2.c:3295: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw2.c:3308: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw2.c:3324: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw2.c:3343: Test failed: Display mode restored after ddraw1-ddraw2 SetCooperativeLevel() call sequence === w8 (32 bit ddraw7) === ddraw7.c:3254: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3267: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3283: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3302: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. === w8 (32 bit ddraw4) === ddraw4.c:3531: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw4.c:3544: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw4.c:3560: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw4.c:3579: Test failed: Display mode restored after ddraw1-ddraw4 SetCooperativeLevel() call sequence ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5804: Test failed: Failed to set display mode, hr 0x80004001.

Feb. 17, 2014

Re: ddraw/tests: Better clean up when skipping the primary palette tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4972 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:3231: Test failed: SetDisplayMode failed, hr 0x80004001. === w8 (32 bit ddraw4) === ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001.

Feb. 17, 2014

Re: ddraw/tests: Skip some tests when switching the display mode is not supported.

by Henri Verbeet

On 17 February 2014 17:45, Francois Gouget <fgouget(a)codeweavers.com> wrote: > This can happen on Windows 8 when the 'Microsoft Basic Display Adapter' driver does not recognize the graphics card, for instance QEmu's 'vga' graphics card. As mentioned earlier on IRC, I think that setup is broken for the purpose of running the tests.

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Martin Storsjö

On Mon, 17 Feb 2014, Stefan Dösinger wrote: > Am 2014-02-17 13:29, schrieb Martin Storsjö: >> Yes, but isn't the wined3d code supposed to be able to run on top >> of plain windows as well, not only on top of wine? > Yes, but Windows behaves the same way. We should have tests for that > somewhere in kernel32/tests, and all our code (tests and otherwise) > assumes that HeapFree(, , NULL) is a no-op. Ok then, that makes me more comfortable with doing it like that. I've resent the set with the remaining patch taking all the comments into consideration now. // Martin

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-17 13:29, schrieb Martin Storsjö: > Yes, but isn't the wined3d code supposed to be able to run on top > of plain windows as well, not only on top of wine? Yes, but Windows behaves the same way. We should have tests for that somewhere in kernel32/tests, and all our code (tests and otherwise) assumes that HeapFree(, , NULL) is a no-op. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAgIhAAoJEN0/YqbEcdMwTHkQAIBEGqDkFrkDxBKAFGHd5ZIV vQ4BBv8FzCUDc3Jv7VkqIqgboVfcIcxTR/WXqJ9aAyoUOVAot3fgmGW2aCNINFL/ JHaNqOIaAJdBgvNc8VSa2Pj2L+82Co8RpbBMFQBY1vCBVjfH6MPvxwN5yXv9D9UM kLGuVZwOG2y8HAM1DikISjGqG0CLTrbRsc1DC4OV+EvrKBCHHRPGWZu67+idkNTq nyBhzkkEL3ijKn04tvvnuNEnfofAO7/REXgCiNj2mjkaNDmARUwnjVRnD9NUV5Q/ HrTaLIAM854HS3zCScrINuiG4NTdXT/ag4JCzxQmKEttwiK9Fly43k2J6+H31vKb NWREMmvKBrVFeQE2rGKuzJ2yQtUWWwUGqLxtIyIK9w5hF0TMJY8dtyzfadq6SKZY Tm5Ezd1hGFL1O+X61k0vqEZpX9EGdkLZetuoAkEI32HfNW5aCcbmPV7I7LFBJi8S ZY1JizytJPJt6PZKGmKSHM3e4hnpfNKTb81Xd4mP/pCTWE2pUwiPyuA0i2jMuTMp yzZLSnnLEd2ezjwh6fSFzuQlHnirUEnjhNo2UqZbcmZ+83Aug/vuv6cCkM5pT7J0 b+yiRRo3SxYFVs7ia7Cvem0OqbB3PRae3ZNIsk0w/BKJdkDhu6C8LPg/0vU0G4lL HJtZE9e0VRVKaS5y/E7p =QBS+ -----END PGP SIGNATURE-----

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Martin Storsjö

On Mon, 17 Feb 2014, Bruno Jesus wrote: > On Mon, Feb 17, 2014 at 9:21 AM, Martin Storsjö <martin(a)martin.st> wrote: >>>> + if (desc) >>>> + HeapFree(GetProcessHeap(), 0, desc); >>> >>> There's no point in checking for NULL before HeapFree(). >> >> >> MSDN says "If this pointer is NULL, the behavior is undefined" about the >> lpMem parameter to HeapFree. > > Actually it does not matter what MSDN says in this case, the wine > source code is very clear: > http://source.winehq.org/source/dlls/ntdll/heap.c#L1740 Yes, but isn't the wined3d code supposed to be able to run on top of plain windows as well, not only on top of wine? // Martin

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Bruno Jesus

On Mon, Feb 17, 2014 at 9:21 AM, Martin Storsjö <martin(a)martin.st> wrote: >>> + if (desc) >>> + HeapFree(GetProcessHeap(), 0, desc); >> >> There's no point in checking for NULL before HeapFree(). > > > MSDN says "If this pointer is NULL, the behavior is undefined" about the > lpMem parameter to HeapFree. Actually it does not matter what MSDN says in this case, the wine source code is very clear: http://source.winehq.org/source/dlls/ntdll/heap.c#L1740 > // Martin Bruno

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Martin Storsjö

On Fri, 14 Feb 2014, Henri Verbeet wrote: > On 13 February 2014 13:05, Martin Storsjo <martin(a)martin.st> wrote: >> static HRESULT arbfp_blit_alloc(struct wined3d_device *device) >> { >> + struct arbfp_blit_priv *priv; >> device->blit_priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct arbfp_blit_priv)); >> if(!device->blit_priv) { >> ERR("Out of memory\n"); >> return E_OUTOFMEMORY; >> } >> + priv = device->blit_priv; >> + >> + if (wine_rb_init(&priv->shaders, &wined3d_arbfp_blit_rb_functions) == -1) >> + { >> + ERR("Failed to initialize rbtree.\n"); >> + HeapFree(GetProcessHeap(), 0, device->blit_priv); >> + device->blit_priv = NULL; >> + return E_OUTOFMEMORY; >> + } >> + >> return WINED3D_OK; >> } >> > The following is probably slightly nicer: > > static HRESULT arbfp_blit_alloc(struct wined3d_device *device) > { > - device->blit_priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(struct arbfp_blit_priv)); > - if(!device->blit_priv) { > - ERR("Out of memory\n"); > + struct arbfp_blit_priv *priv; > + > + if (!(priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)))) > return E_OUTOFMEMORY; > + > + if (wine_rb_init(&priv->shaders, &wined3d_arbfp_blit_rb_functions) == -1) > + { > + ERR("Failed to initialize rbtree.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > } > + > + device->blit_priv = priv; > + > return WINED3D_OK; > } That's nicer indeed, updated the patch accordingly locally. >> + if (desc) >> + HeapFree(GetProcessHeap(), 0, desc); > There's no point in checking for NULL before HeapFree(). MSDN says "If this pointer is NULL, the behavior is undefined" about the lpMem parameter to HeapFree. > Perhaps more importantly, I think it makes more sense to insert the > rbtree entries in arbfp_blit_set(), instead of duplicating the code > between gen_p8_shader() and gen_yuv_shader(). Good point, I've updated my patch accordingly. I'll resend all three patches in a little while unless you or Stefan have got more comments at the moment. // Martin

Feb. 17, 2014

Re: [PATCHv5 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-17 12:53, schrieb Martin Storsjö: > On Fri, 14 Feb 2014, Henri Verbeet wrote: >> That's not technically true, no filtering would be D3DTEXF_NONE. >> I don't know if that's going to make a difference in practice >> though. > > I tested that now as well, and there's no difference, the sharp > edges in the YUV texture are blurred when scaled up. > > I applied the other changes you suggested, those changes will be > part of the next resend of the patchset. D3DTEXF_NONE behaves like D3DTEXF_POINT if used for minification or magnification. It only has a different behavior when assigned to D3DSAMP_MIPFILTER. There is no way to do no min/mag filtering when the source surface / texture size doesn't exactly match the destination rectangle size. In my yuv_color_test cleanup patch I have reworded the comment to correctly say "point filtering" instead of "no filtering". -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAf3GAAoJEN0/YqbEcdMwCXsQAJVp53HiaKCXBce/OtaodwlL axO2Pe8draccKUNupHDhTHtuXLcJV7uc3RV80VxN47h3sDchOFYz0j/H3hQZwuUo 0DrUWFCaLzGB3twpmyZq/zLgERizx6G5NVSMQJTIvAMmOzibJqHxgl+AHBWfmVGG hdldw5fLSbQCpacpbrWpNZOiap0Bs24XTw7si4S8q25PrM89lm8XJKJROnFatloF vvvtw2jbaWtzxQHoIt0y9SnZhDvpftJwDfPhN2jVDJnusuYAwZWTMtrQzHj/jUtI KuK8mxWJUhjocmgv23Qh43S92zOBxRqkz76V0xrPLjIcCMyBoCCojBkahQa0gSbG 1i25pApi59KrnRJ/zUNAOtIDea81Iq71YOVwnC2E/EqpG+vbqYl8mBeKxybrZ8jU S9JA+xsJL+ZFJ1NlTyU/KV4fweHgmerIaj12+XF3TeTR04L268EqDD2jIb14FTfy msaeAyckR2emN5midcFCjUUIEG+t1CsWInfdI8Z1X2sQugBHZvxUEOWovXoTarHi ji0cBNOEfEINtoNj7GIa7OdZsOkVncpUcI2ySTA9Ykb7cO25dYYk4hSmobE/Pvun KaeSsVvXALLfRraXg7cQnTg8Befx+gIZuvyYSK7MENe1S2F8fR257X5lrNXS3djE MEdB/nivZnLkSq4dk39D =gluy -----END PGP SIGNATURE-----

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Michael Stefaniuc

On 02/17/2014 12:20 PM, Alistair Leslie-Hughes wrote: > On 17/02/2014 10:07 PM, Michael Stefaniuc wrote: >> On 02/17/2014 11:27 AM, Alistair Leslie-Hughes wrote: >>> On 17/02/2014 8:04 PM, Marvin wrote: >>>> Hi, >>>> === w8 (32 bit client) === >>>> Timeout >>> Anybody know if DirectPlay is supported on Windows 8? >> I doubt it is installed by default as it is deprecated but you should be >> able to get it for 32bit Windows. It was never supported on 64bit and it >> misses on all 64bit Windows versions. > The testbot is 32bit, so maybe something else is going wrong. Can > someone check if the dpnet.dll is installed by default? I currently > don't have a access to a windows 8 machine. You can check yourself by searching the test results page for that machine. E.g.: http://test.winehq.org/data/aa22a3c4b2e772636163ea50e7245dba01fe7b34/win8_n… dpnet 6.2.9200.16384 >>> It tests are timeout doing >>> hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, >>> CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); >> Are you doing the interactive tests? Those do time out on Windows for >> whatever reason. >> > No, the tests aren't interactive, so this shouldn't be the issue. All > other windows version pass, so this windows 8 issue is confusing. You'll have to figure it out then. But the CoCreateInstance call should not timeout. Especially if CLSID_DirectPlay8Client is unsupported; you would get an error back and that would fast. bye michael

Feb. 17, 2014

d3d bisecting help needed

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, If anyone wants to help me out with a d3d performance issue here's your chance: My regression tests picked up a performance drop on r300g a few weeks ago: http://openbenchmarking.org/result/1402162-STEF-WINE17135&track_view=60 . Read graphs right to left. The regression can be seen in the following tests: drawprim_d3d (a simple draw overhead tester), Half Life 2 and Trackmania Nations. According to the test data, the regression happened between wine-1.7.10-73-g460991a and wine-1.7.10-112-g81c42ce. I do not know if the regression is in Wine or Mesa. Unfortunately my test setup does not track which Mesa revision was used for each test, but usually the date of the used mesa commit matches the date of the Wine commit. What you'll need is a GPU supported by the Mesa r300g driver, a setup where you can use Mesa from git and of course a working Wine build setup. You'll also need one of the games in question. The drawprim_d3d microbenchmark can be found at https://84.112.174.163/~stefan/pts/drawprim_d3d.exe , but the server may be down over the next few days. If the download does not work just mail me and I'll send you the .exe. Thanks, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAfoRAAoJEN0/YqbEcdMwhZsP/0iLEUg0B/KJ2bJdwtFX/DBg IamXt8oACRNpyMqVnEjmynxKOflomeo8rqELK46j0NhCeGzTNJaPzRgLrQ4L3w/0 5atPd/OnWIBRhoD06vXp1vCn5/EgqDqmU+U84bmbJev9lkhd1rLWqt3uHl8tWjxL VPphPbcriUCXhYjmaXdSD12oKJXYaLclYEXXTOjktFvSck18dfiohvypCHPDBlxp oGhFV/B4NtqHXy62O+vztIA+wisDbBtGUfni4WIdCX82H1kE9rEcpj6zhS638IHp xbiWtVsBYzYHqw6VVGUql2JipkYXTnrKBju7BQetd93KSJHFWnn4TdeOI3ggsAnU oQNR5lKmkG/PWVsMi23lVsZVrCmIau8BgSQQLWZgRUdJEHhj1+6hehabUNJVc49q TFhsSDxcNhbv3bLYrmJFhfQWQTFis/iGYcIRWqX+590ycaUEJmEmi5JsdcVdsxRv IlAhPXbAo1rZv/815ZBX4l8QdJecHiHyewhN74O6wG7EzGZaChLhP0dIuHRc6q9g EuICi7CYDrzv047vXELwePqxAkgQva6/JWd8GvzvVbh971qvWKMlB90p3HEHf42L WzB+bpXd1qsxfeXcbC2Cw2iTJWyjUoY1Zs1wbNEUgFXeIyjDYIkCXD1ADLOQqbJB mtimRynrUbtS9TJWwM4W =Z4Pf -----END PGP SIGNATURE-----

Feb. 17, 2014

Re: [PATCHv5 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Martin Storsjö

On Fri, 14 Feb 2014, Henri Verbeet wrote: > On 13 February 2014 14:52, Martin Storsjo <martin(a)martin.st> wrote: > >> + BYTE Y = (color >> 16) & 0xff; >> + BYTE U = (color >> 8) & 0xff; >> + BYTE V = (color >> 0) & 0xff; > It's probably just as easy to just store the separate components to begin with. Actually, since color can either be test_data[i].color1 or test_data[i].color2, splitting it per component would blow it up into Y1/Y2, U1/U2, V1/V2, and duplicating the condition for selecting color based on coordinate for all three components, so I think this format is simpler in the end. >> + hr = IDirect3DDevice9_StretchRect(device, surface, NULL, target, NULL, D3DTEXF_POINT); >> + ok(hr == D3D_OK, "IDirect3DDevice9_StretchRect failed with %#x.\n", hr); >> + >> + /* Native D3D can't resist filtering the YUY surface, even though we asked it not to >> + * do so above. To prevent running into precision problems, read at points with some >> + * margin within the rect. */ > That's not technically true, no filtering would be D3DTEXF_NONE. I > don't know if that's going to make a difference in practice though. I tested that now as well, and there's no difference, the sharp edges in the YUV texture are blurred when scaled up. I applied the other changes you suggested, those changes will be part of the next resend of the patchset. // Martin

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Alistair Leslie-Hughes

On 17/02/2014 10:07 PM, Michael Stefaniuc wrote: > On 02/17/2014 11:27 AM, Alistair Leslie-Hughes wrote: >> On 17/02/2014 8:04 PM, Marvin wrote: >>> Hi, >>> === w8 (32 bit client) === >>> Timeout >> Anybody know if DirectPlay is supported on Windows 8? > I doubt it is installed by default as it is deprecated but you should be > able to get it for 32bit Windows. It was never supported on 64bit and it > misses on all 64bit Windows versions. The testbot is 32bit, so maybe something else is going wrong. Can someone check if the dpnet.dll is installed by default? I currently don't have a access to a windows 8 machine. > >> It tests are timeout doing >> hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, >> CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); > Are you doing the interactive tests? Those do time out on Windows for > whatever reason. > No, the tests aren't interactive, so this shouldn't be the issue. All other windows version pass, so this windows 8 issue is confusing. Alistair

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Michael Stefaniuc

On 02/17/2014 11:27 AM, Alistair Leslie-Hughes wrote: > On 17/02/2014 8:04 PM, Marvin wrote: >> Hi, >> === w8 (32 bit client) === >> Timeout > Anybody know if DirectPlay is supported on Windows 8? I doubt it is installed by default as it is deprecated but you should be able to get it for 32bit Windows. It was never supported on 64bit and it misses on all 64bit Windows versions. > It tests are timeout doing > hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, > CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); Are you doing the interactive tests? Those do time out on Windows for whatever reason. > > For more details > https://newtestbot.winehq.org/JobDetails.pl?Key=4949&log_201=1#k201 bye michael

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Alistair Leslie-Hughes

On 17/02/2014 8:04 PM, Marvin wrote: > Hi, > === w8 (32 bit client) === > Timeout Anybody know if DirectPlay is supported on Windows 8? It tests are timeout doing hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); For more details https://newtestbot.winehq.org/JobDetails.pl?Key=4949&log_201=1#k201 Best Regards Alistair Leslie-Hughes

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4945 Your paranoid android. === w8 (32 bit client) === Timeout

Feb. 17, 2014

Re: [PATCH] comctl32/tests: Some tests for Button control

by Nikolay Sivov

On 2/17/2014 12:37, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> --- /dev/null >> +++ b/dlls/comctl32/tests/button.c >> @@ -0,0 +1,811 @@ >> +/* Unit test suite for Button control. >> + * >> + * Copyright 2014 Nikolay Sivov for CodeWeavers >> + * > If I read this patch correctly this is just a copy of button tests from > user32, and in that case please add all copyright notices from that file, > or just the authors of the copied code. > Done, easy way.

Feb. 17, 2014

Re: [PATCH] comctl32/tests: Some tests for Button control

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > --- /dev/null > +++ b/dlls/comctl32/tests/button.c > @@ -0,0 +1,811 @@ > +/* Unit test suite for Button control. > + * > + * Copyright 2014 Nikolay Sivov for CodeWeavers > + * If I read this patch correctly this is just a copy of button tests from user32, and in that case please add all copyright notices from that file, or just the authors of the copied code. -- Dmitry.

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4942 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4941 Your paranoid android. === build (build) === Patch failed to apply

Feb. 17, 2014

Re: Fixing up the code style

by Frédéric Delanoy

On Sat, Feb 15, 2014 at 7:32 AM, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > ... > I agree, Sebastian and I have been debating what to do with this > function (and RtlAcquireResourceShared) for some time and style is the > only thing keeping us from submitting the one-line fix for these. > Honestly, it would be really great if we could run something like > astyle on the whole codebase so that we were always working off of a > "known good" style. Well, someone's "good style" is someone else's "bad style". For instance, I find "if(...)" constructs ugly, but some devs like it apparently, so if that's what's being used in the "surrounding code", it should be kept that way, for consistency. What could/should be fixed, IMO, is code which is obviously broken/unclear, but limited to the enclosing block, but that should happen quite often. Frédéric

Feb. 17, 2014

Re: Assorted spelling fixes

by Frédéric Delanoy

On Sun, Feb 16, 2014 at 10:14 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 16 February 2014 09:57, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: >> In my years of University the students were told to remember that >> 1Kb == 1024 bytes, 1Mb == 1024Kb and size prefixes should be written >> as a capital letter to emphasize its meaning. I'm very reluctant to >> change this practice to something else regardless of explanations and >> intents. I understand that for not technical people 1K == 1000, but >> I'd assume programmers are not of that kind. >> > Strictly speaking the SI units are kB, etc. for 1000 bytes, and IEC > KiB, etc. for 1024 bytes. For memory sizes, it's usually obvious > enough from context which one is meant, so there's not much of a point > to change it. It's more ambiguous for e.g. file or disk sizes where > drive vendors often use 1000 based units, and transfer speeds where > "b" usually means bits. > > But as I said, in most cases it's obvious enough from context, and > "KB" instead of "Kb" isn't really much clearer. Well, as François pointed out, b stands for bit, and not bytes. Basically the rationale for this patch was to fix spacing (space between number and unit name), and standardize the units abbreviations while doing that. k is SI, and is 1000, while K is 1024, unambiguously. KiB and MiB could have been used instead of KB/MB, but those aren't broadly used, albeit standardized now, while KB is much more used than kB (which isn't correct IMO; see above). Frédéric

Feb. 17, 2014

Re: Gifting steam/gog games to Wine developers

by Jerome Leclanche

On Sun, Feb 16, 2014 at 10:00 PM, Vincent Pelletier <plr.vincent(a)gmail.com> wrote: > On Sun, 16 Feb 2014 16:59:18 +0000, Jerome Leclanche > <adys.wh(a)gmail.com> wrote: >> I have a lot of unused Steam gift links from duplicates in my Humble >> Bundle purchases. I'd like to share those > > While I do like the idea, it may be prohibited by HIB use terms (is > that even what it's called ?). Better check this first. I recall > reading something along the lines that a bundle can not be resold/gifted > in whole nor in chunks. > > Of course, this has nothing to do with other gift origins. That used to be the case. They changed their policy and do offer gift links for all single games. What is not allowed is the resale of games, afaik. J. Leclanche > -- > Vincent Pelletier > >

Feb. 16, 2014

Re: [PATCH 5/5] ddraw/tests: Port test_private_data to ddraw4.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4935 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:3185: Test failed: SetDisplayMode failed, hr 0x80004001. === w8 (32 bit ddraw4) === ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001.

Feb. 16, 2014

Re: configure: Add import library for xmllite.

by Henri Verbeet

On 16 February 2014 15:17, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Henri Verbeet <hverbeet(a)gmail.com> wrote: > >> On 14 February 2014 08:23, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: >> > -WINE_CONFIG_DLL(xmllite) >> > +WINE_CONFIG_DLL(xmllite,,[implib]) >> That's auto-generated by make_makefiles from Makefile.in. > > Just a bit of clarification: does that mean that an import library > gets added once a Wine component (dll or an application) start to > require it and somebody adds a dependency to Makefile.in? Just that you should add a line "IMPORTLIB = xmllite" to dlls/xmllite/Makefile.in, then run tools/make_makefiles, and it will take care of updating configure.ac.

Feb. 16, 2014

Re: [PATCH 4/5] d3d8/tests: Add a test for sub resource private data.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4934 Your paranoid android. === w8 (32 bit device) === device.c:2572: Test failed: Expected foreground window 00030196, got 0002004E. device.c:3268: Test failed: Expected wndproc 0x410530, got 0x410530.

Feb. 16, 2014

Re: [PATCH 1/5] d3d9/tests: Clean up yuv_color_test (try 2).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4931 Your paranoid android. === w8 (32 bit visual) === visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff00ff00: Got color 0x00000000 for pixel 1/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff00ff00: Got color 0x00000000 for pixel 2/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff0000ff: Got color 0x00000000 for pixel 1/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff0000ff: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00ffff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00ffff00: Got color 0x00000000 for pixel 2/1, expected 0x004bffff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00ff00ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00ff00ff: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x0000ffff: Got color 0x00000000 for pixel 1/1, expected 0x004bffff, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x0000ffff: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffffff00: Got color 0x00000000 for pixel 1/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffffff00: Got color 0x00000000 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffff00ff: Got color 0x00000000 for pixel 1/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffff00ff: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffffffff: Got color 0x00000000 for pixel 1/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffffffff: Got color 0x00000000 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x4cff4c54: Got color 0x00000000 for pixel 1/1, expected 0x000b8b00, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x4cff4c54: Got color 0x00000000 for pixel 2/1, expected 0x00b6ffa3, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00800080: Got color 0x00000000 for pixel 1/1, expected 0x0000ff00, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00800080: Got color 0x00000000 for pixel 2/1, expected 0x0000ff00, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff80ff80: Got color 0x00000000 for pixel 1/1, expected 0x00ff00ff, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff80ff80: Got color 0x00000000 for pixel 2/1, expected 0x00ff00ff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x1c6b1cff: Got color 0x00000000 for pixel 1/1, expected 0x006dff45, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x1c6b1cff: Got color 0x00000000 for pixel 2/1, expected 0x0000d500, format D3DFMT_YUY2.

Feb. 16, 2014

Re: Gifting steam/gog games to Wine developers

by Vincent Pelletier

On Sun, 16 Feb 2014 16:59:18 +0000, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > I have a lot of unused Steam gift links from duplicates in my Humble > Bundle purchases. I'd like to share those While I do like the idea, it may be prohibited by HIB use terms (is that even what it's called ?). Better check this first. I recall reading something along the lines that a bundle can not be resold/gifted in whole nor in chunks. Of course, this has nothing to do with other gift origins. -- Vincent Pelletier

Feb. 16, 2014

FOSDEM - Videos now watchable

by Marcus Meissner

Hi, The FOSDEM Videos have been uploaded with correct sound again. http://wiki.winehq.org/FOSDEM2014 has our index. Or more direct links: http://video.fosdem.org/2014/AW1120/Sunday/ If you have not uploaded your slides, please do :) Ciao, Marcus

Feb. 16, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-16 20:39, schrieb Christopher Thielen: > fixme:d3d:wined3d_debug_location Unrecognized location flag(s) > 0xfffffc00. These lines are harmless. That's pretty much code doing something like this TRACE("Removing flags %s.\n", wined3d_debug_location(~WINED3D_LOCATION_SYSMEM); which ends up passing a value like 0xfffffffe to wined3d_debug_location. wined3d_debug_location then does something like if (flags & (SYSMEM | BUFFER | ALL | DEFINED | FLAGS)) FIXME("Unrecognized location flag(s) %#x.\n", flags); What is missing here is a logical and that filters out unknown flags in places where a bitwise not is used, or maybe just the removal of the unknown flags fixme in wined3d_debug_location. > Unfortunately, there is no reference to "ddraw7_GetCaps" or > "GetCaps" anywhere in the 975 MB log. That confirms it isn't using > overlays, right? Pretty much, yeah. > fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 That's WINED3DUSAGE_TEXTURE and needs to be added to the debug function. > This gog.com version uses nGlide to wrap the Glide API to DirectX > calls - DX9 I believe, based on the requirements of nGlide > (http://www.zeus-software.com/downloads/nglide) Not sure if this > information helps. This means the GOG version is using an entirely different codepath than what you're trying to run. It is quite possible that the codepath you're running is broken in some way. I recommend to test if the game's ddraw codepath is working properly on Windows before you bang your head against it. It can save you a lot of time :-) . If it turns out that the ddraw codepath is working just fine on Windows 7 there's certainly value in fixing it. If it is not, but it is working on e.g. Windows XP, it might still be worth a look. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTARfAAAoJEN0/YqbEcdMwSC0P/1iZxKSLjIqEXeDmPsy7ARU9 vWm0Uqo0SYdCAEemGA2vD53IuojRUyMZ9E0ikfCZ7qlVK7uaFs54TtiY15C+p6ic gZhNezdyt/6idLootvCsJ9ZDoSaFdIDvoWga7JThwlZnfGVVZIGj6WeJeTV+rXon QHkQO/jghlHpgZIT6mdicvsltaWujg+Idwfuz1Z8i8+fKEhy7Uvp+QKCqsF8JdNf AuDceOPwF8aaH0YWVieyQfTiqzv4RHTnF5i+LGWPx61SRuRXi2YT+2hHlTbspua2 6/FfQ+c2P6eoI39UiRysWL8+zB+T0o5V0JOF2PD5EJGqc+vP4066XkxZlA7Kdl6W h8RCzDbU+gxeq49cXHTG6AbvLUdkbDowo/dwW6x4wOmnlzZBW5CNxF0NbQ0Jf4sW mQLynduNdejnqgwZSFb5m8AoTqCZ+XbLkGq5uPAcAz6TIlsrKW7oQ41rTkeLxpU/ Z5nlLDmC5MIP8t8he2KuLu8eVrLhSsxYFEyeevhHY/SvNkmi1LxkXJMQHt8gDpdi 3ZW+LuW5nsOJ/9T7vH27ENorqRNtpFWnpdwPMyBgQJbPlNCYVp5ZTKE8WHpk+fk4 T+LzzbOlli8svOLHll4rmDhD89qYiQQUWNv7V7XjTHrgrxpZFY5aLXrprEGTc6Kc PCO4omr8MIkjrtJAHfKX =evKW -----END PGP SIGNATURE-----

Feb. 16, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Christopher Thielen

Unfortunately, there is no reference to "ddraw7_GetCaps" or "GetCaps" anywhere in the 975 MB log. That confirms it isn't using overlays, right? This gog.com version uses nGlide to wrap the Glide API to DirectX calls - DX9 I believe, based on the requirements of nGlide (http://www.zeus-software.com/downloads/nglide) Not sure if this information helps. I re-ran the test case using Ken's suggestion of adding the 'warn' lines and the log went down to 35 MB. I uploaded a gzipped version to the bug report. The two lines I was wondering about still appear even with 'warn+ddraw,warn+d3d,warn+d3d_surface'. The surrounding log lines around the first of the two lines in question are simply repeats. A snippet of the logfile looks something like: fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. The second line I'm curious about is a little more interesting and seems to occur in groups like this: warn:d3d:wined3d_get_adapter_display_mode Overriding format WINED3DFMT_B8G8R8X8_UNORM with stored format WINED3DFMT_B8G8R8A8_UNORM. fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 (end of the Unrecognized usage flag(s) repeating - the line seems to appear 7 times each grouping) Given that these lines appear even with the 'warn' level increased, does anyone think they're significant? I could start reading some API docs and figure out what these unrecognized flags are if it sounds promising. - Christopher Thielen On 02/16/2014 01:48 AM, Ken Thomases wrote: > On Feb 16, 2014, at 3:06 AM, Christopher Thielen wrote: > >> No luck so far: I ran the application for about 30 seconds and generated a 975 MB log file but a case insensitive "overlay" appears not at all. > > To keep the log size down, you could try a warn+ddraw,warn+d3d,warn+d3d_surface log, instead. > > >> Since this missing secondary mouse cursor only appears during certain game states, one idea I had is to look at the 'fixme's in the log and see if any roughly correlate to when the cursor should be on-screen. This is assuming the log growth correlates to game-time, which it probably does with the exception of program start and stop. >> >> I don't know if that's the next best way to debug this but there are two fixme lines that come up a lot (hundreds and hundreds of times): >> >> fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. > > The wined3d_debug_location() function is used in other tracing lines. So, to figure out what is affected by it, you would want to read the next line or two from the log. > >> fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 > > Same here. > > These both may go away if you reduce the logging to just WARNs (and ERRs and FIXMEs which are enabled by default). It's possible they were only be generated by TRACEs. > > -Ken >

Feb. 16, 2014

(no subject)

by Jarkko Korpi

I had similar gifting idea before, we should use steam discount sales for gifting games for wine devs.

Feb. 16, 2014

Re: Gifting steam/gog games to Wine developers

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-16 17:59, schrieb Jerome Leclanche: > I was reading a bug which gave me an idea. I have a lot of unused > Steam gift links from duplicates in my Humble Bundle purchases. I'd > like to share those with whomever needs any of them to work on bugs > (or to Wine devs who want them, you guys more than deserve them). I like the idea. I won't make use of your offer personally though. Since I'm working for codeweavers and they're providing me with all the game licenses I need for my work on Wine I've never had any issues with getting access to games. Unfortunately there's also no shortage of bugs and work to be done :-\ . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTARJuAAoJEN0/YqbEcdMwmGgP+waL7zoMFqdRoguPmrimI1CI MCu0k/BlNx0ngyKcvCE8T5VQqWrf0ahWVMWkwVzvICTt+FDAzdGXhE6u9qUzB5mZ 5pFtwamPNAR6G9ajj7tv8UCd7vTSe9ARHKMGUDhsX/JWOllFci8bMdfFaordtuqy ZL4t0mA+AVZDwfodGnK/e9k0thSGUW14naTZpNTyOfO7ZnKGPLZw616kVa9pfj4r C9148Z8dYlqpVe775aDT7jIVlZWvx6YRKVYPtB+XwL/pH/K/dUIMjLQhMay9CoPS Km4SvKEHLPoSxGC6u2oLNl8lRuBmk25+kpCdyd856wgGTOCA5bKBgOLek2CAdC80 Q82WC5xRS+HtCgfBQQ90yyBEYKTKKkphGMT61B5dSv39CN1aBtUYPPLmmrywyRMi m3Cs7JjbbfAaICPUzaFWeFmgGu7vnAsTIIP6VJkPOA8PuFhxd9yqQqud9Vtow1pY 4qFOqN/xjvzVl+wbItIhVsl88gPpcyli/lNd4zePgOM1ZlUlIry8efj7TKZNPaXf zmx+nQBiKbEFvfT9mwQY66tz/taomaVEEh/bHgFOyWkexePlQDhe86zonARzfMa8 XNZq99/YU4H8lZOGOJIwthrMAMn8bLM0ryVwqu6JebQZLsM8fJB4p9cTiggVfDne 4NeLcvkbU+aThQlHwy/b =DdQR -----END PGP SIGNATURE-----

Feb. 16, 2014

Re: Gifting steam/gog games to Wine developers

by André Hentschel

Am 16.02.2014 17:59, schrieb Jerome Leclanche: > Hi list > > I was reading a bug which gave me an idea. > I have a lot of unused Steam gift links from duplicates in my Humble > Bundle purchases. I'd like to share those with whomever needs any of > them to work on bugs (or to Wine devs who want them, you guys more > than deserve them). > I'd like to set up a Wiki page containing a list of available games > and a point of contact to get it gifted, encouraging other Wine users > to do the same and have one more open method of contributing to the > project. > > Is this something that would interest anyone? Hi Jerome, I once was gifted an Humble Indi Bundle to work on a related Bug, and actually i just used it to fix the bug, not for playing :) So this kind of contribution really works. Thus i think your idea is really good. Sadly i have no time atm to work on such things i guess.

Feb. 16, 2014

Gifting steam/gog games to Wine developers

by Jerome Leclanche

Hi list I was reading a bug which gave me an idea. I have a lot of unused Steam gift links from duplicates in my Humble Bundle purchases. I'd like to share those with whomever needs any of them to work on bugs (or to Wine devs who want them, you guys more than deserve them). I'd like to set up a Wiki page containing a list of available games and a point of contact to get it gifted, encouraging other Wine users to do the same and have one more open method of contributing to the project. Is this something that would interest anyone? J. Leclanche

Feb. 16, 2014

Re: [PATCH 1/5] d3d9/tests: Clean up yuv_color_test.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-14 20:24, schrieb Henri Verbeet: > On 13 February 2014 23:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> + * Unfortunately different implementations(Windows-NV and Mac-AMD tested) interpret some colors vastly >> + * differently, so we need a max diff of 18. */ > And actually, is there any chance the "vastly differently" here is > because of using BT.601 vs. BT.709 coefficients, or not including the > headroom/footroom scaling + offsets? Maybe, but I can't look into either driver. If I remember correctly I got the reference values from the GeForce 7 driver on Windows and our shader results match it pretty well (plus / minus 2 or something). Geforce 8+ cards on Windows are off pretty far, and the GL_APPLE_ycbcr_422 support on OSX deviated even more. I think we're also doing some things wrong with the coefficients in our shader. I read about a common pitfall when handling 8 bit integer chroma that I thought we're falling into, but I don't remember the details. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAN07AAoJEN0/YqbEcdMw1XkQAJIVxUs2cbTwrS5mTQo+DVWA THeFaWm10TbHKNqEZQZMdTjD3BgKsZ5PYNCpGirMlOeLZqMc71Z6IQ6AZLWJcI/o iT8JIZ4KOi3e95ggyCkWkPCnkD2oSq+WorRakgIFoIjrd56KPvPB1vD8DHwz7DA0 ybE1CdHWVyEEDO2LRDnSVI9gqGsWGo+8y4T5hW929KyMOkm8GG//T0NMdoddaJol W1mp2n8Qh3Xb1VP9rMSBHmqPAPC3a/ma/21oflOR/ywDgcofsBGA97tHOYPhWERo mf2G5o1Isv+pgoFz5J8cvvnMaGn7uESWJXGpzTKkDV/zbzqdOVelCC3qHmhP4Pe1 4HVQ+NegBeVORljkTbebCnh5KyfJXBt+9yfiWKW62xjjK3So17eKIYCHLKZQ/uKg pdK1KMseYuXKWAyYJi/4W+UsIBbhgS2yZKSQeuNVMmnTa7hdBG5fPzmL8XGx1jbB 13CzOVSZ7hASA1tZIcnjErUrl6rFkfunf8W3NZS8ExoD5sZ6noTt2kej4kpDyvy/ xt5qzovuN/HNets7D+P4F83hwtK9LgRVSpoxBFm1kR6/GVNQTNaGlXsNxsdlDzHY DVyC1Zgj7fD5LyU4qJ+tlNmTQlUMLxGS6WqNjZzL7vW7bf3l2bWF/DjsatCkb2v3 T1dtcM4ttsR/iqIcfGOs =el3W -----END PGP SIGNATURE-----

Feb. 16, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 There is another easy way to test if the game is using an overlay on Windows: Take a screenshot with the print key. If the mouse pointer shows up, it is *not* an overlay. If it does not show up, it might be an overlay or a user32 mouse pointer. Am 2014-02-16 10:06, schrieb Christopher Thielen: > No luck so far: I ran the application for about 30 seconds and > generated a 975 MB log file but a case insensitive "overlay" > appears not at all. If the game looks for overlay flags it may not even call any overlay-related function if it doesn't find the flags present. And there's no way to find out at which flags it looks, short of disassembling the game code. What you can do is looking for IDirectDraw::GetCaps calls (grep the log for ddraw7_GetCaps). If it does not call that it doesn't look at overlay capabilities and my theory is moot. If it does, you can try to add overlay capabilities and see if it starts calling IDirectDrawSurface::UpdateOverlay (look for ddraw_surface7_UpdateOverlay) and friends. Unfortunately there's not a one-button switch to fake overlay capabilities. You may have to look at a DDCAPS structure returned from Windows and add / remove capabilities from Wine's until they look more alike. I know that I looked into Setter 3's overlay mouse pointer and it was rather tricky to figure out what the game wanted. I think it needed a proper dwMinOverlayStretch and dwMaxOverlayStretch value set, among other things. Some hints to get you started: DDCAPS_OVERLAY, DDSCAPS_OVERLAY, dwMaxVisibleOverlays, dwMinOverlayStretch, etc. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTANmdAAoJEN0/YqbEcdMw+ikP/AqVDKsTP55id74rRQFPrqdI fpZEpjz/Lqu12sZzPdLhK9zPPvsqhon3QyE+VPFrkBB4X0hlZ2vuWzVbjrd/XBLv au6HS3Os/KDMnpkYZlyE8JwdtaOqJOF8f2GdpUvpwZ4AruU9qgVqoKSjP358qa+Y Kl/e9hmdLZw6tDGlKVimfO9gp3up46JQm+o0jzXLSuEoNKGWMxQtXVVuTBfv30DJ hTcVdrCd/FBSvSTSS4+5R6Dj0VbcdM7DaJ3GJrtVs3hMyN0smkD6SbQ7KGq5c3Ds d/Z/Z/X2TcBpxM7UF2Qg/Vg08v0Yubkz5JAqNuHdaU3117Gd4UTfjevdCkTnhFiv 3JQmDKtNQZAq4V33CmGWabYtOddgJP0loD63GX/sMmPQeOJBCztsDN59dhXpCq5O QOZRz5bJEri5317yHbATlNST4mlqR5VpnYvJovNiMNSa4Om82Z8TXLuTisCRkeMr wuTxG45zuMmH/p5BNbuL9eoKhDGWlhm/m7LMv1nGWajnDTFvtXNpIJv8WKIZ7flR ik0+0ak0hSpkLYCrDoe62qv9tktP6L7g1/XBQhysxMCwxkVE/jU7nafYzFbC31bA 8ezCnHbwvVUYL1036nOIZEd0zjcRSHtHvuJgmmbEu4wgjgMBD/T7uL4/1N9NVVuD UZ0eZzT35qwUSkM1siOx =98Q8 -----END PGP SIGNATURE-----

Feb. 16, 2014

Re: Assorted spelling fixes

by Dmitry Timoshkov

Francois Gouget <fgouget(a)free.fr> wrote: > > It's more ambiguous for e.g. file or disk sizes where drive vendors > > often use 1000 based units, > > <offtopic> > > And it's getting even more confusing. Some time ago I bought a 60 GB SSD > which was really 60 * 1024 * 1024 KB. That makes sense since SSDs are > after all more like DIMMS than hard drives. But more recently I bought a > 240 GB SSD which turned out to be 240,000,000 KB. > > So for SSDs there's no telling what GB means anymore :-( That's been always a trick HDD vendors were playing for decades to fool the users, and it has nothing todo with the actual mening of those abbrevations. -- Dmitry.

Feb. 16, 2014

Re: configure: Add import library for xmllite.

by Dmitry Timoshkov

Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 14 February 2014 08:23, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > > -WINE_CONFIG_DLL(xmllite) > > +WINE_CONFIG_DLL(xmllite,,[implib]) > That's auto-generated by make_makefiles from Makefile.in. Just a bit of clarification: does that mean that an import library gets added once a Wine component (dll or an application) start to require it and somebody adds a dependency to Makefile.in? If that's the case what should 3rd party users of winelib do when they compile their code and it fails to link because of a missing import library? Shouldn't they be always available if PSDK provides one? -- Dmitry.

Feb. 16, 2014

Re: Assorted spelling fixes

by Francois Gouget

On Sun, 16 Feb 2014, Henri Verbeet wrote: [...] > It's more ambiguous for e.g. file or disk sizes where drive vendors > often use 1000 based units, <offtopic> And it's getting even more confusing. Some time ago I bought a 60 GB SSD which was really 60 * 1024 * 1024 KB. That makes sense since SSDs are after all more like DIMMS than hard drives. But more recently I bought a 240 GB SSD which turned out to be 240,000,000 KB. So for SSDs there's no telling what GB means anymore :-( </offtopic> -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

Feb. 16, 2014

Re: Assorted spelling fixes

by Francois Gouget

On Sun, 16 Feb 2014, Dmitry Timoshkov wrote: [...] > > >> - cab_ULONG window_size; /* window size (1Kb through 2Mb) */ > > >> + cab_ULONG window_size; /* window size (1 KB through 2 MB) */ [...] > In my years of University the students were told to remember that > 1Kb == 1024 bytes, 1Mb == 1024Kb and size prefixes should be written > as a capital letter to emphasize its meaning. '1Kb' is some number of bits, not bytes and is nowhere close to 1024 bytes. So that's one thing that really needed fixing in the old comment. Now as for the always confusing 1000 vs 1024 ambiguity and kB vs. KB vs. KiB aspect I don't care. Reference: * https://en.wikipedia.org/wiki/Bit The symbol for bit, as a unit of information, is either simply bit (recommended by the ISO/IEC standard 80000-13 (2008)) or lowercase b (recommended by the IEEE 1541 Standard (2002)). * https://en.wikipedia.org/wiki/Byte#Unit_symbol The unit symbol for the byte is specified in IEC 80000-13, IEEE 1541 and the Metric Interchange Format as the upper-case character B. The unit symbol kB is commonly used for kilobyte, but may be confused with the still often-used abbreviation of kb for kilobit. IEEE 1541 specifies the lower case character b as the symbol for bit; however, IEC 80000-13 and Metric-Interchange-Format specify the abbreviation bit (e.g., Mbit for megabit) for the symbol, providing disambiguation from B for byte. * https://en.wikipedia.org/wiki/Kilobyte All existing recommendations prefer to use the uppercase letter B for byte, because b is used for the bit. Just as a note, in the GUI we seem to be using 'k' (*), 'kB', 'MB' and 'GB'. If anyone wants to change the first two to 'KB' I'm fine with that. The 'KiB' variants may prove too confusing for non technical users however. (*) Look for '64k'. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

Feb. 16, 2014

Re: Questions about filename_tests in dlls/shell32/tests/shlexec.c

by Dmitry Timoshkov

Zhenbo Li <litimetal(a)gmail.com> wrote: > I checked wine test errors, and found some errors for > dlls/shell32/tests/shlexec.c[1]. I wanted to fix bugs in > 'static void test_filename(void)'. Probably you should explain first what bugs you want to fix. -- Dmitry.

Feb. 16, 2014

Re: Questions about filename_tests in dlls/shell32/tests/shlexec.c

by Francois Gouget

On Sun, 16 Feb 2014, Zhenbo Li wrote: [...] > However, I can't understand the intention of previous code: All > testcases are put into > 'static filename_tests_t filename_tests[]', > then they are tested via a while-loop. I think it is difficult to locate > *which* testcase really fails. > > Is re-factoring such code encouraged? If so, I'm glad to do it. No. The goal of this test structure is to avoid lots of code duplication. To compensate with the line number being of little use, the failure message prints the full data on what was tested. For instance the first failure is: shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtD671.tmp\test file.noassoc") WaitForSingleObject returned 258 The verb is empty and the base filename 'test file.noassoc' so this corresponds to: /* Test filenames with no association */ {NULL, "%s\\test file.noassoc", 0x0, SE_ERR_NOASSOC}, It turns out I looked into this a bit and in fact all the 'returned 258' errors have the same cause: Windows 8 pops up a 'dialog' that asks whether to look for an app in the Microsoft Store to handle the unknown file extension. shell_execute() has some code to deal with those which centers on: HWND wnd = FindWindowA("#32770", "Windows"); That line is supposed to detect the dialog popped up by Windows, dismiss it and note to skip further tests that could trigger it. The problem is that on Windows 8 the 'dialog' has changed: it's a window with no decoration that looks very much like the Metro apps. So it's too different and thus is not detected. I tried to figure out what class or title that window has using Spy++ but any time I click outside it, it disappears. That's where I got stuck. So if anyone wants to take over... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ There are 10 types of people in the world... those who understand binary and those who don't.

Feb. 16, 2014

Questions about filename_tests in dlls/shell32/tests/shlexec.c

by Zhenbo Li

Hello, I checked wine test errors, and found some errors for dlls/shell32/tests/shlexec.c[1]. I wanted to fix bugs in 'static void test_filename(void)'. However, I can't understand the intention of previous code: All testcases are put into 'static filename_tests_t filename_tests[]', then they are tested via a while-loop. I think it is difficult to locate *which* testcase really fails. Is re-factoring such code encouraged? If so, I'm glad to do it. I really appreciate all finds of ideas. Thank you. [1]: http://test.winehq.org/data/aa22a3c4b2e772636163ea50e7245dba01fe7b34/win8_n… Zhenbo Li

Feb. 16, 2014

Re: Assorted spelling fixes

by Dmitry Timoshkov

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - cab_ULONG window_size; /* window size (1Kb through 2Mb) */ > + cab_ULONG window_size; /* window size (1 KB through 2 MB) */ This is not the typos, that's a common way of writing sizes by programmers, personally I prefer the old form (and will keep using it in future) and hate the "fixed" variant. Please avoid this kind of "fixes". -- Dmitry.

Feb. 16, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Ken Thomases

On Feb 16, 2014, at 3:06 AM, Christopher Thielen wrote: > No luck so far: I ran the application for about 30 seconds and generated a 975 MB log file but a case insensitive "overlay" appears not at all. To keep the log size down, you could try a warn+ddraw,warn+d3d,warn+d3d_surface log, instead. > Since this missing secondary mouse cursor only appears during certain game states, one idea I had is to look at the 'fixme's in the log and see if any roughly correlate to when the cursor should be on-screen. This is assuming the log growth correlates to game-time, which it probably does with the exception of program start and stop. > > I don't know if that's the next best way to debug this but there are two fixme lines that come up a lot (hundreds and hundreds of times): > > fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. The wined3d_debug_location() function is used in other tracing lines. So, to figure out what is affected by it, you would want to read the next line or two from the log. > fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 Same here. These both may go away if you reduce the logging to just WARNs (and ERRs and FIXMEs which are enabled by default). It's possible they were only be generated by TRACEs. -Ken

Feb. 16, 2014

Re: Assorted spelling fixes

by Henri Verbeet

On 16 February 2014 09:57, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > In my years of University the students were told to remember that > 1Kb == 1024 bytes, 1Mb == 1024Kb and size prefixes should be written > as a capital letter to emphasize its meaning. I'm very reluctant to > change this practice to something else regardless of explanations and > intents. I understand that for not technical people 1K == 1000, but > I'd assume programmers are not of that kind. > Strictly speaking the SI units are kB, etc. for 1000 bytes, and IEC KiB, etc. for 1024 bytes. For memory sizes, it's usually obvious enough from context which one is meant, so there's not much of a point to change it. It's more ambiguous for e.g. file or disk sizes where drive vendors often use 1000 based units, and transfer speeds where "b" usually means bits. But as I said, in most cases it's obvious enough from context, and "KB" instead of "Kb" isn't really much clearer.

Feb. 16, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Christopher Thielen

No luck so far: I ran the application for about 30 seconds and generated a 975 MB log file but a case insensitive "overlay" appears not at all. Since this missing secondary mouse cursor only appears during certain game states, one idea I had is to look at the 'fixme's in the log and see if any roughly correlate to when the cursor should be on-screen. This is assuming the log growth correlates to game-time, which it probably does with the exception of program start and stop. I don't know if that's the next best way to debug this but there are two fixme lines that come up a lot (hundreds and hundreds of times): fixme:d3d:wined3d_debug_location Unrecognized location flag(s) 0xfffffc00. (and somewhat less often though still prevalent): fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 Do any of these fixmes sound to be likely candidates to the more knowledgeable DirectX folks? (The former sounds like a DX surface is supposed to be blitted somewhere but the request is invalid - perhaps that's the missing cursor?) - Christopher Thielen On 02/15/2014 05:05 PM, Ken Thomases wrote: > On Feb 15, 2014, at 6:17 PM, Christopher Thielen wrote: > >> I'm attempting to fix http://bugs.winehq.org/show_bug.cgi?id=13683 but need some advice as to where to start. I'm not too familiar with hacking on Wine. >> >> I'd like to test Stefan Dösinger's theory outlined in the comments for #13683 that the missing second mouse cursor is perhaps being implemented using DirectX overlays and that Wine's lack of overlay compatibility flags is to blame. >> >> Would the proper action to test this theory be to fake a certain set of flags in dlls/d3d8/device.c's static HRESULT WINAPI d3d8_device_GetDeviceCaps(IDirect3DDevice8 *iface, D3DCAPS8 *caps) ? If that proves to be the issue, I'd then need to write proper code to report the correct set of flags presumably. > > Probably you should start by collecting a log with the +ddraw,+d3d,+d3d_surface channels and looking for messages that mention "overlay". > > From a cursory look, it seems that wined3d supports some types of overlay surfaces and some operations on those surfaces, but not all. > > >> Is there any easy way to see which DLLs Wine loads when running an application? > > You can look at a +module log. > > -Ken >

Feb. 16, 2014

Re: Assorted spelling fixes

by Dmitry Timoshkov

Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 16 February 2014 12:19, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > > Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > > > >> - cab_ULONG window_size; /* window size (1Kb through 2Mb) */ > >> + cab_ULONG window_size; /* window size (1 KB through 2 MB) */ > > > > This is not the typos, that's a common way of writing sizes by programmers, > > personally I prefer the old form (and will keep using it in future) and hate > > the "fixed" variant. > > > I can't say I'm much of a fan of this kind of change either, but if we > really wanted to be strict about this as a project, I'd prefer either > "kB" or "KiB" (etc.), depending on what's meant. In my years of University the students were told to remember that 1Kb == 1024 bytes, 1Mb == 1024Kb and size prefixes should be written as a capital letter to emphasize its meaning. I'm very reluctant to change this practice to something else regardless of explanations and intents. I understand that for not technical people 1K == 1000, but I'd assume programmers are not of that kind. -- Dmitry.

Feb. 16, 2014

Re: Assorted spelling fixes

by Henri Verbeet

On 16 February 2014 12:19, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > >> - cab_ULONG window_size; /* window size (1Kb through 2Mb) */ >> + cab_ULONG window_size; /* window size (1 KB through 2 MB) */ > > This is not the typos, that's a common way of writing sizes by programmers, > personally I prefer the old form (and will keep using it in future) and hate > the "fixed" variant. > I can't say I'm much of a fan of this kind of change either, but if we really wanted to be strict about this as a project, I'd prefer either "kB" or "KiB" (etc.), depending on what's meant.

Feb. 16, 2014