February 2014 - Wine-Devel - list.winehq.org

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries (resend)

by Jerome Gardou

Le dimanche 23 février 2014, 03:47:27 Marvin a écrit : > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5094 > > Your paranoid android. > > > === w2000pro (32 bit package) === > package.c:3945: Test failed: Expected "C:\\FileName1", got "C:\FileName1" > package.c:3951: Test failed: Expected "C:\\FileName2", got "C:\FileName2" > package.c:3957: Test failed: Expected "C:\\FileName3", got "C:\FileName3" > package.c:3969: Test failed: Expected "C:\\FileName5", got "C:\FileName5" > package.c:3975: Test failed: Expected "C:\\", got "C:\" > package.c:3981: Test failed: Expected "C:\\", got "C:\" > package.c:3997: Test failed: Expected "C:\\FileName8.dll", got > "C:\FileName8.dll" package.c:4008: Test failed: Expected > "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4467: Test failed: > Expected ERROR_SUCCESS, got 1627 > package.c:4559: Test failed: Expected "C:\\FileName1", got "C:\FileName1" > package.c:4570: Test failed: Expected "C:\\", got "C:\" > package.c:4581: Test failed: Expected "C:\\", got "C:\" > package.c:4631: Test failed: Expected "C:\\FileName3.dll", got > "C:\FileName3.dll" package.c:4642: Test failed: Expected > "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4657: Test failed: > Expected "C:\\", got "C:\" > package.c:4662: Test failed: Expected "", got "C:\" > package.c:4678: Test failed: Expected "C:\\FileName1", got "C:\FileName1" > package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" > package.c:4937: Test failed: Expected "C:\\FileName1", got "C:\FileName1" > package.c:4948: Test failed: Expected "C:\\", got "C:\" > package.c:4954: Test failed: Expected "C:\\", got "C:\" > package.c:4975: Test failed: Expected "C:\\FileName2.dll", got > "C:\FileName2.dll" package.c:4986: Test failed: Expected > "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5226: Test failed: > Expected "C:\\FileName1", got "C:\FileName1" package.c:5232: Test failed: > Expected "C:\\", got "C:\" > package.c:5249: Test failed: Expected "C:\\one\two\three\FileName2", got > "C:\one\two\three\FileName2" package.c:5260: Test failed: Expected > "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" > package.c:5268: Test failed: Expected "C:\\FileName3.dll", got > "C:\FileName3.dll" package.c:5612: Test failed: Expected > C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6244: Test > failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus > package.c:6268: Test failed: Expected C:\\ or empty string, got C:\ > package.c:6312: Test failed: Expected C:\\ or empty string, got C:\ > package.c:6321: Test failed: Expected C:\\neosodon\ or empty string, got > C:\neosodon\ package.c:6551: Test failed: Expected "C:\\", got "C:\" > package.c:6552: Test failed: Expected 4, got 3 > package.c:6559: Test failed: Expected "C:\\", got "C:\" > package.c:6560: Test failed: Expected 4, got 3 > package.c:6576: Test failed: Expected "C:\\", got "C:\" > package.c:6577: Test failed: Expected 4, got 3 > package.c:6583: Test failed: Expected "C:\\", got "C:\" > package.c:6584: Test failed: Expected 4, got 3 > package.c:6591: Test failed: Expected "C:\\subsource\", got "C:\subsource\" > package.c:6592: Test failed: Expected 14, got 13 > package.c:6599: Test failed: Expected "C:\\subsource\sub2\", got > "C:\subsource\sub2\" package.c:6600: Test failed: Expected 19, got 18 > package.c:6610: Test failed: Expected "C:\\", got "C:\" > package.c:6611: Test failed: Expected 4, got 3 > package.c:6618: Test failed: Expected "C:\\", got "C:\" > package.c:6619: Test failed: Expected 4, got 3 > package.c:6635: Test failed: Expected "C:\\", got "C:\" > package.c:6636: Test failed: Expected 4, got 3 > package.c:6642: Test failed: Expected "C:\\", got "C:\" > package.c:6643: Test failed: Expected 4, got 3 > package.c:6650: Test failed: Expected "C:\\subsource\", got "C:\subsource\" > package.c:6651: Test failed: Expected 14, got 13 > package.c:6658: Test failed: Expected "C:\\subsource\sub2\", got > "C:\subsource\sub2\" package.c:6659: Test failed: Expected 19, got 18 > package.c:6669: Test failed: Expected "C:\\", got "C:\" > package.c:6670: Test failed: Expected 4, got 3 > package.c:6677: Test failed: Expected "C:\\", got "C:\" > package.c:6678: Test failed: Expected 4, got 3 > package.c:6694: Test failed: Expected "C:\\", got "C:\" > package.c:6695: Test failed: Expected 4, got 3 > package.c:6701: Test failed: Expected "C:\\", got "C:\" > package.c:6702: Test failed: Expected 4, got 3 > package.c:6709: Test failed: Expected "C:\\subsource\", got "C:\subsource\" > package.c:6710: Test failed: Expected 14, got 13 > package.c:6717: Test failed: Expected "C:\\subsource\sub2\", got > "C:\subsource\sub2\" package.c:6718: Test failed: Expected 19, got 18 > package.c:6728: Test failed: Expected "C:\\", got "C:\" > package.c:6729: Test failed: Expected 4, got 3 > package.c:6736: Test failed: Expected "C:\\", got "C:\" > package.c:6737: Test failed: Expected 4, got 3 > package.c:6753: Test failed: Expected "C:\\", got "C:\" > package.c:6754: Test failed: Expected 4, got 3 > package.c:6760: Test failed: Expected "C:\\", got "C:\" > package.c:6761: Test failed: Expected 4, got 3 > package.c:6768: Test failed: Expected "C:\\subsource\", got "C:\subsource\" > package.c:6769: Test failed: Expected 14, got 13 > package.c:6776: Test failed: Expected "C:\\subsource\sub2\", got > "C:\subsource\sub2\" package.c:6777: Test failed: Expected 19, got 18 > package.c:6792: Test failed: Expected 4, got 3 > package.c:6809: Test failed: Expected 4, got 3 > package.c:6815: Test failed: Expected ERROR_MORE_DATA, got 0 > package.c:6818: Test failed: Expected 4, got 3 > package.c:6825: Test failed: Expected "C:\\", got "C:\" > package.c:6826: Test failed: Expected 4, got 3 > package.c:6837: Test failed: Expected "C:\\", got "C:\" > package.c:6838: Test failed: Expected 4, got 3 > package.c:6933: Test failed: Expected "C:\\", got "C:\" > package.c:6934: Test failed: Expected 4, got 3 > package.c:6941: Test failed: Expected "C:\\", got "C:\" > package.c:6942: Test failed: Expected 4, got 3 > package.c:6951: Test failed: Expected "C:\\", got "C:\" > package.c:6952: Test failed: Expected 4, got 3 > package.c:6960: Test failed: Expected "C:\\", got "C:\" > package.c:6961: Test failed: Expected 4, got 3 > package.c:6967: Test failed: Expected "C:\\", got "C:\" > package.c:6968: Test failed: Expected 4, got 3 > package.c:6975: Test failed: Expected "C:\\", got "C:\" > package.c:6976: Test failed: Expected 4, got 3 > package.c:6983: Test failed: Expected "C:\\", got "C:\" > package.c:6984: Test failed: Expected 4, got 3 > package.c:6994: Test failed: Expected "C:\\", got "C:\" > package.c:6995: Test failed: Expected 4, got 3 > package.c:7002: Test failed: Expected "C:\\", got "C:\" > package.c:7003: Test failed: Expected 4, got 3 > package.c:7012: Test failed: Expected "C:\\", got "C:\" > package.c:7013: Test failed: Expected 4, got 3 > package.c:7021: Test failed: Expected "C:\\", got "C:\" > package.c:7022: Test failed: Expected 4, got 3 > package.c:7028: Test failed: Expected "C:\\", got "C:\" > package.c:7029: Test failed: Expected 4, got 3 > package.c:7036: Test failed: Expected "C:\\", got "C:\" > package.c:7037: Test failed: Expected 4, got 3 > package.c:7044: Test failed: Expected "C:\\", got "C:\" > package.c:7045: Test failed: Expected 4, got 3 > package.c:7055: Test failed: Expected "C:\\", got "C:\" > package.c:7056: Test failed: Expected 4, got 3 > package.c:7063: Test failed: Expected "C:\\", got "C:\" > package.c:7064: Test failed: Expected 4, got 3 > package.c:7073: Test failed: Expected "C:\\", got "C:\" > package.c:7074: Test failed: Expected 4, got 3 > package.c:7082: Test failed: Expected "C:\\", got "C:\" > package.c:7083: Test failed: Expected 4, got 3 > package.c:7089: Test failed: Expected "C:\\", got "C:\" > package.c:7090: Test failed: Expected 4, got 3 > package.c:7097: Test failed: Expected "C:\\", got "C:\" > package.c:7098: Test failed: Expected 4, got 3 > package.c:7105: Test failed: Expected "C:\\", got "C:\" > package.c:7106: Test failed: Expected 4, got 3 > package.c:7116: Test failed: Expected "C:\\", got "C:\" > package.c:7117: Test failed: Expected 4, got 3 > package.c:7124: Test failed: Expected "C:\\", got "C:\" > package.c:7125: Test failed: Expected 4, got 3 > package.c:7134: Test failed: Expected "C:\\", got "C:\" > package.c:7135: Test failed: Expected 4, got 3 > package.c:7143: Test failed: Expected "C:\\", got "C:\" > package.c:7144: Test failed: Expected 4, got 3 > package.c:7150: Test failed: Expected "C:\\", got "C:\" > package.c:7151: Test failed: Expected 4, got 3 > package.c:7158: Test failed: Expected "C:\\", got "C:\" > package.c:7159: Test failed: Expected 4, got 3 > package.c:7166: Test failed: Expected "C:\\", got "C:\" > package.c:7167: Test failed: Expected 4, got 3 > package.c:7264: Test failed: Expected "C:\\long\", got "C:\long\" > package.c:7265: Test failed: Expected 9, got 8 > package.c:7274: Test failed: Expected "C:\\long\", got "C:\long\" > package.c:7275: Test failed: Expected 9, got 8 > package.c:7284: Test failed: Expected "C:\\long\", got "C:\long\" > package.c:7285: Test failed: Expected 9, got 8 > package.c:7296: Test failed: Expected "C:\\two\", got "C:\two\" > package.c:7297: Test failed: Expected 8, got 7 > package.c:7308: Test failed: Expected "C:\\four\", got "C:\four\" > package.c:7309: Test failed: Expected 9, got 8 > package.c:7320: Test failed: Expected "C:\\six\", got "C:\six\" > package.c:7321: Test failed: Expected 8, got 7 > package.c:7332: Test failed: Expected "C:\\eight\", got "C:\eight\" > package.c:7333: Test failed: Expected 10, got 9 > package.c:7344: Test failed: Expected "C:\\ten\", got "C:\ten\" > package.c:7345: Test failed: Expected 8, got 7 > package.c:7356: Test failed: Expected "C:\\twelve\", got "C:\twelve\" > package.c:7357: Test failed: Expected 11, got 10 > package.c:7408: Test failed: Expected "C:\\short\", got "C:\short\" > package.c:7409: Test failed: Expected 10, got 9 > package.c:7418: Test failed: Expected "C:\\short\", got "C:\short\" > package.c:7419: Test failed: Expected 10, got 9 > package.c:7428: Test failed: Expected "C:\\short\", got "C:\short\" > package.c:7429: Test failed: Expected 10, got 9 > package.c:7440: Test failed: Expected "C:\\one\", got "C:\one\" > package.c:7441: Test failed: Expected 8, got 7 > package.c:7452: Test failed: Expected "C:\\three\", got "C:\three\" > package.c:7453: Test failed: Expected 10, got 9 > package.c:7464: Test failed: Expected "C:\\five\", got "C:\five\" > package.c:7465: Test failed: Expected 9, got 8 > package.c:7476: Test failed: Expected "C:\\seven\", got "C:\seven\" > package.c:7477: Test failed: Expected 10, got 9 > package.c:7488: Test failed: Expected "C:\\nine\", got "C:\nine\" > package.c:7489: Test failed: Expected 9, got 8 > package.c:7500: Test failed: Expected "C:\\eleven\", got "C:\eleven\" > package.c:7501: Test failed: Expected 11, got 10 > package.c:7637: Test failed: Expected "C:\\", got "C:\" > package.c:7638: Test failed: Expected 4, got 3 > package.c:7649: Test failed: Expected "C:\\", got "C:\" > package.c:7650: Test failed: Expected 4, got 3 > package.c:7657: Test failed: Expected "C:\\", got "C:\" > package.c:7658: Test failed: Expected 4, got 3 > package.c:7755: Test failed: Expected "C:\\", got "C:\" > package.c:7756: Test failed: Expected 4, got 3 > package.c:7763: Test failed: Expected "C:\\", got "C:\" > package.c:7764: Test failed: Expected 4, got 3 > package.c:7771: Test failed: Expected "C:\\", got "C:\" > package.c:7772: Test failed: Expected 4, got 3 > package.c:7791: Test failed: Expected "C:\\", got "C:\" > package.c:7792: Test failed: Expected 4, got 3 > package.c:7799: Test failed: Expected "C:\\", got "C:\" > package.c:7800: Test failed: Expected 4, got 3 > package.c:7819: Test failed: Expected "C:\\", got "C:\" > package.c:7820: Test failed: Expected 4, got 3 > package.c:7827: Test failed: Expected "C:\\", got "C:\" > package.c:7828: Test failed: Expected 4, got 3 > package.c:7847: Test failed: Expected "C:\\", got "C:\" > package.c:7848: Test failed: Expected 4, got 3 > package.c:7855: Test failed: Expected "C:\\", got "C:\" > package.c:7856: Test failed: Expected 4, got 3 Hello, Those failures are not related to my patch. Regards Jérôme

Feb. 24, 2014

Re: Patch to fix bug 34324

by Bruno Jesus

On Sat, Feb 22, 2014 at 12:19 AM, Zhenbo Li <litimetal(a)gmail.com> wrote: > Sorry to bother you. > I don't know which patch is preferred, could someone give me any suggestions? > > Also, I'm sorry for the format problems. I'll re-check them before sending them > to wine-patches. > > Any suggestions are greatly appreciated. > Thank you. > -- > Have a nice day! > Zhenbo Li In my opinion the complex patch is better. + if (hFind == INVALID_HANDLE_VALUE){ + if (GetLastError() == ERROR_PATH_NOT_FOUND) + SetLastError(0x7c); /* DE_INVALIDFILES */ + return FALSE; + } + FindClose(hFind); You are not following the {} styles in the surrounding code. Why using a magic value (0x7c) if there is a define(DE_INVALIDFILES)? Best wishes, Bruno

Feb. 24, 2014

Suggested RFP: LinuxFest Northwest

by Jeremy White

As part of our new initiative, we're trying to encourage people to submit RFPs to give Wine talks. The Wine project can potentially help defray travel costs, although the ideal is to encourage folks that don't have to travel far. So here's one: http://linuxfestnorthwest.org/present LinuxFest Northwest. About 1500 Linux geeks. I'm told by an organizer that a Wine talk would be welcome. Anyone on the US West coast up for giving a talk? Cheers, Jeremy

Feb. 24, 2014

Re: [PATCH 2/5] wined3d: Make use of WGL_WINE_make_current extension to restore the previous GL context without reference to its DC.

by Henri Verbeet

On 24 February 2014 15:39, Ken Thomases <ken(a)codeweavers.com> wrote: > On Feb 24, 2014, at 4:53 AM, Henri Verbeet wrote: > >> On 23 February 2014 23:58, Ken Thomases <ken(a)codeweavers.com> wrote: >>> + if (gl_info->supported[WGL_WINE_MAKE_CURRENT] && >>> + !(gl_info->p_wglMakeContextCurrentWINE = (void *)wglGetProcAddress("wglMakeContextCurrentWINE"))) >>> + gl_info->supported[WGL_WINE_MAKE_CURRENT] = FALSE; >> Why can't load_gl_funcs() take care of this? > > The WGL extensions haven't been parsed by the time load_gl_funcs() is called. > Yes, but load_gl_funcs() doesn't depend on that.

Feb. 24, 2014

Re: Failing dpnet tests

by Francois Gouget

On Wed, 19 Feb 2014, Alistair Leslie-Hughes wrote: [...] > Would it be possible to test windows 8 without the firewall enabled? > > It's going to be hard to get patches accepted if win8 keeps failing. I looked into this and the problem is not with the firewall. The issue is that DirectPlay is deprecated on Windows 8. As a result the libraries are not installed by default and when an application tries to load them one gets a dialog that says: An app on your pc needs the following windows feature DirectPlay This then offers to install it and the application remains stuck until the user says yes or no. That's why the test times out. One option would be to trigger this dialog so DirectPlay is installed. This dialog will then no longer be triggered and the test will run fine. That's what I have done on the w864 VM some time back. However it may be better for the test to detect that the dll is missing and to skip if that's the case. Otherwise even if I fix the issue on this VM we'll still get failures from any other Windows 8 system for which the user did not go through these steps. I suspect a simple LoadLibrary() will trigger that dialog too so some other approach may be needed. Maybe something based on FindExecutable() would work. -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 24, 2014

Re: [PATCH 2/5] wined3d: Make use of WGL_WINE_make_current extension to restore the previous GL context without reference to its DC.

by Ken Thomases

On Feb 24, 2014, at 4:53 AM, Henri Verbeet wrote: > On 23 February 2014 23:58, Ken Thomases <ken(a)codeweavers.com> wrote: >> + if (gl_info->supported[WGL_WINE_MAKE_CURRENT] && >> + !(gl_info->p_wglMakeContextCurrentWINE = (void *)wglGetProcAddress("wglMakeContextCurrentWINE"))) >> + gl_info->supported[WGL_WINE_MAKE_CURRENT] = FALSE; > Why can't load_gl_funcs() take care of this? The WGL extensions haven't been parsed by the time load_gl_funcs() is called. Also, it seemed at least somewhat similar to the other code right above it. > >> {"WGL_WINE_pixel_format_passthrough", WGL_WINE_PIXEL_FORMAT_PASSTHROUGH}, >> + {"WGL_WINE_make_current", WGL_WINE_MAKE_CURRENT}, > ... >> WGL_WINE_PIXEL_FORMAT_PASSTHROUGH, >> + WGL_WINE_MAKE_CURRENT, > With the (obvious) exceptions of WINED3D_GL_EXT_NONE and > WINED3D_GL_EXT_COUNT, the wined3d_gl_extension enum is supposed to be > in lexicographical order. OK. -Ken

Feb. 24, 2014

Re: urlmon: Fixed some tests on IE11.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5116 Your paranoid android. === w8 (32 bit protocol) === protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20

Feb. 24, 2014

Re: [PATCH 3/4] wmp: Added SetObjectRects implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5115 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

Feb. 24, 2014

Re: [PATCH 2/4] wmp: Added DoVerb(OLEIVERB_HIDE) implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5114 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

Feb. 24, 2014

Re: [PATCH 1/4] wmp: Return success in IPersistStreamInit::InitNew.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5113 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

Feb. 24, 2014