February 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

On 18 February 2014 23:14, Ken Thomases <ken(a)codeweavers.com> wrote: > On Feb 18, 2014, at 10:08 AM, Henri Verbeet wrote: >> ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p >> d3d9_test.exe.so device && touch device.ok >> ... >> device.c:7547: Test succeeded >> X Error of failed request: BadMatch (invalid parameter attributes) >> Major opcode of failed request: 154 (GLX) >> Minor opcode of failed request: 11 (X_GLXSwapBuffers) >> Serial number of failed request: 4929 >> Current serial number in output stream: 4933 >> make: *** [device.ok] Error 1 > > Is this with or without patch 1 applied? > With. Without patch 1, I get test failures, but not the BadMatch error.

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Ken Thomases

On Feb 18, 2014, at 10:08 AM, Henri Verbeet wrote: > On 17 February 2014 22:25, Ken Thomases <ken(a)codeweavers.com> wrote: >> dlls/d3d9/tests/device.c | 144 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 144 insertions(+) >> > Unfortunately this fails here: > > ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p > d3d9_test.exe.so device && touch device.ok > ... > device.c:7547: Test succeeded > X Error of failed request: BadMatch (invalid parameter attributes) > Major opcode of failed request: 154 (GLX) > Minor opcode of failed request: 11 (X_GLXSwapBuffers) > Serial number of failed request: 4929 > Current serial number in output stream: 4933 > make: *** [device.ok] Error 1 Is this with or without patch 1 applied? -Ken

Feb. 18, 2014

Re: [PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

by Henri Verbeet

On 17 February 2014 22:25, Ken Thomases <ken(a)codeweavers.com> wrote: > dlls/d3d9/tests/device.c | 144 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 144 insertions(+) > Unfortunately this fails here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so device && touch device.ok ... device.c:7547: Test succeeded X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 154 (GLX) Minor opcode of failed request: 11 (X_GLXSwapBuffers) Serial number of failed request: 4929 Current serial number in output stream: 4933 make: *** [device.ok] Error 1

Feb. 18, 2014

Re: [PATCH] user32: Use public define for Dialog class atom

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > /* Built-in class names (see _Undocumented_Windows_ p.418) */ > #define POPUPMENU_CLASS_ATOM MAKEINTATOM(32768) /* PopupMenu */ > #define DESKTOP_CLASS_ATOM MAKEINTATOM(32769) /* Desktop */ > -#define DIALOG_CLASS_ATOM MAKEINTATOM(32770) /* Dialog */ > #define WINSWITCH_CLASS_ATOM MAKEINTATOM(32771) /* WinSwitch */ > #define ICONTITLE_CLASS_ATOM MAKEINTATOM(32772) /* IconTitle */ This list is very handy when searching for an atom constant in the user32 code, also there is no point in breaking "grep CLASS_ATOM" in favour of a dubious use of just one constant from a public header. -- Dmitry.

Feb. 18, 2014

Re: Failing dpnet tests

by Francois Gouget

On Tue, 18 Feb 2014, Alistair Leslie-Hughes wrote: > Hi, > > On Windows 8, the dpnet are failing with a timeout. I don't see a timeout for either the dpnet:peer or dpnet:server tests: http://test.winehq.org/data/tests/dpnet:peer.html http://test.winehq.org/data/tests/dpnet:server.html In fact it's green on all Windows platforms for the past 12 runs. Kudos! > After manually running the tests, I found a possible cause. > > The dpnet.dll cause the dpnsvr.exe to be loaded which attempts to > create a socket. In turn the firewall dialog appears prompting > whether it's allowed to do so. So no communication between the dpnet test exe > and dpnsvr.exe thus the timeout. > > Could someone run the dpnet test manually and allow the dpnsvr.exe > to create connections? I have run both tests manually on my Windows 8.1 laptop. On the first run the dpnet:server test caused the firewall dialog to pop up but that did not stop the test and it completed almost immediately. A number of other tests cause the firewall dialog to pop up but I believe that as long as the connections are to and/or from the localhost, the firewall lets them through and so does not cause trouble. -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows (try2)

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -1098,13 +1098,62 @@ INT WINAPI GetClassNameW( HWND hwnd, LPWSTR buffer, INT count ) > return ret; > } > > +struct builtinclass_name > +{ > + const char *nameA; > + const WCHAR *nameW; > + int len; > +}; > + > +static const WCHAR buttonW[] = {'B','u','t','t','o','n',0}; > +static const WCHAR comboboxW[] = {'C','o','m','b','o','B','o','x',0}; > +static const WCHAR dialogW[] = {'#','3','2','7','7','0',0}; > +static const WCHAR editW[] = {'E','d','i','t',0}; > +static const WCHAR listboxW[] = {'L','i','s','t','B','o','x',0}; > +static const WCHAR mdiclientW[] = {'M','D','I','C','l','i','e','n','t',0}; > +static const WCHAR scrollbarW[] = {'S','c','r','o','l','l','B','a','r',0}; > +static const WCHAR staticW[] = {'S','t','a','t','i','c',0}; > + > +static const struct builtinclass_name builtinclass_names[BUILTINTYPE_MAX] = > +{ > + { "Button", buttonW, sizeof(buttonW)/sizeof(WCHAR) }, > + { "ComboBox", comboboxW, sizeof(comboboxW)/sizeof(WCHAR) }, > + { "#32770", dialogW, sizeof(dialogW)/sizeof(WCHAR) }, > + { "Edit", editW, sizeof(editW)/sizeof(WCHAR) }, > + { "ListBox", listboxW, sizeof(listboxW)/sizeof(WCHAR) }, > + { "MDIClient", mdiclientW, sizeof(mdiclientW)/sizeof(WCHAR) }, > + { "ScrollBar", scrollbarW, sizeof(scrollbarW)/sizeof(WCHAR) }, > + { "Static", staticW, sizeof(staticW)/sizeof(WCHAR) } > +}; You should use the existing builtin class descriptors instead of duplicating that info. -- Alexandre Julliard julliard(a)winehq.org

Feb. 18, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Stefan Dösinger

Am 18.02.2014 um 06:12 schrieb Christopher Thielen <christopher(a)thielen.co>: > Two questions: > 1) Is there a way to add timestamps to the TRACE statements in Wine? WINEDEBUG=+timestamp This adds timestamps to other traces, so you can do e.g. WINEDEBUG=d3d,timestamp to get a d3d trace with timestamps. > 2) If I know which file is opened by the game, is there a way to debug from that point on, i.e. capture the fopen() and enable +cursor,+resource,+d3d TRACES for say, only 5 seconds after that point? Something along those lines? Afaik no. You could use some search and replace tricks in text editors or with command line text tools though. > > I can find the exact offset within the data file used to load the missing resource - but I'd need a way to know when a fread() was that far along. I figure if I can determine that I can determine if the cursor is loaded as a Windows cursor or as a D3D surface and go from there. Note that there are plenty of ways to open and read files. fopen and fread are just one of them. There are win32 equivalents of those C functions, and there are specific resource loading functions which you’ve probably already seen.

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

by Nikolay Sivov

On 2/18/2014 11:42, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> + else if (ptr->builtin_type != -1) >> + { >> + const struct builtinclass_name *classname = &builtinclass_names[ptr->builtin_type]; >> + ret = min( count, classname->len ) - 1; >> + memcpy( buffer, classname->nameA, ret ); >> + buffer[ret] = 0; >> + } > In case of count = 0 this code will overwrite random data. > No, it won't.

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + else if (ptr->builtin_type != -1) > + { > + const struct builtinclass_name *classname = &builtinclass_names[ptr->builtin_type]; > + ret = min( count, classname->len ) - 1; > + memcpy( buffer, classname->nameA, ret ); > + buffer[ret] = 0; > + } In case of count = 0 this code will overwrite random data. -- Dmitry.

Feb. 18, 2014

Re: [PATCH] user32: Fix RealGetWindowClass() to return what it's supposed to for same process windows

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4995 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6429: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6451: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6429: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6429: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6451: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6429: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6451: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2988: Test failed: GetActiveWindow() = 00000000 win.c:2988: Test failed: GetFocus() = 00000000 win.c:3011: Test failed: GetActiveWindow() = 00000000 win.c:3011: Test failed: GetFocus() = 00000000 win.c:3072: Test failed: GetActiveWindow() = 00000000 win.c:3072: Test failed: GetFocus() = 00000000 win.c:6212: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 0000000000000000 win.c:2988: Test failed: GetFocus() = 0000000000000000 win.c:3011: Test failed: GetActiveWindow() = 0000000000000000 win.c:3011: Test failed: GetFocus() = 0000000000000000 win.c:3072: Test failed: GetActiveWindow() = 0000000000000000 win.c:3072: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 0000000000000000 win.c:2988: Test failed: GetFocus() = 0000000000000000 win.c:3011: Test failed: GetActiveWindow() = 0000000000000000 win.c:3011: Test failed: GetFocus() = 0000000000000000 win.c:3072: Test failed: GetActiveWindow() = 0000000000000000 win.c:3072: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2988: Test failed: GetActiveWindow() = 0000000000000000 win.c:2988: Test failed: GetFocus() = 0000000000000000 win.c:3011: Test failed: GetActiveWindow() = 0000000000000000 win.c:3011: Test failed: GetFocus() = 0000000000000000 win.c:3072: Test failed: GetActiveWindow() = 0000000000000000 win.c:3072: Test failed: GetFocus() = 0000000000000000

Feb. 18, 2014