February 2014 - Wine-Devel - list.winehq.org

Re: ddraw/tests: Skip some tests when switching the display mode is not supported.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4973 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:842: Test failed: Failed to create d3d device (0x887602ea) ddraw2.c:3295: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw2.c:3308: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw2.c:3324: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw2.c:3343: Test failed: Display mode restored after ddraw1-ddraw2 SetCooperativeLevel() call sequence === w8 (32 bit ddraw7) === ddraw7.c:3254: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3267: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3283: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3302: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw7.c:4072: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. === w8 (32 bit ddraw4) === ddraw4.c:3531: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw4.c:3544: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw4.c:3560: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw4.c:3579: Test failed: Display mode restored after ddraw1-ddraw4 SetCooperativeLevel() call sequence ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4267: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5804: Test failed: Failed to set display mode, hr 0x80004001.

Feb. 17, 2014

Re: ddraw/tests: Better clean up when skipping the primary palette tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4972 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:3231: Test failed: SetDisplayMode failed, hr 0x80004001. === w8 (32 bit ddraw4) === ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001.

Feb. 17, 2014

Re: ddraw/tests: Skip some tests when switching the display mode is not supported.

by Henri Verbeet

On 17 February 2014 17:45, Francois Gouget <fgouget(a)codeweavers.com> wrote: > This can happen on Windows 8 when the 'Microsoft Basic Display Adapter' driver does not recognize the graphics card, for instance QEmu's 'vga' graphics card. As mentioned earlier on IRC, I think that setup is broken for the purpose of running the tests.

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Martin Storsjö

On Mon, 17 Feb 2014, Stefan Dösinger wrote: > Am 2014-02-17 13:29, schrieb Martin Storsjö: >> Yes, but isn't the wined3d code supposed to be able to run on top >> of plain windows as well, not only on top of wine? > Yes, but Windows behaves the same way. We should have tests for that > somewhere in kernel32/tests, and all our code (tests and otherwise) > assumes that HeapFree(, , NULL) is a no-op. Ok then, that makes me more comfortable with doing it like that. I've resent the set with the remaining patch taking all the comments into consideration now. // Martin

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-17 13:29, schrieb Martin Storsjö: > Yes, but isn't the wined3d code supposed to be able to run on top > of plain windows as well, not only on top of wine? Yes, but Windows behaves the same way. We should have tests for that somewhere in kernel32/tests, and all our code (tests and otherwise) assumes that HeapFree(, , NULL) is a no-op. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAgIhAAoJEN0/YqbEcdMwTHkQAIBEGqDkFrkDxBKAFGHd5ZIV vQ4BBv8FzCUDc3Jv7VkqIqgboVfcIcxTR/WXqJ9aAyoUOVAot3fgmGW2aCNINFL/ JHaNqOIaAJdBgvNc8VSa2Pj2L+82Co8RpbBMFQBY1vCBVjfH6MPvxwN5yXv9D9UM kLGuVZwOG2y8HAM1DikISjGqG0CLTrbRsc1DC4OV+EvrKBCHHRPGWZu67+idkNTq nyBhzkkEL3ijKn04tvvnuNEnfofAO7/REXgCiNj2mjkaNDmARUwnjVRnD9NUV5Q/ HrTaLIAM854HS3zCScrINuiG4NTdXT/ag4JCzxQmKEttwiK9Fly43k2J6+H31vKb NWREMmvKBrVFeQE2rGKuzJ2yQtUWWwUGqLxtIyIK9w5hF0TMJY8dtyzfadq6SKZY Tm5Ezd1hGFL1O+X61k0vqEZpX9EGdkLZetuoAkEI32HfNW5aCcbmPV7I7LFBJi8S ZY1JizytJPJt6PZKGmKSHM3e4hnpfNKTb81Xd4mP/pCTWE2pUwiPyuA0i2jMuTMp yzZLSnnLEd2ezjwh6fSFzuQlHnirUEnjhNo2UqZbcmZ+83Aug/vuv6cCkM5pT7J0 b+yiRRo3SxYFVs7ia7Cvem0OqbB3PRae3ZNIsk0w/BKJdkDhu6C8LPg/0vU0G4lL HJtZE9e0VRVKaS5y/E7p =QBS+ -----END PGP SIGNATURE-----

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Martin Storsjö

On Mon, 17 Feb 2014, Bruno Jesus wrote: > On Mon, Feb 17, 2014 at 9:21 AM, Martin Storsjö <martin(a)martin.st> wrote: >>>> + if (desc) >>>> + HeapFree(GetProcessHeap(), 0, desc); >>> >>> There's no point in checking for NULL before HeapFree(). >> >> >> MSDN says "If this pointer is NULL, the behavior is undefined" about the >> lpMem parameter to HeapFree. > > Actually it does not matter what MSDN says in this case, the wine > source code is very clear: > http://source.winehq.org/source/dlls/ntdll/heap.c#L1740 Yes, but isn't the wined3d code supposed to be able to run on top of plain windows as well, not only on top of wine? // Martin

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Bruno Jesus

On Mon, Feb 17, 2014 at 9:21 AM, Martin Storsjö <martin(a)martin.st> wrote: >>> + if (desc) >>> + HeapFree(GetProcessHeap(), 0, desc); >> >> There's no point in checking for NULL before HeapFree(). > > > MSDN says "If this pointer is NULL, the behavior is undefined" about the > lpMem parameter to HeapFree. Actually it does not matter what MSDN says in this case, the wine source code is very clear: http://source.winehq.org/source/dlls/ntdll/heap.c#L1740 > // Martin Bruno

Feb. 17, 2014

Re: [PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Martin Storsjö

On Fri, 14 Feb 2014, Henri Verbeet wrote: > On 13 February 2014 13:05, Martin Storsjo <martin(a)martin.st> wrote: >> static HRESULT arbfp_blit_alloc(struct wined3d_device *device) >> { >> + struct arbfp_blit_priv *priv; >> device->blit_priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct arbfp_blit_priv)); >> if(!device->blit_priv) { >> ERR("Out of memory\n"); >> return E_OUTOFMEMORY; >> } >> + priv = device->blit_priv; >> + >> + if (wine_rb_init(&priv->shaders, &wined3d_arbfp_blit_rb_functions) == -1) >> + { >> + ERR("Failed to initialize rbtree.\n"); >> + HeapFree(GetProcessHeap(), 0, device->blit_priv); >> + device->blit_priv = NULL; >> + return E_OUTOFMEMORY; >> + } >> + >> return WINED3D_OK; >> } >> > The following is probably slightly nicer: > > static HRESULT arbfp_blit_alloc(struct wined3d_device *device) > { > - device->blit_priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(struct arbfp_blit_priv)); > - if(!device->blit_priv) { > - ERR("Out of memory\n"); > + struct arbfp_blit_priv *priv; > + > + if (!(priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)))) > return E_OUTOFMEMORY; > + > + if (wine_rb_init(&priv->shaders, &wined3d_arbfp_blit_rb_functions) == -1) > + { > + ERR("Failed to initialize rbtree.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > } > + > + device->blit_priv = priv; > + > return WINED3D_OK; > } That's nicer indeed, updated the patch accordingly locally. >> + if (desc) >> + HeapFree(GetProcessHeap(), 0, desc); > There's no point in checking for NULL before HeapFree(). MSDN says "If this pointer is NULL, the behavior is undefined" about the lpMem parameter to HeapFree. > Perhaps more importantly, I think it makes more sense to insert the > rbtree entries in arbfp_blit_set(), instead of duplicating the code > between gen_p8_shader() and gen_yuv_shader(). Good point, I've updated my patch accordingly. I'll resend all three patches in a little while unless you or Stefan have got more comments at the moment. // Martin

Feb. 17, 2014

Re: [PATCHv5 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-17 12:53, schrieb Martin Storsjö: > On Fri, 14 Feb 2014, Henri Verbeet wrote: >> That's not technically true, no filtering would be D3DTEXF_NONE. >> I don't know if that's going to make a difference in practice >> though. > > I tested that now as well, and there's no difference, the sharp > edges in the YUV texture are blurred when scaled up. > > I applied the other changes you suggested, those changes will be > part of the next resend of the patchset. D3DTEXF_NONE behaves like D3DTEXF_POINT if used for minification or magnification. It only has a different behavior when assigned to D3DSAMP_MIPFILTER. There is no way to do no min/mag filtering when the source surface / texture size doesn't exactly match the destination rectangle size. In my yuv_color_test cleanup patch I have reworded the comment to correctly say "point filtering" instead of "no filtering". -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAf3GAAoJEN0/YqbEcdMwCXsQAJVp53HiaKCXBce/OtaodwlL axO2Pe8draccKUNupHDhTHtuXLcJV7uc3RV80VxN47h3sDchOFYz0j/H3hQZwuUo 0DrUWFCaLzGB3twpmyZq/zLgERizx6G5NVSMQJTIvAMmOzibJqHxgl+AHBWfmVGG hdldw5fLSbQCpacpbrWpNZOiap0Bs24XTw7si4S8q25PrM89lm8XJKJROnFatloF vvvtw2jbaWtzxQHoIt0y9SnZhDvpftJwDfPhN2jVDJnusuYAwZWTMtrQzHj/jUtI KuK8mxWJUhjocmgv23Qh43S92zOBxRqkz76V0xrPLjIcCMyBoCCojBkahQa0gSbG 1i25pApi59KrnRJ/zUNAOtIDea81Iq71YOVwnC2E/EqpG+vbqYl8mBeKxybrZ8jU S9JA+xsJL+ZFJ1NlTyU/KV4fweHgmerIaj12+XF3TeTR04L268EqDD2jIb14FTfy msaeAyckR2emN5midcFCjUUIEG+t1CsWInfdI8Z1X2sQugBHZvxUEOWovXoTarHi ji0cBNOEfEINtoNj7GIa7OdZsOkVncpUcI2ySTA9Ykb7cO25dYYk4hSmobE/Pvun KaeSsVvXALLfRraXg7cQnTg8Befx+gIZuvyYSK7MENe1S2F8fR257X5lrNXS3djE MEdB/nivZnLkSq4dk39D =gluy -----END PGP SIGNATURE-----

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Michael Stefaniuc

On 02/17/2014 12:20 PM, Alistair Leslie-Hughes wrote: > On 17/02/2014 10:07 PM, Michael Stefaniuc wrote: >> On 02/17/2014 11:27 AM, Alistair Leslie-Hughes wrote: >>> On 17/02/2014 8:04 PM, Marvin wrote: >>>> Hi, >>>> === w8 (32 bit client) === >>>> Timeout >>> Anybody know if DirectPlay is supported on Windows 8? >> I doubt it is installed by default as it is deprecated but you should be >> able to get it for 32bit Windows. It was never supported on 64bit and it >> misses on all 64bit Windows versions. > The testbot is 32bit, so maybe something else is going wrong. Can > someone check if the dpnet.dll is installed by default? I currently > don't have a access to a windows 8 machine. You can check yourself by searching the test results page for that machine. E.g.: http://test.winehq.org/data/aa22a3c4b2e772636163ea50e7245dba01fe7b34/win8_n… dpnet 6.2.9200.16384 >>> It tests are timeout doing >>> hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, >>> CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); >> Are you doing the interactive tests? Those do time out on Windows for >> whatever reason. >> > No, the tests aren't interactive, so this shouldn't be the issue. All > other windows version pass, so this windows 8 issue is confusing. You'll have to figure it out then. But the CoCreateInstance call should not timeout. Especially if CLSID_DirectPlay8Client is unsupported; you would get an error back and that would fast. bye michael

Feb. 17, 2014