February 2014 - Wine-Devel - list.winehq.org

d3d bisecting help needed

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, If anyone wants to help me out with a d3d performance issue here's your chance: My regression tests picked up a performance drop on r300g a few weeks ago: http://openbenchmarking.org/result/1402162-STEF-WINE17135&track_view=60 . Read graphs right to left. The regression can be seen in the following tests: drawprim_d3d (a simple draw overhead tester), Half Life 2 and Trackmania Nations. According to the test data, the regression happened between wine-1.7.10-73-g460991a and wine-1.7.10-112-g81c42ce. I do not know if the regression is in Wine or Mesa. Unfortunately my test setup does not track which Mesa revision was used for each test, but usually the date of the used mesa commit matches the date of the Wine commit. What you'll need is a GPU supported by the Mesa r300g driver, a setup where you can use Mesa from git and of course a working Wine build setup. You'll also need one of the games in question. The drawprim_d3d microbenchmark can be found at https://84.112.174.163/~stefan/pts/drawprim_d3d.exe , but the server may be down over the next few days. If the download does not work just mail me and I'll send you the .exe. Thanks, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTAfoRAAoJEN0/YqbEcdMwhZsP/0iLEUg0B/KJ2bJdwtFX/DBg IamXt8oACRNpyMqVnEjmynxKOflomeo8rqELK46j0NhCeGzTNJaPzRgLrQ4L3w/0 5atPd/OnWIBRhoD06vXp1vCn5/EgqDqmU+U84bmbJev9lkhd1rLWqt3uHl8tWjxL VPphPbcriUCXhYjmaXdSD12oKJXYaLclYEXXTOjktFvSck18dfiohvypCHPDBlxp oGhFV/B4NtqHXy62O+vztIA+wisDbBtGUfni4WIdCX82H1kE9rEcpj6zhS638IHp xbiWtVsBYzYHqw6VVGUql2JipkYXTnrKBju7BQetd93KSJHFWnn4TdeOI3ggsAnU oQNR5lKmkG/PWVsMi23lVsZVrCmIau8BgSQQLWZgRUdJEHhj1+6hehabUNJVc49q TFhsSDxcNhbv3bLYrmJFhfQWQTFis/iGYcIRWqX+590ycaUEJmEmi5JsdcVdsxRv IlAhPXbAo1rZv/815ZBX4l8QdJecHiHyewhN74O6wG7EzGZaChLhP0dIuHRc6q9g EuICi7CYDrzv047vXELwePqxAkgQva6/JWd8GvzvVbh971qvWKMlB90p3HEHf42L WzB+bpXd1qsxfeXcbC2Cw2iTJWyjUoY1Zs1wbNEUgFXeIyjDYIkCXD1ADLOQqbJB mtimRynrUbtS9TJWwM4W =Z4Pf -----END PGP SIGNATURE-----

Feb. 17, 2014

Re: [PATCHv5 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Martin Storsjö

On Fri, 14 Feb 2014, Henri Verbeet wrote: > On 13 February 2014 14:52, Martin Storsjo <martin(a)martin.st> wrote: > >> + BYTE Y = (color >> 16) & 0xff; >> + BYTE U = (color >> 8) & 0xff; >> + BYTE V = (color >> 0) & 0xff; > It's probably just as easy to just store the separate components to begin with. Actually, since color can either be test_data[i].color1 or test_data[i].color2, splitting it per component would blow it up into Y1/Y2, U1/U2, V1/V2, and duplicating the condition for selecting color based on coordinate for all three components, so I think this format is simpler in the end. >> + hr = IDirect3DDevice9_StretchRect(device, surface, NULL, target, NULL, D3DTEXF_POINT); >> + ok(hr == D3D_OK, "IDirect3DDevice9_StretchRect failed with %#x.\n", hr); >> + >> + /* Native D3D can't resist filtering the YUY surface, even though we asked it not to >> + * do so above. To prevent running into precision problems, read at points with some >> + * margin within the rect. */ > That's not technically true, no filtering would be D3DTEXF_NONE. I > don't know if that's going to make a difference in practice though. I tested that now as well, and there's no difference, the sharp edges in the YUV texture are blurred when scaled up. I applied the other changes you suggested, those changes will be part of the next resend of the patchset. // Martin

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Alistair Leslie-Hughes

On 17/02/2014 10:07 PM, Michael Stefaniuc wrote: > On 02/17/2014 11:27 AM, Alistair Leslie-Hughes wrote: >> On 17/02/2014 8:04 PM, Marvin wrote: >>> Hi, >>> === w8 (32 bit client) === >>> Timeout >> Anybody know if DirectPlay is supported on Windows 8? > I doubt it is installed by default as it is deprecated but you should be > able to get it for 32bit Windows. It was never supported on 64bit and it > misses on all 64bit Windows versions. The testbot is 32bit, so maybe something else is going wrong. Can someone check if the dpnet.dll is installed by default? I currently don't have a access to a windows 8 machine. > >> It tests are timeout doing >> hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, >> CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); > Are you doing the interactive tests? Those do time out on Windows for > whatever reason. > No, the tests aren't interactive, so this shouldn't be the issue. All other windows version pass, so this windows 8 issue is confusing. Alistair

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Michael Stefaniuc

On 02/17/2014 11:27 AM, Alistair Leslie-Hughes wrote: > On 17/02/2014 8:04 PM, Marvin wrote: >> Hi, >> === w8 (32 bit client) === >> Timeout > Anybody know if DirectPlay is supported on Windows 8? I doubt it is installed by default as it is deprecated but you should be able to get it for 32bit Windows. It was never supported on 64bit and it misses on all 64bit Windows versions. > It tests are timeout doing > hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, > CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); Are you doing the interactive tests? Those do time out on Windows for whatever reason. > > For more details > https://newtestbot.winehq.org/JobDetails.pl?Key=4949&log_201=1#k201 bye michael

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Alistair Leslie-Hughes

On 17/02/2014 8:04 PM, Marvin wrote: > Hi, > === w8 (32 bit client) === > Timeout Anybody know if DirectPlay is supported on Windows 8? It tests are timeout doing hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); For more details https://newtestbot.winehq.org/JobDetails.pl?Key=4949&log_201=1#k201 Best Regards Alistair Leslie-Hughes

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4945 Your paranoid android. === w8 (32 bit client) === Timeout

Feb. 17, 2014

Re: [PATCH] comctl32/tests: Some tests for Button control

by Nikolay Sivov

On 2/17/2014 12:37, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> --- /dev/null >> +++ b/dlls/comctl32/tests/button.c >> @@ -0,0 +1,811 @@ >> +/* Unit test suite for Button control. >> + * >> + * Copyright 2014 Nikolay Sivov for CodeWeavers >> + * > If I read this patch correctly this is just a copy of button tests from > user32, and in that case please add all copyright notices from that file, > or just the authors of the copied code. > Done, easy way.

Feb. 17, 2014

Re: [PATCH] comctl32/tests: Some tests for Button control

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > --- /dev/null > +++ b/dlls/comctl32/tests/button.c > @@ -0,0 +1,811 @@ > +/* Unit test suite for Button control. > + * > + * Copyright 2014 Nikolay Sivov for CodeWeavers > + * If I read this patch correctly this is just a copy of button tests from user32, and in that case please add all copyright notices from that file, or just the authors of the copied code. -- Dmitry.

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4942 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

Feb. 17, 2014

Re: dpnet: Implement IDirectPlay8Client Initialize

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4941 Your paranoid android. === build (build) === Patch failed to apply

Feb. 17, 2014