February 2014 - Wine-Devel - list.winehq.org

Re: Fixing up the code style

by Frédéric Delanoy

On Sat, Feb 15, 2014 at 7:32 AM, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > ... > I agree, Sebastian and I have been debating what to do with this > function (and RtlAcquireResourceShared) for some time and style is the > only thing keeping us from submitting the one-line fix for these. > Honestly, it would be really great if we could run something like > astyle on the whole codebase so that we were always working off of a > "known good" style. Well, someone's "good style" is someone else's "bad style". For instance, I find "if(...)" constructs ugly, but some devs like it apparently, so if that's what's being used in the "surrounding code", it should be kept that way, for consistency. What could/should be fixed, IMO, is code which is obviously broken/unclear, but limited to the enclosing block, but that should happen quite often. Frédéric

Feb. 17, 2014

Re: Assorted spelling fixes

by Frédéric Delanoy

On Sun, Feb 16, 2014 at 10:14 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 16 February 2014 09:57, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: >> In my years of University the students were told to remember that >> 1Kb == 1024 bytes, 1Mb == 1024Kb and size prefixes should be written >> as a capital letter to emphasize its meaning. I'm very reluctant to >> change this practice to something else regardless of explanations and >> intents. I understand that for not technical people 1K == 1000, but >> I'd assume programmers are not of that kind. >> > Strictly speaking the SI units are kB, etc. for 1000 bytes, and IEC > KiB, etc. for 1024 bytes. For memory sizes, it's usually obvious > enough from context which one is meant, so there's not much of a point > to change it. It's more ambiguous for e.g. file or disk sizes where > drive vendors often use 1000 based units, and transfer speeds where > "b" usually means bits. > > But as I said, in most cases it's obvious enough from context, and > "KB" instead of "Kb" isn't really much clearer. Well, as François pointed out, b stands for bit, and not bytes. Basically the rationale for this patch was to fix spacing (space between number and unit name), and standardize the units abbreviations while doing that. k is SI, and is 1000, while K is 1024, unambiguously. KiB and MiB could have been used instead of KB/MB, but those aren't broadly used, albeit standardized now, while KB is much more used than kB (which isn't correct IMO; see above). Frédéric

Feb. 17, 2014

Re: Gifting steam/gog games to Wine developers

by Jerome Leclanche

On Sun, Feb 16, 2014 at 10:00 PM, Vincent Pelletier <plr.vincent(a)gmail.com> wrote: > On Sun, 16 Feb 2014 16:59:18 +0000, Jerome Leclanche > <adys.wh(a)gmail.com> wrote: >> I have a lot of unused Steam gift links from duplicates in my Humble >> Bundle purchases. I'd like to share those > > While I do like the idea, it may be prohibited by HIB use terms (is > that even what it's called ?). Better check this first. I recall > reading something along the lines that a bundle can not be resold/gifted > in whole nor in chunks. > > Of course, this has nothing to do with other gift origins. That used to be the case. They changed their policy and do offer gift links for all single games. What is not allowed is the resale of games, afaik. J. Leclanche > -- > Vincent Pelletier > >

Feb. 16, 2014

Re: [PATCH 5/5] ddraw/tests: Port test_private_data to ddraw4.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4935 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:3185: Test failed: SetDisplayMode failed, hr 0x80004001. === w8 (32 bit ddraw4) === ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001.

Feb. 16, 2014

Re: configure: Add import library for xmllite.

by Henri Verbeet

On 16 February 2014 15:17, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Henri Verbeet <hverbeet(a)gmail.com> wrote: > >> On 14 February 2014 08:23, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: >> > -WINE_CONFIG_DLL(xmllite) >> > +WINE_CONFIG_DLL(xmllite,,[implib]) >> That's auto-generated by make_makefiles from Makefile.in. > > Just a bit of clarification: does that mean that an import library > gets added once a Wine component (dll or an application) start to > require it and somebody adds a dependency to Makefile.in? Just that you should add a line "IMPORTLIB = xmllite" to dlls/xmllite/Makefile.in, then run tools/make_makefiles, and it will take care of updating configure.ac.

Feb. 16, 2014

Re: [PATCH 4/5] d3d8/tests: Add a test for sub resource private data.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4934 Your paranoid android. === w8 (32 bit device) === device.c:2572: Test failed: Expected foreground window 00030196, got 0002004E. device.c:3268: Test failed: Expected wndproc 0x410530, got 0x410530.

Feb. 16, 2014

Re: [PATCH 1/5] d3d9/tests: Clean up yuv_color_test (try 2).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4931 Your paranoid android. === w8 (32 bit visual) === visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff00ff00: Got color 0x00000000 for pixel 1/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff00ff00: Got color 0x00000000 for pixel 2/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff0000ff: Got color 0x00000000 for pixel 1/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff0000ff: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00ffff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00ffff00: Got color 0x00000000 for pixel 2/1, expected 0x004bffff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00ff00ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00ff00ff: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x0000ffff: Got color 0x00000000 for pixel 1/1, expected 0x004bffff, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x0000ffff: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffffff00: Got color 0x00000000 for pixel 1/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffffff00: Got color 0x00000000 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffff00ff: Got color 0x00000000 for pixel 1/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffff00ff: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xffffffff: Got color 0x00000000 for pixel 1/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xffffffff: Got color 0x00000000 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x4cff4c54: Got color 0x00000000 for pixel 1/1, expected 0x000b8b00, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x4cff4c54: Got color 0x00000000 for pixel 2/1, expected 0x00b6ffa3, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x00800080: Got color 0x00000000 for pixel 1/1, expected 0x0000ff00, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x00800080: Got color 0x00000000 for pixel 2/1, expected 0x0000ff00, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0xff80ff80: Got color 0x00000000 for pixel 1/1, expected 0x00ff00ff, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0xff80ff80: Got color 0x00000000 for pixel 2/1, expected 0x00ff00ff, format D3DFMT_YUY2. visual.c:10473: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10482: Test failed: Input 0x1c6b1cff: Got color 0x00000000 for pixel 1/1, expected 0x006dff45, format D3DFMT_YUY2. visual.c:10486: Test failed: Input 0x1c6b1cff: Got color 0x00000000 for pixel 2/1, expected 0x0000d500, format D3DFMT_YUY2.

Feb. 16, 2014

Re: Gifting steam/gog games to Wine developers

by Vincent Pelletier

On Sun, 16 Feb 2014 16:59:18 +0000, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > I have a lot of unused Steam gift links from duplicates in my Humble > Bundle purchases. I'd like to share those While I do like the idea, it may be prohibited by HIB use terms (is that even what it's called ?). Better check this first. I recall reading something along the lines that a bundle can not be resold/gifted in whole nor in chunks. Of course, this has nothing to do with other gift origins. -- Vincent Pelletier

Feb. 16, 2014

FOSDEM - Videos now watchable

by Marcus Meissner

Hi, The FOSDEM Videos have been uploaded with correct sound again. http://wiki.winehq.org/FOSDEM2014 has our index. Or more direct links: http://video.fosdem.org/2014/AW1120/Sunday/ If you have not uploaded your slides, please do :) Ciao, Marcus

Feb. 16, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-16 20:39, schrieb Christopher Thielen: > fixme:d3d:wined3d_debug_location Unrecognized location flag(s) > 0xfffffc00. These lines are harmless. That's pretty much code doing something like this TRACE("Removing flags %s.\n", wined3d_debug_location(~WINED3D_LOCATION_SYSMEM); which ends up passing a value like 0xfffffffe to wined3d_debug_location. wined3d_debug_location then does something like if (flags & (SYSMEM | BUFFER | ALL | DEFINED | FLAGS)) FIXME("Unrecognized location flag(s) %#x.\n", flags); What is missing here is a logical and that filters out unknown flags in places where a bitwise not is used, or maybe just the removal of the unknown flags fixme in wined3d_debug_location. > Unfortunately, there is no reference to "ddraw7_GetCaps" or > "GetCaps" anywhere in the 975 MB log. That confirms it isn't using > overlays, right? Pretty much, yeah. > fixme:d3d:debug_d3dusage Unrecognized usage flag(s) 0x10000000 That's WINED3DUSAGE_TEXTURE and needs to be added to the debug function. > This gog.com version uses nGlide to wrap the Glide API to DirectX > calls - DX9 I believe, based on the requirements of nGlide > (http://www.zeus-software.com/downloads/nglide) Not sure if this > information helps. This means the GOG version is using an entirely different codepath than what you're trying to run. It is quite possible that the codepath you're running is broken in some way. I recommend to test if the game's ddraw codepath is working properly on Windows before you bang your head against it. It can save you a lot of time :-) . If it turns out that the ddraw codepath is working just fine on Windows 7 there's certainly value in fixing it. If it is not, but it is working on e.g. Windows XP, it might still be worth a look. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTARfAAAoJEN0/YqbEcdMwSC0P/1iZxKSLjIqEXeDmPsy7ARU9 vWm0Uqo0SYdCAEemGA2vD53IuojRUyMZ9E0ikfCZ7qlVK7uaFs54TtiY15C+p6ic gZhNezdyt/6idLootvCsJ9ZDoSaFdIDvoWga7JThwlZnfGVVZIGj6WeJeTV+rXon QHkQO/jghlHpgZIT6mdicvsltaWujg+Idwfuz1Z8i8+fKEhy7Uvp+QKCqsF8JdNf AuDceOPwF8aaH0YWVieyQfTiqzv4RHTnF5i+LGWPx61SRuRXi2YT+2hHlTbspua2 6/FfQ+c2P6eoI39UiRysWL8+zB+T0o5V0JOF2PD5EJGqc+vP4066XkxZlA7Kdl6W h8RCzDbU+gxeq49cXHTG6AbvLUdkbDowo/dwW6x4wOmnlzZBW5CNxF0NbQ0Jf4sW mQLynduNdejnqgwZSFb5m8AoTqCZ+XbLkGq5uPAcAz6TIlsrKW7oQ41rTkeLxpU/ Z5nlLDmC5MIP8t8he2KuLu8eVrLhSsxYFEyeevhHY/SvNkmi1LxkXJMQHt8gDpdi 3ZW+LuW5nsOJ/9T7vH27ENorqRNtpFWnpdwPMyBgQJbPlNCYVp5ZTKE8WHpk+fk4 T+LzzbOlli8svOLHll4rmDhD89qYiQQUWNv7V7XjTHrgrxpZFY5aLXrprEGTc6Kc PCO4omr8MIkjrtJAHfKX =evKW -----END PGP SIGNATURE-----

Feb. 16, 2014