February 2014 - Wine-Devel - list.winehq.org

Re: ws2_32: Fix some edge cases for getaddrinfo in BSD and OSX

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4901 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (b34): unexpectedly at the OOB mark: 0 === wvistau64 (32 bit sock) === sock.c:557: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 753E9799 === w2008s64 (32 bit sock) === sock.c:547: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757C9799 === wvistau64 (64 bit sock) === sock.c:557: Test failed: oob_server (b5c): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:547: Test failed: oob_server (a54): unexpectedly at the OOB mark: 0 sock.c:557: Test failed: oob_server (a54): unexpectedly at the OOB mark: 0 sock.c:326: Test failed: do_synchronous_recv (a54): error 10054: sock.c:572: Test failed: oob_server (a54): not at the OOB mark: 1

Feb. 14, 2014

Re: [PATCH 5/5] tests: Allow broken results to cause failures on the "windows" platform as well.

by Alexandre Julliard

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > include/wine/test.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/wine/test.h b/include/wine/test.h > index f8b608f..c81fe11 100644 > --- a/include/wine/test.h > +++ b/include/wine/test.h > @@ -208,6 +208,9 @@ const char *winetest_platform = "windows"; > /* report successful tests (BOOL) */ > static int report_success = 0; > > +/* fail on broken() */ > +static int fail_broken = 0; > + > /* passing arguments around */ > static int winetest_argc; > static char** winetest_argv; > @@ -289,7 +292,7 @@ void winetest_set_location( const char* file, int line ) > > int broken( int condition ) > { > - return (strcmp(winetest_platform, "windows") == 0) && condition; > + return !fail_broken && condition; > } > > /* > @@ -636,6 +639,8 @@ int main( int argc, char **argv ) > if (GetEnvironmentVariableA( "WINETEST_DEBUG", p, sizeof(p) )) winetest_debug = atoi(p); > if (GetEnvironmentVariableA( "WINETEST_INTERACTIVE", p, sizeof(p) )) winetest_interactive = atoi(p); > if (GetEnvironmentVariableA( "WINETEST_REPORT_SUCCESS", p, sizeof(p) )) report_success = atoi(p); > + if (GetEnvironmentVariableA( "WINETEST_FAIL_BROKEN", p, sizeof(p) )) fail_broken = atoi(p); > + else fail_broken = strcmp( winetest_platform, "windows" ); Couldn't you simply set the platform to "windows_broken" or something like that? -- Alexandre Julliard julliard(a)winehq.org

Feb. 14, 2014

Re: ntdll: add a stub for NtSetLdtEntries/ZwSetLdtEntries

by Dmitry Timoshkov

Austin English <austinenglish(a)gmail.com> wrote: > On Mon, Jan 27, 2014 at 3:48 PM, Austin English <austinenglish(a)gmail.com>wrote: > > > Fixes http://bugs.winehq.org/show_bug.cgi?id=26268 (tested with Kwik > > Support). > > > > -- > > -Austin > > > > Any comments on this patch? It's clearly wrong. -- Dmitry.

Feb. 14, 2014

Re: dpnet: Use registry for lookup in IDirectPlay8Peer (try 2)

by Alistair Leslie-Hughes

Hi Bruno, On 14/02/2014 8:30 PM, Bruno Jesus wrote: > On Fri, Feb 14, 2014 at 5:28 AM, Alistair Leslie-Hughes > Not really, because when you add a size to a pointer it increments in > the pointer size and not bytes. So WCHAR *ptr=0; ptr+=10; > printf("%p\n", p); would print 0x14 (20 in decimal although we just > added 10 to it). The theory is correct. However RegGetValueW returns the size of the buffer we would need to allocate including the null terminator. In your example it would return 20 (9+1*sizeof(WCHAR)) and not 10. Best Regards Alistair Leslie-Hughes

Feb. 14, 2014

Re: dpnet: Use registry for lookup in IDirectPlay8Peer (try 2)

by Bruno Jesus

On Fri, Feb 14, 2014 at 5:28 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi Bruno, > > > On 14/02/2014 10:18 AM, Bruno Jesus wrote: >> >> On Thu, Feb 13, 2014 at 1:23 AM, Alistair Leslie-Hughes >> <leslie_alistair(a)hotmail.com> wrote: >> You are only reading the key value in the first loop to trace it, >> maybe you could simplify this loop with a single RegGetValueW call and >> no memory allocation just to get the size required and in the next >> loop where you really copy the data you could trace it. > > > Thanks for you feedback. I've re-factored the patch and it's alot cleaner > than the first few iterations. > > Its still needs to be a char cast since RegGetValueW returns the size in > bytes which would make the offset incorrect. Not really, because when you add a size to a pointer it increments in the pointer size and not bytes. So WCHAR *ptr=0; ptr+=10; printf("%p\n", p); would print 0x14 (20 in decimal although we just added 10 to it). > Best Regards > Alistair Leslie-Hughes Bruno

Feb. 14, 2014

Re: [PATCH 1/5] d3d9/tests: Clean up yuv_color_test.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-14 00:08, schrieb Marvin: > === w8 (32 bit visual) === visual.c:10474: Test failed: Failed to > draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test > failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, > expected 0x00008700, format D3DFMT_YUY2. visual.c:10487: Test > failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, > expected 0x00008700, format D3DFMT_YUY2. Patch 2 fixes those issues. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/dYtAAoJEN0/YqbEcdMwnUkP/R/jBsozPhUxXxuQ4hYmDHmi ZLeWZIzp7KwEjJB+UxzpZlDKOCtPc5lfhIxYIViqviF9XRx/rAoVMJp5TFoRQNT5 RQVe6hO1cnXexGOZ0MHE11w51lsV49XEtPXntyb8jTGyhFpsMvJrIX6Kb8spqlG+ YMzUdHO2fzFpTnDiR2unOnGZwwHXbkz8XWWkdwJuF2xzUj3GEutd03OxXawPcWcR mdvxg+XphWNevxsaNCv7z8jknu7VycVhXfPB9bdCHN91iOFACh9b6nmp6pfPAVHm NDnycvPXQj3wi8e49uhFE2nvPqmXc0jpdGn0XNk3bQ2Jpu5QSczpQQkVehhjbcJ2 cSAO1W+uc9eIkILnd1enLtrwJv82ySf3cXMzBcXpex9q9LgL/A5zM3mIetjQEWJS zOYeBGxD6PoMeMoqdjZcwstE6FxUHdH7E9b4Wbe2iNXA4EEeQO46ALKydjCzxe+l x2YUOWR5ArMLFJzCQYdD2E+SOw21urO9+FiwDqHlAHj5AcHoEi20R5a5Nw2amlt7 q9PR8suYjxnlOEk7yW6Gn7ppAQNGqbR9cR03oPdjkjhl6M+Z9Bjbq/y6WcOKCzHg wPCpOxVwTARL46N6q4vdHyxXBrqyWy+oqFXjTzr3aChsVfxQ51AZ/savzFluau8E qYNb8N0PvYPB6DgGPCbx =5Znm -----END PGP SIGNATURE-----

Feb. 14, 2014

Re: dpnet: Use registry for lookup in IDirectPlay8Peer (try 2)

by Alistair Leslie-Hughes

Hi Bruno, On 14/02/2014 10:18 AM, Bruno Jesus wrote: > On Thu, Feb 13, 2014 at 1:23 AM, Alistair Leslie-Hughes > <leslie_alistair(a)hotmail.com> wrote: > You are only reading the key value in the first loop to trace it, > maybe you could simplify this loop with a single RegGetValueW call and > no memory allocation just to get the size required and in the next > loop where you really copy the data you could trace it. Thanks for you feedback. I've re-factored the patch and it's alot cleaner than the first few iterations. Its still needs to be a char cast since RegGetValueW returns the size in bytes which would make the offset incorrect. Best Regards Alistair Leslie-Hughes

Feb. 14, 2014

Re: [PATCH 5/7] ddraw/tests: Test that DirectDraw4 doesn't modify the pixel format of the window it targets.

by Ken Thomases

On Feb 13, 2014, at 7:01 PM, Marvin wrote: > === w8 (32 bit ddraw4) === > ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001. Not related to my patch. -Ken

Feb. 13, 2014

Re: [PATCH 5/7] ddraw/tests: Test that DirectDraw4 doesn't modify the pixel format of the window it targets.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4892 Your paranoid android. === w8 (32 bit ddraw4) === ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001.

Feb. 13, 2014

Re: [PATCH 3/7] d3d8/tests: Test that Direct3D8 doesn't modify the pixel format of the window it targets.

by Ken Thomases

On Feb 13, 2014, at 6:35 PM, Marvin wrote: > === w8 (32 bit device) === > device.c:2572: Test failed: Expected foreground window 00030196, got 0002004E. > device.c:3268: Test failed: Expected wndproc 0x4100c0, got 0x4100c0. Not related to my patch. -Ken

Feb. 13, 2014