February 2014 - Wine-Devel - list.winehq.org

Re: [PATCHv3 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4869 Your paranoid android. === w8 (32 bit visual) === visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0xff7dff. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0xb800ee. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0xffe114. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0x4affff. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0x4affff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0xb80000. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0xb80000. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0xffe114. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0x24ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0x24ee. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0xb800ee. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0x4aff14. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0x4aff14. visual.c:10636: Test failed: IDirect3DDevice9_StretchRect failed with 0x8876086c. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(0/4), pixel 80 60, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(0/4), pixel 240 60, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(0/4), pixel 400 60, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(0/4), pixel 560 60, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(1/4), pixel 80 180, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(1/4), pixel 240 180, expected 0xff7dff. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(1/4), pixel 400 180, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(1/4), pixel 560 180, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(2/4), pixel 80 300, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(2/4), pixel 240 300, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(2/4), pixel 400 300, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(2/4), pixel 560 300, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (0/4)/(3/4), pixel 80 420, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (1/4)/(3/4), pixel 240 420, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (2/4)/(3/4), pixel 400 420, expected 0x8800. visual.c:10649: Test failed: Format D3DFMT_YUY2: Got color 0 for pixel (3/4)/(3/4), pixel 560 420, expected 0x8800.

Feb. 13, 2014

Re: [PATCHv2 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Martin Storsjö

On Thu, 13 Feb 2014, Stefan Dösinger wrote: > You still have a few formatting issues in this patch, I've quoted the > ones I found below. The quotes seem to be missing, but I think I found the places you referred to. I'll resend the full set now. // Martin

Feb. 13, 2014

Re: [PATCHv3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Two more non-functional nitpicks: Am 2014-02-13 11:16, schrieb Martin Storsjo: > +static void arbfp_free_blit_shader(struct wine_rb_entry *entry, void *context) > +{ > + const struct wined3d_gl_info *gl_info = context; > + struct arbfp_blit_desc *entry_arb = WINE_RB_ENTRY_VALUE(entry, struct arbfp_blit_desc, entry); > + > + GL_EXTCALL(glDeleteProgramsARB(1, &entry_arb->shader)); > + checkGLcall("glDeleteProgramsARB(1, &entry_arb->shader)"); > + HeapFree(GetProcessHeap(), 0, entry_arb); > +} Please add a comment /* Context activation is done by the caller. */ above the function. While you're at it, please also add it above gen_p8_shader. It is not necessary to add this comment above gen_planar_yuv_read and gen_nv12_read because those functions do not call OpenGL functions. > + switch (fixup) > + { > case COMPLEX_FIXUP_P8: > - shader = textype == GL_TEXTURE_RECTANGLE_ARB ? priv->p8_rect_shader : priv->p8_2d_shader; > - if (!shader) shader = gen_p8_shader(priv, gl_info, textype); > - > - upload_palette(surface, context); > + shader = gen_p8_shader(priv, gl_info, textype); > break; > > default: > + shader = gen_yuv_shader(priv, gl_info, fixup, textype); > + break; > + } Please add 4 spaces of indentation, like this switch (fixup) { case foo: code(); more_code(); break; case bar: other_code(); break; } Other than that the code looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/K4ZAAoJEN0/YqbEcdMwHzoP/0/wPibZu3Jy3MAlACpiPlq9 0inM3Egyh/qfYw7Qi8I+2eaAYZKZYy9LZDJ89fXjS87Ip8v+ryoGMXpLeCGgGze4 VV7F/mr/V7OKHs6ObFipmO4pEgqYn6gbc5x87SCuHvEwz70CUOfZiTPzt94d71Z4 Hr69M6wSU4DNOndOr83pJNjEQAff9qIecvNZwp/xlvgg/rZSdr3uMBLap/fJmAGy NtbJVgIAtCovkANBTDmE55U8bPQLdRQapZbBH+JQN3LMxmg3C4pJ++Wnc/1kRmmv 3ZvVSBHdwTK7dPuLx7aGl66gMYo9IdyGUYvD+Jk2GchfhRowwC2FcWDhLEDRhWpd ahQnoa8bTuKgtlTwygWZLm748e8asaC1Chcr5pKj+IZDo/F/qq6U46LL9K5SBFC1 1sTjF578QQ3K5LiCrGv6ivsHvJq+JkwQz0QxDhqJ4Bs0lJ5LEvC54l7XjumDvtfg 8+4slUf/FKhZNjgp/XRF/qip1+hwMehZULlHIo0CBzSjBiNxxKA+IQq/CeKfjAMa cjPkhRW42H/l47IJthepxuMaoNO5WAp75TXha2vwHQY/Axs8AsKqyzTyImuMa50U b+kHVilfW9hjSJWSGbLb7JgCurgTMKHkt1W2+6OQpbFOBrCihr3uQWAifo8+IuTP 3U5Y0hUe8rU9IKyDS0eO =AU5Y -----END PGP SIGNATURE-----

Feb. 13, 2014

Re: [PATCHv2 3/3] d3d9/tests: Add tests for different YUV texture layouts

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, You still have a few formatting issues in this patch, I've quoted the ones I found below. I ran the test on my Windows boxes and it passed on the following devices: Windows 7 x86_64, Radeon HD 5770 Windows 7 x86_64, Radeon X1600 Windows 7 x32, Nvidia GeForce 9600 Windows Vista x32, Nvidia GeForce 7400 It did not pass on my very ancient Windows XP x32 laptop with a Radeon 9000 Mobility. It fails there the same way as on the testbot - the card claims to support YUY2 and YV12, but the StretchRect call fails with D3DERR_INVALIDCALL. Do you have any idea why that might happen? If not maybe the best solution is to accept the error with broken() and skip the rest of the test. There's IDirect3D9::CheckDeviceFormatConversion, but according to msdn it only tests backbuffer and adapter format compatibility. That's not the way we implement it, but I don't think we have tests to find out how it's really supposed to behave. Fwiw none of the above machines claims I420 support. There are plenty of other odd formats though. Am 2014-02-12 21:05, schrieb Martin Storsjo: Use 8 space indentation vs the first line of the if and put the && into the next line. Same as above. Curly bracket placement. Same. 8 space indent on line contiuation as in if conditions. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/KsdAAoJEN0/YqbEcdMwckoP/RTST4uApXJwApHZeP5DC7M9 9gN0k8G/zKFN/79I9RPC/fVhMbk/uniloVK+uuYwKmNsoFLRnT1ikg320D09KclZ R1+sLK3Cr9x8lR9NAbR/NsCglRupoE3qX916T1QVApWgeGb9WvExkto6rP+DhI8L sw5T/Rtr3odiMKdSXyllXNgZl0cljhd821OXn5bl6A1VpRO5tXJr7WFfMSIl5TUT VDOub/n2bPwKB38wUwxSgd+m/9hgl+4U+z4V1gfyichgVp4gZKSRH+mr96WI3trc eGjWxtH4+kk1LLshxjCaQOJ0fqoMDQbxJjUBtkAqSKYbCvd7KEfbcTcyKfd4mOHX ZgTqsMRlB/jVK2ugmojf2JgCasecDhENcibjOH2DHXe2SbUUx/QV7cFzjGEGiMNj fOBW0B/f1WJHuyYcKrpw1EWhsR4lFjM6uehmNC+ndA78zy5NPg15U6iBS0ArwZLN kSqbUd6VJy74zVs8CH/v6/cbjUhHguyYcO77/I7k9CMVV3rssgO2oV4GyOnfJGZg dLqN+mQGD3mZhhBhTZrqmuSK1BoPMgA89O7kbJB/x+l3f5XNuCmCxzK4ydgUsr11 kJ/gjrnc51/snAE61+qUZ7sxvGdJKqNdk19Xwrtjp7z2NIcJaNVT8qB41JJFrr4/ Woj0DvcYK1wrmPg8XSJ3 =Hogg -----END PGP SIGNATURE-----

Feb. 13, 2014

Re: [PATCHv2 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-12 21:05, schrieb Martin Storsjo: > + entry = wine_rb_get(&priv->shaders, &type); > + if (entry) > { > - case COMPLEX_FIXUP_YUY2: > - shader = textype == GL_TEXTURE_RECTANGLE_ARB ? priv->yuy2_rect_shader : priv->yuy2_2d_shader; > ... > - break; > - > + struct arbfp_blit_desc *desc = WINE_RB_ENTRY_VALUE(entry, struct arbfp_blit_desc, entry); > + shader = desc->shader; > + } > + else > + { > + switch(fixup) > + { > case COMPLEX_FIXUP_P8: > - shader = textype == GL_TEXTURE_RECTANGLE_ARB ? priv->p8_rect_shader : priv->p8_2d_shader; > - if (!shader) shader = gen_p8_shader(priv, gl_info, textype); > ... > + } > } You'll have to execute upload_palette before running the p8 shader, not just when generating it. > struct arbfp_blit_priv { > - GLenum yuy2_rect_shader, yuy2_2d_shader; > - GLenum uyvy_rect_shader, uyvy_2d_shader; > - GLenum yv12_rect_shader, yv12_2d_shader; > - GLenum nv12_rect_shader, nv12_2d_shader; > - GLenum p8_rect_shader, p8_2d_shader; > + struct wine_rb_tree shaders; > GLuint palette_texture; > }; When you're resending the patch please take the opportunity to move the opening { to its own line. Otherwise the patch (and the first one) looks good to me. Thanks for your perseverance :-) . I'll run the test in patch 3 on my Windows machines and report back. I ran the earlier version it on the Radeon X1600 + Win7 box yesterday. It passed, NV12 was supported, I420 was not. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/JOCAAoJEN0/YqbEcdMwmCgP/2SeBnj9x5Nm3iWAQnqwEHs9 1ECpmmuCkbEcjOgxCrZEQWf7iv9RyrX3iEjyjqs5JJfpckOFEH51ydb+7JQpG/Q4 3+gLlXA1R5Qnku+Iz+gS6JW3aRSGIowlnbWTsggrqj71FzonFroy71z1NRsVmIQI f8SpgmtSVRSUoQ3b3K0Zc2zUb6+oaBsk55zRC8W37RejA73Alsc+C3vad+mFpMxQ xOtVkCyMqMGIxvb+llUygSMVf7oIT8AbAW0Yy6RMzS4FElG41HkCk1tTWI93v6b1 Aq064B6nZ7fkSqktwMpxdP8+xxQpuUUSWL4jA3ydq0UNoK7CrPQJlsP/ePtMBVkb 4yylQeVw+2Z2LbeDOJWbtLCQXVuJdvii1ULjlQciWSMvABmLy04pb8NqRAzvYfrL WL12mLfjKmA+9oylMbFll321vIXyoIyOBvSITLrEolAOUGU+xZu+pdIR8lVoyJpQ Djdu2zRmQnKIv3Q8zFQsdk201xKI9SqZScQHO68IwqqyNK5cyhIg91d7lFDlMFJx BihHAXW61O+fZfz1Q+SGWEztaFYYNZouBhFo0F7odjCHHGodNjVtLVJaa6N7fLHA rEek5LL+Uj2kzg4r+t3EnpSn+qhwZ3kOQYgyNqHlvY/m1MqvDRBp5Ln0RU0qtFHm rhaw1CZsViF5dlKEB72H =7Xyb -----END PGP SIGNATURE-----

Feb. 13, 2014

Re: FOSDEM Videos - previews

by Marcus Meissner

Hi, I dropped the video guys at fosdem an email again. Its basically in their hands to reencode it again :( Ciao, Marcus On Wed, Feb 12, 2014 at 03:00:16PM -0800, Scott Ritchie wrote: > Are there currently watchable videos with working audio anywhere? > > On Thu, Feb 6, 2014 at 9:29 AM, Marcus Meissner <meissner(a)suse.de> wrote: > > Hi, > > > > The FOSDEM Video team is still processing our videos. > > > > But! Previews can be checked out at: > > > > http://video.fosdem.org/2014/previews/AW1120/2014-02-02/ > > > > > > They are basically in order of appearance. The filenames > > are UTC (so Bruessel - 1 hour). > > > > (timetable:) > > https://fosdem.org/2014/schedule/track/wine/ > > > > Notes: > > - We only got the master recording laptop around 9:10, > > so Alexandres keynote is mostly lost in time and space. > > > > I did not dare him to redo it for us ;) > > > > - I failed to select the +48V switch in fear of blowing > > up the microphone. > > > > So sound arrived at 42:20 in the Pipelight Talk after > > the audio angel helped us. > > > > Sound is only on the left side. > > > > - The presenter laptop->slave laptop firewire cable was broken, > > so it only started working for Rosannes talk. > > (Its also the reason her talk is cut into various pieces > > as we rebooted the machines inbetween.) > > > > - Talks after Rosannes are good. > > > > - As there were no BOF topics, the recording slot is empty. > > - We did not record the blame session. > > > > Ciao, Marcus > > > > >

Feb. 13, 2014

Re: Strange behavior from native OpenGL

by Roderick Colenbrander

Hi Ken, The problem you explain is indeed strange. I have never encountered this issue with opengl32 before. I tried to find a bug in the test, but didn't really see anything strange. If your theory about wglCreateContext being needed to 'heat things up' is true, maybe it has to do with ICD loading. Assuming you picked a pixel format, which requires the hw vendor's ICD, I believe wglCreateContext kicks of driver initialization unless it is done implicitly at an earlier stage (something happens for sure earlier for pixel format enumeration). Various ICD provided functions like the ICD version of wglGetProcAddress are loaded at time and I wouldn't be surprised if that is also when they hook up the ICD versions of MakeCurrent, CreateContext, SetPixelFormat, GetPixelFormat and others. Just a wild guess. Thanks, Roderick On Wed, Feb 12, 2014 at 6:46 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > Hi, > > I have been working on refining a d3d9 test patch I recently submitted < > http://source.winehq.org/patches/data/102263> and noticed a strange > behavior when running on a real Windows machine. I'm wondering if anybody > is familiar with it or can check my reasoning. > > The strange behavior is that a failed call to wglCreateContext() must be > done before SetPixelFormat() will work properly. The call to > wglCreateContext() has to fail because it can't succeed until > SetPixelFormat() has been done. And yet it still seems to be necessary. > > My test does the following sequence: > > CreateWindowA() > GetDC() > ChoosePixelFormat() > SetPixelFormat() > GetPixelFormat() > > This seems fairly simple, straightforward, and commonplace. Although > everything through the SetPixelFormat() indicates success, the > GetPixelFormat() call still returns 0. This causes the test to be skipped. > This happened on the testbot, but I assumed that was caused by the VM's > display driver. However, when I got the chance to try on a real Windows > machine, it happened there, too. > > I looked around to see if the same sort of thing is done elsewhere in > Wine. It's done in the opengl32 tests in test_setpixelformat() < > http://source.winehq.org/source/dlls/opengl32/tests/opengl.c#L254> and it > works there, both on the testbot and the Windows machine. > > So, then I figured it must be working in those tests because of stuff that > is done beforehand. I disabled most of the opengl32 tests other than > test_setpixelformat(). That was testbot job < > https://newtestbot.winehq.org/JobDetails.pl?Key=4751> and it still passed > on the testbot and real Windows. > > I then disabled the expected-to-fail call to wglCreateContext() that is > done in the test main entry function (START_TEST(opengl)). Once that is > disabled, test_setpixelformat() starts failing in the same way as my d3d9 > test. That is testbot job < > https://newtestbot.winehq.org/JobDetails.pl?Key=4752>. > > So, can it really be that a failed call to wglCreateContext() is necessary > before SetPixelFormat() will work properly? > > One thing that I haven't had the chance to test yet is whether a > wglCreateContext() call _after_ SetPixelFormat() will cause a subsequent > GetPixelFormat() to return the right format. That is, perhaps > SetPixelFormat() has worked and the pixel format is remembered, but it's > only "realized" once wglCreateContext() is called. And GetPixelFormat() > only returns realized pixel formats. > > Also, it's possible that it's sufficient to call any opengl32 function and > not wglCreateContext() specifically. (ChoosePixelFormat(), > SetPixelFormat(), and GetPixelFormat() are gdi32 functions.) > > In any case, that would mean that my d3d9 test will have to link with > opengl32 and call one of its functions. > > -Ken > > > >

Feb. 13, 2014

Re: dpnet: Improve Error checking in Get/Set SP (try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4854 Your paranoid android. === w8 (32 bit address) === Timeout

Feb. 12, 2014

Re: wininet: Fix InternetGetConnectedStateEx[A|W] (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4853 Your paranoid android. === w8 (32 bit internet) === internet.c:203: Test failed: Got wrong error code 0 internet.c:690: Test failed: sz wrong, got 16, expected 14 or 30 internet.c:701: Test failed: cookie data wrong internet.c:1073: Test failed: GetLastError() = 0

Feb. 12, 2014

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (resend).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4848 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (b2c): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

Feb. 12, 2014