February 2014 - Wine-Devel - list.winehq.org

Re: msvcrt: Return error on invalid handle in _open_osfhandle (try4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4819 Your paranoid android. === wxppro (32 bit file) === file.c:2202: Test failed: info->exflag = 1, expected 4

Feb. 12, 2014

Re: shell32/tests: Skip any test that needs the .shlexec association if we could not create it.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4818 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:1211: Test failed: expected 1 args, got 4 shlexec.c:2283: Test failed: argcA expected 5, but got 4 === w2008s64 (32 bit shlexec) === shlexec.c:1564: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt6C3.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt6C3.tmp\test file.shlexec' shlexec.c:2660: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt6C3.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt6C3.tmp\test2.exe' shlexec.c:2673: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt6C3.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt6C3.tmp\test2.exe' shlexec.c:2685: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt6C3.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt6C3.tmp\test2.exe' === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\wt8C15.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\wt8C15.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2102: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt8C14.tmp\wt8C15.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1564: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt249F.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt249F.tmp\test file.shlexec' shlexec.c:2660: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt249F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt249F.tmp\test2.exe' shlexec.c:2673: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt249F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt249F.tmp\test2.exe' shlexec.c:2685: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt249F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt249F.tmp\test2.exe'

Feb. 12, 2014

Re: ole32/tests: Use wine_dbgstr_guid for printing GUIDs.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4817 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:3054: Test failed: wait timed out marshal.c:3058: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 0041C45C === w8 (32 bit marshal) === marshal.c:3315: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3332: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3370: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3388: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3352: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3315: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3332: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3370: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3388: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3352: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3315: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3332: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3370: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3388: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0xc04 instead of 0xb00 marshal.c:3352: Test failed: info->cbSize was -873875100 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0xc04 instead of 0xb00

Feb. 12, 2014

Re: [PATCH 5/5] d3d10core: Implement d3d10_depthstencil_view_GetDevice().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4815 Your paranoid android. === wvista (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. device.c:244: Test failed: Got unexpected refcount 4. device.c:248: Test failed: Got unexpected refcount 6. device.c:253: Test failed: Got unexpected refcount 7. device.c:298: Test failed: Got unexpected refcount 4. device.c:303: Test failed: Got unexpected refcount 5. === w2008s64 (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. device.c:244: Test failed: Got unexpected refcount 4. device.c:248: Test failed: Got unexpected refcount 6. device.c:253: Test failed: Got unexpected refcount 7. device.c:298: Test failed: Got unexpected refcount 4. device.c:303: Test failed: Got unexpected refcount 5. === w2008s64 (64 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. device.c:244: Test failed: Got unexpected refcount 4. device.c:248: Test failed: Got unexpected refcount 6. device.c:253: Test failed: Got unexpected refcount 7. device.c:298: Test failed: Got unexpected refcount 4. device.c:303: Test failed: Got unexpected refcount 5.

Feb. 12, 2014

Re: [PATCH 4/5] d3d10core: Implement d3d10_buffer_GetDevice().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4814 Your paranoid android. === wvista (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. device.c:288: Test failed: Got unexpected refcount 4. device.c:293: Test failed: Got unexpected refcount 5. === w2008s64 (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. device.c:288: Test failed: Got unexpected refcount 4. device.c:293: Test failed: Got unexpected refcount 5. === w2008s64 (64 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. device.c:288: Test failed: Got unexpected refcount 4. device.c:293: Test failed: Got unexpected refcount 5.

Feb. 12, 2014

Re: [PATCH 3/5] d3d10core: Implement d3d10_texture3d_GetDevice().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4813 Your paranoid android. === wvista (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. === w2008s64 (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5. === w2008s64 (64 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. device.c:165: Test failed: Got unexpected refcount 4. device.c:170: Test failed: Got unexpected refcount 5. device.c:184: Test failed: Got unexpected refcount 4. device.c:189: Test failed: Got unexpected refcount 5.

Feb. 12, 2014

Re: [PATCH 2/5] d3d10core: Implement d3d10_texture2d_GetDevice().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4812 Your paranoid android. === wvista (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. === w2008s64 (32 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5. === w2008s64 (64 bit device) === device.c:76: Test failed: Got unexpected refcount 4. device.c:81: Test failed: Got unexpected refcount 5. device.c:95: Test failed: Got unexpected refcount 4. device.c:100: Test failed: Got unexpected refcount 5.

Feb. 12, 2014

Re: [PATCH 6/6] d3d9/tests: Add tests for different YUV texture layouts

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I sent two patches that should get rid of the texture_rectangle crashes. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS+1rLAAoJEN0/YqbEcdMwmt0P/A1mB/aCzixb9Anw9NNvOkyL Ued/hk5aKfzC7Fbx3VOGsd1+2UcI5EHUFRTRU0Hxa/GQiG96nxIRXnYxCFfJVPxH nS5iqpRTD4ej8V0LyioID11hbueTARhKYUBCztXDJkglys2hgso2nKmoyzSn+Ftt JvCP5tTCU5abdDSyTxo/ae//1ZnzbzZvEGJ+ZUKNv/vzwXd50vPoTdstip8VnFzQ 8gq405aZ6AzrihfDowthekvO4++81xfZYzpim4HTio1tBJw64OkUbGPWa2UjKoCD mkLbiUbzuCEm5hj/DUbPralzGOl6a6TYoK5xbarQAVetQOKKgtCtt/+4EVvbr2lT lWKVG6ZRmV31bSMzO+ynvr1zzIlQ04RsAZfpI4RHTG9lEfC3OFMKt8Hw57d84Cnw 3jWWroAgmUtxwO3HWWsTyk6EUe8l2oMjgdgjh3bleCiaRJ0xrL8R4otjJR0nQYCQ GLRm6INJgXxMVkRwH7xYz7wKQFavSvgKRkqr3fIgEZ/BwnIiIJJImT0/uO0YWfUX WCUU3nuGIPhJ0nWUx1XoshL4JKYJh1cPwYoFXIxEoFN0YpRUrlpjj5KHEYg4y17V iYCKSmUcLve8NM9/Unj9gK88t+tCCHolhqaYqnQVCDlaef20536TSQ4U8OplLn8c d73F1YfiLxC7/caJzHNa =dp9a -----END PGP SIGNATURE-----

Feb. 12, 2014

Re: ddraw/tests: Skip the primary palette tests if the 640x480x8 mode is not supported.

by Henri Verbeet

On 12 February 2014 10:28, Francois Gouget <fgouget(a)codeweavers.com> wrote: > hr = IDirectDraw_SetDisplayMode(ddraw, 640, 480, 8); > + if (hr == E_NOTIMPL) > + { > + win_skip("8bpp display mode is not supported\n"); > + DestroyWindow(window); > + return; > + } Is this for the Win 8 testbot? Unsupported display modes should return DDERR_UNSUPPORTED, and 640x480 at 8 bpp should pretty much always be supported. Does changing display modes work at all on that VM? IIRC it had more issues with changing display modes, and not just in the ddraw tests.

Feb. 12, 2014

Re: [2/2] dpnet: Use registry for lookup in IDirectPlay8Peer, EnumServiceProviders

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -141,30 +175,56 @@ static HRESULT WINAPI IDirectPlay8PeerImpl_EnumServiceProviders(IDirectPlay8Peer > else > { > FIXME("Application requested a provider we don't handle (yet)\n"); > - *pcReturned = 0; > return DPNERR_DOESNOTEXIST; > } > > if(*pcbEnumData < req_size) > { > + RegCloseKey(key); > + > *pcbEnumData = req_size; > return DPNERR_BUFFERTOOSMALL; > } > > - pSPInfoBuffer->pwszName = (LPWSTR)(pSPInfoBuffer + 1); > - > if(!pguidServiceProvider) > { > - lstrcpyW(pSPInfoBuffer->pwszName, dp_providerW); > - pSPInfoBuffer->guid = CLSID_DP8SP_TCPIP; > + int offset = 1; > + int count = 0; > + LPWSTR infoend = ((LPWSTR)pSPInfoBuffer + (sizeof(DPN_SERVICE_PROVIDER_INFO) * (*pcReturned))); > + > + index = 0; > + nextKeyNameResult = RegEnumKeyW( key, index, provider, MAX_PATH); > + while(nextKeyNameResult == ERROR_SUCCESS) > + { > + DWORD dwBufLen = 350; > + WCHAR name[350]; > + > + res = RegGetValueW( key, provider, friendly, RRF_RT_REG_SZ, NULL, name, &dwBufLen); > + if(res == ERROR_SUCCESS) > + { > + pSPInfoBuffer[count].guid = CLSID_DP8SP_TCPIP; > + pSPInfoBuffer[count].pwszName = (LPWSTR)(infoend + offset); > + lstrcpyW(pSPInfoBuffer[count].pwszName, name); > + > + offset += dwBufLen/sizeof(WCHAR); > + > + count++; > + } > + > + index++; > + nextKeyNameResult = RegEnumKeyW( key, index, provider, MAX_PATH ); > + } The buffer sizes and pointers are pretty much all handled incorrectly. -- Alexandre Julliard julliard(a)winehq.org

Feb. 12, 2014