February 2014 - Wine-Devel - list.winehq.org

Re: usp10/tests: Use BOOL type where appropriate

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5166 Your paranoid android. === w8 (32 bit usp10) === usp10.c:497: Test failed: 0:Wrong fRTL(0) usp10.c:497: Test failed: 0:Wrong fLayoutRTL(0) usp10.c:497: Test failed: 0:Wrong BidiLevel(0) usp10.c:498: Test failed: 1:Wrong fRTL(0) usp10.c:498: Test failed: 1:Wrong fLayoutRTL(0) usp10.c:498: Test failed: 1:Wrong BidiLevel(0)

Feb. 26, 2014

Getting Introduced with the Community and Looking forward to Contribute to the Project as part of Gsoc 2014

by Gaurav Bansal

Hi, Firstly I, Gaurav would like to introduce myself to the developers of this commmunity. I am a sophomore from Birla Institute of Science and Technology Pilani, India currently pursuing Bachelors in Computer Science and Engineering. My skills include Programming languages: GNU C/C++, Python, Java,PHP/MySQL Version control systems and Git/Github. I am also aware with many of the web development application tools and content management systems. I am an ambitous person willing to learn other technologies when need in future. I choose this organisation for the contribution as the work the community does looks very appealing and interesting to me and useful for the whole community. The skills used by the organisation for the development of open source software matches with my skills to much extent. I had installed the required necessary tools and setup the environment in my system needed for the contribution to open source software. I had got myself aware of the source to some extent. I had also read the contribution, development tutorial on the community webpage. I would like to seek the mentors help in the selection of the project for which the idea has been proposed for the Gsoc and someone is willing to mentor the project idea. I will highly appreciate with any kind of help, guidance from the mentors to help me move forward to contribute to the software starting off with some easy tasks and then moving levels higher so as to make a strong proposal for the upcoming Google Summer of Code 2014. [1] Github : https://github.com/gauravb7090 [2] IRC : gauravb7090 *--Gaurav*

Feb. 26, 2014

Re: user32: Check WS_CHILD style in IsChild function

by Piotr Caban

On 02/25/14 16:40, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5155 > > Your paranoid android. > This failures are not caused by my patch.

Feb. 25, 2014

Re: user32: Check WS_CHILD style in IsChild function

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5155 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00050094 fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6180: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

Feb. 25, 2014

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-25 13:27, schrieb Henri Verbeet: > Calling HeapAlloc() for a struct list seems less than ideal, That is easy to fix. It will move the actual structure definition into the public header though. > and I'd like the WINED3DSPD_IUNKNOWN handling to be done by the > callers. For get_private_data that's fairly easy. I can just return the stored flags and the caller decides if it wants to addref anything. For set_private_data it's tricky. The caller would have to know the old contents, same for free_private_data and the destruction of the store. With that amount of logic in the caller we might as well re-implement the entire thing in each calling library. But the getter behavior is version specific part, so I think just moving that out makes sense on its own. wine-devel(a)winehq.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTDLZnAAoJEN0/YqbEcdMwyNcP/3Yalc3Rvg25xk6LkI1jAVwT M+n1sdBNyYt0mFMOM2bbg4CWr6TwFtO4Wq4xOYJIV1L/JpjEipK5N3Acv7mCFCGL X+Ksth9juulUULc187fKbZgOgbB/vZP6LWiO23bmIlI+5RYAODavvjrIzJN4FyTh Fvw8sAKpIv6fiX4Ev5GyqRwmVTeUMU5UZ7Gmc1D269YXTAINeVnlrVoBOOTGCCfm toZwXsLmzgGbJRkI/Zul3sx5KJBdwvAY6ZOK9NSIoDuqdAYfVqyKVqP/AQEaX196 LcgkCkMBqYpk4VpWOD52TluIQ1cLBtBch6VDxW8ULor3VYt0jhtYuvA1K5uU7FI0 BiR/w32tIT1ApPN71Qn/EpRwUfsDvKRZB3hYNO4AmfAo+Ro8eVuMPKJRtXx7Icyy XXbtGhYGauiEP90M3yhy3fxxrxhuzaiMnymZWFt3Zxr+dWNoJT82ILflp/v0uYp0 BXYArO9AM8O2KeFl3eBRey/Xl+pHVBdfd1fHjWBBqpsWcWQ3MZ5fcdY30vwmjBIq plzxMZWWA+2Gl9HVwLmNSSORPjtjqsC/mBP19IPr0WWiCDUQNuwpwCf1LKUZWGTP xwOwYSQd7k+U8IrqkVwotEDGsEPADWpaR81aiudEJqV4J2d8Wt3ck3iwDtjSPPKZ QTnAy4/SvHNmek46m6oM =+wqG -----END PGP SIGNATURE-----

Feb. 25, 2014

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 3)

by Bruno Jesus

Please rebase and resend your patches. On Fri, Jan 24, 2014 at 5:46 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > Load registry functions dynamically, test caused an error message box to pop > up on Windows XP instead of skipping the test, causing a timout error. > > Test now queries registry values to compare them with the function's result. > > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 ++ > dlls/bcrypt/tests/bcrypt.c | 107 > ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 113 insertions(+) > > >

Feb. 25, 2014

Re: Raise the minimum version of FreeBSD to 8.0. (PING)

by Lauri Kenttä

On 2014-02-24 00:15, Gerald Pfeifer wrote: > Any problem why this patch was not included yet? At least you have not changed all 7.0's to 8.0's, for example README.sv: "FreeBSD-versioner äldre än 7.0." -- Lauri Kenttä

Feb. 25, 2014

Re: d3d9/tests: Fix some test failures on Windows 2000.

by Bruno Jesus

On Mon, Feb 24, 2014 at 7:54 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) I was not aware that we are adding broken for Windows 2000. Otherwise I would not have sent http://source.winehq.org/git/wine.git/commitdiff/de0c46fd52b9f9f4ebfff256c7… I thought broken was for <= NT only. Bruno

Feb. 25, 2014

Re: d3d9/tests: Fix some test failures on Windows 2000.

by Henri Verbeet

On 24 February 2014 23:54, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > Most of the IDirect3D9_CreateDevice() calls in device.c should be calls to create_device() instead. (And then just skip() if it fails to create a device.) I think the only exceptions are test_fpu_setup() and test_swvp_buffer().

Feb. 25, 2014

Re: Patch to fix bug 34324

by Bruno Jesus

On Tue, Feb 25, 2014 at 1:49 AM, Zhenbo Li <litimetal(a)gmail.com> wrote: >> Why using a magic value (0x7c) if there is a define(DE_INVALIDFILES)? > This is related to legacy. MSDN said[3], > "These are pre-Win32 error codes and are no longer supported or > defined in any public header file." > And DE_INVALIDFILES is not defined in wine's shell32 code. > Maybe to define it is better than to use a magic number? I'm not sure. I see, I guess it's ok then. Never saw that situation before so I can't really tell what is best. > BTW, in irc channel, Stefand suggested me to avoid SetLastError(). > If I have to do that, could I change SHELL_DeleteDirectoryW() > from BOOL to DWORD? If BOOL is no longer enough and the function is internal I see no problem in changing it, but there are other calls to this function so you would have to review and update then accordingly. And yes, avoiding the SetLastError is better as Windows may not set it too and the application may not be expecting that. Best wishes, Bruno

Feb. 25, 2014