February 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure.

by Henri Verbeet

On 24 February 2014 15:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +struct wined3d_privstore *wined3d_privstore_create(void) DECLSPEC_HIDDEN; > +void wined3d_privstore_destroy(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, BOOL addref) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > I'm not entirely convinced this is how we want this to work. Calling HeapAlloc() for a struct list seems less than ideal, and I'd like the WINED3DSPD_IUNKNOWN handling to be done by the callers.

Feb. 25, 2014

Re: winmm/tests: Change the current directory to a place that will be writable.

by Francois Gouget

On Mon, 24 Feb 2014, Marvin wrote: [...] > === w8 (32 bit mci) === > mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) Not related to my patch. -- Francois Gouget <fgouget(a)codeweavers.com>

Feb. 25, 2014

Re: Assorted typos fixes (try 2)

by Nikolay Sivov

On 2/25/2014 13:53, Andrey Gusev wrote: > --- a/dlls/dssenh/tests/dssenh.c > +++ b/dlls/dssenh/tests/dssenh.c > @@ -405,7 +405,7 @@ struct hash_test { > }; > > static const char testHashVal1[] = "I love working with Wine"; > -static const char testHashVal2[] = "Wine is not an emulater."; > +static const char testHashVal2[] = "Wine is not an emulator."; > static const char testHashVal3[] = ""; > This breaks now. Don't forget to do a 'make test' after making changes to test data.

Feb. 25, 2014

Re: Suggested RFP: LinuxFest Northwest

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I'll see if the Linuxwochen Österreich organizers are interested in a Wine talk: http://linuxwochen.at/ . Their main topic this year appears to be privacy, but they usually have plenty of "off-topic" presentations as well. Cheers, Stefan Am 2014-02-25 09:38, schrieb Steven Edwards: > Hi, Everyone should try to do this whenever there is a conference > and they have the spare cycles. Dan used to do it quite a bit and > it did a lot of good bring new people in and generating positive PR > for Wine. > > I did one at the South East Linux Fest a few years back and it > didn't take that much time or effort. There are plenty of good > Wine presentations already online to 'borrow' from and you get to > be a VIP rockstar representing a project you know and love. > > Thanks Steven > > > On Mon, Feb 24, 2014 at 7:37 AM, Jeremy White > <jwhite(a)codeweavers.com <mailto:jwhite(a)codeweavers.com>> wrote: > > As part of our new initiative, we're trying to encourage people to > submit RFPs to give Wine talks. > > The Wine project can potentially help defray travel costs, > although the ideal is to encourage folks that don't have to travel > far. > > So here's one: http://linuxfestnorthwest.org/__present > <http://linuxfestnorthwest.org/present> > > LinuxFest Northwest. About 1500 Linux geeks. I'm told by an > organizer that a Wine talk would be welcome. Anyone on the US > West coast up for giving a talk? > > Cheers, > > Jeremy > > > > > > -- Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTDHFpAAoJEN0/YqbEcdMwJ0gP/iey89XS0IDxa/aRaYc337zZ 5x7eAZOYzfJFPvNm4nvXmxDCdAKCLshYRgjztYhq5SxN5V3fVQXRSBHNQW9ipq3e 43CX1S25ZxFmfwl+xpyGs54d5ytQOwQwf1RZTJ2zZzAAEJEQUihL0xpev4MUZQ+u Hv1rKBmCe79iTUBWZtMnbwLI9Ca42fE9TAqeI6xUQn13bEDMVQs6haYWVUcttPcw wesJ/Hf092fYk6yTBBpyQflOOlfcDLHUxqjDVlrqGeelZba5AlnhIEhA9ECB/UAx fcjC+QbmtxlWg2c1h/8Z0Hw09akbn2Ag0baAy/ggFLWWeV9wOUAjorc+wQbbTTfr E9oswVs0nbUGIwCbv8MmhY6gtrHS4ClfNwpmpv8CBQ5QMdug4X9r+Wbh0yq7ScO0 0ckqMhTRJE1TnSHyBTQWnfUmp9YJe/5qaVhemBzywcQupsynILVo6mb22mLllZVO VrwMkENrZcVp95Y5vCOdIsuyRi2sQBOCoG5PfgdeFwkBxNhMpFc519FsEruRmxHS FwVR0SgwHnqRyKoBkQXQOgmotPQcJuxMqeUnuWAVLNyWVdcJhMu7To1NDx1HYcfE rSFzQp3N3mZENytfRl1TqdiiOqgl3xd5ZAwdjF1z1ci5k7ql559/TK57vewtvE0c /oaLItnultbvn+bALib8 =lD0q -----END PGP SIGNATURE-----

Feb. 25, 2014

Re: Assorted typos fixes (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5149 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

Feb. 25, 2014

Re: Suggested RFP: LinuxFest Northwest

by Steven Edwards

Hi, Everyone should try to do this whenever there is a conference and they have the spare cycles. Dan used to do it quite a bit and it did a lot of good bring new people in and generating positive PR for Wine. I did one at the South East Linux Fest a few years back and it didn't take that much time or effort. There are plenty of good Wine presentations already online to 'borrow' from and you get to be a VIP rockstar representing a project you know and love. Thanks Steven On Mon, Feb 24, 2014 at 7:37 AM, Jeremy White <jwhite(a)codeweavers.com>wrote: > As part of our new initiative, we're trying to encourage people to submit > RFPs to give Wine talks. > > The Wine project can potentially help defray travel costs, although the > ideal is to encourage folks that don't have to travel far. > > So here's one: > http://linuxfestnorthwest.org/present > > LinuxFest Northwest. About 1500 Linux geeks. I'm told by an organizer > that a Wine talk would be welcome. Anyone on the US West coast up for > giving a talk? > > Cheers, > > Jeremy > > > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Feb. 25, 2014

Re: Patch to fix bug 34324

by Zhenbo Li

Thank you for checking it. 2014-02-24 23:39 GMT+08:00 Bruno Jesus <00cpxxx(a)gmail.com>: > > In my opinion the complex patch is better. > > + if (hFind == INVALID_HANDLE_VALUE){ > + if (GetLastError() == ERROR_PATH_NOT_FOUND) > + SetLastError(0x7c); /* DE_INVALIDFILES */ > + return FALSE; > + } > + FindClose(hFind); > > You are not following the {} styles in the surrounding code. Sorry, it's my fault. I was confused by old code style. I've sent a new patch[1] to bugzilla[2], you may check that. > Why using a magic value (0x7c) if there is a define(DE_INVALIDFILES)? This is related to legacy. MSDN said[3], "These are pre-Win32 error codes and are no longer supported or defined in any public header file." And DE_INVALIDFILES is not defined in wine's shell32 code. Maybe to define it is better than to use a magic number? I'm not sure. BTW, in irc channel, Stefand suggested me to avoid SetLastError(). If I have to do that, could I change SHELL_DeleteDirectoryW() from BOOL to DWORD? Thank you very much. [1]: http://bugs.winehq.org/attachment.cgi?id=47626&action=diff [2]: http://bugs.winehq.org/show_bug.cgi?id=34324 [3]: http://msdn.microsoft.com/en-us/library/windows/desktop/bb762164%28v=vs.85%… -- Have a nice day! Zhenbo Li

Feb. 25, 2014

Re: winmm/tests: Change the current directory to a place that will be writable.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5140 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

Feb. 25, 2014

Re: msi: Add tests for [un]registering progids.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5134 Your paranoid android. === w2000pro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605 === wxppro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605

Feb. 24, 2014

Conferences wiki page

by Rosanne DiMesio

FYI, I've created a wiki page to collect information on conferences that might be good venues for Wine outreach efforts, http://wiki.winehq.org/Conferences2014. Please add any conferences/meetings you think might be suitable, even if the deadline for this year has passed (it will serve as a reminder to check earlier for next year). -- Rosanne DiMesio <dimesio(a)earthlink.net>

Feb. 24, 2014