March 2014 - Wine-Devel - list.winehq.org

GSoC 2014: Student application period is almost over!

by Austin English

Howdy everyone, If you're a student that wants to apply for GSoC 2014, you have until tomorrow*, **March 21 at 19:00 UTC*, to submit your proposals. See https://www.google-melange.com/gsoc/events/google/gsoc2014 for the timeline, and https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine I'd like to also remind students that a patch or testcase must have been submitted to wine before to be considered. It is not required to have been accepted, but you must show that you are able to build/tinker on wine's source code. See http://wiki.winehq.org/SummerOfCode and http://wiki.winehq.org/SubmittingPatches for more info. Good luck! -- -Austin

March 20, 2014

Re: wintab: Incorrectly classifying cursor as stylus instead of eraser

by Alexandre Julliard

Eriks Dobelis <eriks.dobelis(a)biti.lv> writes: > Did not attach the patch in my last email :( > > For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly > detected as stylus. > The tablet returns its eraser cursor name as: > Wacom Intuos PT S Pen eraser > and type as: > ERASER > > Current code classifies this as STYLUS, because name of the cursor > contains the word 'Pen'. It is very unlikely that a cursor with type > ERASER is STYLUS. There is already a check for eraser type, you should be able to use that instead. -- Alexandre Julliard julliard(a)winehq.org

March 20, 2014

Re: [PATCH 3/6] d3d8: Use the private store api for buffers.

by Henri Verbeet

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (stored_data->flags & WINED3DSPD_IUNKNOWN) > + { > + *(IUnknown **)data = stored_data->content.object; > + IUnknown_AddRef(*(IUnknown **)data); > + } > + else > + memcpy(data, stored_data->content.data, stored_data->size); + if (stored_data->flags & WINED3DSPD_IUNKNOWN) + IUnknown_AddRef(stored_data->content.object); + memcpy(data, stored_data->content.data, stored_data->size);

March 20, 2014

Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).

by Stefan Dösinger

Am 20.03.2014 16:45 schrieb "Henri Verbeet" <hverbeet(a)gmail.com>: > > On 20 March 2014 14:44, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Am 2014-03-20 14:06, schrieb Henri Verbeet: > >> Perhaps not quite enough to fix all the device type checks right > >> now, but I certainly don't think we should add extra code to make > >> the behaviour worse either. > > So you'd prefer to just ignore the possibly set WINED3D_NO3D flag in > > d3d8/9/dxgi? The result of that is (at least in the tests) a crash > > later. I'm fine with that, just mentioning it. > > > Which test is that? I think it was some operator error by me. I could not reproduce it when I tested before sending v3. It was the d3d8 visual test. It crashed during device creation inside wined3d. I suspect I had a mismatched d3d8 and wined3d build.

March 20, 2014

Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).

by Henri Verbeet

On 20 March 2014 14:44, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2014-03-20 14:06, schrieb Henri Verbeet: >> Perhaps not quite enough to fix all the device type checks right >> now, but I certainly don't think we should add extra code to make >> the behaviour worse either. > So you'd prefer to just ignore the possibly set WINED3D_NO3D flag in > d3d8/9/dxgi? The result of that is (at least in the tests) a crash > later. I'm fine with that, just mentioning it. > Which test is that?

March 20, 2014

Re: [PATCH] scrrun/tests: Update idl file in tests

by Nikolay Sivov

On 3/20/2014 09:57, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5791 > > Your paranoid android. The problem is that it doesn't know which test to run when none of .c files are changed.

March 20, 2014

Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-03-20 14:06, schrieb Henri Verbeet: > Perhaps not quite enough to fix all the device type checks right > now, but I certainly don't think we should add extra code to make > the behaviour worse either. So you'd prefer to just ignore the possibly set WINED3D_NO3D flag in d3d8/9/dxgi? The result of that is (at least in the tests) a crash later. I'm fine with that, just mentioning it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTKvDMAAoJEN0/YqbEcdMwbqsP/RYLxwtWy5m0d/+T3Or3tzn3 0Zet58ss1smMKZ3jRAxAU9S4M1jDgWLzF1DEdP4MMNbS6YcgcClJuKf+xMCVGt6f 8Lthlc5X8RUw2P9UlgOjP99qDITwncVllO68IyA1oVEDZ7eCrUHht1Xea8LPU9LP 1LGq06E/8L60D8vtZyVWYwhdNGdkL2hA3Kay3f20kJA1Z+LqA4VoyXR+JKKyeidN 4jtISrRhf5+/MzZj0aHd+7GXCdBCRR019t+5GAz+hC81axM8qtbuLYDqmJ+jp0Hh jnbdnjZqrLz4NgrZYA/AQtj70eNBuKOx3De0vVx/OMcfrVE77Kh17ArNlrs5u7VN oHtALoCQIQHgYpoLxroZw3P8V6KKFnwIr918Kvf/2nlwe6lANFjCap2bq5EcgWPv R0NPPZBgFeOR8hAw1khZMRtd+GjURm2EuZsb5C8wQCd2ySJC84+1nVx0m71sw7u9 LKzpKJv0bnIRwDHKzAGzK0Xz5iI0pxAdr5Dk2o9XLwYgS2uLhGzUhCZ6sMcE0Ymj CAWEJxKdsvayjQfIsadruSzRJVaA+9UNQ0voP2UeX13Ld69fGoxcBXqoksEHv1pm WLjh8Pk/c+v2mFWAjzCSgZ/LzyIMa2wY8PCv/r/FPIuRoeaPNMiHCzUg7ecIS7AZ zHkm0jaiuVVZyJ/f1cdo =SeBd -----END PGP SIGNATURE-----

March 20, 2014

Re: regsvr32: Replace printf calls with WriteConsole function (try 2)

by Akihiro Sagawa

On Tue, 18 Mar 2014 21:26:30 -0400, Hugh McMaster wrote: > This patch adds the function output_write to regsvr32.c. The function > calls LoadString, FormatMessage and WriteConsole to output string text > to the console. This patch sequence looks nice. It will resolve bug 28189. Thanks, Akihiro Sagawa

March 20, 2014

Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).

by Henri Verbeet

On 20 March 2014 13:28, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > Am 2014-03-20 12:46, schrieb Henri Verbeet: >> I don't think that really matches Windows. Going by the testbot >> results, I think creating a D3D object should succeed, and >> creating a (hardware) device should fail. > Do we care enough about this? The behavior of my patch matches the > behavior if OpenGL is not available. Perhaps not quite enough to fix all the device type checks right now, but I certainly don't think we should add extra code to make the behaviour worse either.

March 20, 2014

Re: [2/4] widl: Pass type attributes from write_array_tfs to write_pointer_description.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > >> >> >> > This allows to differentiate strings and write appropriate rpc type > >> >> >> > (FC_C_C[W]STRING instead of FC_[W]CHAR). > >> >> >> > >> >> >> It also changes some pointers from UP to RP, that doesn't look right. > >> >> > > >> >> > I don't see any changes in server_c.c and server_s.c in dlls/rpcrt4/tests, > >> >> > do you see this somewhere else? > >> >> > >> >> In many of the generated proxy files, in actxprxy for instance. > >> > > >> > As far as I can see new behaviour matches what midl generates, for instance > >> > for wireBSTR/SAFEARR_BSTR. > >> > >> It generates FC_UP here (midl 7.0). Is it different in newer versions? > > > > I don't see differences between the code generated by midl shipped with > > PSDK 7.1 (midl 7.00.0555) and Visual Studio Express 12.0 (midl 8.00.603). > > Do you really get FC_RP pointers in there? Did you build with the Wine > headers? I was testing actxprxy_activscp.idl, it doesn't build with Wine headers, so I had to simplify the dependant .idl files quite a bit. I could retry tomorrow if you think that I may have screwed something during simplification. -- Dmitry.

March 20, 2014