March 2014 - Wine-Devel - list.winehq.org

Re: gdi32/tests: GetGlyphOutlineA is broken for johab charset on windows.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android. === w8 (32 bit font) === font.c:3609: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3609: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c

March 19, 2014

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf. (try 2)

by Nikolay Sivov

On 3/19/2014 17:02, Jactry Zeng wrote: > Update: > - Add a todo_wine. > > + ITextDocument_Open(txtDoc, &testfile, tomReadOnly|tomRTF, CP_ACP); It's a common practice to check a return value. > + /* open a rtf without } in the end */ > + result = ITextDocument_Open(txtDoc, &testfile, tomReadOnly, CP_ACP); > + /* 0x80070026 is HRESUILT_FROM_WIN32(ERROR_HANDLE_EOF) */ > + todo_wine ok(result == 0x80070026, "ITextDocument_Open: Should return an ERROR_HANDLE_EOF error.\n"); No need to put a magic number, use HRESULT_FROM_WIN32(), and don't forget to use proper type for return value. Also a typo in a comment, but that it go anyway.

March 19, 2014

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf.

by Jactry Zeng

2014-03-18 1:46 GMT+08:00 Alexandre Julliard <julliard(a)winehq.org>: > > richole.c:445: Test failed: ITextDocument_Open: Should return an ERROR_HANDLE_EOF error. > make[1]: *** [richole.ok] Error 1 Sorry, I forgot a todo_wine here. An new one was sent. Thank you. -- Regards, Jactry Zeng

March 19, 2014

Re: [PATCH 1/2] user32: Improve SetFocus implementation

by Piotr Caban

On 03/19/14 10:51, Alexandre Julliard wrote: > Piotr Caban <piotr(a)codeweavers.com> writes: > >> --- >> dlls/user32/focus.c | 1 + >> dlls/user32/tests/win.c | 4 ++++ >> 2 files changed, 5 insertions(+) >> >> >> >> diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c >> index bd2e572..c47a82d 100644 >> --- a/dlls/user32/focus.c >> +++ b/dlls/user32/focus.c >> @@ -277,6 +277,7 @@ HWND WINAPI SetFocus( HWND hwnd ) >> HWND parent; >> LONG style = GetWindowLongW( hwndTop, GWL_STYLE ); >> if (style & (WS_MINIMIZE | WS_DISABLED)) return 0; >> + if (!(style & WS_CHILD)) break; > > It doesn't look right to allow setting focus if a parent is > disabled. This would need more tests. At least on Windows 7 it's possible to set focus if parent is disabled and child has no WS_CHILD flag. I'll write more tests. I'll also try to check why the tests are currently failing on testbot before sending it again. Thanks, Piotr

March 19, 2014

Re: [PATCH 1/2] user32: Improve SetFocus implementation

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/focus.c | 1 + > dlls/user32/tests/win.c | 4 ++++ > 2 files changed, 5 insertions(+) > > > > diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c > index bd2e572..c47a82d 100644 > --- a/dlls/user32/focus.c > +++ b/dlls/user32/focus.c > @@ -277,6 +277,7 @@ HWND WINAPI SetFocus( HWND hwnd ) > HWND parent; > LONG style = GetWindowLongW( hwndTop, GWL_STYLE ); > if (style & (WS_MINIMIZE | WS_DISABLED)) return 0; > + if (!(style & WS_CHILD)) break; It doesn't look right to allow setting focus if a parent is disabled. This would need more tests. Also please write a better description of the change, "improve implementation" is not very helpful. -- Alexandre Julliard julliard(a)winehq.org

March 19, 2014

Re: [PATCH 1/2] user32: Improve SetFocus implementation

by Piotr Caban

On 03/19/14 10:25, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5775 > > Your paranoid android. > All of these test are failing without my changes. Here are results of tests run without my patches: https://testbot.winehq.org/JobDetails.pl?Key=5777

March 19, 2014

Re: [PATCH 2/2] user32: Improve SetForegroundWindow implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5776 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0156 fg 00010048 in hook HCBT_ACTIVATE win.c:6405: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6405: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6405: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6188: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

March 19, 2014

Re: [PATCH 1/2] user32: Improve SetFocus implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5775 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0006019E fg 00010048 in hook HCBT_ACTIVATE win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6193: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

March 19, 2014

Re: Ideas about mshtml for GSoC 2014

by Austin English

On Fri, Mar 14, 2014 at 8:21 PM, Zhenbo Li <litimetal(a)gmail.com> wrote: > Hi Jacek, > > 2014-03-14 22:22 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>: > > > > Sorry for the delay. I'm not sure that's the best strategy for having > > results that will help users in general. Having all functions > implemented is > > a nice thing, but many of them don't cause problems in real world > > application and web pages. I think I would prefer testing random web > pages > > and implementing things that they need. This, however, would be tricky to > > set goals required for GSoC application. Maybe you could come up with a > mix > > of both? Start with selected area (say, IHTMLTable*, not necessarily > whole) > > and move to random APIs required by pages as the project progresses? > > > I think work on both of them is a great idea, And I'm glad to do such job. > As you said, it is not easy to set up goals. > I have nearly 12 weeks, so my previous plan is to split them into several > parts: > IHTMLTableCell 3 weeks > IHTMLTableCol & IHTMLTableRow 3 weeks > IHTMLTableSection 2 weeks > IHTMLTable 4 weeks > (test-cases included) > > I don't know if this meets the need of GSoC. Also, is it necessary to add > "fix real work webpage/app problem" in this schedule? > > Thank you very much. > > > Cheers, > > Jacek > > > > > -- > Have a nice day! > Zhenbo Li > > > There are 92 mshtml bugs open in bugzilla, you might browse those for related reports: https://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&b… -- -Austin

March 19, 2014

Re: include: Added netcfgx.idl

by Nikolay Sivov

On 3/19/2014 08:48, Alistair Leslie-Hughes wrote: > + uuid(C0E8AE93-306E-11D1-AACF-00805FC1270E) Please use lower case for uuids.

March 19, 2014