March 2014 - Wine-Devel - list.winehq.org

Re: [RFC 6/11] Linux FF: Linux effect: conditional effect's parameters

by Andrew Eikum

On Tue, Mar 04, 2014 at 08:20:13PM +0100, Elias Vanderstuyft wrote: > for (i = 0; i < 2; ++i) { > This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; > This->effect.u.condition[i].right_coeff = > (tsp[i].lPositiveCoefficient / 10) * 32; > This->effect.u.condition[i].left_coeff = > (tsp[i].lNegativeCoefficient / 10) * 32; > This->effect.u.condition[i].right_saturation = > (tsp[i].dwPositiveSaturation / 10) * 65; > This->effect.u.condition[i].left_saturation = > (tsp[i].dwNegativeSaturation / 10) * 65; > This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 65; > } > I agree with this in principle, but I think I would change the implementation to be a bit more explicit. Something like, left_coeff = (lNegativeCoefficient / (double)10000) * 32767; right_saturation = (dwPositiveSaturation / (double)10000) * 65535; which shows an explicit mapping between full ranges. (This might need some more thinking at the extreme edges of the bounds, so we don't go out of bounds during type coersion.) > - Don't return an error. This seems to be the behavior of the > Windows Logitech FFB driver (MOMO, MOMO2, ...). We should match Windows. Sounds like they ignore envelopes for effects which don't support them, so we should too. Your change looks good. I would probably use a TRACE instead of WARN, since we're doing the right thing. Andrew

March 5, 2014

Re: [RFC 5/11] Linux FF: Linux effect parameters: time parameters

by Andrew Eikum

On Tue, Mar 04, 2014 at 08:20:09PM +0100, Elias Vanderstuyft wrote: > So change in dinput/effect_linuxinput.c:488 : > This->effect.u.periodic.period = tsp->dwPeriod / 1000; > to : > if (0 < tsp->dwPeriod && tsp->dwPeriod <= 1000) > This->effect.u.periodic.period = 1; > else > This->effect.u.periodic.period = tsp->dwPeriod / 1000; > Seems good. While we're here, any reason not to use round(3) instead of always rounding down in the >1000 case? > b) Anticipate if dwPeriod < 0, otherwise periodic.period will > incorrectly wrap around because it's unsigned. > We can choose to let periodic.period be proportional to: > - 0 (driver will generate EINVAL) > - abs(dwPeriod) (no error, and is mathematically more correct) DWORDs are usually treated as unsigned. Is this how Windows behaves for massive dwPeriod? I would expect E_INVALIDARG, since it's out of the range [0,36000). > So, change in dinput/effect_linuxinput.c:191 : > if (dwFlags & DIEP_DURATION) { > peff->dwDuration = (DWORD)This->effect.replay.length * 1000; > } > to : > if (dwFlags & DIEP_DURATION) { > peff->dwDuration = (This->effect.replay.length ? > (DWORD)This->effect.replay.length * 1000 : -1); > } > > And change in dinput/effect_linuxinput.c:424 : > if (dwFlags & DIEP_DURATION) > This->effect.replay.length = peff->dwDuration / 1000; > to : > if (dwFlags & DIEP_DURATION) { > if (peff->dwDuration == -1) > This->effect.replay.length = 0; // Infinity > else if (peff->dwDuration > 1000) > This->effect.replay.length = peff->dwDuration / 1000; > else > This->effect.replay.length = 1; // Smallest non-zero value > } > This seems okay, though again, maybe use round(). You should also use INFINITE instead of -1. Andrew

March 5, 2014

Re: [RFC 4/11] Linux FF: Linux effect parameter: periodic effect's phase

by Andrew Eikum

On Tue, Mar 04, 2014 at 08:20:01PM +0100, Elias Vanderstuyft wrote: > phase should be related to time, not to angle: > This seems correct to me. I would add a short comment noting that we're performing the conversion because ff_effect's phase should be a time parameter, while DIEFFECT's is angle. Andrew

March 5, 2014

Re: [RFC 3/11] Linux FF: Linux effect parameter: start delay

by Andrew Eikum

On Tue, Mar 04, 2014 at 08:19:56PM +0100, Elias Vanderstuyft wrote: > a) Keep in mind that startDelay is not supported in DX5 or lower: These seem like good fixes. You could add a test by using a DIEFFECT with its dwSize member set to sizeof(DIEFFECT_DX5) to set/get the delay value, and seeing if Windows modifies the delay value in the struct. Andrew

March 5, 2014

winetestbot day 1: Frustrating lack of personal blame, praise required instead

by Jeremy White

Alright, So I have started my once a day attack on test.winehq.org. Summary: 049f08f4cda0 04 Mar 39 test failures on wtb * But the win8 wtb did not fire, so there are likely 38 more The first set I examined were the Wine Test Bot Win 2K tests with 12 failures. This is a relatively new VM, and it has a new set of failures, not seen on the old test bot. A number of the test failures: comctl32:listview, comctl32:propsheet, and a few others, look to be timing related. So there is not a clear person to blame; in fact, it may be a qemu bug. However, Nikolay, as the last person to touch the comctl32:listview test, has volunteered to look into this issue and see if he can get to the bottom of it. So I cannot publicly shame anyone, as I had hoped, and instead have to commend Nikolay for volunteering. Cheers, Jeremy

March 5, 2014

Re: [RFC 2/11] Linux FF: Linux effect status management

by Andrew Eikum

On Tue, Mar 04, 2014 at 08:19:39PM +0100, Elias Vanderstuyft wrote: > => This has been discussed (see > http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08513.html) > and the following is true: > My opinion appeared to be correct, but for to be sure, I was > recommended to apply the change in Wine as well. > Yes, we should also fix this in Wine to support "buggy" old kernels. It would be worth adding a short comment to the code explaining which kernel versions are affected by this bug. > b) Be more precise in returning errors. > Seems fine. If you can add tests (EINVAL seems easy to test, at least), that would be even better. > c) The following in dinput/effect_linuxinput.c:336 : > if (res != DI_OK) > should be probably : > if (FAILED(res)) > for example if a device reports S_FALSE because it has already > updated an identical effect. > > The same for line 549: > if (retval != DI_OK) > should be then : > if (FAILED(retval)) > Sure, seems fine. As an additional fix, you could demonstrate with tests that Download and Start can return S_FALSE under those circumstances on Windows, and fix the Wine behavior to match. Andrew

March 5, 2014

Re: [RFC 1/11] Linux FF: Joystick control panel program

by Andrew Eikum

On Tue, Mar 04, 2014 at 08:19:16PM +0100, Elias Vanderstuyft wrote: > a) When unloading conditional effects in joy.cpl, the program crashes: > When unloading the conditional effect array entries, > Wine tries to access an invalid (high) address because > dieffect.lpvTypeSpecificParams was not set at the time the > effect was created. > So declare a valid 'standard' (maxed out) conditional effect. > For other unknown effects: > - The same can happen when CustomForce effects are available, > but because Wine's FF dinput->linux translation does > not support this yet, > we simply print a FIXME to indicate a possible cause > if a crash would happen. > - The same for other (unsupported) effects (this is > probably not safe?), > but then we print a WARN. For unhandled types, it's probably best to print a FIXME and return DIENUM_CONTINUE, rather than continue to rely on uninitialized data. Additionally, our IDirectInputEffect implementations could check for NULL lpvTypeSpecificParams and fail appropriately instead of crashing, if this is what Windows does. > b) Weirdly, I had to add these commands that evaluates the DIEFFECT > pointers at the end of each if-case, > otherwise the pointers seemed to point to other address or data on > that address was getting overwritten: > TRACE("&rforce=0x%x\n", &rforce); > TRACE("&cforce=0x%x\n", &cforce); > TRACE("&pforce=0x%x\n", &pforce); > TRACE("&cxyforce[0]=0x%x; &cxyforce[1]=0x%x\n", > &(cxyforce[0]), &(cxyforce[1])); > This is an out of scope problem. pforce, rforce, etc are local to the body of the if-blocks and fall out of scope when the if-blocks close. They should be moved to the top of the function. By the way, when you begin to send patches to wine-patches, please only send up to 2-4 at a time, in logical groups. That way they can be reasonably reviewed & resubmitted as necessary. Andrew

March 5, 2014

Re: cmd/tests: Fix a test in Windows 8

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5397 Your paranoid android. === w2000pro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 263 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 264 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 299 (got 'C:\C D', wanted '@pwd@\C D(a)or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 300 (got 'C:\E', wanted '@pwd@\E(a)or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 303 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 304 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 310 (got ''C:\R S'', wanted ''@drive@@shortpath(a)R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 311 (got ''C:\T'', wanted ''@drive@@shortpath(a)T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 312 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath(a)ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 321 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 322 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 335 (got 'C:\C D', wanted '@pwd@\C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 336 (got 'C:\E', wanted '@pwd@\E') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 339 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 340 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 346 (got ''C:\R S'', wanted ''@drive@@shortpath(a)R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 347 (got ''C:\T'', wanted ''@drive@@shortpath(a)T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 348 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath(a)ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 349 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 350 (got 'C:\', wanted '@drive@@path@') batch.c:304: Test failed: excess characters on line 392 (got 'Current dir: C:\foobar', wanted 'Current dir: @pwd@\foobar(a)or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 393 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 395 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 397 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 401 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 402 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 403 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1090 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1092 (got 'C:\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1094 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1099 (got 'A C:\foobar\foo', wanted 'A @pwd@\foobar\foo(a)or_broken@A @pwd@\foobar\foo(a)or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1101 (got 'A R C:\foobar\foo', wanted 'A R @pwd@\foobar\foo(a)or_broken@A R @pwd@\foobar\foo(a)or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1107 (got 'A C:\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2(a)or_broken@A @pwd@\foobar\baz\level2(a)or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1108 (got 'A R C:\foobar\level1', wanted 'A R @pwd@\foobar\level1(a)or_broken@A R @pwd@\foobar\level1(a)or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1109 (got 'A R C:\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2(a)or_broken@A R @pwd@\foobar\baz\level2(a)or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\bar', wanted 'A @pwd@\foobar\bar(a)or_broken@A @pwd@\foobar\bar(a)or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1112 (got ' C:\foobar', wanted ' @pwd@\foobar(a)or_broken@ @pwd@\foobar(a)or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1113 (got ' R C:\foobar\baz', wanted ' R @pwd@\foobar\baz(a)or_broken@ R @pwd@\foobar\baz(a)or_broken@ @pwd@\foobar\baz(a)or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1114 (got 'A C:\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto(a)or_broken@A @pwd@\foobar\baz\toto(a)or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1251 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1253 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1255 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1259 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1261 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1279 (got 'C:\foobar\foodir3', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1284 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1288 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1290 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1295 (got 'C:\foobar', wanted '@pwd@\foobar') === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

March 5, 2014

Re: msi/tests: Skip some package tests if in a non-administrator, non-power user account.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5390 Your paranoid android. === w2000pro (32 bit package) === package.c:3954: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3960: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3966: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3978: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3984: Test failed: Expected "C:\\", got "C:\" package.c:3990: Test failed: Expected "C:\\", got "C:\" package.c:4006: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4017: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4476: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4568: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4579: Test failed: Expected "C:\\", got "C:\" package.c:4590: Test failed: Expected "C:\\", got "C:\" package.c:4640: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4651: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4666: Test failed: Expected "C:\\", got "C:\" package.c:4671: Test failed: Expected "", got "C:\" package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4696: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4946: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4957: Test failed: Expected "C:\\", got "C:\" package.c:4963: Test failed: Expected "C:\\", got "C:\" package.c:4984: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4995: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5235: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5241: Test failed: Expected "C:\\", got "C:\" package.c:5258: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5269: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5277: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5621: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6253: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6277: Test failed: Expected C:\\ or empty string, got C:\ package.c:6321: Test failed: Expected C:\\ or empty string, got C:\ package.c:6330: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6560: Test failed: Expected "C:\\", got "C:\" package.c:6561: Test failed: Expected 4, got 3 package.c:6568: Test failed: Expected "C:\\", got "C:\" package.c:6569: Test failed: Expected 4, got 3 package.c:6585: Test failed: Expected "C:\\", got "C:\" package.c:6586: Test failed: Expected 4, got 3 package.c:6592: Test failed: Expected "C:\\", got "C:\" package.c:6593: Test failed: Expected 4, got 3 package.c:6600: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6601: Test failed: Expected 14, got 13 package.c:6608: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6609: Test failed: Expected 19, got 18 package.c:6619: Test failed: Expected "C:\\", got "C:\" package.c:6620: Test failed: Expected 4, got 3 package.c:6627: Test failed: Expected "C:\\", got "C:\" package.c:6628: Test failed: Expected 4, got 3 package.c:6644: Test failed: Expected "C:\\", got "C:\" package.c:6645: Test failed: Expected 4, got 3 package.c:6651: Test failed: Expected "C:\\", got "C:\" package.c:6652: Test failed: Expected 4, got 3 package.c:6659: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6660: Test failed: Expected 14, got 13 package.c:6667: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6668: Test failed: Expected 19, got 18 package.c:6678: Test failed: Expected "C:\\", got "C:\" package.c:6679: Test failed: Expected 4, got 3 package.c:6686: Test failed: Expected "C:\\", got "C:\" package.c:6687: Test failed: Expected 4, got 3 package.c:6703: Test failed: Expected "C:\\", got "C:\" package.c:6704: Test failed: Expected 4, got 3 package.c:6710: Test failed: Expected "C:\\", got "C:\" package.c:6711: Test failed: Expected 4, got 3 package.c:6718: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6719: Test failed: Expected 14, got 13 package.c:6726: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6727: Test failed: Expected 19, got 18 package.c:6737: Test failed: Expected "C:\\", got "C:\" package.c:6738: Test failed: Expected 4, got 3 package.c:6745: Test failed: Expected "C:\\", got "C:\" package.c:6746: Test failed: Expected 4, got 3 package.c:6762: Test failed: Expected "C:\\", got "C:\" package.c:6763: Test failed: Expected 4, got 3 package.c:6769: Test failed: Expected "C:\\", got "C:\" package.c:6770: Test failed: Expected 4, got 3 package.c:6777: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6778: Test failed: Expected 14, got 13 package.c:6785: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6786: Test failed: Expected 19, got 18 package.c:6801: Test failed: Expected 4, got 3 package.c:6818: Test failed: Expected 4, got 3 package.c:6824: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6827: Test failed: Expected 4, got 3 package.c:6834: Test failed: Expected "C:\\", got "C:\" package.c:6835: Test failed: Expected 4, got 3 package.c:6846: Test failed: Expected "C:\\", got "C:\" package.c:6847: Test failed: Expected 4, got 3 package.c:6942: Test failed: Expected "C:\\", got "C:\" package.c:6943: Test failed: Expected 4, got 3 package.c:6950: Test failed: Expected "C:\\", got "C:\" package.c:6951: Test failed: Expected 4, got 3 package.c:6960: Test failed: Expected "C:\\", got "C:\" package.c:6961: Test failed: Expected 4, got 3 package.c:6969: Test failed: Expected "C:\\", got "C:\" package.c:6970: Test failed: Expected 4, got 3 package.c:6976: Test failed: Expected "C:\\", got "C:\" package.c:6977: Test failed: Expected 4, got 3 package.c:6984: Test failed: Expected "C:\\", got "C:\" package.c:6985: Test failed: Expected 4, got 3 package.c:6992: Test failed: Expected "C:\\", got "C:\" package.c:6993: Test failed: Expected 4, got 3 package.c:7003: Test failed: Expected "C:\\", got "C:\" package.c:7004: Test failed: Expected 4, got 3 package.c:7011: Test failed: Expected "C:\\", got "C:\" package.c:7012: Test failed: Expected 4, got 3 package.c:7021: Test failed: Expected "C:\\", got "C:\" package.c:7022: Test failed: Expected 4, got 3 package.c:7030: Test failed: Expected "C:\\", got "C:\" package.c:7031: Test failed: Expected 4, got 3 package.c:7037: Test failed: Expected "C:\\", got "C:\" package.c:7038: Test failed: Expected 4, got 3 package.c:7045: Test failed: Expected "C:\\", got "C:\" package.c:7046: Test failed: Expected 4, got 3 package.c:7053: Test failed: Expected "C:\\", got "C:\" package.c:7054: Test failed: Expected 4, got 3 package.c:7064: Test failed: Expected "C:\\", got "C:\" package.c:7065: Test failed: Expected 4, got 3 package.c:7072: Test failed: Expected "C:\\", got "C:\" package.c:7073: Test failed: Expected 4, got 3 package.c:7082: Test failed: Expected "C:\\", got "C:\" package.c:7083: Test failed: Expected 4, got 3 package.c:7091: Test failed: Expected "C:\\", got "C:\" package.c:7092: Test failed: Expected 4, got 3 package.c:7098: Test failed: Expected "C:\\", got "C:\" package.c:7099: Test failed: Expected 4, got 3 package.c:7106: Test failed: Expected "C:\\", got "C:\" package.c:7107: Test failed: Expected 4, got 3 package.c:7114: Test failed: Expected "C:\\", got "C:\" package.c:7115: Test failed: Expected 4, got 3 package.c:7125: Test failed: Expected "C:\\", got "C:\" package.c:7126: Test failed: Expected 4, got 3 package.c:7133: Test failed: Expected "C:\\", got "C:\" package.c:7134: Test failed: Expected 4, got 3 package.c:7143: Test failed: Expected "C:\\", got "C:\" package.c:7144: Test failed: Expected 4, got 3 package.c:7152: Test failed: Expected "C:\\", got "C:\" package.c:7153: Test failed: Expected 4, got 3 package.c:7159: Test failed: Expected "C:\\", got "C:\" package.c:7160: Test failed: Expected 4, got 3 package.c:7167: Test failed: Expected "C:\\", got "C:\" package.c:7168: Test failed: Expected 4, got 3 package.c:7175: Test failed: Expected "C:\\", got "C:\" package.c:7176: Test failed: Expected 4, got 3 package.c:7273: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7274: Test failed: Expected 9, got 8 package.c:7283: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7284: Test failed: Expected 9, got 8 package.c:7293: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7294: Test failed: Expected 9, got 8 package.c:7305: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7306: Test failed: Expected 8, got 7 package.c:7317: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7318: Test failed: Expected 9, got 8 package.c:7329: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7330: Test failed: Expected 8, got 7 package.c:7341: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7342: Test failed: Expected 10, got 9 package.c:7353: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7354: Test failed: Expected 8, got 7 package.c:7365: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7366: Test failed: Expected 11, got 10 package.c:7417: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7418: Test failed: Expected 10, got 9 package.c:7427: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7428: Test failed: Expected 10, got 9 package.c:7437: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7438: Test failed: Expected 10, got 9 package.c:7449: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7450: Test failed: Expected 8, got 7 package.c:7461: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7462: Test failed: Expected 10, got 9 package.c:7473: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7474: Test failed: Expected 9, got 8 package.c:7485: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7486: Test failed: Expected 10, got 9 package.c:7497: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7498: Test failed: Expected 9, got 8 package.c:7509: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7510: Test failed: Expected 11, got 10 package.c:7646: Test failed: Expected "C:\\", got "C:\" package.c:7647: Test failed: Expected 4, got 3 package.c:7658: Test failed: Expected "C:\\", got "C:\" package.c:7659: Test failed: Expected 4, got 3 package.c:7666: Test failed: Expected "C:\\", got "C:\" package.c:7667: Test failed: Expected 4, got 3 package.c:7764: Test failed: Expected "C:\\", got "C:\" package.c:7765: Test failed: Expected 4, got 3 package.c:7772: Test failed: Expected "C:\\", got "C:\" package.c:7773: Test failed: Expected 4, got 3 package.c:7780: Test failed: Expected "C:\\", got "C:\" package.c:7781: Test failed: Expected 4, got 3 package.c:7800: Test failed: Expected "C:\\", got "C:\" package.c:7801: Test failed: Expected 4, got 3 package.c:7808: Test failed: Expected "C:\\", got "C:\" package.c:7809: Test failed: Expected 4, got 3 package.c:7828: Test failed: Expected "C:\\", got "C:\" package.c:7829: Test failed: Expected 4, got 3 package.c:7836: Test failed: Expected "C:\\", got "C:\" package.c:7837: Test failed: Expected 4, got 3 package.c:7856: Test failed: Expected "C:\\", got "C:\" package.c:7857: Test failed: Expected 4, got 3 package.c:7864: Test failed: Expected "C:\\", got "C:\" package.c:7865: Test failed: Expected 4, got 3

March 5, 2014

Re: atl/tests: Update registrar's is_process_limited() to deal with non-administrator, non-power user accounts.

by Jacek Caban

Hi Francois, On 03/05/14 11:31, Francois Gouget wrote: > --- > > This should fix the test failures on the fg-win2000-rusr, fg-winxp-lusr > and fg-win7u64-1spie9usr VMs. I think we could change tests to use HKCU only so that those checks are not needed. Could you please test if the attached patch works on those boxes? Thanks, Jacek

March 5, 2014