March 2014 - Wine-Devel - list.winehq.org

Re: gdiplus: skip some tests if Arial is not installed

by Dmitry Timoshkov

Austin English <austinenglish(a)gmail.com> wrote: > + status = GdipCreateFontFamilyFromName(Arial, NULL, &family); > + if (status == FontFamilyNotFound) > + { > + skip("Arial not installed\n"); > + return; > + } Why do you need this? This test doesn't depend on Arial font presence. -- Dmitry.

March 23, 2014

Re: gdi32: skip some tests if Times New Roman is not installed

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5864 Your paranoid android. === w8 (32 bit font) === font.c:3615: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3615: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c

March 22, 2014

Re: ws2_32: skip some tests on broken ISPs

by Austin English

On Sat, Mar 22, 2014 at 2:04 PM, Marvin <testbot(a)winehq.org> wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5855 > > Your paranoid android. > > > === w2000pro (32 bit sock) === > sock: unhandled exception c0000005 at C0000241 > > === wxppro (32 bit sock) === > sock: unhandled exception c0000005 at 71AB3F3A > > === wvistau64 (32 bit sock) === > sock: unhandled exception c0000005 at 00000000 > Not related to my patch: https://testbot.winehq.org/JobDetails.pl?Key=5856 -- -Austin

March 22, 2014

Re: ws2_32: skip some tests on broken ISPs

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5855 Your paranoid android. === w2000pro (32 bit sock) === sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB3F3A === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

March 22, 2014

Re: user32: Fix side effect in SubtractRect()

by Nikolay Sivov

On 3/23/2014 00:06, Javier Cantero wrote: >> Hi, Jose. >> >> Please add a test case for this change to user32/tests/uitools.c >> > OK, but... I don't see any test function for SubtractRect() in > dlls/user32/tests/uitools.c (in fact there is only 1 test case in that > file). > > Am I missing something? That means we don't have any tests for it yet, so feel free to add test_SubtractRect(). >

March 22, 2014

Re: user32: Fix side effect in SubtractRect()

by Javier Cantero

> Hi, Jose. > > Please add a test case for this change to user32/tests/uitools.c > OK, but... I don't see any test function for SubtractRect() in dlls/user32/tests/uitools.c (in fact there is only 1 test case in that file). Am I missing something?

March 22, 2014

Re: wintab: Incorrectly classifying cursor as stylus instead of eraser

by John Klehm

Hello, >To be able to prioritize we have to change current functions into smth like this: >get_cursor_type(cursor) { //new function > can we determine type based on cursor.device? Yes -> return CSR_TYPE_PEN; > can we determine type based on cursor.name? Yes -> return CSR_TYPE_ERASER; > return CSR_TYPE_OTHER; >} I worked on this code a little bit back in the day, I remember the detection stuff getting weird due to some odd ball drivers (non-wacom stuff doing strange things). Bug http://bugs.winehq.org/show_bug.cgi?id=11699 and specifically the log http://bugs.winehq.org/attachment.cgi?id=13358 of an Acecad table driver's settings. Just thought it might be handy to consider if you were to take a shot at rewriting the detection code. Regards, --John On Fri, Mar 21, 2014 at 4:09 AM, Michael Stefaniuc <mstefani(a)redhat.com>wrote: > On 03/21/2014 10:04 AM, Eriks Dobelis wrote: > > To be able to prioritize we have to change current functions into smth > > like this: > > > > get_cursor_type(cursor) { //new function > > can we determine type based on cursor.device? Yes -> return > > CSR_TYPE_PEN; > > can we determine type based on cursor.name? Yes -> return > > CSR_TYPE_ERASER; > > return CSR_TYPE_OTHER; > > } > > > > and rewriting is_stylus and is_eraser into more simple functions like > > is_stylus(cursor) { > > return get_cursor_type(cursor) == CSR_TYPE_PEN; > > } > In that case you could actually get rid of the is_* functions; > "get_cursor_type(cursor) == CSR_TYPE_PEN" is as readable. > > bye > michael > > > > > > > On 2014.03.21. 10:54, Alexandre Julliard wrote: > >> Eriks Dobelis <eriks.dobelis(a)biti.lv> writes: > >> > >>> The alternative - just to switch order of checks in > >>> X11DRV_LoadTabletInfo. There is a code fragment: > >>> /* prefer finding TYPE_PEN(most capable) */ > >>> if (is_stylus(target->name, device_type)) > >>> cursor.TYPE = CSR_TYPE_PEN; > >>> else if (is_eraser(target->name, device_type)) > >>> cursor.TYPE = CSR_TYPE_ERASER; > >>> else > >>> cursor.TYPE = CSR_TYPE_OTHER; > >>> > >>> I would need to switch order and check for ERASER first. Problems > >>> would arise if for some device name would be "Pen & Eraser", and type > >>> would be "STYLUS" , and then it would be detected as eraser. In the > >>> proposed patch this problem would not arise as only device is checked > >>> for ERASER. For my specific case both approaches work. Which one you > >>> consider as better? > >> Maybe a better way would be to restructure the checks, and give priority > >> to the type over the name or something like that. The thing is that we > >> don't want to have an is_stylus function that also checks for erasers, > >> and then an is_eraser function with slightly different checks. > >> > > > > > > > > > -- > Michael Stefaniuc Tel.: +49-711-96437-199 > Supervisor, APAC/EMEA IT Network Fax.: +49-711-96437-111 > -------------------------------------------------------------------- > Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 Grasbrunn > Handelsregister: Amtsgericht Muenchen HRB 153243 > Geschäftsführer: Mark Hegarty, Charlie Peters, Michael Cunningham, > Charles Cachera > > >

March 22, 2014

Re: Mass effect 2 - Bink movies freezes game

by Tomas Gustavsson

Who knew.. It works on my laptop, my cpu is a Intel(R) Core(TM) i3-2350M CPU @ 2.30GHz. But the laptop is not good enough to play this effect, would like to get it working on my other machine (with a HD5770 GPU). Have wanted to try out the open source drivers for the GPU, sadly I get some error about DRI3 that stops my attempt every time I try to start the game! 2014-03-21 22:11 GMT+01:00 Tomas Gustavsson <tomplast(a)gmail.com>: > Hi! > > Have tried for a while to get Mass Effect 2 working through Wine and > though it's very playable for me it has a large drawback, I have to disable > all movie playbacks with the -nomoviestartup argument. If I don't, the > game freezes up and I can hear the sound stuck in a loop - it does not > unfreeze itself. > > By looking through AppDB it seems that there are a large group of people > that doesn't have this problem. I assume it's either related to my > processor (AMD A10-6700) or GPU (HD5770, Catalyst driver)? I have tried to > several Wine versions but it didn't help. > > The interesting thing is that there are many Windows users with the exact > problem. Here's a link > http://answers.ea.com/t5/Mass-Effect-2/Can-t-run-ME2-without-nomoviestartup…. > > So though the game works rather well, an important part (and some > locations in the game supposedly breaks when you use nomoviestartup) is > lost when movies are turned off, at least for me. > > Is there any way to debug the bink movie playback functionality? Because I > really would like to be able to play the game without losing the ability to > watch the ingame movies. > > Best regards > /Tomas Gustavsson >

March 22, 2014

Re: user32: Fix side effect in SubtractRect()

by Nikolay Sivov

Hi, Jose. Please add a test case for this change to user32/tests/uitools.c

March 22, 2014

Ignore me

by Jeremy Newman

I am a test post... -N

March 22, 2014