March 2014 - Wine-Devel - list.winehq.org

Re: GSoC 2014 proposal - Implement VBScript built-in functions

by Shuai Meng

Thank you. I have finished it. 2014-03-21 15:37 GMT+08:00 Austin English <austinenglish(a)gmail.com>: > > > > On Thu, Mar 20, 2014 at 4:33 AM, 孟帅 <mengshuaicalendr(a)gmail.com> wrote: >> >> Hi all! >> I'm Shuai Meng, a student from software school of Beihang University, >> China, GMT+08:00. I'm pursuing a master degree and now in grade one. >> You can call me shuaimeng, that's my nickname used in irc. Now I'm >> here to apply for GSoC to work for Wine. I'm familiar with C, and I >> can code with python as well. Besides, I know a little about html and >> vbscript. From May to August, I have plenty of free time. >> >> About one year ago I started my way to linux, it's not smooth for a >> person who had got used to windows then embrace linux. Soon I got a >> problem: QQ(the most popular IM software in China) doesn't support >> linux, but I really need it. Fortunately I knew wine through searching >> google, it helped me solve this problem.Since then I have become a >> wine user. >> >> In the past three months, I had focused on dlls/vbscript/global.c, >> searching MSDN for related documents[1]~[4]. Accordding those >> documents, I added more tests in dlls/vbscript/tests/api.vbs, then got >> some similar bugs and only reported one[5]. In order to fix them, I >> read wine source code in dlls/vbscript/global.c, again and again. >> Finally I finished a few draft patches[6] and I will send them to >> wine-patches later. >> >> As I have made so much effort in this module and gain a little >> experience, during GSoC this part will go on to occupy most of my >> attention. On the basis of difficulty to be implemented, I divide all >> the functions in dlls/vbscript/global.c into four groups as following: >> >> 1: Abs ScriptEngine ScriptEngineBuildVersion ScriptEngineMajorVersion >> IsArray IsDate IsNumeric IsObject Sgn TypeName VarType >> >> These are the easiest to implement, I will take about one week to >> finish the unimplemented. >> >> 2: FormatCurrency FormatDateTime FormatPercent Hour FormatNumber Join >> Minute Month Oct Rnd Second Space TimeValue Year >> >> The second group will occupy two weeks of the whole GSoC time. They >> are not as easy as the first group and there are more to be >> accomplished. Most of them are involved in time functions while a few >> is about strings. >> >> 3: Asc Ant Cos DateAdd DateDiff DatePart DateSerial Day Exp LBound Log >> Replace Sin Sqr String Tan TimeSerial UBound Weekday CBool CByte CCur >> CDate CDbl CInt CLng CSng CStr InStrRev Int Fix StrComp Timer >> >> These are more difficult. However a large part is conversion functions >> and they have been implemented or improved by me. You can find the >> details in attchment. Optimistically speaking, I need at least three >> weeks to complete all of them. When I finish that, this bug[7] will be >> fixed. >> >> 4: Array Date DateValue Escape Eval Filter GetLocale GetRef InputBox >> LoadPicture Now RGB SetLocale >> Split Time Unescape >> >> Here come the most difficult ones. I am not so sure whether I can fix >> or even understand them, but I will try my best. Maybe after I have >> finish the above three groups, I can gain a little confidence to face >> them. This group would cost me four weeks or even longer. If I have a >> good luck, maybe I can fix this bug[8]. >> >> To be prudent, I'll spare at least one week to do a review on all my >> codes. Write a summary as a guidence for my work to be continued after >> GSoC. >> >> Though I have a rough plan now, as a greenhand to wine, I hava too >> much to learn and I badly need advice from all of you. I hope I can >> make a proper schedule after communicating with my mentor. >> >> Any comment or advice is greatly appreciated. >> Thank you! >> >> >> [1]http://msdn.microsoft.com/en-us/library/9e7a57cf(v=vs.84).aspx >> [2]http://msdn.microsoft.com/en-us/library/t7zd6etz(v=vs.84).aspx >> [3]http://msdn.microsoft.com/en-us/library/3ca8tfek(v=vs.84).aspx >> [4]http://msdn.microsoft.com/en-us/library/10wcf65z(v=vs.84).aspx >> [5]http://bugs.winehq.org/show_bug.cgi?id=35441 >> [6]In the attachment >> [7]http://bugs.winehq.org/show_bug.cgi?id=34913 >> [8]http://bugs.winehq.org/show_bug.cgi?id=35472 >> >> >> > > Hello Shuai, > > For your proposal to be considered, it must be submitted to Melange by the > deadline (though it was good to introduce yourself here, I don't want you to > miss the deadline :)). > > -- > -Austin

March 21, 2014

Re: netcfgx: Add INetCfg interface support

by Michael Stefaniuc

Hello Alistair, On 03/21/2014 08:11 AM, Alistair Leslie-Hughes wrote: > On 21/03/2014 11:25 AM, Marvin wrote: >> Hi, >> >> While running your changed tests on Windows, I think I found new >> failures. >> Being a bot and all I'm not very good at pattern recognition, so I >> might be >> wrong, but could you please double-check? >> Full results can be found at >> https://newtestbot.winehq.org/JobDetails.pl?Key=5820 >> >> Your paranoid android. >> > This is due to the missing configure.ac/configure in the patch. > Should we include configure.ac nowadays? I do include both configure.ac and configure because of the testbot. They are oneliners so the "spam" is minimal. bye michael

March 21, 2014

Re: GSoC 2014 proposal - Implement VBScript built-in functions

by Austin English

On Thu, Mar 20, 2014 at 4:33 AM, 孟帅 <mengshuaicalendr(a)gmail.com> wrote: > Hi all! > I'm Shuai Meng, a student from software school of Beihang University, > China, GMT+08:00. I'm pursuing a master degree and now in grade one. > You can call me shuaimeng, that's my nickname used in irc. Now I'm > here to apply for GSoC to work for Wine. I'm familiar with C, and I > can code with python as well. Besides, I know a little about html and > vbscript. From May to August, I have plenty of free time. > > About one year ago I started my way to linux, it's not smooth for a > person who had got used to windows then embrace linux. Soon I got a > problem: QQ(the most popular IM software in China) doesn't support > linux, but I really need it. Fortunately I knew wine through searching > google, it helped me solve this problem.Since then I have become a > wine user. > > In the past three months, I had focused on dlls/vbscript/global.c, > searching MSDN for related documents[1]~[4]. Accordding those > documents, I added more tests in dlls/vbscript/tests/api.vbs, then got > some similar bugs and only reported one[5]. In order to fix them, I > read wine source code in dlls/vbscript/global.c, again and again. > Finally I finished a few draft patches[6] and I will send them to > wine-patches later. > > As I have made so much effort in this module and gain a little > experience, during GSoC this part will go on to occupy most of my > attention. On the basis of difficulty to be implemented, I divide all > the functions in dlls/vbscript/global.c into four groups as following: > > 1: Abs ScriptEngine ScriptEngineBuildVersion ScriptEngineMajorVersion > IsArray IsDate IsNumeric IsObject Sgn TypeName VarType > > These are the easiest to implement, I will take about one week to > finish the unimplemented. > > 2: FormatCurrency FormatDateTime FormatPercent Hour FormatNumber Join > Minute Month Oct Rnd Second Space TimeValue Year > > The second group will occupy two weeks of the whole GSoC time. They > are not as easy as the first group and there are more to be > accomplished. Most of them are involved in time functions while a few > is about strings. > > 3: Asc Ant Cos DateAdd DateDiff DatePart DateSerial Day Exp LBound Log > Replace Sin Sqr String Tan TimeSerial UBound Weekday CBool CByte CCur > CDate CDbl CInt CLng CSng CStr InStrRev Int Fix StrComp Timer > > These are more difficult. However a large part is conversion functions > and they have been implemented or improved by me. You can find the > details in attchment. Optimistically speaking, I need at least three > weeks to complete all of them. When I finish that, this bug[7] will be > fixed. > > 4: Array Date DateValue Escape Eval Filter GetLocale GetRef InputBox > LoadPicture Now RGB SetLocale > Split Time Unescape > > Here come the most difficult ones. I am not so sure whether I can fix > or even understand them, but I will try my best. Maybe after I have > finish the above three groups, I can gain a little confidence to face > them. This group would cost me four weeks or even longer. If I have a > good luck, maybe I can fix this bug[8]. > > To be prudent, I'll spare at least one week to do a review on all my > codes. Write a summary as a guidence for my work to be continued after > GSoC. > > Though I have a rough plan now, as a greenhand to wine, I hava too > much to learn and I badly need advice from all of you. I hope I can > make a proper schedule after communicating with my mentor. > > Any comment or advice is greatly appreciated. > Thank you! > > > [1]http://msdn.microsoft.com/en-us/library/9e7a57cf(v=vs.84).aspx > [2]http://msdn.microsoft.com/en-us/library/t7zd6etz(v=vs.84).aspx > [3]http://msdn.microsoft.com/en-us/library/3ca8tfek(v=vs.84).aspx > [4]http://msdn.microsoft.com/en-us/library/10wcf65z(v=vs.84).aspx > [5]http://bugs.winehq.org/show_bug.cgi?id=35441 > [6]In the attachment > [7]http://bugs.winehq.org/show_bug.cgi?id=34913 > [8]http://bugs.winehq.org/show_bug.cgi?id=35472 > > > > Hello Shuai, For your proposal to be considered, it must be submitted to Melange by the deadline (though it was good to introduce yourself here, I don't want you to miss the deadline :)). -- -Austin

March 21, 2014

Re: [1/3] widl: Pass type attributes from write_array_tfs to write_pointer_description. Take 2.

by Dmitry Timoshkov

Nikolay Sivov <bunglehead(a)gmail.com> wrote: > I think it'd be cleaner to let write_pointer_description() handle that, > as now you pass all needed info in anyway. My intent was to not cause more unwnted changes than really required at this point, and since the only caller of write_pointer_description() that is interested in passing attribues is write_array_tfs() then it's more logical IMO to make the decision in write_array_tfs() itself. -- Dmitry.

March 21, 2014

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5825 Your paranoid android. === build (build) === Make failed

March 21, 2014

Re: [1/3] widl: Pass type attributes from write_array_tfs to write_pointer_description. Take 2.

by Nikolay Sivov

On 3/21/2014 11:09, Dmitry Timoshkov wrote: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). > > This version of the patch limits write_array_tfs() to pass attributes > to write_pointer_description() only for strings and avoids unwanted > changes to other pointer types. > --- > tools/widl/typegen.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index 37d18f5..889d8c5 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -2728,7 +2728,7 @@ static int write_varying_array_pointer_descriptions( > return pointer_count; > } > > -static void write_pointer_description(FILE *file, type_t *type, > +static void write_pointer_description(FILE *file, const attr_list_t *attrs, type_t *type, > unsigned int *typestring_offset) > { > unsigned int offset_in_buffer; > @@ -2757,7 +2757,7 @@ static void write_pointer_description(FILE *file, type_t *type, > if (is_conformant_array(type) && > (type_array_is_decl_as_ptr(type) || !current_structure)) > write_conformant_array_pointer_descriptions( > - file, NULL, type, 0, typestring_offset); > + file, attrs, type, 0, typestring_offset); > else if (type_get_type(type) == TYPE_STRUCT && > get_struct_fc(type) == RPC_FC_CPSTRUCT) > { > @@ -2962,7 +2962,7 @@ static unsigned int write_array_tfs(FILE *file, const attr_list_t *attrs, type_t > print_file(file, 2, "0x%x,\t/* FC_PP */\n", RPC_FC_PP); > print_file(file, 2, "0x%x,\t/* FC_PAD */\n", RPC_FC_PAD); > *typestring_offset += 2; > - write_pointer_description(file, type, typestring_offset); > + write_pointer_description(file, is_string_type(attrs, type) ? attrs : NULL, type, typestring_offset); I think it'd be cleaner to let write_pointer_description() handle that, as now you pass all needed info in anyway.

March 21, 2014

Re: netcfgx: Add INetCfg interface support

by Alistair Leslie-Hughes

On 21/03/2014 11:25 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=5820 > > Your paranoid android. > This is due to the missing configure.ac/configure in the patch. Should we include configure.ac nowadays? Best Regards Alistair Leslie-Hughes

March 21, 2014

Re: wintab: Incorrectly classifying cursor as stylus instead of eraser

by Eriks Dobelis

The alternative - just to switch order of checks in X11DRV_LoadTabletInfo. There is a code fragment: /* prefer finding TYPE_PEN(most capable) */ if (is_stylus(target->name, device_type)) cursor.TYPE = CSR_TYPE_PEN; else if (is_eraser(target->name, device_type)) cursor.TYPE = CSR_TYPE_ERASER; else cursor.TYPE = CSR_TYPE_OTHER; I would need to switch order and check for ERASER first. Problems would arise if for some device name would be "Pen & Eraser", and type would be "STYLUS" , and then it would be detected as eraser. In the proposed patch this problem would not arise as only device is checked for ERASER. For my specific case both approaches work. Which one you consider as better? On 2014.03.20. 22:11, Alexandre Julliard wrote: > Eriks Dobelis <eriks.dobelis(a)biti.lv> writes: > >> Did not attach the patch in my last email :( >> >> For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly >> detected as stylus. >> The tablet returns its eraser cursor name as: >> Wacom Intuos PT S Pen eraser >> and type as: >> ERASER >> >> Current code classifies this as STYLUS, because name of the cursor >> contains the word 'Pen'. It is very unlikely that a cursor with type >> ERASER is STYLUS. > There is already a check for eraser type, you should be able to use that > instead. >

March 21, 2014

Re: Advice fixing #13683 (DirectX mouse overlay?)

by Christopher Thielen

I could be running it wrong but both: WINEDEBUG=d3d+warn wine ./u9.exe and WINEDEBUG=+d3d+warn wine ./u9.exe show no lines about D3D warnings. Just this, right at program start: fixme:d3d:init_driver_info Unable to find a driver/device info for vendor_id=0x10de device_id=0x421 for driver_model=2 fixme:win:EnumDisplayDevicesW ((null),0,0x32e8c8,0x00000000), stub! fixme:d3d:init_driver_info Unable to find a driver/device info for vendor_id=0x10de device_id=0x421 for driver_model=2 fixme:win:EnumDisplayDevicesW ((null),0,0x32e6a8,0x00000000), stub! fixme:d3d:resource_check_usage Unhandled usage flags 0x8. fixme:d3d:resource_check_usage Unhandled usage flags 0x8. apitrace is really neat, thanks for pointing it out. I ran it on Windows XP with the Ultima IX (GOG edition) and generated a trace - which shows the missing mouse cursor - then rebooted into Linux and ran the Windows version of apitrace's GUI using the same .trace file and it _did_ also show the mouse cursor, running under Wine. What does this mean? What direction would one explore from here? How is it when u9.exe executes the same D3D calls (running the game under Wine) the cursor is missing but when Wine runs the apitrace GUI, making the same D3D calls and getting translated through the same Wine code, the cursor doesn't appear. What am I missing? Also, I don't know apitrace that well, but is the per-frame 'texture' tab only showing textures utilized in that frame, not counting anything already in the framebuffer? I couldn't find the cursor texture after looking at about two dozen frames, but then again, I didn't find most textures using that method. I did run an apitrace of Ultima IX (GOG edition) on Linux for kicks but I don't think it'll help much. There is a factor of about 4x as many calls per frame when running under Wine FYI, but I'm assuming the Wine D3D folks are already aware of that sort of issue. On 03/19/2014 03:13 PM, Stefan Dösinger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2014-03-19 22:45, schrieb Christopher Thielen: >> I determined this isn't the User32 cursor stuff. It's probably a >> D3D surface with incorrect properties. > Apitrace works for d3d9. > >> Can anyone recommend an OpenGL debugger or other mechanism for >> exploring the surfaces of a given scene and playing with their >> properties? My guess is the tools are pretty primitive for this >> kind of thing. > Did you see if d3d+warn writes anything about failed surface creation? > > You can try to record a game drawing with apitrace on Windows and see > if it plays back correctly on Wine. Also check if the playback shows > the mouse pointer in Windows. > > I don't know if d3d9 recording with apitrace works in Wine - it might > just work, or it might be missing some DECLSPEC_HOTPATCH markers on > some d3d9 functions. > > You can also use the Linux version of apitrace to record the opengl > calls wined3d creates. This will probably not help you in your case. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJTKhZ3AAoJEN0/YqbEcdMwuxsP/iK9wDECv6CoMjYxjDo1yxQV > jPC0KbSUw2DwUl0fFTCdWi6PxeTUoz8Hp2IC60D07BvGDiPaxJwRvewfO5jeYuqr > sINzPgk5NgnZjkUN+cs4oGYlEFXY4p02eSe3uZhihlD0lnbJ0pV/g+8f4RPeIctM > acTdC6kaIOUQLkRGliOotaj3w27e5QomXiaHcn1l8Ov3of7dBnJtg7hJTvlymL0g > bUOpnCVHtN1BoeWwQUPUEzhqMjmU4gUCgBZ7lBDsbReeNmFHoeR0QaIqC8EWKr0D > jznbKuAjuK+9GB/cVhqJj+hHlCaj6xoyNfOQQ34KHYcdtbAMhOTCkJbKzPmCeH8r > xU3C2nSH88fld/Ie7oULE671XUNnXjPgDQPIcyeBC3PYZ33dR5vzLJrMA63/zA9X > dP2qiF/A2N7Sk0Mq0FHtKcLICo9W+w7AXOdksZlrWEX4iiUB6LX3sQ+vMm+IePL0 > WxcxP4CEAhXGiu/bub4hj8y3BbvbfyQklrZ4cz05iIf+WS4xYo6cwZ53ciVpgwBu > V52s8N/XpC6QSy7UpqV1b6JuvMliHlLKGSbCZMezbsB6mShKdGyq45T1JhGukkh0 > Q3DEQoX5TQSg8RqyRwr8coDZDwD0zese6uE+aVuzzznyY0LrTDo4Jio+Y3mWL45e > jivFvw1C6uoFTKPqU8oM > =QPSs > -----END PGP SIGNATURE----- >

March 21, 2014

Re: netcfgx: Add INetCfg interface support

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5820 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

March 21, 2014