March 2014 - Wine-Devel - list.winehq.org

About GSoC - The Wine Project

by SpedsT .

Hello. I want to apply to this project and I have a question about this note: * Note: Beginning with Summer of Code 2014, applicants *MUST* have submitted a patch or testcase to wine-patches (see http://wiki.winehq.org/SubmittingPatches) to be considered for acceptance. What kind of patch or testcase should I submit, what would you like to be about?

March 15, 2014

Re: gdiplus: Use BOOL type where appropriate

by Vincent Povirk

On Sat, Mar 15, 2014 at 9:44 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - rotate_90 = type&1; > + rotate_90 = (type & 1) != 0; > flip_x = (type&6) == 2 || (type&6) == 4; > flip_y = (type&3) == 1 || (type&3) == 2; If you must change the style, I prefer (type&1) == 1 here, as it has fewer negatives and matches the lines after it.

March 15, 2014

Re: mshtml: Added IHTMLTableRow::rowIndex property implementation.

by Zhenbo Li

Sorry, I sent the same patch twice due to network problem. Please ignore the second one. Thank you. 2014-03-15 11:23 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/mshtml/htmltablerow.c | 11 +++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > -- Have a nice day! Zhenbo Li

March 15, 2014

Re: Ideas about mshtml for GSoC 2014

by Zhenbo Li

Hi Jacek, 2014-03-14 22:22 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>: > > Sorry for the delay. I'm not sure that's the best strategy for having > results that will help users in general. Having all functions implemented is > a nice thing, but many of them don't cause problems in real world > application and web pages. I think I would prefer testing random web pages > and implementing things that they need. This, however, would be tricky to > set goals required for GSoC application. Maybe you could come up with a mix > of both? Start with selected area (say, IHTMLTable*, not necessarily whole) > and move to random APIs required by pages as the project progresses? > I think work on both of them is a great idea, And I'm glad to do such job. As you said, it is not easy to set up goals. I have nearly 12 weeks, so my previous plan is to split them into several parts: IHTMLTableCell 3 weeks IHTMLTableCol & IHTMLTableRow 3 weeks IHTMLTableSection 2 weeks IHTMLTable 4 weeks (test-cases included) I don't know if this meets the need of GSoC. Also, is it necessary to add "fix real work webpage/app problem" in this schedule? Thank you very much. > Cheers, > Jacek -- Have a nice day! Zhenbo Li

March 15, 2014

Re: [PATCH 2/2] wined3d: Re-use old wined3d_private_data structures if the size matches.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-03-14 16:27, schrieb Henri Verbeet: > On 14 March 2014 14:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> + if ((old = wined3d_private_store_get_private_data(store, guid)) && old->size == data_size) >> + { >> + IUnknown *release = NULL; >> + if (old->flags & WINED3DSPD_IUNKNOWN) >> + release = old->content.object; >> + memcpy(old->content.data, ptr, data_size); >> + old->flags = flags; >> + if (flags & WINED3DSPD_IUNKNOWN) >> + IUnknown_AddRef(old->content.object); >> + if (release) >> + IUnknown_Release(release); >> + return WINED3D_OK; >> + } > What is the motivation for this? It certainly doesn't make the code > any prettier. Avoid re-allocating the same sized object needlessly. But I don't feel strongly about it. I'll send a separate patch that fixes the release before addref problem without retaining the allocated memory. Pick whichever you like. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTIyb4AAoJEN0/YqbEcdMw4A4QAJHCponfvsfW50Hq+Oumolxo yP9nEnNz41PsMrWIKPN10McjJDlN002G7wy9B1WQu52zbNHAnt8eIetRb96S+b6i WP5dRF7dx1LWSbK0x/qek7vZAqWapLtvxhxRxNxM/k6jTetWfpI2WC+tmzXS49Z1 ZlgsvI2zx6rzfGpfMbvXIhBfUtm4aPb+OIJ3zaytctZPBcSa9V+xUo43faLRKljz zEV4C1Vn/Jqx6PMjx6zQ968/sUQq0P5D5fUq/UBStUEPyRhscneKpmaQSmeKO0tG Y9FlwXdnd1Gv7jZqT8Ixx/QAb4voql1hUqh9ZVxx/DoqwJzCbDXNprzIQG0+hlFq mAFBOUVhuqH2bokiFkbOh66h4TEBScQcfEraPdbA48FumQ06o0cl6HTRXN+O76jg SI02NVjol603BFzjfobE3RULi0ar+HVholu9fz3z8MzRvXLnWXXh2W9HH1mDgJ3u /PSBduOjal+lJWn7ZYo/ZlLMWKWLDIYgRzhB6fpqUAQg3kGtuh9N14WgQWEwOhaK NPO5u1CL2z/LN6qdjyYWhEJiRCh1XV4l8d8Waq4KOPnySnGQiPFMQUTGwUEix3SU fCZYCSDgVAL9y9m35A/JyFaCA2Vn+z6SUcO0g1UKtVKroD7JRb1ayqN6WVX2nEkH 8oWDPyCqOY0fIaUrKh6l =fdE1 -----END PGP SIGNATURE-----

March 14, 2014

Re: [PATCH 2/2] wined3d: Re-use old wined3d_private_data structures if the size matches.

by Henri Verbeet

On 14 March 2014 14:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if ((old = wined3d_private_store_get_private_data(store, guid)) && old->size == data_size) > + { > + IUnknown *release = NULL; > + if (old->flags & WINED3DSPD_IUNKNOWN) > + release = old->content.object; > + memcpy(old->content.data, ptr, data_size); > + old->flags = flags; > + if (flags & WINED3DSPD_IUNKNOWN) > + IUnknown_AddRef(old->content.object); > + if (release) > + IUnknown_Release(release); > + return WINED3D_OK; > + } What is the motivation for this? It certainly doesn't make the code any prettier.

March 14, 2014

Re: [3/3] gdiplus: Limit image output to the bounds of the Graphics object.

by Vincent Povirk

Don't commit this one. I messed up the case where output is fully outside the Graphics object bounds. On Thu, Mar 13, 2014 at 4:49 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >

March 14, 2014

Re: Ideas about mshtml for GSoC 2014

by Jacek Caban

Hi Zhenbo, On 03/11/14 15:32, Zhenbo Li wrote: > Thank you very much! > > 2014-03-11 17:35 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>: >> I think that MSHTML may make a good GSoC project. The application will >> probably need some more concrete task. We will also need to see that >> you're prepared to the task and sending those patches is a good start. > If I concentrate on implementing most IHTMLTable* functions, would it be a > good idea? Sorry for the delay. I'm not sure that's the best strategy for having results that will help users in general. Having all functions implemented is a nice thing, but many of them don't cause problems in real world application and web pages. I think I would prefer testing random web pages and implementing things that they need. This, however, would be tricky to set goals required for GSoC application. Maybe you could come up with a mix of both? Start with selected area (say, IHTMLTable*, not necessarily whole) and move to random APIs required by pages as the project progresses? Cheers, Jacek

March 14, 2014

Re: [PATCH] winedump: Improve typelib header dumping

by Jacek Caban

On 03/14/14 15:04, Jacek Caban wrote: > Hi Nikolay, > > On 03/14/14 14:48, Nikolay Sivov wrote: >> + if (flags & 1) >> + printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0); >> + flags >>= 1; > i should be increased on each iteration, not only when the flag is found. Also you should print '\n' instead of nullbyte if no more flags are found. Cheers, Jacek

March 14, 2014

Re: [PATCH] winedump: Improve typelib header dumping

by Jacek Caban

Hi Nikolay, On 03/14/14 14:48, Nikolay Sivov wrote: > + if (flags & 1) > + printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0); > + flags >>= 1; i should be increased on each iteration, not only when the flag is found. Cheers, Jacek

March 14, 2014