March 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] msxml3: Fix some test failures on Win8.1

by Nikolay Sivov

On 3/13/2014 20:18, Alexandre Julliard wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> writes: > >> --- >> dlls/msxml3/schema.c | 9 +++++++-- >> dlls/msxml3/tests/domdoc.c | 28 +++++++++++++++++----------- >> 2 files changed, 24 insertions(+), 13 deletions(-) > It doesn't work here: > > ../../../tools/runtest -q -P wine -T ../../.. -M msxml3.dll -p msxml3_test.exe.so schema && touch schema.ok > schema.c:1526: Test failed: got 0x80004003, expected 0x80004001 > make: *** [schema.ok] Error 1 > Sorry about that, I sent a fixed version.

March 13, 2014

Re: vbscript: Allow empty brackets in argument declarations.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5671 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

March 13, 2014

Re: [PATCH] msxml3: Fix some test failures on Win8.1

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/msxml3/schema.c | 9 +++++++-- > dlls/msxml3/tests/domdoc.c | 28 +++++++++++++++++----------- > 2 files changed, 24 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M msxml3.dll -p msxml3_test.exe.so schema && touch schema.ok schema.c:1526: Test failed: got 0x80004003, expected 0x80004001 make: *** [schema.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

March 13, 2014

Re: shell32: Supply a module name to CreateProcess (try 5)

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Corrected the accidental line being removed. > > Changelog: > shell32: Supply a module name to CreateProcess It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlexec && touch shlexec.ok Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 10, but got 10 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params20", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="p"): the cmdline is '(null)' instead of ' "p0"' shlexec.c:1457: Test failed: argvA4 expected 'p0', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="'p2 p3` p4\ $even"): the cmdline is '(null)' instead of ' "'p2" "p3`" "p4\" "$even" ""' shlexec.c:1457: Test failed: argvA4 expected ''p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3`', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p=2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p-3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA9 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA10 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 Fatal: test 'file.shlexec' does not exist. etc. -- Alexandre Julliard julliard(a)winehq.org

March 13, 2014

Re: riched20/tests: Fix a SysAllocString leak

by Jactry Zeng

2014-03-12 23:47 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com>: > > On 3/12/2014 19:36, Jactry Zeng wrote: >> >> I made this leak, sorry.. :( >> "What goes around comes around" was confirmed! :p >> VariantInit(&testfile); >> V_VT(&testfile) = VT_BSTR; >> V_BSTR(&testfile) = SysAllocString(filename); > > No need for VariantInit() here. > >> + SysFreeString(V_BSTR(&testfile)); > > It's cleaner to use VariantClear(). Thank you, Nikolay! I have sent a new one. Proverb was confirmed again.. :( -- Regards, Jactry Zeng

March 13, 2014

Re: [PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.

by Jacek Caban

On 03/13/14 14:35, Qian Hong wrote: > Hi Jacek, > > + > + hres = get_frame_by_name(top_window, target, TRUE, &ret_window); > + if(FAILED(hres) || !window) { > + *use_new_window = TRUE; > + return NULL; > + } > > Is there a typo here? Is "!window" suppose to be "!ret_window"? > > Thanks for the work! Good catch. Thanks, Jacek

March 13, 2014

Re: [PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.

by Qian Hong

Hi Jacek, + + hres = get_frame_by_name(top_window, target, TRUE, &ret_window); + if(FAILED(hres) || !window) { + *use_new_window = TRUE; + return NULL; + } Is there a typo here? Is "!window" suppose to be "!ret_window"? Thanks for the work!

March 13, 2014

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation (try2)

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL)) > + return c; You'd also have to handle the case of the length being just 1. -- Alexandre Julliard julliard(a)winehq.org

March 13, 2014

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation

by Piotr Caban

On 03/13/14 13:32, Alexandre Julliard wrote: > Piotr Caban <piotr(a)codeweavers.com> writes: > >> + if(!MultiByteToWideChar(locinfo->lc_codepage, >> + MB_ERR_INVALID_CHARS, (char*)str, p-str, &wide, 1)) >> + return c; >> + >> + lower = tolowerW(wide); >> + if(lower == wide) >> + return str[0] + (str[1]<<8); >> + >> + WideCharToMultiByte(locinfo->lc_codepage, 0, >> + &lower, 1, (char*)str, 2, NULL, NULL); > > You should probably also check the resulting length here. > I've sent a fixed version. Thanks.

March 13, 2014

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!MultiByteToWideChar(locinfo->lc_codepage, > + MB_ERR_INVALID_CHARS, (char*)str, p-str, &wide, 1)) > + return c; > + > + lower = tolowerW(wide); > + if(lower == wide) > + return str[0] + (str[1]<<8); > + > + WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL); You should probably also check the resulting length here. -- Alexandre Julliard julliard(a)winehq.org

March 13, 2014