March 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/3] mshtml: Added IHTMLDocument7 stub implementation.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > Due to how tests are written, we need to switch to IWebBrowserPriv2IE9 > in the same patch. > > --- > dlls/ieframe/ieframe.h | 2 +- > dlls/ieframe/navigate.c | 104 +---- > dlls/mshtml/Makefile.in | 1 + > dlls/mshtml/htmldoc.c | 4 + > dlls/mshtml/htmldoc7.c | 939 +++++++++++++++++++++++++++++++++++++++++++ Merging htmldoc3 and htmldoc5 was a good start, couldn't we do this with the rest of the htmldoc implementations too? There are way too many files in that dll already. -- Alexandre Julliard julliard(a)winehq.org

March 12, 2014

Re: Glorious winetestbot results, why this matters

by Jacek Caban

On 03/12/14 15:31, Jeremy White wrote: > So here's today's data: > http://www.winehq.org/~jwhite/31faed571d5a.html > > The main changes are the addition of some new failures in mshtml; > failures that Marvin actually pointed out here: > http://www.winehq.org/pipermail/wine-devel/2014-March/103419.html > > The glorious result is that if I get to publicly shame anyone, it's > both Jacek and Alexandre. For someone with my JR, that's a rare > opportunity <grin>. This should be fixed by my recent patches. The more worrying failure is crypt32:chain. Those happened with no change in tests at all and they don't happen on single test runs: https://testbot.winehq.org/JobDetails.pl?Key=5623 https://testbot.winehq.org/JobDetails.pl?Key=5624 I sent a patch that should help diagnose the problem if failures will continue to happen on full test runs. Cheers, Jacek

March 12, 2014

Re: Glorious winetestbot results, why this matters

by Alexandre Julliard

Jeremy White <jwhite(a)codeweavers.com> writes: > On 03/12/2014 09:48 AM, Henri Verbeet wrote: >> On 12 March 2014 15:31, Jeremy White <jwhite(a)codeweavers.com> wrote: >>> But really, it illustrates the problem: Alexandre does not trust the new >>> test bot results, so he did not wait for testbot review of patches, and so >>> he did not catch a problem. We need to restore that trust. That's why this >>> matters. >>> >> I'm not going to argue about the basic point, but I don't think it's >> all that clear that some of the tests timing out on occasion is really >> about the tests themselves, as opposed to the testbot infrastructure. > > I asked Alexandre, and he thought that this one might be a fair cop; > not just an infrastructure failure, but a real failure that should > have been caught. It was caught, it's just that there are spurious timeouts often enough that I assumed it was probably a testbot glitch, and committed the patch so that we'd find out if it was real... -- Alexandre Julliard julliard(a)winehq.org

March 12, 2014

Re: Glorious winetestbot results, why this matters

by Jeremy White

On 03/12/2014 09:48 AM, Henri Verbeet wrote: > On 12 March 2014 15:31, Jeremy White <jwhite(a)codeweavers.com> wrote: >> But really, it illustrates the problem: Alexandre does not trust the new >> test bot results, so he did not wait for testbot review of patches, and so >> he did not catch a problem. We need to restore that trust. That's why this >> matters. >> > I'm not going to argue about the basic point, but I don't think it's > all that clear that some of the tests timing out on occasion is really > about the tests themselves, as opposed to the testbot infrastructure. I asked Alexandre, and he thought that this one might be a fair cop; not just an infrastructure failure, but a real failure that should have been caught. But you are right that the infrastructure instability makes it very difficult to do any real work against the failing test list. My hope is that it's close enough now that we can, by trying to fix tests, more clearly identify the remaining issues and resolve them. And I also felt remiss in failing to shame *anyone* <grin>. Cheers, Jeremy

March 12, 2014

Re: riched20/tests: Fix a SysAllocString leak

by Nikolay Sivov

On 3/12/2014 19:36, Jactry Zeng wrote: > I made this leak, sorry.. :( > "What goes around comes around" was confirmed! :p > VariantInit(&testfile); > V_VT(&testfile) = VT_BSTR; > V_BSTR(&testfile) = SysAllocString(filename); No need for VariantInit() here. > + SysFreeString(V_BSTR(&testfile)); It's cleaner to use VariantClear().

March 12, 2014

Re: Glorious winetestbot results, why this matters

by Henri Verbeet

On 12 March 2014 15:31, Jeremy White <jwhite(a)codeweavers.com> wrote: > But really, it illustrates the problem: Alexandre does not trust the new > test bot results, so he did not wait for testbot review of patches, and so > he did not catch a problem. We need to restore that trust. That's why this > matters. > I'm not going to argue about the basic point, but I don't think it's all that clear that some of the tests timing out on occasion is really about the tests themselves, as opposed to the testbot infrastructure.

March 12, 2014

Glorious winetestbot results, why this matters

by Jeremy White

So here's today's data: http://www.winehq.org/~jwhite/31faed571d5a.html The main changes are the addition of some new failures in mshtml; failures that Marvin actually pointed out here: http://www.winehq.org/pipermail/wine-devel/2014-March/103419.html The glorious result is that if I get to publicly shame anyone, it's both Jacek and Alexandre. For someone with my JR, that's a rare opportunity <grin>. But really, it illustrates the problem: Alexandre does not trust the new test bot results, so he did not wait for testbot review of patches, and so he did not catch a problem. We need to restore that trust. That's why this matters. Cheers, Jeremy p.s. Looks like Francois's patch has fixed winmm:mci (yay!), and a few tests that my script felt were 'solved' have proven themselves to be actually intermittent (comctl:propsheet and user32:listbox)

March 12, 2014

Re: [PATCH 5/5] d3d8/tests: Test GetPrivateData size behavior.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5629 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000901BC, got 00010048.

March 12, 2014

Re: [PATCH 4/5] d3d8/tests: Use a custom GUID for the private data tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5628 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000401E4, got 00010048. device.c:3038: Test failed: Expected wndproc 0x40fa10, got 0x40fa10.

March 12, 2014

Re: Valve has released a Direct3D to OpenGL translator (for a subset of Direct3D 9.0c)

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-03-11 19:02, schrieb Artem S. Tashkinov: > Hi, > > Just wanted to let everyone know that Valve has released a > Direct3D to OpenGL translator (for a subset of Direct3D 9.0c). > > More here: https://github.com/ValveSoftware/ToGL > > I don't know if it's of any use for Wine development however. No, it's not. It is *very* limited. It doesn't even have stateblock interface declaration, and it's surface implementation is pretty much nonexistent. It doesn't care about any of the corner cases that make d3d9 interesting. Note that this is not an exhaustive review of this code. It's just the first two things I found in a 2 minute look. Those limitations make sense as design decisions for Valve's purposes, but they make this wrapper useless for anything other than a cheap compile-time abstraction layer between d3d and gl. Releasing this code may be useful for other developers who want to port a game to Linux though. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTIGECAAoJEN0/YqbEcdMwjBIP/3cexlG4jxkY2UGOQAsZv30s 1gxKGXFQkqkUSmdeysvwLwNiyQrXlOURyiZnIlCrWkazngZ7/ew9bKBN0frUfmRM Uf1SQF+69mWOWYg06why5M29g+JJswVpROSlgjKl+5/sUErlKPuv7W2OMF/IJtIm FTVBsAGhC9LbECO7L5SeLejHLAU992A7EdW4zhB63S6bRgkbgKofKXF5/A1sQZ9G 5Q1XlsF57c7bH+Qvp6yCBiPoVy7VEywoRtCYGhZ3w1XpbxGosKnqvVyyiWBO0jUY QvCXmjvHM8gme5MJZdsmGWLWWD9lwUPjrOdJa8r+CRqnql3dlmLNDIen/weRp0Gh LDzMUc958E6/iWjH5XzGL2fg74uXKdha3kG06eOAH0IVVhpJKqM7/nqZj/99egNk Pw0fVnnuiamckNA8qofSp31uJdYkS2STJFOAg6ILiJvxbgWRIbKd++DKAf1Y+VkP N80YpHpR87SSBwAKrOEBePBD+HYlvYnf62zEbl+72F4QoL1ZazgrPt+MqS4cXiIf 8Fjs6Fo8LTt3+DZvb2NqmOoSdtsiM+J3bbPat5SlT78wyNK5ruLqS6sgyBzFgTPD OEsbklXKIz7/IRitwRSyo3Vv50J1kbmhhwdqtwZd3HJB8Gcr5086hPdKOZE/v8VJ wcQlGlCFGL+mQnIjO8o2 =gkPd -----END PGP SIGNATURE-----

March 12, 2014