March 2014 - Wine-Devel - list.winehq.org

Re: [1/2] ntdll/tests: Add tests for RtlUnicodeToUTF8N.

by Thomas Faber

On 2014-03-29 17:24, Nikolay Sivov wrote: > On 3/29/2014 20:16, Thomas Faber wrote: >> + /* output truncation */ >> +#define truncate_expect(len, out_len, expect_status) do { \ >> + bytes_out = 0x55555555; \ >> + memset(buffer, 0x55, sizeof(buffer)); \ >> + status = pRtlUnicodeToUTF8N( \ >> + buffer, len, &bytes_out, \ >> + special_string, sizeof(special_string)); \ >> + ok(status == (expect_status), "status = 0x%x\n", status); \ >> + ok(bytes_out == (out_len), "bytes_out = %u\n", bytes_out); \ >> + for (i = 0; i < bytes_out; i++) \ >> + ok(buf[i] == special_expected[i], \ >> + "buffer[%d] = 0x%x\n", i, buf[i]); \ >> + for (; i < sizeof(buffer); i++) \ >> + ok(buf[i] == 0x55, "buffer[%d] = 0x%x\n", i, buf[i]); \ >> + } while (0) > It's better to avoid large macros like this one. A common way to do that > is to move code to another function and call it with a single line > macro, for line information ok_() should be used. Good point. Will fix, thanks.

March 29, 2014

Re: [1/2] ntdll/tests: Add tests for RtlUnicodeToUTF8N.

by Nikolay Sivov

On 3/29/2014 20:16, Thomas Faber wrote: > + /* output truncation */ > +#define truncate_expect(len, out_len, expect_status) do { \ > + bytes_out = 0x55555555; \ > + memset(buffer, 0x55, sizeof(buffer)); \ > + status = pRtlUnicodeToUTF8N( \ > + buffer, len, &bytes_out, \ > + special_string, sizeof(special_string)); \ > + ok(status == (expect_status), "status = 0x%x\n", status); \ > + ok(bytes_out == (out_len), "bytes_out = %u\n", bytes_out); \ > + for (i = 0; i < bytes_out; i++) \ > + ok(buf[i] == special_expected[i], \ > + "buffer[%d] = 0x%x\n", i, buf[i]); \ > + for (; i < sizeof(buffer); i++) \ > + ok(buf[i] == 0x55, "buffer[%d] = 0x%x\n", i, buf[i]); \ > + } while (0) It's better to avoid large macros like this one. A common way to do that is to move code to another function and call it with a single line macro, for line information ok_() should be used.

March 29, 2014

How to cross-compile wine?

by Akira Nakagawa

./configure --host=arm-linux-androideabi then it said --with-wine-tools was needed. What do I set to the option? -- Akira Nakagawa <matyapiro31(a)gmail.com>

March 29, 2014

Re: MS releases vintage DOS source code

by Vassilis Virvilis

word 2.x was a 16bit program. Word 6.x was also 16bit. Word95 was the first 32bit AFAIK. Somehow I doubt a port to 32bit would be trivial... On 03/27/14 21:25, Steven Edwards wrote: > The more interesting thing is the MS Word for Windows 2.x. It would be > amusing if someone did a 32bit port as a winelib app. > > > On Tue, Mar 25, 2014 at 2:18 PM, Michael Stefaniuc <mstefani(a)redhat.com > <mailto:mstefani(a)redhat.com>> wrote: > > Not directly relevant to us as DOS got outsourced to dosbox but here it > is nevertheless: > http://www.computerhistory.org/atchm/microsoft-ms-dos-2-0-source-code/ > > If they keep releasing the source roughly 30 years after the OS hit the > market, then Windows 3.11 is still 10 years out. > > bye > michael > > > > > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and that > is an idea whose time has come." - Victor Hugo > > >

March 28, 2014

Re: [PATCH 6/6] user32: Implement EnumDisplayDevicesW() based on EnumDisplayMonitors() and GetMonitorInfoW().

by Alexandre Julliard

Ken Thomases <ken(a)codeweavers.com> writes: > For <http://bugs.winehq.org/show_bug.cgi?id=34978>. > --- > dlls/user32/misc.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 84 insertions(+), 12 deletions(-) I think it should be the other way around, with EnumDisplayDevices being the main function, with some sort of centralized management of display devices. -- Alexandre Julliard julliard(a)winehq.org

March 28, 2014

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > > dlls/rpcrt4/tests/server.c | 55 ++++++++++++++++++++++++++++++++++++++++++++ > > dlls/rpcrt4/tests/server.idl | 5 ++++ > > 2 files changed, 60 insertions(+) > > It doesn't work on 64-bit: There are several problems in widl that lead to the failures: 1. widl generates array descriptions very differently from midl 2. widl generates negative offsets in the pointer layout descriptions, while negative offsets apparently work for some things, it looks like rpcrt4 in windows doesn't support them for arrays of strings, and the test crashes. Manually changing offsets in generated by widl *_c.c and *_s.c files and moving pointer layout descriptions before the array descriptions (currently that's reversed) makes the test run under Windows. 3. for win64 widl generates FC_BOGUS_ARRAY descriptions which are very different from midl generated code, and the test crashes under Windows. Probably FC_BOGUS_ARRAY case is not very well tested, especially in 64-bit build. I have the patches for #1 and #2, but they need more testing, and #3 will require quite a bit of additional effort. I'd appreciate any help with these problems. -- Dmitry.

March 28, 2014

Re: [PATCH 1/6] winemac: Make ChangeDisplaySettingsEx() operate on the display named by the devname parameter.

by Ken Thomases

Hi, The first two patches in this series aren't quite right. Please don't commit them. They don't do the right thing with the registry settings. Patches 3 through 6 can be applied independently and are useful, so they can still be committed. (Bug 34978 won't quite be solved because DisplayFusion will be confused by enumerating the wrong modes for the second display.) -Ken

March 28, 2014

Re: MS releases vintage DOS source code

by Steven Edwards

The more interesting thing is the MS Word for Windows 2.x. It would be amusing if someone did a 32bit port as a winelib app. On Tue, Mar 25, 2014 at 2:18 PM, Michael Stefaniuc <mstefani(a)redhat.com>wrote: > Not directly relevant to us as DOS got outsourced to dosbox but here it > is nevertheless: > http://www.computerhistory.org/atchm/microsoft-ms-dos-2-0-source-code/ > > If they keep releasing the source roughly 30 years after the OS hit the > market, then Windows 3.11 is still 10 years out. > > bye > michael > > > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

March 27, 2014

Re: user32: Change SetForegroundWindow behavior on windows with parent and no WS_CHILD flag

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6025 Your paranoid android. === w8 (32 bit win) === win.c:6433: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6433: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6433: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6216: Test failed: wrong error 31

March 27, 2014

Re: loader: Add registry keys for Hidden and HideFileExt.

by Alexandre Julliard

Rico Schüller <kgbricola(a)web.de> writes: > --- > loader/wine.inf.in | 2 ++ > 1 file changed, 2 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlfolder && touch shlfolder.ok shlfolder.c:817: Test failed: SetNameOf failed! hr = 80004005 make: *** [shlfolder.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

March 26, 2014