March 2014 - Wine-Devel - list.winehq.org

Re: [RFC 5/11] Linux FF: Linux effect parameters: time parameters

by Elias Vanderstuyft

On Wed, Mar 5, 2014 at 4:03 PM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > On Tue, Mar 04, 2014 at 08:20:09PM +0100, Elias Vanderstuyft wrote: >> So change in dinput/effect_linuxinput.c:488 : >> This->effect.u.periodic.period = tsp->dwPeriod / 1000; >> to : >> if (0 < tsp->dwPeriod && tsp->dwPeriod <= 1000) >> This->effect.u.periodic.period = 1; >> else >> This->effect.u.periodic.period = tsp->dwPeriod / 1000; >> > > Seems good. While we're here, any reason not to use round(3) instead > of always rounding down in the >1000 case? That's a good question, the reason is that I want to avoid floating point arithmetic (round(3)). But you also have to see this in perspective: The behaviour of my code is indeed inconsistent around the dwPeriod == 1000 +- 500 region (in respect with higher values of dwPeriod), but this is practically irrelevant: a dwPeriod of 1000 means 1ms; a period of a periodic effect should be minimum 2*sampleperiod, so this inconsistency will only be perceived (and I'm even not sure a human would perceive this) when the Linux FF driver has a sampleperiod of 0.5ms, and this is unlikely (lowest value I have seen is 8ms). (Except maybe for realtime systems like real-motion simulators, but in that case, I don't think DInput (or other software) will be used as low level interface, it's more likely that would be implemented in hardware.) So can I leave it as I suggested before? > >> b) Anticipate if dwPeriod < 0, otherwise periodic.period will >> incorrectly wrap around because it's unsigned. >> We can choose to let periodic.period be proportional to: >> - 0 (driver will generate EINVAL) >> - abs(dwPeriod) (no error, and is mathematically more correct) > > DWORDs are usually treated as unsigned. Thanks for clarifying, I'll fix it. For some odd reason, I remembered them as signed 32bit values ;) My code should then become: if (tsp->dwPeriod && tsp->dwPeriod <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = tsp->dwPeriod / 1000; > Is this how Windows behaves > for massive dwPeriod? I would expect E_INVALIDARG, since it's out of > the range [0,36000). I think you're mixing up dwPeriod with dwPhase. The range of dwPeriod is not defined in MSDN. > >> So, change in dinput/effect_linuxinput.c:191 : >> if (dwFlags & DIEP_DURATION) { >> peff->dwDuration = (DWORD)This->effect.replay.length * 1000; >> } >> to : >> if (dwFlags & DIEP_DURATION) { >> peff->dwDuration = (This->effect.replay.length ? >> (DWORD)This->effect.replay.length * 1000 : -1); >> } >> >> And change in dinput/effect_linuxinput.c:424 : >> if (dwFlags & DIEP_DURATION) >> This->effect.replay.length = peff->dwDuration / 1000; >> to : >> if (dwFlags & DIEP_DURATION) { >> if (peff->dwDuration == -1) >> This->effect.replay.length = 0; // Infinity >> else if (peff->dwDuration > 1000) >> This->effect.replay.length = peff->dwDuration / 1000; >> else >> This->effect.replay.length = 1; // Smallest non-zero value >> } >> > > This seems okay, though again, maybe use round(). Again, practically an inconsistency in duration at the 1ms bound, will not be perceivable, see my comment above. > You should also use > INFINITE instead of -1. OK. Maybe we should also change all occurrences of 10000 in a force context to DI_FFNOMINALMAX, in the whole FF dinput implementation? Elias

March 9, 2014

Re: [RFC 6/11] Linux FF: Linux effect: conditional effect's parameters

by Elias Vanderstuyft

On Wed, Mar 5, 2014 at 4:05 PM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > On Tue, Mar 04, 2014 at 08:20:13PM +0100, Elias Vanderstuyft wrote: >> for (i = 0; i < 2; ++i) { >> This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; >> This->effect.u.condition[i].right_coeff = >> (tsp[i].lPositiveCoefficient / 10) * 32; >> This->effect.u.condition[i].left_coeff = >> (tsp[i].lNegativeCoefficient / 10) * 32; >> This->effect.u.condition[i].right_saturation = >> (tsp[i].dwPositiveSaturation / 10) * 65; >> This->effect.u.condition[i].left_saturation = >> (tsp[i].dwNegativeSaturation / 10) * 65; >> This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 65; >> } >> > > I agree with this in principle, but I think I would change the > implementation to be a bit more explicit. Something like, > left_coeff = (lNegativeCoefficient / (double)10000) * 32767; > right_saturation = (dwPositiveSaturation / (double)10000) * 65535; > which shows an explicit mapping between full ranges. (This might need > some more thinking at the extreme edges of the bounds, so we don't go > out of bounds during type coersion.) That's a good idea, in one of my further RFC mails, I say: "Provide a more accurate mapping of force levels from dinput to linux", and this should actually also apply to the conditional effect parameters. I would change your code a little bit, like this (also to avoid floating point operations (and maintaining precision) and thus avoid floating point context switching, ~maintaining performance): left_coeff = (max(min(lNegativeCoefficient, 0), 10000) * 0x7FFF) / 10000; right_saturation = (max(min(dwPositiveSaturation, 0), 10000) * 0xFFFF) / 10000; No overflow will happen, because the type of the return-value of max() will be LONG (= 32bit signed), so 10000*0xFFFF < 2^31-1 > >> - Don't return an error. This seems to be the behavior of the >> Windows Logitech FFB driver (MOMO, MOMO2, ...). > > We should match Windows. Sounds like they ignore envelopes for effects > which don't support them, so we should too. It's also possible that drivers other than Logitech *do* return an error, but I think they won't. > Your change looks good. I > would probably use a TRACE instead of WARN, since we're doing the > right thing. OK.

March 9, 2014

GSOC 2014

by Udayan Tandon

Hi, I’m Udayan Tandon. Im studying computer science in India at the Indraprastha Institute of Information Technology-Delhi. I’ve been studying and coding in C for the past year. Im enthusiastic to take part in GSoC 2014 and the wine project is really interesting. Im interested in the project "CMD:implement more robust parser" and would like if you could the course action as to what to do in this project. Regards Udayan Tandon

March 9, 2014

Re: GSoC 2014

by André Hentschel

Am 08.03.2014 18:24, schrieb HuddenSin Yuan: > Hello, > > I'm Yuanchen,an undergraduate student from China.I have begun to use C to program sth since two years ago.I'm willing to take part in GSoC 2014. > > The Wine Project has many ideas programed by C,I think I can do sth helpful to you and also can apply what I learn to reality.And I want to do sth cool like fixing bugs. > > I'm interested in Winetest User Graphic Interface and other similiar ideas which use C. > > I'll appreciate it very much if you give me some advice. Hi Yuanchen, i think for this project the best first steps are to compile Wine yourself from latest git [1][2] If you want to have a look at the "Tools - Winetest Graphical User Interface", then run the testsuite and submit the results [3]. This way you get a feeling what it's like to get to the results at the moment [4][5]. I recommend to have a look at other ideas, too. [1] http://wiki.winehq.org/FAQ#head-7ed3c3163e2b932ee2030a48f9c5e553dc41817b [2] http://wiki.winehq.org/GitWine [3] http://wiki.winehq.org/ConformanceTests [4] https://test.winehq.org/data/ [5] http://wiki.winehq.org/WineTestBot

March 8, 2014

GSoC 2014

by HuddenSin Yuan

Hello, I'm Yuanchen,an undergraduate student from China.I have begun to use C to program sth since two years ago.I'm willing to take part in GSoC 2014. The Wine Project has many ideas programed by C,I think I can do sth helpful to you and also can apply what I learn to reality.And I want to do sth cool like fixing bugs. I'm interested in Winetest User Graphic Interface and other similiar ideas which use C. I'll appreciate it very much if you give me some advice. Regards, Yuanchen

March 8, 2014

Re: Wine project aspirant for GSOC 2014 : Tools - Winetest Graphical User Interface

by André Hentschel

Am 08.03.2014 12:08, schrieb Siddhartha Narang: > > Hello , > I am Siddhartha Narang a second year Undergraduate in INFORMATION TECHNOLOGY at University Institute of Engineering and Technology (UIET) Panjab University, Chandigarh,India . > > > Skill set :- > > I have a deep knowledge of C and C++ and have made various games on console like the snake and food, tunnel came , bouncing ball . > I have a average knowledge of Data Structures ,linux, Html5. > I am currently learning Css . > > > I have gone through various projects of your's for GSOC and the one which interest me a most is Tools - Winetest Graphical User Interface . I am very keen to be a part of this project . > > What i could interpret from the idea's page about the project is that to build a graphical user interface where user can see the test results . > > I am very enthusiastic about the coding. I would put my best foot forward to learn as much as I can and try and contribute to your community . > > It will be very nice of you if you guide me how to go about this project and from where i could start and elaborate what i need to do . > Hi Siddhartha, i think for this project the best first steps are to compile Wine yourself from latest git [1][2], then run the testsuite and submit the results [3]. This way you get a feeling what it's like to get to the results at the moment [4][5]. [1] http://wiki.winehq.org/FAQ#head-7ed3c3163e2b932ee2030a48f9c5e553dc41817b [2] http://wiki.winehq.org/GitWine [3] http://wiki.winehq.org/ConformanceTests [4] https://test.winehq.org/data/ [5] http://wiki.winehq.org/WineTestBot

March 8, 2014

Re: [PATCH 4/4] vbscript: Added support for VARIANT references to interp_newenum.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5511 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

March 8, 2014

Re: [PATCH 3/4] vbscipt: Allow ':' to be a separator in select case statement.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5510 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

March 8, 2014

Re: [PATCH 2/4] vbscript: Use VariantCopyInd in invoke_variant_prop.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5509 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

March 8, 2014

Re: [PATCH 1/4] vbscipt: Use VariantCopyInd in exec_script.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5508 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

March 8, 2014