Wine-Devel

By thread

wine-devel@list.winehq.org

March 2014

78 participants
468 messages

About GSoC 2014

by Nemina Amarasinghe

Hi, I am willing to participate GSoC this year. I looked through the accepted organization list and I'm interested in wine. So I would like to know how to connect with mentors to get more details. I would really appreciate if someone help me to get above information Best regards, Nemina

March 1, 2014

Re: Conferences wiki page

by Tom Wickline

Hello, http://lanyrd.com/topics/linux/2014/ http://events.linuxfoundation.org/ Should take care of all big events :) Cheers, Tom On Tue, Feb 25, 2014 at 4:50 AM, Rosanne DiMesio <dimesio(a)earthlink.net>wrote: > FYI, I've created a wiki page to collect information on conferences that > might be good venues for Wine outreach efforts, > http://wiki.winehq.org/Conferences2014. > > Please add any conferences/meetings you think might be suitable, even if > the deadline for this year has passed (it will serve as a reminder to check > earlier for next year). > > -- > Rosanne DiMesio <dimesio(a)earthlink.net> > > > -- Wine is not a conclusion but a process...

March 1, 2014

Re: [PATCH] Avoid a divide by zero crash.

by Max Woodbury

On 03/01/2014 05:16 AM, Dmitry Timoshkov wrote: > Max Woodbury <mtewoodbury(a)gmail.com> wrote: > >>>>>> While tmHeight is not _supposed_ to ever be zero, it is an external >>>>>> >>>>>> input and has been found to be zero in a few rare fonts. Detecting >>>>>> >>>>>> and fixing THAT problem should be handled elsewhere. This change just >>>>>> >>>>>> keeps the application from being blown away by a divide by zero >>>>>> >>>>>> exception. >>>>> >>>>> This change needs at least more details and preferrably a test case. >>>>> >>>> The test case was submitted about a year ago. >>>> >>>> What more details do you think are needed? >>>> >>>> tmHeight is an external input, so it can have any value including >>>> zero. As such, it should NOT be used as a divisor. This change uses >>>> it as a multiplier on the other side of the comparison so it should not >>>> cause THAT particular problem. A little additional algebra simplifies >>>> the code. >>> >>> Sounds like a deja-vu. >>> >> 8-) and your question was answered!?! > > I'm afraid that nothing has changed since last time. > :-( Last time you said you would fix the problem elsewhere. You have NOT done that. The problem persists for those with the unusual fonts installed. It still needs a fix. You can still make the other changes when you get around to it. That is NOT a reason for rejecting this patch.

March 1, 2014

Re: [PATCH] Avoid a divide by zero crash.

by Dmitry Timoshkov

Max Woodbury <mtewoodbury(a)gmail.com> wrote: > >>>> While tmHeight is not _supposed_ to ever be zero, it is an external > >>>> > >>>> input and has been found to be zero in a few rare fonts. Detecting > >>>> > >>>> and fixing THAT problem should be handled elsewhere. This change just > >>>> > >>>> keeps the application from being blown away by a divide by zero > >>>> > >>>> exception. > >>> > >>> This change needs at least more details and preferrably a test case. > >>> > >> The test case was submitted about a year ago. > >> > >> What more details do you think are needed? > >> > >> tmHeight is an external input, so it can have any value including > >> zero. As such, it should NOT be used as a divisor. This change uses > >> it as a multiplier on the other side of the comparison so it should not > >> cause THAT particular problem. A little additional algebra simplifies > >> the code. > > > > Sounds like a deja-vu. > > > 8-) and your question was answered!?! I'm afraid that nothing has changed since last time. -- Dmitry.

March 1, 2014

Re: [PATCH] Avoid a divide by zero crash.

by Max Woodbury

On 03/01/2014 05:07 AM, Dmitry Timoshkov wrote: > Max Woodbury <mtewoodbury(a)gmail.com> wrote: > >>>> While tmHeight is not _supposed_ to ever be zero, it is an external >>>> >>>> input and has been found to be zero in a few rare fonts. Detecting >>>> >>>> and fixing THAT problem should be handled elsewhere. This change just >>>> >>>> keeps the application from being blown away by a divide by zero >>>> >>>> exception. >>> >>> This change needs at least more details and preferrably a test case. >>> >> The test case was submitted about a year ago. >> >> What more details do you think are needed? >> >> tmHeight is an external input, so it can have any value including >> zero. As such, it should NOT be used as a divisor. This change uses >> it as a multiplier on the other side of the comparison so it should not >> cause THAT particular problem. A little additional algebra simplifies >> the code. > > Sounds like a deja-vu. > 8-) and your question was answered!?!

March 1, 2014

Re: [PATCH] Avoid a divide by zero crash.

by Dmitry Timoshkov

Max Woodbury <mtewoodbury(a)gmail.com> wrote: > >> While tmHeight is not _supposed_ to ever be zero, it is an external > >> > >> input and has been found to be zero in a few rare fonts. Detecting > >> > >> and fixing THAT problem should be handled elsewhere. This change just > >> > >> keeps the application from being blown away by a divide by zero > >> > >> exception. > > > > This change needs at least more details and preferrably a test case. > > > The test case was submitted about a year ago. > > What more details do you think are needed? > > tmHeight is an external input, so it can have any value including > zero. As such, it should NOT be used as a divisor. This change uses > it as a multiplier on the other side of the comparison so it should not > cause THAT particular problem. A little additional algebra simplifies > the code. Sounds like a deja-vu. -- Dmitry.

March 1, 2014

Re: [PATCH] Avoid a divide by zero crash.

by Max Woodbury

On 03/01/2014 04:24 AM, Dmitry Timoshkov wrote: > Max Woodbury <mtewoodbury(a)gmail.com> wrote: > >> While tmHeight is not _supposed_ to ever be zero, it is an external >> >> input and has been found to be zero in a few rare fonts. Detecting >> >> and fixing THAT problem should be handled elsewhere. This change just >> >> keeps the application from being blown away by a divide by zero >> >> exception. > > This change needs at least more details and preferrably a test case. > The test case was submitted about a year ago. What more details do you think are needed? tmHeight is an external input, so it can have any value including zero. As such, it should NOT be used as a divisor. This change uses it as a multiplier on the other side of the comparison so it should not cause THAT particular problem. A little additional algebra simplifies the code. max

March 1, 2014

Re: [PATCH] Avoid a divide by zero crash.

by Dmitry Timoshkov

Max Woodbury <mtewoodbury(a)gmail.com> wrote: > While tmHeight is not _supposed_ to ever be zero, it is an external > > input and has been found to be zero in a few rare fonts. Detecting > > and fixing THAT problem should be handled elsewhere. This change just > > keeps the application from being blown away by a divide by zero > > exception. This change needs at least more details and preferrably a test case. -- Dmitry.

March 1, 2014

Jump to page: