March 2014 - Wine-Devel - list.winehq.org

Re: mshtml: Added IHTMLTableRow::bgColor property implementation.

by Alexandre Julliard

Zhenbo Li <litimetal(a)gmail.com> writes: > As MSDN said, bgColor property can be a VARIANT of type VT_BSTR or > VT_I4 that receives one of the color names or RGB values in the Color > Table.[1] So I declared variant_to_nscolor(from htmlbody.c) in > mshtml_private.h > > [1]: http://msdn.microsoft.com/en-us/library/aa741715%28v=vs.85%29.aspx > --- > dlls/mshtml/htmlbody.c | 2 +- > dlls/mshtml/htmltablerow.c | 29 +++++++++++++++++++++++++---- > dlls/mshtml/mshtml_private.h | 2 ++ > dlls/mshtml/tests/dom.c | 37 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 65 insertions(+), 5 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok dom.c:5641: Test failed: get_bgColor returned L"red" dom.c:5653: Test failed: get_bgColor returned L"#Ff0000" make: *** [dom.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

March 25, 2014

Re: ws2_32: Avoid a variable-length array.

by Thomas Faber

On 2014-03-25 13:34, Bruno Jesus wrote: > On Tue, Mar 25, 2014 at 7:59 AM, Thomas Faber <thomas.faber(a)reactos.org> wrote: >> #ifdef HAS_IRDA >> +#define MAX_IRDA_DEVICES 10 >> + > > I guess you could #undef before the #endif for HAS_IRDA since the > define is no longer used, but that is just my opinion. Yeah, can do. Sending an updated version.

March 25, 2014

Re: Wine test week 2 - nice apparent progress

by Michael Stefaniuc

On 03/25/2014 01:51 PM, Jeremy White wrote: > On 03/25/2014 02:33 AM, Henri Verbeet wrote: >> On 25 March 2014 01:00, Jeremy White <jwhite(a)codeweavers.com> wrote: >>> My script results are here: >>> http://www.winehq.org/~jwhite/ebd5f96aea22.html >>> >> For what it's worth, note that the intermittent failures in >> ddraw:ddraw7 are timeouts, and happening in different places. I >> suspect that's either the generic issue of the testbot timing out on >> occasion, or the testbot just not being fast enough to finish the test >> in time, perhaps due to it being under some load from a different VM. >> >> > > Francois, do we have (or could we easily create) a mechanism to test > that by constraining the number of VMs that run simultaneously? I know > it would slow performance, but it would be interesting to see if we > can quantify that. Just two run in parallel. I wanted to ask Francois to bump that number up not lower it. The testbot is basically unusable for hours during the daily test run due to that. > Hardware is cheap; we can easily throw more testbots at the problem... I got told repeatedly by well informed sources that that isn't needed. Just sayin' bye michael

March 25, 2014

Re: Wine test week 2 - nice apparent progress

by Jeremy White

On 03/25/2014 02:33 AM, Henri Verbeet wrote: > On 25 March 2014 01:00, Jeremy White <jwhite(a)codeweavers.com> wrote: >> My script results are here: >> http://www.winehq.org/~jwhite/ebd5f96aea22.html >> > For what it's worth, note that the intermittent failures in > ddraw:ddraw7 are timeouts, and happening in different places. I > suspect that's either the generic issue of the testbot timing out on > occasion, or the testbot just not being fast enough to finish the test > in time, perhaps due to it being under some load from a different VM. > > Francois, do we have (or could we easily create) a mechanism to test that by constraining the number of VMs that run simultaneously? I know it would slow performance, but it would be interesting to see if we can quantify that. Hardware is cheap; we can easily throw more testbots at the problem... Cheers, Jeremy

March 25, 2014

Re: [PATCH 1/5] d3d9/tests: Use a separate device for test_vshader_input().

by Henri Verbeet

On 25 March 2014 09:50, Marvin <testbot(a)winehq.org> wrote: > === w8 (32 bit visual) === > visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 > visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 > visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 > This looks at least somewhat like a legitimate failure, so I think it's best to ignore this series for the moment.

March 25, 2014

Re: ws2_32: Avoid a variable-length array.

by Bruno Jesus

On Tue, Mar 25, 2014 at 7:59 AM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > > #ifdef HAS_IRDA > +#define MAX_IRDA_DEVICES 10 > + I guess you could #undef before the #endif for HAS_IRDA since the define is no longer used, but that is just my opinion.

March 25, 2014

Re: [PATCH 5/5] d3d9/tests: Use a separate device for loop_index_test().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

March 25, 2014

Re: [PATCH 4/5] d3d9/tests: Use a separate device for sincos_test().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5940 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

March 25, 2014

Re: [PATCH 3/5] d3d9/tests: Use a separate device for sgn_test().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5939 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

March 25, 2014

Re: [PATCH 2/5] d3d9/tests: Use a separate device for clip_planes_test().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5938 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

March 25, 2014