April 2014 - Wine-Devel - list.winehq.org

Re: [3/3] taskschd: Implement setters for IRegistrationInfo string properties. Take 2.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6298 Your paranoid android. === build (build) === Patch failed to apply

April 11, 2014

Re: [2/3] taskschd: Implement getters for IRegistrationInfo string properties. Take 2.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6297 Your paranoid android. === build (build) === Patch failed to apply

April 11, 2014

Re: [1/3] taskschd/tests: Add some tests for task registration info.

by Nikolay Sivov

On 4/11/2014 11:56, Dmitry Timoshkov wrote: >> For other tests when it returns NULL bstr it >> would be cleaner to set pointer to some non-zero value to test that each >> method actually resets it to NULL. > That's a matter of taste. Not really. You don't know if it's changed or not after the call if you don't know what initial value was. For series of calls like these: --- + hr = IRegistrationInfo_get_Documentation(reginfo, &bstr); +todo_wine + ok(hr == S_OK, "get_Documentation error %#x\n", hr); +if (hr == S_OK) + ok(!bstr, "expected NULL, got %s\n", wine_dbgstr_w(bstr)); + hr = IRegistrationInfo_get_URI(reginfo, &bstr); +todo_wine + ok(hr == S_OK, "get_URI error %#x\n", hr); +if (hr == S_OK) + ok(!bstr, "expected NULL, got %s\n", wine_dbgstr_w(bstr)); --- there's no way to tell did get_URI set it to NULL or not.

April 11, 2014

Re: [1/3] taskschd/tests: Add some tests for task registration info.

by Dmitry Timoshkov

Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On 4/11/2014 11:26, Dmitry Timoshkov wrote: > > + hr = IRegistrationInfo_get_Description(reginfo, &bstr); > > +todo_wine > > + ok(hr == S_OK, "get_Description error %#x\n", hr); > > +if (hr == S_OK) > > +{ > > + ok(bstr && !lstrcmpW(bstr, Task1), "expected Task1, got %s\n", wine_dbgstr_w(bstr)); > It's redundant to check for 'bstr' being not NULL, lstrcmpW test will > fail in this case too. I had an impression that when __WINESRC__ is defined lstrcmpW() gets replaced by an inline implementation which doesn't have a SEH wrapper and crashes, but it looks like that's not the case. Thanks. > For other tests when it returns NULL bstr it > would be cleaner to set pointer to some non-zero value to test that each > method actually resets it to NULL. That's a matter of taste. -- Dmitry.

April 11, 2014

Re: [1/3] taskschd/tests: Add some tests for task registration info.

by Nikolay Sivov

On 4/11/2014 11:26, Dmitry Timoshkov wrote: > + hr = IRegistrationInfo_get_Description(reginfo, &bstr); > +todo_wine > + ok(hr == S_OK, "get_Description error %#x\n", hr); > +if (hr == S_OK) > +{ > + ok(bstr && !lstrcmpW(bstr, Task1), "expected Task1, got %s\n", wine_dbgstr_w(bstr)); It's redundant to check for 'bstr' being not NULL, lstrcmpW test will fail in this case too. For other tests when it returns NULL bstr it would be cleaner to set pointer to some non-zero value to test that each method actually resets it to NULL.

April 11, 2014

Re: [2/3] taskschd: Implement getters for IRegistrationInfo string properties.

by Nikolay Sivov

On 4/11/2014 11:27, Dmitry Timoshkov wrote: > + *description = reginfo->description ? SysAllocString(reginfo->description) : NULL; > + return S_OK; SysAllocString(NULL) returns NULL, so no need to handle it separately.

April 11, 2014

Re: [3/3] taskschd: Implement setters for IRegistrationInfo string properties.

by Nikolay Sivov

On 4/11/2014 11:27, Dmitry Timoshkov wrote: > static HRESULT WINAPI RegistrationInfo_put_Description(IRegistrationInfo *iface, BSTR description) > { > - FIXME("%p,%p: stub\n", iface, debugstr_w(description)); > - return E_NOTIMPL; > + registration_info *reginfo = impl_from_IRegistrationInfo(iface); > + > + TRACE("%p,%p\n", iface, debugstr_w(description)); > + > + if (!description) return E_INVALIDARG; > + > + reginfo->description = heap_strdupW(description); > + /* FIXME: update XML on the server side */ > + return reginfo->description ? S_OK : E_OUTOFMEMORY; Looks like you need to free previously set string.

April 11, 2014

Re: [2/2] dpnet: Improve Error checking in Get/Set SP (try 6)

by Stefan Dösinger

Am 11.04.2014 um 04:21 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > Fixed Copy/paste issue. > > Changelog: > dpnet: Improve Error checking in Get/Set SP > > > Best Regards > Alistair Leslie-Hughes Looks good to me!

April 11, 2014

Re: include: Add dvoice.h

by Dmitry Timoshkov

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > include: Add dvoice.h Isn't this supposed to be generated from an .idl? Also which PSDK version has this header? At least 7.1 doesn't contain it. -- Dmitry.

April 11, 2014

Re: mshtml: Ignore &IID_IWebBrowserPriv2IE7 in wb_qi.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6273 Your paranoid android. === build (build) === Patch failed to apply

April 11, 2014

Re: dpnet: Improve Error checking in Get/Set SP (try 5)

by Stefan Dösinger

Am 10.04.2014 um 11:51 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: Is this intentional? > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); Otherwise this looks good to me.

April 10, 2014

Re: Implementing (parts of) BindImageEx

by Bernhard Reiter

Am 2014-04-10 23:32, schrieb André Hentschel: > Am 09.04.2014 22:33, schrieb Bernhard Reiter: >> So I've tried to implement what I've described above, but unfortunately, >> I can't seem to figure out the very first part required: obtaining >> something that can be used as the "base" parameter for >> ImageDirectoryEntryToDataEx from the ImageName string passed to >> BindImageEx. I've tried LoadLibraryA(ImageName), >> LoadLibraryExA(ImageName, NULL, LOAD_LIBRARY_AS_DATAFILE), and >> MapAndLoad(), but unfortunately, all of them seem to either import all >> the PE's symbols in a fashion that collides with the already loaded ones >> (in particular in a python-freezing context, like running "wine >> C:\\Python27\\python.exe setup.py build" with the test case attached to >> [1]), or not load them in a way that can be used for >> ImageDirectoryEntryToDataEx. I'm hoping for someone to help me figure >> out how to do this... >> > Have you tried duplicating those functions and adjust them so they don't collide with something? (just as a proof that this will work?) > I'm afraid I don't quite understand what you mean by duplicating and adjusting. (Maybe I should've mentioned that I'm actually pretty much of a Wine (and Windows API, and PE format) newbie that still has to figure out his way through theses things; especially all that RVAing still seems pretty complex to me, and I don't really know how much of it I need to apply when I'm not going to actually call those imported functions...) Anyway, any help very much appreciated! Bernhard

April 10, 2014

Re: Implementing (parts of) BindImageEx

by André Hentschel

Am 09.04.2014 22:33, schrieb Bernhard Reiter: > So I've tried to implement what I've described above, but unfortunately, > I can't seem to figure out the very first part required: obtaining > something that can be used as the "base" parameter for > ImageDirectoryEntryToDataEx from the ImageName string passed to > BindImageEx. I've tried LoadLibraryA(ImageName), > LoadLibraryExA(ImageName, NULL, LOAD_LIBRARY_AS_DATAFILE), and > MapAndLoad(), but unfortunately, all of them seem to either import all > the PE's symbols in a fashion that collides with the already loaded ones > (in particular in a python-freezing context, like running "wine > C:\\Python27\\python.exe setup.py build" with the test case attached to > [1]), or not load them in a way that can be used for > ImageDirectoryEntryToDataEx. I'm hoping for someone to help me figure > out how to do this... > Have you tried duplicating those functions and adjust them so they don't collide with something? (just as a proof that this will work?)

April 10, 2014

Re: [PATCH] gdiplus: fix segfault in gdip_format_string

by Vincent Povirk

Looks good to me, thanks. (Maybe we should consider setting format to an empty GpStringFormat if it's not specified.)

April 10, 2014

wined3d: Add NVIDIA Geforce GTX 750 to device list.

by Ryan Turner

D'oh! Upon closer inspection, I messed up and put the test patch in the wrong directory, so Portage didn't actually apply it when I ran the test build. I must have read the patch a million times before sending it too. Well that's embarrassing. :S Actually, now that I look super-close, there's a tiny non-breaking typo in my 760 patch too. (inconsistent capitalization of "GeForce" in one spot) Should I fix that in a separate patch, or roll it into this 750 patch? On 04/10/2014 09:23 AM, Henri Verbeet wrote: > On 10 April 2014 08:47, Ryan Turner <zdbiohazard2(a)gmail.com> wrote: >> + CARD_NVIDIA_GEFORCE_GTX750 = 0x1381, >> + CARD_NVIDIA_GEFOREE_GTX750TI = 0x1380, > Did you try to compile this? >

April 10, 2014

Re: audio reset failed

by Andrew Eikum

On Thu, Apr 10, 2014 at 12:00:04PM +0200, Pawel Por wrote: > I receive periodically the following error popup window: > "Audio Reset Failed: Access violation at address 7BC503AA in module > 'ntdll.dll'. Write of address F818611C" > What is displaying this message? Wine itself does not contain the message "Audio Reset Failed." > When it occurs the audio hangs up and only the restart of the wine > application helps. There is a list of sound-related debug log channels at <http://wiki.winehq.org/Sound>. Getting a debug log with those channels set could give us a clue as to what's going wrong. You might consider opening a bug to keep track of this. Andrew

April 10, 2014

Re: wined3d: Add NVIDIA Geforce GTX 750 to device list.

by Henri Verbeet

On 10 April 2014 08:47, Ryan Turner <zdbiohazard2(a)gmail.com> wrote: > + CARD_NVIDIA_GEFORCE_GTX750 = 0x1381, > + CARD_NVIDIA_GEFOREE_GTX750TI = 0x1380, Did you try to compile this?

April 10, 2014

Re: user32: Don't fail on windows without menu bar in DrawMenuBar

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6272 Your paranoid android. === w2000pro (32 bit msg) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

April 10, 2014

audio reset failed

by Pawel Por

Hi I receive periodically the following error popup window: "Audio Reset Failed: Access violation at address 7BC503AA in module 'ntdll.dll'. Write of address F818611C" The message is the same every time. Even the addresses 7BC503AA and 7BC503AA are the same. When it occurs the audio hangs up and only the restart of the wine application helps. I use 64-bit Arch Linux and run 32 bit wine applications. Wine version is wine 1.7.14-1 (32 bit). The /proc/<wine app's PID>/maps is as follows. I can see that memroy region ffbd0000-ffbf0000 is not writtable and the memory region 7bc10000-7bc11000 is most likely BSS. 7bc00000-7bc10000 r-xp 00000000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bc10000-7bc11000 r-xp 00000000 00:00 0 7bc11000-7bcc6000 r-xp 00011000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc6000-7bcc7000 r--p 000c5000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc7000-7bcd1000 rwxp 000c6000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so f7747000-f7748000 r-xp 00000000 00:00 0 [vdso] f7750000-ffba0000 ---p 00000000 00:00 0 ffba8000-ffbc9000 rw-p 00000000 00:00 0 ffbd0000-ffbf0000 ---p 00000000 00:00 0 ffbf0000-ffff0000 rwxp 00000000 00:00 0 wine.log is as follows: fixme:ole:RemUnknown_QueryInterface No interface for iid {00000019-0000-0000-c000-000000000046} fixme:ole:CoResumeClassObjects stub err:ole:CoGetClassObject class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:create_server class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:CoGetClassObject no class object {a910187f-0c7a-45ac-92cc-59edafb77b53} could be created for context 0x5 dmesg sound related entries are: snd_hda_intel 0000:00:1b.0: irq 43 for MSI/MSI-X input: HDA Intel Front Headphone as /devices/pci0000:00/0000:00:1b.0/sound/card0/input8 input: HDA Intel Line Out as /devices/pci0000:00/0000:00:1b.0/sound/card0/input7 input: HDA Intel Line as /devices/pci0000:00/0000:00:1b.0/sound/card0/input6 input: HDA Intel Mic as /devices/pci0000:00/0000:00:1b.0/sound/card0/input5 lsmod sound related entries are: snd_hda_codec_analog 9307 1 snd_hda_intel 37352 0 snd_hda_codec 150017 2 snd_hda_intel,snd_hda_codec_analog snd_hwdep 6332 1 snd_hda_codec snd_pcm 77822 2 snd_hda_codec,snd_hda_intel snd_page_alloc 7298 2 snd_pcm,snd_hda_intel snd_timer 18718 1 snd_pcm snd 59029 6 snd_hwdep,snd_timer,snd_pcm,snd_hda_codec,snd_hda_intel,snd_hda_codec_analog soundcore 5418 1 snd I use alsa only (no pulse audio). Do you have any ideas how to solve this issue. I tried to use all possible sound outputs in winecfg but nothing helps. Thanks in advance.

April 10, 2014

Re: dpnet: Improve Error checking in Get/Set SP (try 5)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6271 Your paranoid android. === w2000pro (32 bit address) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

April 10, 2014

audio reset failed

by Pawel Por

Hi I receive periodically the following error popup window: "Audio Reset Failed: Access violation at address 7BC503AA in module 'ntdll.dll'. Write of address F818611C" The message is the same every time. Even the addresses 7BC503AA and 7BC503AA are the same. When it occurs the audio hangs up and only the restart of the wine application helps. I use 64-bit Arch Linux and run 32 bit wine applications. Wine version is wine 1.7.14-1 (32 bit). The /proc/<wine app's PID>/maps is as follows. I can see that memroy region ffbd0000-ffbf0000 is not writtable and the memory region 7bc10000-7bc11000 is most likely BSS. 7bc00000-7bc10000 r-xp 00000000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bc10000-7bc11000 r-xp 00000000 00:00 0 7bc11000-7bcc6000 r-xp 00011000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc6000-7bcc7000 r--p 000c5000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc7000-7bcd1000 rwxp 000c6000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so f7747000-f7748000 r-xp 00000000 00:00 0 [vdso] f7750000-ffba0000 ---p 00000000 00:00 0 ffba8000-ffbc9000 rw-p 00000000 00:00 0 ffbd0000-ffbf0000 ---p 00000000 00:00 0 ffbf0000-ffff0000 rwxp 00000000 00:00 0 wine.log is as follows: fixme:ole:RemUnknown_QueryInterface No interface for iid {00000019-0000-0000-c000-000000000046} fixme:ole:CoResumeClassObjects stub err:ole:CoGetClassObject class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:create_server class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:CoGetClassObject no class object {a910187f-0c7a-45ac-92cc-59edafb77b53} could be created for context 0x5 dmesg sound related entries are: snd_hda_intel 0000:00:1b.0: irq 43 for MSI/MSI-X input: HDA Intel Front Headphone as /devices/pci0000:00/0000:00:1b.0/sound/card0/input8 input: HDA Intel Line Out as /devices/pci0000:00/0000:00:1b.0/sound/card0/input7 input: HDA Intel Line as /devices/pci0000:00/0000:00:1b.0/sound/card0/input6 input: HDA Intel Mic as /devices/pci0000:00/0000:00:1b.0/sound/card0/input5 lsmod sound related entries are: snd_hda_codec_analog 9307 1 snd_hda_intel 37352 0 snd_hda_codec 150017 2 snd_hda_intel,snd_hda_codec_analog snd_hwdep 6332 1 snd_hda_codec snd_pcm 77822 2 snd_hda_codec,snd_hda_intel snd_page_alloc 7298 2 snd_pcm,snd_hda_intel snd_timer 18718 1 snd_pcm snd 59029 6 snd_hwdep,snd_timer,snd_pcm,snd_hda_codec,snd_hda_intel,snd_hda_codec_analog soundcore 5418 1 snd I use alsa only (no pulse audio). Do you have any ideas how to solve this issue. I tried to use all possible sound outputs in winecfg but nothing helps. Thanks in advance.

April 10, 2014

Re: [1/5] taskschd: Add invalid parameter check to IRegisteredTask::get_State and IRegisteredTask::get_Enabled.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6266 Your paranoid android. === w2000pro (32 bit scheduler) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

April 10, 2014

Re: [PATCH 5/5] d3d9/tests: Use a separate device for color_fill_test().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6265 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

April 10, 2014

Re: [PATCH 4/5] d3d9/tests: Use a separate device for fog_test().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6264 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

April 10, 2014

Re: [PATCH 3/5] d3d9/tests: Use a separate device for test_cube_wrap().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6263 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

April 10, 2014