April 2014 - Wine-Devel - list.winehq.org

Re: [2/2] schedsvc/tests: Avoid test failures on file systems with enabled directory randomization.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6220 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [1/2] schedsvc/tests: Fix a couple of typos.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6219 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 2/2] dwrite: Added partial implementation for CreateEllipsisTrimmingSign()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6218 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 1/2] dwrite: Added GetTrimming()/SetTrimming() for text format

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6217 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 5/5] ddraw: SetPrivateData(..., data = NULL, ...) is not valid.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6216 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 4/5] dxgi/tests: Add private data tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6215 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 3/5] ddraw/tests: Nvidia has an off-by-one rectangle handling bug.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6214 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 2/5] d3d8/tests: Test locking of mipmap textures.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 1/5] d3d9/tests: Test locking of mipmap textures.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6212 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 6/6] ole32: Add more SetConvertStg amd WriteFmtUserTypeStg tests (try2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6207 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 5/6] ole32: Add OleDoAutoConvert implementation (try2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6206 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [4/4] user32: Emit EM_SETSEL message when choosing "Select All" from context menu.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6205 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [3/4] user32: Don't emit WM_COMMAND on choosing an item in a context menu (Edit control).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6204 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [2/4] user32/tests: Add some tests for edit control context menu messages.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6203 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [1/4] user32/tests: Don't forget to destroy the parent window after the tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6202 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [1/4] user32/tests: Don't forget to destroy the parent window after the tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6202 Your paranoid android. === build (build) === Missing build status line

April 8, 2014

Re: [PATCH 1/2] ntdll: Add a replacement getmntent for Android.

by Huw Davies

On Tue, Apr 08, 2014 at 12:18:23PM +0400, Vitaly Lipatov wrote: > I think the more appropriate place for a missed libc function is > libs/port. If it is ever needed by another dll, then it can get moved there. Huw.

April 8, 2014

Re: [PATCH 1/2] ntdll: Add a replacement getmntent for Android.

by Vitaly Lipatov

Huw Davies писал 2014-04-07 16:22: > Bionic has a stub function named getmntent which outputs an > unimplemented message. > --- > dlls/ntdll/directory.c | 101 I think the more appropriate place for a missed libc function is libs/port. -- Vitaly Lipatov, Etersoft

April 8, 2014

Re: [4/4] taskschd: Implement IRegisteredTask::get_Path.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/taskschd/regtask.c | 12 ++++++++++-- > dlls/taskschd/tests/scheduler.c | 34 ++++++++++++++++++++++++++-------- > 2 files changed, 36 insertions(+), 10 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok scheduler.c:827: Test succeeded inside todo block: expected VARIANT_FALSE, got 0 scheduler.c:887: Test succeeded inside todo block: expected VARIANT_FALSE, got 0 make: *** [scheduler.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

April 8, 2014

RE: regsvr32: Improve a few resource strings

by Hugh McMaster

On Monday, 7 April 2014 10:08 PM, Nikolay Sivov wrote: > You don't really register a module, it registers COM server that's > implemented in some module. So server is important part, module hosting it > is details. Well, I stand corrected. I'd still like a better expression than "Unregister a server", though.

April 7, 2014

Re: [PATCH 3/6] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function (try2)

by Vincent Povirk

Looks good to me.

April 7, 2014

Re: [PATCH 3/5] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function

by Piotr Caban

On 04/07/14 18:24, Vincent Povirk wrote: > This looks like a no-op to me. It means we read/update the flags even > if we created the stream, but in that case it should already be > correct. Why do we need this? My bad, I'll send a fixed version. The intention of this patch was to avoid call to IStorage::CreateStream. There's no point in writing the flag twice.

April 7, 2014

Re: [PATCH 3/5] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function

by Vincent Povirk

This looks like a no-op to me. It means we read/update the flags even if we created the stream, but in that case it should already be correct. Why do we need this?

April 7, 2014

Re: [3/5] netprofm: Add a class factory implementation.

by Dmitry Timoshkov

Hi Hans, Hans Leidekker <hans(a)codeweavers.com> wrote: > +struct netprofm_cf > +{ > + const struct IClassFactoryVtbl *vtbl; > + HRESULT (*create_instance)(void **); > +}; > + > +static inline struct netprofm_cf *impl_from_IClassFactory( IClassFactory *iface ) > +{ > + return (struct netprofm_cf *)((char *)iface - FIELD_OFFSET( struct netprofm_cf, vtbl )); > +} Objects in this new dll don't follow http://wiki.winehq.org/COMGuideline, but that's not a big problem, and could be fixed later. > +static HRESULT WINAPI netprofm_cf_CreateInstance( IClassFactory *iface, LPUNKNOWN outer, > + REFIID riid, LPVOID *obj ) > +{ > + struct netprofm_cf *factory = impl_from_IClassFactory( iface ); > + IUnknown *unk; > + HRESULT r; > + > + TRACE( "%p %s %p\n", outer, debugstr_guid(riid), obj ); > + > + *obj = NULL; > + if (outer) return CLASS_E_NOAGGREGATION; > + > + r = factory->create_instance( (void **)&unk ); > + if (FAILED( r )) > + return r; > + > + r = IUnknown_QueryInterface( unk, riid, obj ); > + if (FAILED( r )) > + return r; > + > + IUnknown_Release( unk ); > + return r; > +} It seems that 'unk' is leaked if IUnknown_QueryInterface fails. -- Dmitry.

April 7, 2014

Re: regsvr32: Improve a few resource strings

by Nikolay Sivov

I don't want another oversized thread on this, but: -\ [/u] Unregister a server.\n\ +\ [/u] Unregister a module.\n\ You don't really register a module, it registers COM server that's implemented in some module. So server is important part, module hosting it is details.

April 7, 2014