April 2014 - Wine-Devel - list.winehq.org

Re: wtsapi32: Partial implementation of WTSEnumerateProcessesW (try 4)

by Stefan Leichter

Hello, after this patch has left http://source.winehq.org/patches/ without any comment, i like to know what needs to be change to get this patch commited. Regards Stefan --- dlls/wtsapi32/tests/wtsapi.c | 1 - dlls/wtsapi32/wtsapi32.c | 65 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 63 insertions(+), 3 deletions(-)

April 28, 2014

Re: [PATCH 5/5] ddraw/tests: Test mipmap GetDC behavior.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6629 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6115: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6428: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6493: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6558: Test failed: Failed to create surface, hr 0x80004002.

April 28, 2014

Re: Fixing conflicts between WineD3D and WGL

by Ken Thomases

On Apr 28, 2014, at 11:25 AM, Bruno Jesus wrote: > On Mon, Apr 28, 2014 at 12:27 PM, Ken Thomases <ken(a)codeweavers.com> wrote: >> ... >> Thanks. Somebody else already reported something like that in private email and I have a fix already. I've uploaded that fix here <http://www.codeweavers.com/xfer/ken/wgl_wine_surface/wgl_surface_fix_list_m…> if you want to test. It applies on top of the original patch set plus the additional patch I linked in my previous email on this thread. I hope to have a revised consolidated patch set soon, too. > > That links shows an access forbidden patch requesting an unlock code. Sorry, yes. The access code was mentioned in the email where I first linked to my patch set. It is "wgl_wine_surface". I'll try to remember to mention that each time I post such a link. -Ken

April 28, 2014

Re: [PATCH 4/5] ddraw/tests: Add a test for getdc palette handling.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6628 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6115: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6428: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6493: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6553: Test failed: Failed to create surface, hr 0x80004002.

April 28, 2014

Re: Fixing conflicts between WineD3D and WGL

by Bruno Jesus

On Mon, Apr 28, 2014 at 12:27 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > ... > Thanks. Somebody else already reported something like that in private email and I have a fix already. I've uploaded that fix here <http://www.codeweavers.com/xfer/ken/wgl_wine_surface/wgl_surface_fix_list_m…> if you want to test. It applies on top of the original patch set plus the additional patch I linked in my previous email on this thread. I hope to have a revised consolidated patch set soon, too. That links shows an access forbidden patch requesting an unlock code. > -Ken Bruno

April 28, 2014

Re: [PATCH 01/10] vbscript: Fixed CBool(try 3)

by Piotr Caban

On 04/28/14 17:26, Shuai Meng wrote: > > > > 2014-04-21 17:18 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com > <mailto:jacek(a)codeweavers.com>>: > > Hi Shuai, > > On 04/21/14 03:45, Shuai Meng wrote: > > - > > - return return_bool(res, val); > > + V_VT(res) = VT_EMPTY; > > + return VariantChangeType(res, arg, VARIANT_LOCALBOOL, VT_BOOL); > > You can't assume that res is not NULL. If result of the function is not > used, it will be NULL. A simple test case is like this: > > call CBool(0) > > Also, are you sure we want VARIANT_LOCALBOOL here? Did you test it > (probably by running tests on localized Windows with translated string > "False")? > > I don't quite understand what this parameter means, in fact I just > copy it from to_string(). If not VARIANT_LOCALBOOL, waht esle should be > filled here? I've checked what happens on non-english locale and CStr(True) = "True". So the flag is used incorrectly in CStr implementation. CBool is also failing when localized string is passed. You can use 0 as flag in VariantChangeType.

April 28, 2014

Re: [PATCH 3/5] ddraw/tests: Handle a backbuffer palette misbehavior on Windows 8.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6626 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6115: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6428: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6493: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6553: Test failed: Failed to create surface, hr 0x80004002.

April 28, 2014

Re: Fixing conflicts between WineD3D and WGL

by Ken Thomases

Hi, On Apr 28, 2014, at 6:53 AM, Jerome Leclanche wrote: > Your patchset causes X11 errors with the Battle.net client. 100% > reproducible, and also crashes within explorer.exe with +synchronous. > > I thought it was something else at first due to a bad revert and filed > the details here: https://bugs.winehq.org/show_bug.cgi?id=36141 Thanks. Somebody else already reported something like that in private email and I have a fix already. I've uploaded that fix here <http://www.codeweavers.com/xfer/ken/wgl_wine_surface/wgl_surface_fix_list_m…> if you want to test. It applies on top of the original patch set plus the additional patch I linked in my previous email on this thread. I hope to have a revised consolidated patch set soon, too. -Ken

April 28, 2014

Re: [PATCH 01/10] vbscript: Fixed CBool(try 3)

by Shuai Meng

2014-04-21 17:18 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>: > Hi Shuai, > > On 04/21/14 03:45, Shuai Meng wrote: > > - > > - return return_bool(res, val); > > + V_VT(res) = VT_EMPTY; > > + return VariantChangeType(res, arg, VARIANT_LOCALBOOL, VT_BOOL); > > You can't assume that res is not NULL. If result of the function is not > used, it will be NULL. A simple test case is like this: > > call CBool(0) > > Also, are you sure we want VARIANT_LOCALBOOL here? Did you test it > (probably by running tests on localized Windows with translated string > "False")? > > I don't quite understand what this parameter means, in fact I just copy it from to_string(). If not VARIANT_LOCALBOOL, waht esle should be filled here? > Looking at CBool tests: > > +Call ok(CBool(Empty) = False, "CBool(Empty) = " & CBool(Empty)) > +Call ok(getVT(CBool(Empty)) = "VT_BOOL", "getVT(CBool(Empty)) = " & > getVT(CBool(Empty))) > +Call ok(CBool(1) = True, "CBool(1) = " & CBool(1)) > +Call ok(getVT(CBool(1)) = "VT_BOOL", "getVT(CBool(1)) = " & > getVT(CBool(1))) > +Call ok(CBool(CLng(0)) = False, "CBool(CLng(0)) = " & CBool(CLng(0))) > +Call ok(getVT(CBool(CLng(0))) = "VT_BOOL", "getVT(CBool(CLng(0))) = " & > getVT(CBool(CLng(0)))) > +Call ok(CBool(CSng(0.5)) = True, "CBool(CSng(0.5)) = " & CBool(CSng(0.5))) > +Call ok(getVT(CBool(CSng(0.5))) = "VT_BOOL", "getVT(CBool(CSng(0.5))) = " > & getVT(CBool(CSng(0.5)))) > +Call ok(CBool(-0.56) = True, "CBool(-0.56) = " & CBool(-0.56)) > +Call ok(getVT(CBool(-0.56)) = "VT_BOOL", "getVT(CBool(-0.56)) = " & > getVT(CBool(-0.56))) > +Call ok(CBool(CCur(8.55)) = True, "CBool(CCur(8.55)) = " & > CBool(CCur(8.55))) > +Call ok(getVT(CBool(CCur(8.55))) = "VT_BOOL", "getVT(CBool(CCur(8.55))) = > " & getVT(CBool(CCur(8.55)))) > +Call ok(CBool(CDate(0)) = False, "CBool(CDate(0)) = " & CBool(CDate(0))) > +Call ok(getVT(CBool(CDate(0))) = "VT_BOOL", "getVT(CBool(CDate(0))) = " & > getVT(CBool(CDate(0)))) > +Call ok(CBool(CDate(3.33)) = True, "CBool(CDate(3.33)) = " & > CBool(CDate(3.33))) > +Call ok(getVT(CBool(CDate(3.33))) = "VT_BOOL", "getVT(CBool(CDate(3.33))) > = " & getVT(CBool(CDate(3.33)))) > +Call ok(CBool("6666.78") = True, "CBool(""6666.78"") = " & > CBool("6666.78")) > +Call ok(getVT(CBool("6666.78")) = "VT_BOOL", "getVT(CBool(""6666.78"")) = > " & getVT(CBool("6666.78"))) > +Call ok(CBool(CByte(-0.1)) = False, "CBool(CByte(-0.1)) = " & > CBool(CByte(-0.1))) > +Call ok(getVT(CBool(CByte(-0.1))) = "VT_BOOL", "getVT(CBool(CByte(-0.1))) > = " & getVT(CBool(CByte(-0.1)))) > > Those look mostly good. However I'd like to see some more tests. > Interesting case is for example empty string and a "false", "False" and > "#FALSE#" string. Also I'd really like to see tests on object default > values. See the attached patch for an example. > > Those comments apply also to other patches in the series. It may be > easier to proceed if you resent just the first patch fixed and include > tests that don't depending on other patches in the series in the patch > itself. > > Cheers, > Jacek > > > >

April 28, 2014

Re: [PATCH 2/5] ddraw/tests: Skip the ddraw7 primary palette test if 8 bpp mode doesn't work.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === w864 (32 bit ddraw7) === ddraw7.c:5635: Test failed: Got unexpected refcount 3. ddraw7.c:5654: Test failed: Got unexpected refcount 3. ddraw7.c:5661: Test failed: Got unexpected hr 0. ddraw7.c:5664: Test failed: Got unexpected refcount 3. ddraw7.c:5666: Test failed: Got unexpected refcount 2. ddraw7.c:5672: Test failed: Got unexpected hr 0. ddraw7.c:5675: Test failed: Got unexpected refcount 2. ddraw7.c:5679: Test failed: Got unexpected refcount 6. ddraw7.c:5796: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:6352: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6091: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6352: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6404: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6469: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6529: Test failed: Failed to create surface, hr 0x80004002.

April 28, 2014