May 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] vbscript: Implemented CCur

by Piotr Caban

On 05/19/14 08:47, Shuai Meng wrote: > +Call ok(CCur(0.000149) = 0.0001, "CCur(0.000149) = " & CCur(0.000149)) > +Call ok(getVT(CCur(0.000149)) = "VT_CY", "getVT(CCur(0.000149)) = " & getVT(CCur(0.000149))) > +Call ok(CCur(2147483647.99) = 2147483647.99, "CCur(2147483647.99) = " & CCur(2147483647.99)) > +Call ok(getVT(CCur(2147483647.99)) = "VT_CY", "getVT(CCur(2147483647.99)) = " & getVT(CCur(2147483647.99))) This tests are failing on polish locale. > +Call ok(CCur(MyObject) = 0, "CCur(MyObject) = " & CCur(MyObject)) > +Call ok(getVT(CCur(MyObject)) = "VT_CY", "getVT(CCur(MyObject)) = " & getVT(CCur(MyObject))) > +MyObject.myval = 1 > +Call ok(CCur(MyObject) = 1, "CCur(MyObject) = " & CCur(MyObject)) > +Call ok(getVT(CCur(MyObject)) = "VT_CY", "getVT(CCur(MyObject)) = " & getVT(CCur(MyObject))) > +MyObject.myval = 0 > +Call ok(CCur(MyObject) = 0, "CCur(MyObject) = " & CCur(MyObject)) > +Call ok(getVT(CCur(MyObject)) = "VT_CY", "getVT(CCur(MyObject)) = " & getVT(CCur(MyObject))) There are two identical tests on MyObject. MyObject.myval is set to 0 in first test (it's set this way in earlier tests). Thanks, Piotr

May 19, 2014

Re: [website] German translation for release 1.7.19

by Michael Stefaniuc

On 05/18/2014 09:37 PM, Frédéric Delanoy wrote: > On Sun, May 18, 2014 at 5:40 PM, Julian Rüger <jr98(a)gmx.net> wrote: >> Hi Frédéric, >> >>> "writer" should probably be translated as well... >> >> I don't think there is a useful translation that is not clunky or sounds >> awkward. Plus, "writer" is probably a familiar term to most users >> because of i.e. LibreOffice Writer. > > LibreOffice Writer is an English product name, and maybe not known to > non-techies (it's just a word processing application to them) IMHO. > In German, it should probably be something like Redaktor, but you know > German better than me ;-) Ze Germans love their Denglish. Unlike in French not everything needs to be translated. Bonus points for English words and phrases that mean something totally different in English than what the politicians/marketing/mass media want you to believe. bye michael

May 19, 2014

Re: msi: Prevent call to memset with a nullptr in get_tablecolumns function

by Hans Leidekker

On Sun, 2014-05-18 at 13:27 -0400, Daniel Beitler wrote: > This is a fix for bug #36139. > > It looks like calling memset with a nullptr is undefined behavior. Gcc > 4.9 will actually optimize out the "if(colinfo)" condition if memset was > called on colinfo before. > > > --- > dlls/msi/table.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Looks good, thanks.

May 19, 2014

Re: [website] German translation for release 1.7.19

by Frédéric Delanoy

On Sun, May 18, 2014 at 5:40 PM, Julian Rüger <jr98(a)gmx.net> wrote: > Hi Frédéric, > >> "writer" should probably be translated as well... > > I don't think there is a useful translation that is not clunky or sounds > awkward. Plus, "writer" is probably a familiar term to most users > because of i.e. LibreOffice Writer. LibreOffice Writer is an English product name, and maybe not known to non-techies (it's just a word processing application to them) IMHO. In German, it should probably be something like Redaktor, but you know German better than me ;-) Frédéric Delanoy

May 18, 2014

Re: [patch]Japanese Translation update

by Akihiro Sagawa

On Fri, 16 May 2014 10:08:47 -0400 (EDT), Toshiaki Hirose wrote: > From 67e0fca928a2f2de03adaf96f7a1f8f55e2cf85d Mon Sep 17 00:00:00 2001 > Message-Id: <67e0fca928a2f2de03adaf96f7a1f8f55e2cf85d.1400248197.git.t_hirose(a)aol.com> > From: Toshiaki Hirose <t_hirose(a)aol.com> > Date: Fri, 16 May 2014 22:49:46 +0900 > Subject: [PATCH] Japanese Translation Update for 1.7.18 > > --- > po/ja.po | 172 ++++++++++++++++++++++++--------------------------------------- > 1 file changed, 65 insertions(+), 107 deletions(-) Hello Hirose-san, Your translation is getting better, but it needs some more work. Could you read my comments and submit again? I also welcome your feedback. > #: oleacc.rc:97 > -#, fuzzy > #| msgid "Normal" > -msgctxt "object state" > msgid "normal" > -msgstr "標準" > +msgstr "normal" Msgctxt line can't be removed. The line indicates message context, and is used with msgid to specify translation. > #: oleacc.rc:98 > #: oleacc.rc:99 : : > #: oleacc.rc:128 Same as above. > #: regsvr32.rc:41 > msgid "" > "regsvr32: Invalid or unrecognized switch [%1]\n" > "\n" > msgstr "" > +"regsvr32: 無効または認識できない切り替えです[%1]\n" > +"\n" I'm not sure about this translation. This `switch' means `command-line switch'. In that case, we usually translate into `スイッチ'. For instance, see http://support.microsoft.com/kb/227091/ja vs http://support.microsoft.com/kb/227091/en-us . > #: regsvr32.rc:46 > msgid "regsvr32: Failed to unregister DLL '%1'\n" > -msgstr "" > +msgstr "regsvr32: DLL '%1'の登録消去に失敗しました。\n" You removed some full-stops, but didn't about this line. > #: regsvr32.rc:49 > msgid "regsvr32: Successfully installed DLL '%1'\n" > -msgstr "" > +msgstr "regsvr32: DLL '%1'のインストールに成功しました。\n" Ditto. Otherwise looks fine. Regards, Akihiro Sagawa

May 18, 2014

Re: [website] German translation for release 1.7.19

by Julian Rüger

Hi Frédéric, > "writer" should probably be translated as well... I don't think there is a useful translation that is not clunky or sounds awkward. Plus, "writer" is probably a familiar term to most users because of i.e. LibreOffice Writer. PS: Sorry for double post, forgot to CC wine-devel...

May 18, 2014

Re: msvcp90/msvcp90.h: right-hand operand of comma expression has no effect

by Gerald Pfeifer

On Wed, 16 Apr 2014, Paul Chitescu wrote: >> Digging into this in more detail I see >> >> ../msvcp90/ios.c: In function 'basic_streambuf_char__Xsgetn_s': >> ../msvcp90/msvcp90.h:529:75: warning: right-hand operand of comma >> expression has no effect [-Wunused-value] >> #define memcpy_s( dst, size, src, count ) (memcpy( (dst), (src), (count) >> ), 0) ^ ../msvcp90/ios.c:1218:13: note: in expansion of macro 'memcpy_s' >> memcpy_s(ptr+copied, size, *this->prpos, chunk); >> ^ > memcpy_s() returns an errno_t so the author tried to force returning > zero (no error). > > A simple replacement (still without any checks memcpy_s does) would be: > > #define memcpy_s( dst, size, src, count ) (!memcpy( (dst), (src), (count) )) I tried to make this change, but that now gets: ../msvcp90/msvcp90.h:529:44: warning: value computed is not used [-Wunused-value] #define memcpy_s( dst, size, src, count ) (!memcpy( (dst), (src), (count) )) ^ Since, clearly, the result is never intended to be used, we can as well simply cast the result away instead of using ", 0". This is what the patch below does. Tested successfully with GCC 4.9.0. Gerald diff --git a/dlls/msvcp90/msvcp90.h b/dlls/msvcp90/msvcp90.h index 0d5e124..0691141 100644 --- a/dlls/msvcp90/msvcp90.h +++ b/dlls/msvcp90/msvcp90.h @@ -526,7 +526,7 @@ typedef struct { } complex_double; #if _MSVCP_VER < 80 -#define memcpy_s( dst, size, src, count ) (memcpy( (dst), (src), (count) ), 0) +#define memcpy_s( dst, size, src, count ) ((void)memcpy( (dst), (src), (count) )) #define memmove_s( dst, size, src, count ) (memmove( (dst), (src), (count) ), 0) #define mbstowcs_s( ret, wcs, size, mbs, count ) (mbstowcs( (wcs), (mbs), (count) ), 0) #define hypotf( x, y ) ((float)hypot( (double)(x), (double)(y) ))

May 18, 2014

Re: [website] German translation for release 1.7.19

by Frédéric Delanoy

On Sat, May 17, 2014 at 4:00 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > Am 17.05.2014 02:10, schrieb Julian Rüger: >> +<date>16. Main 2014</date> > > -n, everything else is fine ;) "writer" should probably be translated as well... -- Frédéric Delanoy

May 17, 2014

Re: [website] German translation for release 1.7.19

by André Hentschel

Am 17.05.2014 02:10, schrieb Julian Rüger: > +<date>16. Main 2014</date> -n, everything else is fine ;)

May 17, 2014

Re: shell32: Fix SHFileOperation when deleting a nonexistent directory.

by Zhenbo Li

Excuse me, is there anything to to to improve this patch? Thank you. 2014-05-10 8:28 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > 2014-05-09 23:09 GMT+08:00 Marvin <testbot(a)winehq.org>: >> >> >> === wvistau64 (32 bit shlfileop) === >> shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR >> >> === wvistau64 (64 bit shlfileop) === >> shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR > > > As http://testbot.winehq.org/JobDetails.pl?Key=6956 showes, they are not > caused by my patch. > > -- > Have a nice day! > Zhenbo Li -- Have a nice day! Zhenbo Li

May 17, 2014