May 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/6] wined3d: Validate and handle query size parameter.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6720 Your paranoid android. === w864 (32 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000). === w864 (64 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000).

May 1, 2014

Re: [PATCH 1/6] d3d9/tests: Test GetData behavior with various size values.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6719 Your paranoid android. === w864 (32 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000). === w864 (64 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000).

May 1, 2014

Re: [PATCH] vbscript: Fixed CBool(try 2)

by Jacek Caban

On 05/01/14 16:38, Piotr Caban wrote: > >> These are the failing tests: >> Call testCBoolError("#TRUE#", 458) >> Call testCBoolError("#FALSE#", 458) >> Call testCBoolError(MyObject, 458) > In order to fix it you need to change the implementation. Probably you > need to check if string equals to "#TRUE#" and return early without > calling VariantChangeType. I'm not sure what needs to be done in > MyObject case. Actually, I'd like to see a cleaner solution than special casing specific strings. Jacek

May 1, 2014

Re: [PATCH] vbscript: Fixed CBool(try 2)

by Piotr Caban

On 05/01/14 15:22, Shuai Meng wrote: > I have changed the tests like this and they can pass on wine with no > failure. > 481 Sub testCBoolError > 482 on error resume next > 483 > 484 Call Err.clear() > 485 Call CBool("") > 486 Call ok(Err.number = 13, "Err.number = " & Err.number) > 487 > 488 Call Err.clear() > 489 Call CBool("#False#") > 490 Call ok(Err.number = 13, "Err.number = " & Err.number) > 491 > 492 Call Err.clear() > 493 Call CBool("#True#") > 494 Call ok(Err.number = 13, "Err.number = " & Err.number) > 495 > 496 Call Err.clear() > 497 Call CBool("MyObject") > 498 Call ok(Err.number = 13, "Err.number = " & Err.number) > 499 End Sub I think that previous way of implementing this tests was nicer. The results are different because you're testing different things (e.g. "MyObject" instead of MyObject, "#True#" instead of "#TRUE#"). > These are the failing tests: > Call testCBoolError("#TRUE#", 458) > Call testCBoolError("#FALSE#", 458) > Call testCBoolError(MyObject, 458) In order to fix it you need to change the implementation. Probably you need to check if string equals to "#TRUE#" and return early without calling VariantChangeType. I'm not sure what needs to be done in MyObject case. > As showed above, I have changed 458 into 13, and can pass on winxp. > However there two failures come nowhere like this: > run.c:1013: Test failed: api.vbs: L"Err.number = 0" > run.c:1013: Test failed: api.vbs: L"Err.number = 0" > I can't understand it: if Err.number = 0 then everything is right, why > does it come out? It's happening because on wine the test is succeeding while it's supposed to fail. > Could you please also add following tests: > MyObject.myval = 1 > Call ok(CBool(MyObject) = True, "CBool(MyObject) = " & CBool(MyObject)) > MyObject.myval = 0 > Call ok(CBool(MyObject) = False, "CBool(MyObject) = " & CBool(MyObject)) > > Ok, but does this mean I am testing object in the proper way? Currently you're only testing what happens if default value is unset (variant VT_EMPTY). This is just testing what happens if other values are returned.

May 1, 2014

Re: [PATCH 11/11] oleacc: Add tests for default client accessible object (try2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6716 Your paranoid android. === w2000pro (32 bit main) === main.c:347: Test failed: V_I4(&v) = 8000 === w2008s64 (64 bit main) === main.c:223: Test failed: wparam = 0 main.c:229: Test failed: unexpected (-12) === w864 (64 bit main) === main.c:223: Test failed: wparam = 0 main.c:229: Test failed: unexpected (-12)

May 1, 2014

Re: [PATCH 11/11] oleacc: Add tests for default client accessible object

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6714 Your paranoid android. === build (build) === Unable to regenerate dlls/oleacc/Makefile Unable to regenerate dlls/oleacc/Makefile

May 1, 2014

regsvr32 patches (argument handler, unicode)

by Hugh McMaster

Is there a reason that patches 104221 to 104224 were not committed? Perhaps a test case is needed? [1/4] regsvr32: Implement new method of handling arguments/flags ( http://source.winehq.org/patches/data/104221 ) This patch replaces the existing argument/flag handler in regsvr32.c (mostly repeated calls to strcasecmp) with a new handler based on a switch statement. [2/4] regsvr32: Convert to Unicod ( http://source.winehq.org/patches/data/104222 ) This patch modifies the source in regsvr32.c so that regsvr32.exe runs entirely in Unicode. Note that the Windows version has Unicode support. Wine does not (yet). [3/4] regsvr32: Add WriteFile support ( http://source.winehq.org/patches/data/104223 ) This patch adds WriteFile() support to regsvr32's output_write() function. It is used in the event that WriteConsoleW() fails. [4/4] regsvr32: Fix a number of errors in the comments of regsvr32.c ( http://source.winehq.org/patches/data/104224 ) This patch fixes a number of spelling, grammar and logic errors in the comments of regsvr32.c. Thank you. -- Hugh McMaster

May 1, 2014

Re: user32: Reduce the minimum Set[System]Timer from 15 ms to 10 ms.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6713 Your paranoid android. === wxppro (32 bit msg) === msg.c:13332: Test failed: 9: WaitForSingleObject failed === w7u (32 bit msg) === msg.c:12098: Test failed: unexpected hwnd 00150136 msg.c:12120: Test failed: bad time 31ef4/31f14

May 1, 2014

Re: [PATCH] vbscript: Fixed CBool(try 2)

by Shuai Meng

Thank you for commenting. 2014-05-01 17:59 GMT+08:00 Piotr Caban <piotr.caban(a)gmail.com>: > On 05/01/14 10:16, Shuai Meng wrote: > >> Changelog: >> added tests on object subtype. >> improved CBool. >> >> https://newtestbot.winehq.org/JobDetails.pl?Key=6689 >> >> --- >> dlls/vbscript/global.c | 41 >> ++++++++++++----------------------------- >> dlls/vbscript/tests/api.vbs | 42 >> ++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 54 insertions(+), 29 deletions(-) >> > The tests are not passing on wine: > run.c:1013: Test failed: api.vbs: L"Err.number = 0" > run.c:1013: Test failed: api.vbs: L"Err.number = 0" > run.c:1013: Test failed: api.vbs: L"Err.number = 0" > > I have changed the tests like this and they can pass on wine with no failure. 481 Sub testCBoolError 482 on error resume next 483 484 Call Err.clear() 485 Call CBool("") 486 Call ok(Err.number = 13, "Err.number = " & Err.number) 487 488 Call Err.clear() 489 Call CBool("#False#") 490 Call ok(Err.number = 13, "Err.number = " & Err.number) 491 492 Call Err.clear() 493 Call CBool("#True#") 494 Call ok(Err.number = 13, "Err.number = " & Err.number) 495 496 Call Err.clear() 497 Call CBool("MyObject") 498 Call ok(Err.number = 13, "Err.number = " & Err.number) 499 End Sub These are the failing tests: > Call testCBoolError("#TRUE#", 458) > Call testCBoolError("#FALSE#", 458) > Call testCBoolError(MyObject, 458) > > As showed above, I have changed 458 into 13, and can pass on winxp. However there two failures come nowhere like this: run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" I can't understand it: if Err.number = 0 then everything is right, why does it come out? > Could you please also add following tests: > MyObject.myval = 1 > Call ok(CBool(MyObject) = True, "CBool(MyObject) = " & CBool(MyObject)) > MyObject.myval = 0 > Call ok(CBool(MyObject) = False, "CBool(MyObject) = " & CBool(MyObject)) > Ok, but does this mean I am testing object in the proper way?

May 1, 2014

Re: [PATCH] vbscript: Fixed CBool(try 2)

by Piotr Caban

On 05/01/14 10:16, Shuai Meng wrote: > Changelog: > added tests on object subtype. > improved CBool. > > https://newtestbot.winehq.org/JobDetails.pl?Key=6689 > > --- > dlls/vbscript/global.c | 41 > ++++++++++++----------------------------- > dlls/vbscript/tests/api.vbs | 42 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 29 deletions(-) The tests are not passing on wine: run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" These are the failing tests: Call testCBoolError("#TRUE#", 458) Call testCBoolError("#FALSE#", 458) Call testCBoolError(MyObject, 458) Could you please also add following tests: MyObject.myval = 1 Call ok(CBool(MyObject) = True, "CBool(MyObject) = " & CBool(MyObject)) MyObject.myval = 0 Call ok(CBool(MyObject) = False, "CBool(MyObject) = " & CBool(MyObject))

May 1, 2014