May 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] propsys: Forward exported calls to corresponding methods

by Jacek Caban

Hi Nikolay, On 05/27/14 11:09, Nikolay Sivov wrote: > From 386a536f9ae75505cd95601e4a8ca936b826658c Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Mon, 26 May 2014 22:38:35 +0400 > Subject: [PATCH 2/2] propsys: Forward exported calls to corresponding methods It seems to me that forwarding the other way be more logical. Jacek

May 27, 2014

Re: [PATCH 2/2] shell32: Improve checking for folder index validity in NameSpace()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7279 Your paranoid android. === w2000pro (32 bit shelldispatch) === shelldispatch.c:94: Test failed: got 00000001 shelldispatch: unhandled exception c0000005 at 0040EB1D

May 27, 2014

Re: About wineserver and winsock

by jordan

> We could speed up calls to the wineserver, which involve at least 4 > system calls, 2 context switches, and 4 memory copies (in and out of > the UNIX socket's buffers), by porting the wineserver to be a kernel > module on the underlying *nix kernel, so that it only needs a single > system call, zero context switches, and zero memory copies. I know > Transgaming was considering this years ago - don't know how far they > got - but I imagine it to be extremely difficult. Maybe it's possible > to port only a small part of it that deals with performance critical > areas, like sockets and synchronization, while the rest stays running > as a user space application? This conversation reminds me of this blog; http://www.linuxtoday.com/developer/2010060303135OSKNDV ...from a few years ago, comparing 'longene' or Linux Unified kernel vs Wine. The project doesn't appear to be active, but there is some source code here; https://sourceforge.net/projects/longene/files/longene/longene-0.3.2/source/ ... I've never used it, but did take a look at one point. [back when]. cheerz Jordan > Damjan > > On Mon, May 26, 2014 at 5:10 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: >> Hi all, after studying the ws2_32 dll code for some time while looking >> for ways to optimize it I started wondering why is the wineserver >> required (please don't stop reading yet). >> >> make test takes 45 seconds in my machine while it takes 25 seconds in >> a XP VM running on the same machine. The culprit is test_send() [1] >> which takes 24 seconds in wine and 1.8 seconds in windows. >> >> This long time is related to the 1 million recv() calls in >> test_send(). Each call to recv() has to call wineserver to do a >> enable_event(FD_READ) operation, if you comment that line out [2] wine >> magically takes 1.7 seconds, just like windows does (obviously >> commenting that line generaters other errors related to event >> sequences). >> >> So, in simple words: what if we move all wineserver socket code to a >> thread that is started in the ws2_32 DLL. I know this may sound very >> silly for the experienced wine developers, maybe some operations are >> impossible without the wineserver, maybe there is much more things >> affected, but I think it's better to ask and get crushed with >> (hopefully) constructive criticism than forget about the idea. >> >> My main objective with this is to speedup the whole implementation and >> properly implement the select call (different socket states result in >> different checks required) and WSACleanup call (which needs to close >> every open socket on last cleanup) and some other get/setsockopt >> stuff. >> >> [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/tests/sock.c#l… >> [2] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/socket.c#l6684 >> >> Best wishes, >> Bruno >> >> > >

May 27, 2014

Re: [PATCH] vbscript: Implemented CDbl(try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7277 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

May 27, 2014

Re: About wineserver and winsock

by Chris Robinson

On 05/26/2014 09:31 AM, Damjan Jovanovic wrote: > That wouldn't always work: in theory, DuplicateHandle() could transmit > the socket to another process, which wouldn't have the same ws2_32 > thread. I don't know much about winsock and wineserver and such, but would it be possible for a handle to track whether it's been duplicated from/to another process and only involve wineserver when it has been?

May 26, 2014

Re: About wineserver and winsock

by Damjan Jovanovic

That wouldn't always work: in theory, DuplicateHandle() could transmit the socket to another process, which wouldn't have the same ws2_32 thread. We could speed up calls to the wineserver, which involve at least 4 system calls, 2 context switches, and 4 memory copies (in and out of the UNIX socket's buffers), by porting the wineserver to be a kernel module on the underlying *nix kernel, so that it only needs a single system call, zero context switches, and zero memory copies. I know Transgaming was considering this years ago - don't know how far they got - but I imagine it to be extremely difficult. Maybe it's possible to port only a small part of it that deals with performance critical areas, like sockets and synchronization, while the rest stays running as a user space application? Damjan On Mon, May 26, 2014 at 5:10 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Hi all, after studying the ws2_32 dll code for some time while looking > for ways to optimize it I started wondering why is the wineserver > required (please don't stop reading yet). > > make test takes 45 seconds in my machine while it takes 25 seconds in > a XP VM running on the same machine. The culprit is test_send() [1] > which takes 24 seconds in wine and 1.8 seconds in windows. > > This long time is related to the 1 million recv() calls in > test_send(). Each call to recv() has to call wineserver to do a > enable_event(FD_READ) operation, if you comment that line out [2] wine > magically takes 1.7 seconds, just like windows does (obviously > commenting that line generaters other errors related to event > sequences). > > So, in simple words: what if we move all wineserver socket code to a > thread that is started in the ws2_32 DLL. I know this may sound very > silly for the experienced wine developers, maybe some operations are > impossible without the wineserver, maybe there is much more things > affected, but I think it's better to ask and get crushed with > (hopefully) constructive criticism than forget about the idea. > > My main objective with this is to speedup the whole implementation and > properly implement the select call (different socket states result in > different checks required) and WSACleanup call (which needs to close > every open socket on last cleanup) and some other get/setsockopt > stuff. > > [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/tests/sock.c#l… > [2] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/socket.c#l6684 > > Best wishes, > Bruno > >

May 26, 2014

About wineserver and winsock

by Bruno Jesus

Hi all, after studying the ws2_32 dll code for some time while looking for ways to optimize it I started wondering why is the wineserver required (please don't stop reading yet). make test takes 45 seconds in my machine while it takes 25 seconds in a XP VM running on the same machine. The culprit is test_send() [1] which takes 24 seconds in wine and 1.8 seconds in windows. This long time is related to the 1 million recv() calls in test_send(). Each call to recv() has to call wineserver to do a enable_event(FD_READ) operation, if you comment that line out [2] wine magically takes 1.7 seconds, just like windows does (obviously commenting that line generaters other errors related to event sequences). So, in simple words: what if we move all wineserver socket code to a thread that is started in the ws2_32 DLL. I know this may sound very silly for the experienced wine developers, maybe some operations are impossible without the wineserver, maybe there is much more things affected, but I think it's better to ask and get crushed with (hopefully) constructive criticism than forget about the idea. My main objective with this is to speedup the whole implementation and properly implement the select call (different socket states result in different checks required) and WSACleanup call (which needs to close every open socket on last cleanup) and some other get/setsockopt stuff. [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/tests/sock.c#l… [2] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ws2_32/socket.c#l6684 Best wishes, Bruno

May 26, 2014

New Wine patches

by Chakke, Neha (GE Oil & Gas)

Hello , I am trying to run a GE software and hardware on Debian (Linux platform) using WineHQ. In order to run the hardware we need to install device drivers for USB (Cypress) . http://wiki.winehq.org/USB I have been trying to look for some solutions online since a week. Could you kindly send me the new wine patches and please guide me with the procedure. Thanks and regards, Miss Neha Chakke Engineering/Technology GE Oil & Gas Measurement & Control T: +49 (0) 2233 601 123 neha.chakke(a)ge.com<mailto:neha.chakke(a)ge.com> www.ge-mcs.com<http://www.ge-mcs.com/> [NewMeatball] GE Sensing & Inspection Technologies GmbH Robert-Bosch-Str. 3 50354 Hürth Germany

May 26, 2014

Re: mshtml: Added IHTMLTableRow::insertCell method implementation. (try 3)

by Jacek Caban

Hi Zhenbo, This version looks good except: On 05/24/14 11:56, Zhenbo Li wrote: > + *row = (IDispatch *)&elem->IHTMLElement_iface; > + IDispatch_AddRef(*row); > + IHTMLElement_Release(&elem->IHTMLElement_iface); You don't need to add such AddRef()/Release() calls. Reference count doesn't change anyway. Cheers, Jacek

May 26, 2014

Re: Japanese translation updates (try 4) for 1.7.19.

by Toshiaki Hirose

Thank you. Sent from AOL Mobile Mail -----Original Message----- From: Akihiro Sagawa <sagawa.aki(a)gmail.com> To: wine-devel <wine-devel(a)winehq.org> Cc: t_hirose <t_hirose(a)aol.com> Sent: Thu, May 22, 2014 11:53 PM Subject: Re: Japanese translation updates (try 4) for 1.7.19. On Wed, 21 May 2014 12:09:30 -0400 (EDT), Toshiaki Hirose wrote: > From 16832fa3d12785db591144f2005f953dd8937b9f Mon Sep 17 00:00:00 2001 > Message-Id: <16832fa3d12785db591144f2005f953dd8937b9f.1400688520.git.t_hirose(a)aol.com> > From: Toshiaki Hirose <t_hirose(a)aol.com> > Date: Thu, 22 May 2014 01:08:29 +0900 > Subject: [PATCH] Japanese translation updates(try4) for 1.7.19 > > --- > po/ja.po | 159 ++++++++++++++++++++++++++------------------------------------- > 1 file changed, 65 insertions(+), 94 deletions(-) Looks good to me. Akihiro Sagawa

May 25, 2014