May 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] add function iphlpapi/CreateSortedAddressPairs, FreeMibTable

by Bruno Jesus

This patch is just a hack, I'll send a correct stub later. On Wed, May 21, 2014 at 8:10 AM, Akira Nakagawa <matyapiro31(a)gmail.com> wrote: > -- universe* god::bigbang (void); //and then it all began...

May 21, 2014

Re: [1/2] ws2_32: Avoid memory allocation for simple sends

by Bruno Jesus

On Wed, May 21, 2014 at 12:34 AM, Austin English <austinenglish(a)gmail.com> wrote: > In (very non-scientific) timing runs, these two patches reduced valgrind > test time by ~20% (5 vs 4 minutes), thanks! Great to hear that, I was hoping it would help bug http://bugs.winehq.org/show_bug.cgi?id=28269 but it didn't =/

May 21, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.

by Jactry Zeng

2014-05-21 16:26 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com>: > > But ITextSelection is a ITextRange too, so you need to implement it for ITextRange only. Yes, ITextSelection interface is inherits from ITextRange. But I think functions of ITextRange and functions of ITextSelection are independent of each other. And there are some different between them: range of an ITextRange is given by ITextDocument::Range and immovable but range of ITextSelection of is depend on *pCursor in ME_TextEditor. So I think implementing ITextSelection independently and just share some functions like ME_ITextGetText between ITextRange and ITextSelection is a more convenient way. -- Regards, Jactry Zeng

May 21, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.

by Nikolay Sivov

On 5/21/2014 12:20, Jactry Zeng wrote: > Hi Nikolay, > 2014-05-21 14:56 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>>: > >> > >> +HRESULT ME_ITextGetText(ME_TextEditor *editor, ME_Cursor *start, > ME_Cursor *end, BSTR *pb) DECLSPEC_HIDDEN; > > > > Is this really needed? > > I would like to share ME_ITextGetText between ITextSelection::GetText > and ITextRange::GetText. But ITextSelection is a ITextRange too, so you need to implement it for ITextRange only. > > Thanks for your review! > -- > Regards, > Jactry Zeng >

May 21, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.

by Jactry Zeng

Hi Nikolay, 2014-05-21 14:56 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com>: >> >> +HRESULT ME_ITextGetText(ME_TextEditor *editor, ME_Cursor *start, ME_Cursor *end, BSTR *pb) DECLSPEC_HIDDEN; > > Is this really needed? I would like to share ME_ITextGetText between ITextSelection::GetText and ITextRange::GetText. Thanks for your review! -- Regards, Jactry Zeng

May 21, 2014

BitBlt doesn't honor the rotation specified by SetWorldTransform

by Alexander Almaleh

I have a test program that shows how BitBlt does not support rotation, when the rotation is specified by SetWorldTransform. Interestinly, the Rectangle() function works correctly and the rectangle is rotated. Here's a screenshot of the program in VirtualBox and in Wine<http://imgur.com/TIYx7XU> . Here is the code of the program. I'm setting a rotation XFORM, and then calling BitBlt. I load a bitmap file from the current directory for the BitBlt. hdc = BeginPaint(hWnd, &ps); double angle = 0.385398163; XFORM xf; xf.eDx = 0; xf.eDy = 0; xf.eM11 = cos(angle); xf.eM12 = sin(angle); xf.eM21 = -sin(angle); xf.eM22 = cos(angle); SetGraphicsMode(hdc, GM_ADVANCED); SetWorldTransform(hdc, &xf); HBITMAP hbmp = (HBITMAP) LoadImage( NULL, L"a.bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE); HDC hmemdc = CreateCompatibleDC(hdc); SelectObject(hmemdc, hbmp); BitBlt(hdc, 100, 0, 150, 50, hmemdc, 0, 0, SRCCOPY); EndPaint(hWnd, &ps);

May 21, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.

by Nikolay Sivov

> +HRESULT ME_ITextGetText(ME_TextEditor *editor, ME_Cursor *start, ME_Cursor *end, BSTR *pb) DECLSPEC_HIDDEN; Is this really needed? > + buffer = heap_alloc((nChars + 1) * sizeof(WCHAR)); > + if (!buffer) > + return E_OUTOFMEMORY; > + ME_GetTextW(editor, buffer, nChars, start, nChars, 0); > + buffer[nChars] = 0; > + /* FIXME: a '\r' should be appended at the end of a story */ > + *pb = SysAllocString(buffer); > + heap_free(buffer); This could be simplified with SysAllocStringLen().

May 21, 2014

Re: [PATCH 2/2] riched20: Implement ITextSelection::GetChar.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7197 Your paranoid android. === wvistau64 (64 bit richole) === richole: unhandled exception c0000005 at 000007FEF57FACFA === w2008s64 (64 bit richole) === richole: unhandled exception c0000005 at 000007FEF745ACFA

May 21, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7196 Your paranoid android. === wvistau64 (64 bit richole) === richole: unhandled exception c0000005 at 000007FEF57FACFA === w2008s64 (64 bit richole) === richole: unhandled exception c0000005 at 000007FEF745ACFA

May 21, 2014

Re: [1/2] ws2_32: Avoid memory allocation for simple sends

by Austin English

On Mon, May 19, 2014 at 2:16 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > send() will ever use a single wsabuffer structure and most common > applications use of WSASend() will also send a single buffer. Saves > over 6 thousand calls to HeapAlloc in make test. > In (very non-scientific) timing runs, these two patches reduced valgrind test time by ~20% (5 vs 4 minutes), thanks! -- -Austin

May 21, 2014