June 2014 - Wine-Devel - list.winehq.org

Re: services: Defer service delete until all handles are closed

by Nikolay Sivov

On 6/12/2014 01:32, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=7438 > > Your paranoid android. > > > === w7u (32 bit service) === > service.c:1381: Test failed: Something wrong in the calculation > service.c:1417: Test failed: Active services mismatch 1 > The test timed out I believe it's not related to a patch, only another open/close was added and some code handling Wine bug was removed. I don't see how it can make it time out, especially since all other VMs are fine.

June 12, 2014

Re: [PATCH 07/10] dmloader: Use the generic DirectMusicObject implementation for DMContainer.

by Michael Stefaniuc

On 06/12/2014 11:57 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=7450 > > Your paranoid android. > > > === build (build) === > Patch failed to apply Patch depends on the outstanding http://source.winehq.org/patches/data/104953 Full dmloader test results can be seen in https://testbot.winehq.org/JobDetails.pl?Key=7424 (canceled it once I had enough results; the 64bit tests are skipped anyway). This apply failure cascades through to patch 8 and 9 which depend on patch 7. bye michael

June 12, 2014

Re: [PATCH 09/10] dmloader: Add and use a generic IPersistStream_GetClassID.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7452 Your paranoid android. === build (build) === Patch failed to apply

June 12, 2014

Re: [PATCH 08/10] dmloader/tests: Add more DirectMusicCollection tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7451 Your paranoid android. === build (build) === Patch failed to apply

June 12, 2014

Re: [PATCH 07/10] dmloader: Use the generic DirectMusicObject implementation for DMContainer.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7450 Your paranoid android. === build (build) === Patch failed to apply

June 12, 2014

Re: msvcp90/msvcp90.h: right-hand operand of comma expression has no effect (PING)

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > On Wed, 16 Apr 2014, Paul Chitescu wrote: >>> Digging into this in more detail I see >>> >>> ../msvcp90/ios.c: In function 'basic_streambuf_char__Xsgetn_s': >>> ../msvcp90/msvcp90.h:529:75: warning: right-hand operand of comma >>> expression has no effect [-Wunused-value] >>> #define memcpy_s( dst, size, src, count ) (memcpy( (dst), (src), (count) >>> ), 0) ^ ../msvcp90/ios.c:1218:13: note: in expansion of macro 'memcpy_s' >>> memcpy_s(ptr+copied, size, *this->prpos, chunk); >>> ^ >> memcpy_s() returns an errno_t so the author tried to force returning >> zero (no error). > > Since, clearly, the result is never intended to be used, we can as > well simply cast the result away instead of using ", 0". memcpy_s is supposed to return a value, and callers could (and probably should) check it. -- Alexandre Julliard julliard(a)winehq.org

June 12, 2014

Re: services: Defer service delete until all handles are closed

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7438 Your paranoid android. === w7u (32 bit service) === service.c:1381: Test failed: Something wrong in the calculation service.c:1417: Test failed: Active services mismatch 1 The test timed out

June 11, 2014

Re: wined3d: Recognize cards that expose GLSL 1.30 as DX10 capable even if they don't support EXT_GPU_SHADER4 (try 4)

by Henri Verbeet

On 11 June 2014 21:00, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > On Fri, May 30, 2014 at 5:10 AM, Stefan Dösinger > Try 1 was commited [1] instead of try 4 [2], was that intentional? > > [1] http://source.winehq.org/git/wine.git/commitdiff/fbdf618251c7d9c3f01f53bc53… > [2] http://source.winehq.org/patches/data/104891 > Yeah.

June 11, 2014

Re: wined3d: Recognize cards that expose GLSL 1.30 as DX10 capable even if they don't support EXT_GPU_SHADER4 (try 4)

by Bruno Jesus

On Fri, May 30, 2014 at 5:10 AM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2014-05-30 00:45, schrieb Andrei Slăvoiu: >> Add back glsl check to make sure the card is capable of DX10. >> >> --- dlls/wined3d/directx.c | 4 +++- 1 file changed, 3 >> insertions(+), 1 deletion(-) > Looks good to me. Note that Alexandre and Henri are on holidays right > now, so it might take a while before it is committed or you receive > further comments. Try 1 was commited [1] instead of try 4 [2], was that intentional? [1] http://source.winehq.org/git/wine.git/commitdiff/fbdf618251c7d9c3f01f53bc53… [2] http://source.winehq.org/patches/data/104891 Best regards, Bruno

June 11, 2014

Re: [PATCH 4/5] ddraw: Properly support creating compressed user memory surfaces.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7433 Your paranoid android. === wvistau64 (64 bit ddraw7) === ddraw7.c:6467: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw7) === ddraw7.c:6467: Test failed: Test 7: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6644: Test failed: Test 7: Got unexpected pitch 252, expected 256. === w2008s64 (64 bit ddraw4) === ddraw4.c:6644: Test failed: Test 7: Got unexpected pitch 252, expected 256.

June 11, 2014