June 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] vbscript: Implemented Abs(try 4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7727 Your paranoid android. === build (build) === Patch failed to apply

June 27, 2014

Re: [PATCH 3/4] vbscript: Implemented Sgn(try 4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7726 Your paranoid android. === build (build) === Patch failed to apply

June 27, 2014

Re: [PATCH 2/4] vbscript: Implemented VarType(try 4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7725 Your paranoid android. === build (build) === Patch failed to apply

June 27, 2014

Re: [PATCH 1/4] vbscript: Implemented TypeName(try 4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7724 Your paranoid android. === build (build) === Patch failed to apply

June 27, 2014

Re: [2/7] advapi32: Changed an invalid comment

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7716 Your paranoid android. === w2008s64 (32 bit security) === Unable to set the VM system time: the "nc -q0 '10.42.42.136' '4242'" command returned 1

June 27, 2014

Re: [PATCH 4/4] vbscript: Implemented Abs(try 4)

by Piotr Caban

On 06/27/14 04:44, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + double v; > + HRESULT hres; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + > + if(V_VT(arg) == VT_NULL) > + return return_null(res); > + > + hres = to_double(arg, &v); > + if (FAILED(hres)) > + return hres; > + > + if(res) { > + V_VT(res) = VT_R8; > + V_R8(res) = v >= 0 ? v : -v; > + } > + return S_OK; > } You can use return_double helper here. Also there are 2 newlines after assert.

June 27, 2014

Re: [PATCH 3/4] vbscript: Implemented Sgn(try 4)

by Piotr Caban

Please add VT_NULL argument handling and tests. This function is returning error on Sgn(Null) call.

June 27, 2014

Re: [PATCH 2/4] vbscript: Implemented VarType(try 4)

by Piotr Caban

On 06/27/14 04:40, Shuai Meng wrote: > + if(res) { > + V_VT(res) = VT_I2; > + V_I2(res) = V_VT(arg); > + } > + return S_OK; You can use return_short helper here.

June 27, 2014

Re: [PATCH 1/4] vbscript: Implemented TypeName(try 4)

by Piotr Caban

This patch was already committed. Please update wine source before sending patches. Cheers, Piotr

June 27, 2014

Fwd: [1/7] server: Any of the 4 SE_*_DEFAULTED controls should not be stored on objects, their usage is transient. (try 3)

by Joris van der Wel

Just a heads up in case anyone missed this, it looks like the VM is offline? ---------- Forwarded message ---------- From: Marvin <testbot(a)winehq.org> Date: Thu, Jun 26, 2014 at 10:05 PM Subject: Re: [1/7] server: Any of the 4 SE_*_DEFAULTED controls should not be stored on objects, their usage is transient. (try 3) To: joris(a)jorisvanderwel.com Cc: wine-devel(a)winehq.org Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid android. === build (build) === Could not copy the patch to the VM: the "nc -q0 '10.42.42.130' '4242'" command returned 1

June 26, 2014