June 2014 - Wine-Devel - list.winehq.org

Re: [1/7] server: Any of the 4 SE_*_DEFAULTED controls should not be stored on objects, their usage is transient. (try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid android. === build (build) === Could not copy the patch to the VM: the "nc -q0 '10.42.42.130' '4242'" command returned 1

June 26, 2014

Re: [PATCH 4/5] msvcrt: Use file->_flag to check if file buffering is enabled

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/file.c | 64 > +++++++++++++++++++++++++++++------------------------- > 1 file changed, 35 insertions(+), 29 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok wine: Unhandled page fault on write access to 0x00000000 at address 0x559c685b (thread 0045), starting debugger... Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x559c685b). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:559c685b ESP:0032ea30 EBP:0032ea58 EFLAGS:00210246( R- -- I Z- -P- ) EAX:00000000 EBX:55a2ba90 ECX:00000030 EDX:00000001 ESI:55a33cc0 EDI:003d2de3 Stack dump: 0x0032ea30: 0000001e 00000000 4d430003 00000000 0x0032ea40: 0032ea60 55a2ba90 0032ea98 559c6943 0x0032ea50: 55a2ba90 55a33cc0 0032ea98 559c6a7e 0x0032ea60: 00000030 55a33cc0 0032ed78 7bc3c409 0x0032ea70: 00000000 003d2d24 0000004b 00000000 0x0032ea80: 000001f4 003d2de3 0032eab8 003d2d98 Backtrace: =>0 0x559c685b MSVCRT__flsbuf+0x4b(c=<is not available>, file=<is not available>) [/home/julliard/wine/wine/dlls/msvcrt/file.c:3671] in msvcrt (0x0032ea58) 1 0x559c6a7e MSVCRT_fwrite+0x17d(ptr=<is not available>, size=<is not available>, nmemb=<is not available>, file=<is not available>) [/home/julliard/wine/wine/dlls/msvcrt/file.c:3738] in msvcrt (0x0032ea98) 2 0x00334cd0 in nspr4 (+0x4ccf) (0x0032eab8) 3 0x003354d3 in nspr4 (+0x54d2) (0x0032ed38) 4 0x6a65ce06 in xul (+0xa1ce05) (0x0032edd8) 5 0x69f4e2ef in xul (+0x30e2ee) (0x0032ef18) 0x559c685b MSVCRT__flsbuf+0x4b [/home/julliard/wine/wine/dlls/msvcrt/file.c:3671] in msvcrt: movb %cl,0x0(%eax) 3671 *file->_ptr++ = c; -- Alexandre Julliard julliard(a)winehq.org

June 26, 2014

Re: [PATCH 3/5] msvcrt: Support NULL buffer in setvbuf

by Francois Gouget

On Thu, 26 Jun 2014, Piotr Caban wrote: [...] > Testbot failed to update wine source yesterday. For whatever reason the build VM's disk image became corrupted. This is why it suddenly got a Perl error in an unchanged Perl script. It also had a bunch of other errors with many tools like ls not working anymore. So time morning I restored the disk image from backup and now it appears to be working fine again. I'm keeping the broken disk image around in case someone's interested in doing some forensic analysis to figure out what happened (I checked that the file could be read without trouble so it's not an issue in the host's disk). However given that the VM host still runs the 3.2.0 kernel (to avoid further instability in newer kernels ironically), it may not be very fruitful. -- Francois Gouget <fgouget(a)codeweavers.com>

June 26, 2014

Re: [PATCH 4/4] vbscript: Implemented Abs(try 2)

by Piotr Caban

On 06/26/14 12:13, Shuai Meng wrote: > I guess you mean that I need to handle res==NULL case in branch > if(V_VT(arg) == VT_NULL), right? Yes, but return_null() function will already cover it for you. > There is another problem: though Abs(Null) should return Null according to > http://msdn.microsoft.com/en-__us/library/307330xe(v=vs.84).__aspx > <http://msdn.microsoft.com/en-us/library/307330xe(v=vs.84).aspx> , but I > test it in WINXP, i.e. when arg == Null, the vbscript code: > Call Abs(Null) > and > dim b > b = Abs(Null) > MsgBox b > returns an error. I don't see this issue. Probably you have done something incorrectly. Here's result from a testbot run that tests Abs(Null). The tests are working on all machines. http://newtestbot.winehq.org/JobDetails.pl?Key=7712

June 26, 2014

Re: [PATCH] gdi32: XFORM matrix in PlgBlt() is calculated incorrectly

by GOUJON Alexandre

On 06/26/2014 02:04 PM, Alexander Almaleh wrote: > As suggested by Sebastian Lackner, I am submitting his much simpler > version of the fix. Only one line is touched. The patch file is attached. > > The bugzilla link is http://bugs.winehq.org/show_bug.cgi?id=36504 Patches should be sent to wine-patches(a)winehq.org, please read http://wiki.winehq.org/SubmittingPatches for more information

June 26, 2014

Re: [PATCH] gdi32: XFORM matrix in PlgBlt() is calculated incorrectly

by Alexander Almaleh

I see that the file was scrubbed, I don't know why, so I'm pasting it, just in case. >From 603c09dee7beda5a6be08fe252bffecda8d48ed8 Mon Sep 17 00:00:00 2001 From: Alexander Almaleh <sashoalm(a)gmail.com> Date: Thu, 26 Jun 2014 14:56:49 +0300 Subject: [PATCH] Fix for http://bugs.winehq.org/show_bug.cgi?id=36504. --- dlls/gdi32/bitblt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/gdi32/bitblt.c b/dlls/gdi32/bitblt.c index 4750d1b..762ca0f 100644 --- a/dlls/gdi32/bitblt.c +++ b/dlls/gdi32/bitblt.c @@ -1037,7 +1037,7 @@ BOOL WINAPI PlgBlt( HDC hdcDest, const POINT *lpPoint, /* Y components */ xf.eM12 = (plg[1].y*(rect[2].y - rect[0].y) - plg[2].y*(rect[1].y - rect[0].y) - plg[0].y*(rect[2].y - rect[1].y)) / det; - xf.eM22 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; + xf.eM22 = (rect[1].x*(plg[2].y - plg[0].y) - rect[2].x*(plg[1].y - plg[0].y) - rect[0].x*(plg[2].y - plg[1].y)) / det; xf.eDy = (rect[0].x*(rect[1].y*plg[2].y - rect[2].y*plg[1].y) - rect[1].x*(rect[0].y*plg[2].y - rect[2].y*plg[0].y) + rect[2].x*(rect[0].y*plg[1].y - rect[1].y*plg[0].y) -- 1.7.10.4 On Thu, Jun 26, 2014 at 3:04 PM, Alexander Almaleh <sashoalm(a)gmail.com> wrote: > As suggested by Sebastian Lackner, I am submitting his much simpler > version of the fix. Only one line is touched. The patch file is attached. > > The bugzilla link is http://bugs.winehq.org/show_bug.cgi?id=36504 > >

June 26, 2014

[PATCH] gdi32: XFORM matrix in PlgBlt() is calculated incorrectly

by Alexander Almaleh

As suggested by Sebastian Lackner, I am submitting his much simpler version of the fix. Only one line is touched. The patch file is attached. The bugzilla link is http://bugs.winehq.org/show_bug.cgi?id=36504

June 26, 2014

Re: [PATCH] riched20: Don't create too many IRichEditOle interfaces for a RichEdit. (try 3)

by Jactry Zeng

Hi Huw, 2014-06-26 15:54 GMT+08:00 Huw Davies <huw(a)codeweavers.com>: > > > I'm sure you can think about how to simplify this a bit. > The clue that it needs simplification is that you've > got two AddRef()s in there. > > Hint: The code is trying to do two things: > > 1. If needed, assign an interface to reOle > 2. AddRef and return. > > > --- a/dlls/riched20/richole.c > > +++ b/dlls/riched20/richole.c > > @@ -126,12 +126,13 @@ IRichEditOle_fnRelease(IRichEditOle *me) > > > > TRACE ("%p ref=%u\n", This, ref); > > > > - if (!ref) > > + if (ref == 1) > > { > > TRACE ("Destroying %p\n", This); > > This->txtSel->reOle = NULL; > > ITextSelection_Release(&This->txtSel->ITextSelection_iface); > > IOleClientSite_Release(&This->clientSite->IOleClientSite_iface); > > + This->editor->reOle = NULL; > > No, this is wrong. This function should remain unchanged. > > The editor is in charge of the reOle reference, so it > needs to release it when the editor is destroyed - > ie in ME_DestroyEditor(). > I will try again. Thanks for your review. :) -- Regards, Jactry Zeng

June 26, 2014

Re: [PATCH 3/5] msvcrt: Support NULL buffer in setvbuf

by Piotr Caban

On 06/26/14 12:31, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=7709 > > Your paranoid android. > > > === build (build) === > Patch failed to apply Testbot failed to update wine source yesterday.

June 26, 2014

Re: [PATCH 5/5] msvcrt: Don't touch _bufsiz value while initializing FILE structure

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7710 Your paranoid android. === build (build) === Patch failed to apply

June 26, 2014