July 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] vbscript: Implemented IsNumeric

by Shuai Meng

Thanks for commenting, I'm working on it now. 2014-07-17 11:11 GMT+08:00 Dmitry Timoshkov <dmitry(a)baikal.ru>: > Shuai Meng <mengshuaicalendr(a)gmail.com> wrote: > > > + switch(V_VT(arg)) { > > + case VT_UI1: > > + case VT_I2: > > + case VT_I4: > > + case VT_I8: > > + case VT_R4: > > + case VT_R8: > > + case VT_BOOL: > > + case VT_EMPTY: > > + case VT_CY: > > + V_BOOL(res) = VARIANT_TRUE; > > + break; > > This list is far from being complete. It seems that it should also > contain at least VT_UI2, VT_UI4, VT_UI8, VT_I1, VT_INT, VT_UINT. > VT_VECTOR, VT_ARRAY and VT_BYREF modifers probably also should be > taken into account. > > -- > Dmitry. >

July 17, 2014

Re: [PATCH] vbscript: Implemented IsNumeric

by Dmitry Timoshkov

Shuai Meng <mengshuaicalendr(a)gmail.com> wrote: > + switch(V_VT(arg)) { > + case VT_UI1: > + case VT_I2: > + case VT_I4: > + case VT_I8: > + case VT_R4: > + case VT_R8: > + case VT_BOOL: > + case VT_EMPTY: > + case VT_CY: > + V_BOOL(res) = VARIANT_TRUE; > + break; This list is far from being complete. It seems that it should also contain at least VT_UI2, VT_UI4, VT_UI8, VT_I1, VT_INT, VT_UINT. VT_VECTOR, VT_ARRAY and VT_BYREF modifers probably also should be taken into account. -- Dmitry.

July 17, 2014

Re: [PATCH] vbscript: Implemented IsNumeric

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8022 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

July 17, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)

by Jactry Zeng

2014-07-16 19:44 GMT+08:00 Huw Davies <huw(a)codeweavers.com>: > > Yes. So adding a special case to SetSelection should fix this. > > 'to' is already setup correctly to len+1, so the problem is > adjusting cursors[0]. MoveCursorChars is clamping the > cursor to len. > > So you have two options, either alter MoveCursorChars > to allow it to move to len + 1. You'd need to retain the current > behaviour in some circumstances though (such as moving > to the right on right-arrow keys press), so you'd need to pass > a flag or something. > > Option 2 is just the modify cursor[0] in SetSelection. If this > is the only place where one can select the final EOP, then > this is probably the preferred solution. > > Either way, you probably need to change the 'middle of > end paragraph run' fix up for cursor[0] at the end of > SetSelection (probably by setting nOffset = run.len). > > Having done this, check the tests still work (and the > todos are fixed). Also play with wordpad for a while > to see it behaves correctly. > > Does that make sense? Thank you! I will have a try. -- Regards, Jactry Zeng

July 16, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)

by Huw Davies

On 15 Jul 2014, at 14:43, Jactry Zeng wrote: 2014-07-15 21:29 GMT+08:00 Huw Davies <huw(a)codeweavers.com>: > > > > Can you at least point to a test that shows this bug? > > Do you mean tests about bug of S/GetSelection? > It seem is a known bug: > http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/riched20/tests/editor… Yes. So adding a special case to SetSelection should fix this. 'to' is already setup correctly to len+1, so the problem is adjusting cursors[0]. MoveCursorChars is clamping the cursor to len. So you have two options, either alter MoveCursorChars to allow it to move to len + 1. You'd need to retain the current behaviour in some circumstances though (such as moving to the right on right-arrow keys press), so you'd need to pass a flag or something. Option 2 is just the modify cursor[0] in SetSelection. If this is the only place where one can select the final EOP, then this is probably the preferred solution. Either way, you probably need to change the 'middle of end paragraph run' fix up for cursor[0] at the end of SetSelection (probably by setting nOffset = run.len). Having done this, check the tests still work (and the todos are fixed). Also play with wordpad for a while to see it behaves correctly. Does that make sense? Huw.

July 16, 2014

Re: [7/8] msi/tests: Add more registry tests.

by Alexandre Julliard

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/msi/tests/install.c | 90 ++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 83 insertions(+), 7 deletions(-) It doesn't work here on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M msi.dll -p msi_test.exe.so install && touch install.ok install.c:5712: Test failed: value test1 should found, got 2 install.c:5720: Test failed: value test1 shouldn't found install.c:5751: Test failed: 32-bit component key not removed install.c:5754: Test failed: 64-bit component key not removed install.c:5773: Test failed: value test1 should found, got 2 install.c:5781: Test failed: value test1 shouldn't found install.c:5812: Test failed: 32-bit component key not removed install.c:5815: Test failed: 64-bit component key not removed -- Alexandre Julliard julliard(a)winehq.org

July 15, 2014

Re: [1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback. (try2)

by Andrei Slăvoiu

În ziua de Mar 15 Iul 2014, la 12:52:25, Henri Verbeet a scris: > I'd probably let the cards that currently aren't matched against a > specific renderer string just hit the fallback code, since that's > effectively what was happening before. So remove the matchers that I added (GeForce3 and Geforce) and leave the existing ones. BTW, GeForce2 was a already there, but because of the OpenGL level check it was not matched for newer cards. Now it might cause problems if Nvidia decides to use GeForce2000 for a future card. > For what it's worth, you may also want to consider splitting this by > e.g. first getting rid of d3d_level_from_gl_info() in > select_card_nvidia_binary(), then in select_card_amd_binary(), etc., > and try to avoid large series. I.e., first work on getting the first 5 > or so patches comitted, then work on the next couple, etc. So drop this series completely and start over with smaller ones?

July 15, 2014

Re: [PATCH 2/2] vbscript/tests: Added tests for the subtype of TypeName(try 5)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8004 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

July 15, 2014

Re: [PATCH 1/2] vbscript: Implemented Abs(try 9)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8003 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

July 15, 2014

Re: [PATCH 1/6] ddraw: Add validation to SetPriority / GetPriority.

by Henri Verbeet

On 15 July 2014 16:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static HRESULT WINAPI ddraw_surface7_SetPriority(IDirectDrawSurface7 *iface, DWORD Priority) > +static HRESULT WINAPI ddraw_surface7_SetPriority(IDirectDrawSurface7 *iface, DWORD priority) > { > struct ddraw_surface *surface = impl_from_IDirectDrawSurface7(iface); > + DWORD managed = DDSCAPS2_TEXTUREMANAGE | DDSCAPS2_D3DTEXTUREMANAGE; > HRESULT hr; > > - TRACE("iface %p, priority %u.\n", iface, Priority); > + TRACE("iface %p, priority %u.\n", iface, priority); > > wined3d_mutex_lock(); > - hr = wined3d_surface_set_priority(surface->wined3d_surface, Priority); > + /* No need to check for offscreen plain surfaces or mipmap sublevels. SetPriority > + * calls on such surfaces segfault on Windows. */ > + if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed)) > + { > + WARN("Called on non-managed texture returning DDERR_INVALIDPARAMS.\n"); > + hr = DDERR_INVALIDPARAMS; > + } > + else > + hr = wined3d_surface_set_priority(surface->wined3d_surface, priority); > wined3d_mutex_unlock(); > > return hr; > } The existing code already had this of course, but note that wined3d_surface_set_priority() returns the previous priority.

July 15, 2014