July 2014 - Wine-Devel - list.winehq.org

Re: [1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback. (try2)

by Henri Verbeet

On 15 July 2014 01:37, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > Yes, I realize now this was completely broken, and patch nr. 3 was just a > partial fix for the damage I done here. But how do I get the exact renderer > string for those old cards? I guess from the comments that the original > Geforce cards or either identified as "Geforce 256" or "Geforce DDR". But what > about the Quadro cards? How do I make those less generic? So the easy fix is to > just get rid of those old cards identified by such generic strings. I'd probably let the cards that currently aren't matched against a specific renderer string just hit the fallback code, since that's effectively what was happening before. I probably wouldn't bother removing existing entries, since it doesn't really gain us anything. For what it's worth, you may also want to consider splitting this by e.g. first getting rid of d3d_level_from_gl_info() in select_card_nvidia_binary(), then in select_card_amd_binary(), etc., and try to avoid large series. I.e., first work on getting the first 5 or so patches comitted, then work on the next couple, etc.

July 15, 2014

Re: Re: [2/2] ddraw: add dsurface dimension tests, try 11

by Henri Verbeet

On 15 July 2014 10:20, Patrick Rudolph <siro(a)das-labor.org> wrote: > I've not included the tests for DirectDraw surfaces with dimension 1 by > 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by > Opengl textures and the maximum texture size is less than 0xffff. However on > Windows these tests pass, if the graphic cards pitch is great enough. Stefan > pointed out that on old cards this test might fail. > Should I add a separate test for this including a wine_todo ? I guess this > won't be fixed any time soon... > Marking it as todo_wine should be fine, although I wonder if you'll actually get a video memory surface that way, or only a system memory surface.

July 15, 2014

Re: mshtml: Fixed typos in HTMLTable_QI.

by Jacek Caban

On 07/15/14 06:51, Zhenbo Li wrote: > On 07/15/2014 02:21 AM, Alexandre Julliard wrote: >> Jacek Caban <jacek(a)codeweavers.com> writes: >> >>> --- >>> dlls/mshtml/htmltable.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> It doesn't work: > I think another patch is needed: > > > diff --git a/dlls/mshtml/htmltable.c b/dlls/mshtml/htmltable.c > index de12537..484032f 100644 > --- a/dlls/mshtml/htmltable.c > +++ b/dlls/mshtml/htmltable.c > @@ -969,6 +969,8 @@ HRESULT HTMLTable_Create(HTMLDocumentNode *doc, > nsIDOMHTMLElement *nselem, HTMLE > > ret->element.node.vtbl = &HTMLTableImplVtbl; > ret->IHTMLTable_iface.lpVtbl = &HTMLTableVtbl; > + ret->IHTMLTable2_iface.lpVtbl = &HTMLTable2Vtbl; > + ret->IHTMLTable3_iface.lpVtbl = &HTMLTable3Vtbl; > > HTMLElement_Init(&ret->element, doc, nselem, &HTMLTable_dispex); > > Should I squash them? Yes, please send a patch that includes both fixes. Thanks, Jacek

July 15, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)

by Huw Davies

On 15 Jul 2014, at 02:18, Jactry Zeng wrote: > But because of bug of EM_SETSEL or EM_GETSEL, this feature > still cannot be implemented completely. > For example: > When the text in Rich Edit control is: "TestSomeText" > 01234567890123 > We cannot distinguish between SendMessageA(w, EM_SETSEL, 0, 12) and SendMessageA(w, EM_SETSEL, 0, 13). > Attachment is the patch, I just added wine_todo for failed tests cause by this bug. > But I still have no idea about fixing this bug. Could you give me some suggestion? > Or just mark them as todo now is OK? Do you fully understand this bug yet? In other words under what conditions does the current implementation fail? It should be trivial to fix up ME_SetSelection(). Huw.

July 15, 2014

Re: [PATCH 1/2] vbscript: Implemented Abs(try 8)

by Piotr Caban

On 07/15/14 04:55, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + HRESULT hres; > + VARIANT dst; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + hres = VarAbs(arg, &dst); > + if FAILED(hres) > + return hres; Please use parenthesis around if condition; > + if(!res) > + return DISP_E_BADVARTYPE; You have already written a test that shows this is incorrect (Call Abs(-4)). You also need to call VariantClear if dst is not used. > + return VariantCopy(res, &dst); Please change it to: *res = dst; return S_OK;

July 15, 2014

Re: [PATCH 5/5] d3d8/tests: Get rid of struct nvertex.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7993 Your paranoid android. === w8 (32 bit device) === device.c:2398: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3040: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

July 15, 2014

Re: Re: [2/2] ddraw: add dsurface dimension tests, try 11

by Patrick Rudolph

Hi Henri, thanks for reviewing. >> + /* 6: Test maximum surface height */ >> + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, >> DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS}, >> + /* 7: Test maximum surface width */ >> + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, >> DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS}, > It would perhaps also be useful to verify that e.g. a 1 by 0xffff > surface actually is allowed. I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon... Regards, Patrick

July 15, 2014

Re: [PATCH 2/5] ddraw/tests: Get rid of struct sVertexT.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7990 Your paranoid android. === w8 (32 bit visual) === visual.c:1659: Test failed: Got color 00000000, expected 000000ff or near visual.c:1665: Test failed: Got color 00000000, expected 000000ff or near visual.c:1671: Test failed: Got color 00000000, expected 00000080 or near visual.c:1677: Test failed: Got color 00000000, expected 00000080 or near visual.c:2635: Test failed: unexpected colortable on offscreen surface

July 15, 2014

Re: [PATCH] rpcrt4: fixed memory leak on error exit (Coverity)

by Dmitry Timoshkov

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -941,6 +941,7 @@ static size_t rpcrt4_ip_tcp_get_top_of_tower(unsigned char *tower_data, > } > else > { > + freeaddrinfo(ai); > ERR("unexpected protocol family %d\n", ai->ai_family); > return 0; > } This will introduce use after free (by ERR() statement). -- Dmitry.

July 15, 2014

Re: [PATCH 1/5] ddraw/tests: Get rid of struct sVertex.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7989 Your paranoid android. === w8 (32 bit visual) === visual.c:2633: Test failed: unexpected colortable on offscreen surface

July 15, 2014