July 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] ddraw/tests: Add tests for lost P8 primaries.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-07-08 16:47, schrieb Alexandre Julliard: > Stefan Dösinger <stefandoesinger(a)gmail.com> writes: > >> Am 2014-07-07 22:58, schrieb Alexandre Julliard: >>> It doesn't work here: >>> >>> ../../../tools/runtest -q -P wine -T ../../.. -M ddraw.dll -p >>> ddraw_test.exe.so ddraw1 && touch ddraw1.ok ddraw1.c:5694: Test >>> failed: Got unexpected hr 0. ddraw1.c:5696: Test failed: Got >>> unexpected hr 0. >> I cannot reproduce this, but I think I see what's going wrong. >> The screen is in 8 bpp mode when this part of the test is >> executed. Can you try the attached patch? It explicitly requests >> a 32 bpp mode. > > It seems to avoid the error, but it somehow screws up the mode > changing so that subsequent tests fail. Can you send me a +ddraw,+d3d log of the original patch and the new one? Thanks, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTvAW9AAoJEN0/YqbEcdMwBPgP/i2CgkiomenRj0CaNdOPL9/8 Im1g+fU5XS+lYfnBmXMvNbxB0FK4v4dWW2qktSXjEgVwxxcoQe1i80uea+p0MvGo 3seyfsPYWM2hB+OPgYScfzXUhWxdjWXuUdH7s+2C951jFFYpmO7Ka90RcWnzU1Vc Ky7ARZLsWGx/sTXVHKeTaD0FOMx++wSJ2ckLbvUFo1sTvjN7QOC5Vlv0KOok0eZf FJisUSxHsza8KkmPSzLFonmwyrkdWyy44t7HlF1jfQ4S+GFmxYoJiqshOmZj72GP Rgw0xDxPKP19YoNMYcxIN/a5ZxViHIusULVOFR15VgDuGyzhojyEJ1r7AdOiijZU I/XXqBWmOM/B9/gYjSMUbc2y6wbYQaRBPi14l6SqiqsEwiOF2DrNKYKX6ow0OvRd h27wkrfO3JmskNrN0gug1YpdyEWFh2QpkrrEvPKZvtVNN/o8xxGkUMV40jpYSBc2 meLq6a1Ry4Sn2NWB3A+NoR5ZDEOK31TD6xowWUhS5lhEDMH2+4o/Bb1m20GydoDh 8B7Cn4CqO2HG1QWLCjE1ODYFhu+h06vrRf6byBTmqsrPNYFsw4/GlTXNeBYQkrUw YxaoAPpJnJxHHYwLYOQjD0WYacIyDeHmx83W2JB90hCT5FQPY2/60fEDBLxj0Mlx IZR4j0Yp7/eJtWmWzx6X =NXix -----END PGP SIGNATURE-----

July 8, 2014

Re: [PATCH 3/4] ddraw/tests: Add tests for lost P8 primaries.

by Alexandre Julliard

Stefan Dösinger <stefandoesinger(a)gmail.com> writes: > Am 2014-07-07 22:58, schrieb Alexandre Julliard: >> It doesn't work here: >> >> ../../../tools/runtest -q -P wine -T ../../.. -M ddraw.dll -p ddraw_test.exe.so ddraw1 && touch ddraw1.ok >> ddraw1.c:5694: Test failed: Got unexpected hr 0. >> ddraw1.c:5696: Test failed: Got unexpected hr 0. > I cannot reproduce this, but I think I see what's going wrong. The > screen is in 8 bpp mode when this part of the test is executed. Can > you try the attached patch? It explicitly requests a 32 bpp mode. It seems to avoid the error, but it somehow screws up the mode changing so that subsequent tests fail. -- Alexandre Julliard julliard(a)winehq.org

July 8, 2014

Re: [PATCH 4/5] d3d8/tests: Add a test for SetPriority / GetPriority.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7894 Your paranoid android. === w8 (32 bit device) === device.c:2397: Test failed: Expected foreground window 000801B0, got 0002004C. device.c:3039: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

July 8, 2014

Re: [PATCH 3/4] ddraw/tests: Add tests for lost P8 primaries.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-07-07 22:58, schrieb Alexandre Julliard: > It doesn't work here: > > ../../../tools/runtest -q -P wine -T ../../.. -M ddraw.dll -p ddraw_test.exe.so ddraw1 && touch ddraw1.ok > ddraw1.c:5694: Test failed: Got unexpected hr 0. > ddraw1.c:5696: Test failed: Got unexpected hr 0. I cannot reproduce this, but I think I see what's going wrong. The screen is in 8 bpp mode when this part of the test is executed. Can you try the attached patch? It explicitly requests a 32 bpp mode. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTu+IPAAoJEN0/YqbEcdMwdAwQAJMm+xqoAq3+OpQTRPjvSIf9 NcOkLeAW5c+ulZVm/j9GAUCOXme/WieYmG3Gngbc5nxG1fbCLERKceZ62J5XBG2Q 3ruoMDKSeYkYaaQkB9JeTzwjvuZYdtYIlI8JI2t0mB6iKS2hksRr+/5WA/wLVrAd of1jsl0+GRI2G0zHL74BjAPuFro4dxc0cvYlACVpMNNroPXjWoYM1JjEMO6dRQkJ 9Z6EVSwPVq9y/dmztjlkF6x+CccH/HWMjsZwCPc1CQ1wUjRUnZZuTbgjfG5DMWjP r6Rw2Dmb9fg/JxlwYgg0ZJm9D42OhzHCYoo8lQOBBaRlQxIMTt6VrwdoYItSucX0 Y7JnA+vULEgImk1kPHT56wQHdm2MOdsNJ3o7IT7rcqh4gj/y0NAZdzPuSeCJ2Obk CR05V5+fIhZeRzQD/vsXKzi31dBd62G+iESJC3kXHXynsIXnGMdUq1BXUducM5di BAXMTHDJY6Qn6M3g5LaaLR8BDP0zTELm5xoKTB/dMCazb6XaMomyIu9Jx7f/4Ic3 RPt4ZatdGWAXBOqQcSvttJzvNipDe5lLatxqx7ctm+IASht0ZS41nUEWo9cjKQ9p knNrKNyLETxZHhMNbXbJbtNR58GtOUoszwRRxSKqgLpvWf0/slvDxmpofKyjSIxv XURJqt2KvxXHzkETRXZ+ =GIhl -----END PGP SIGNATURE-----

July 8, 2014

Re: kernel32: initialize return value in CreateSemaphoreExW

by Henri Verbeet

This seems like the kind of thing for which writing a test should be easy.

July 8, 2014

Re: Wine development questions

by Rui Caridade

Hello, Sorry if this was on the wrong list :) Reverting it would break whatever that patch was supposed to fix. Implementing the correct behaviour is not the best choice if the rest of the structure suffers functional regressions due to it by not being prepared. I know the 1.7.x versions are development releases but if something is not done its go into the stable release. This bug http://bugs.winehq.org/show_bug.cgi?id=33125 and the latter fix. 2014-07-08 1:21 GMT+01:00 Vincent Povirk <madewokherd(a)gmail.com>: > This would've been more appropriate on wine-users. > > > - If a patch/commit has a bad impact for users why not remove it, > especially > > if a possible solution is not accepted? > > Reverting it would break whatever that patch was supposed to fix. > > > -This summer sale i bought Tomb Raider 2013 on steam just to find the > game > > playable only with a patch on bugzilla. Is it only a case of the patch > not > > having come through the correct channels.Can it be accepted ? Its not a > > single case. > > Which bug and patch are you referring to? >

July 8, 2014

Re: [PATCH 3/4] ddraw/tests: Add tests for lost P8 primaries.

by Henri Verbeet

On 6 July 2014 18:06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + IDirectDraw *ddraw; ... > + hr = IDirectDraw4_CreateSurface(ddraw, &surface_desc, &texture, NULL); > + ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); I didn't notice this before, but you'll want to use IDirectDraw_CreateSurface() here.

July 8, 2014

Re: kernel32: Partially implement GetGeoInfo()

by Nikolay Sivov

On 07/08/2014 07:32 AM, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >>> Wouldn't it be easier to just map geo id to locale id instead of creating >>> a completely separate data set? That way mapping between locale and geo >>> info would look something like this: >>> >>> GEO_ISO2 -> LOCALE_SISO3166CTRYNAME >>> GEO_ISO3 -> LOCALE_SABBREVCTRYNAME >> Well, you don't have locale info for all supported locations. > > Is it possible to add new ones as needed? My understanding is that multiple locations can map to same default language, and there's not enough sublangs defined to describe them all. So I don't think it's possible. See locations 352 or 114 for example. > >>> GEO_RFC1766 -> LOCALE_SISO639LANGNAME (mlang uses this mapping) >> This one doesn't work like that, it's synthesized from location and >> specified langid. > > Yeah, mlang uses lowercased LOCALE_SISO639LANGNAME+LOCALE_SISO3166CTRYNAME. > In GetGeoInfo() you can get a rfc1766 name like zh-us or fr-us for example. >>> GEO_FRIENDLYNAME -> something appropriate >>> GEO_OFFICIALNAME -> something appropriate >>> >> What's appropriate for that is to add ~300*2 localized strings for each >> locale Wine supports, and that's where we need nls files. >> >> We also need to support the rest of types, like GEO_LATITUDE/LONGITUDE >> and GET_ISO_UN_NUMBER. Both are mapped by location id, so even if it'd >> be possible to reuse something we already have (and I don't think it is) >> we still need a mapping table for the rest of supported data. > > Well, nothing prevents you from adding missing data. And still a centralized > storage would be much better IMO. > It's probably better, but I don't see how it could be done in this case. And having partial support for a subset of locations is not okay. Actually we could do this other way around, storing location id in nls file and use it to get ISO2/ISO3 name using GetGeoInfo once implemented.

July 7, 2014

Re: kernel32: Partially implement GetGeoInfo()

by Nikolay Sivov

On 07/08/2014 01:05 AM, Alexandre Julliard wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> writes: > >> -INT WINAPI GetGeoInfoW(GEOID GeoId, GEOTYPE GeoType, LPWSTR lpGeoData, >> - int cchData, LANGID language) >> +struct geoinfo_t { >> + char iso2A[3]; >> + char iso3A[4]; >> + WCHAR iso2W[3]; >> + WCHAR iso3W[4]; >> + INT uncode; >> +}; > > Surely you don't need both A and W versions of every string. > Ok, will fix that.

July 7, 2014

Re: kernel32: Partially implement GetGeoInfo()

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > > Wouldn't it be easier to just map geo id to locale id instead of creating > > a completely separate data set? That way mapping between locale and geo > > info would look something like this: > > > > GEO_ISO2 -> LOCALE_SISO3166CTRYNAME > > GEO_ISO3 -> LOCALE_SABBREVCTRYNAME > Well, you don't have locale info for all supported locations. Is it possible to add new ones as needed? > > GEO_RFC1766 -> LOCALE_SISO639LANGNAME (mlang uses this mapping) > This one doesn't work like that, it's synthesized from location and > specified langid. Yeah, mlang uses lowercased LOCALE_SISO639LANGNAME+LOCALE_SISO3166CTRYNAME. > > GEO_FRIENDLYNAME -> something appropriate > > GEO_OFFICIALNAME -> something appropriate > > > What's appropriate for that is to add ~300*2 localized strings for each > locale Wine supports, and that's where we need nls files. > > We also need to support the rest of types, like GEO_LATITUDE/LONGITUDE > and GET_ISO_UN_NUMBER. Both are mapped by location id, so even if it'd > be possible to reuse something we already have (and I don't think it is) > we still need a mapping table for the rest of supported data. Well, nothing prevents you from adding missing data. And still a centralized storage would be much better IMO. -- Dmitry.

July 7, 2014